self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2025-03-06 15:36:49 +02:00
Code Issues Releases Activity

Mobile: Fixes #7503: Settings save button visible even when no settings have been changed

Browse Source
This commit is contained in:
Laurent Cozic 2023-01-02 18:36:39 +00:00
parent d5c6690606
commit 27d1a0ee7c
1 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
packages/lib/components/shared/config-shared.js
View File

@ -5,7 +5,7 @@ const { _ } = require('../../locale');
const { createSelector } = require('reselect');
const Logger = require('../../Logger').default;
const logger = Logger.create('config/lib');
const logger = Logger.create('config-shared');
const shared = {};
@ -77,6 +77,19 @@ shared.checkSyncConfigMessages = function(comp) {
shared.updateSettingValue = function(comp, key, value) {
comp.setState(state => {
// @react-native-community/slider (4.4.0) will emit a valueChanged event
// when the component is mounted, even though the value hasn't changed.
// We should ignore this, otherwise it will mark the settings as
// unsaved.
//
// Upstream: https://github.com/callstack/react-native-slider/issues/395
//
// https://github.com/laurent22/joplin/issues/7503
if (state.settings[key] === value) {
logger.info('Trying to update a setting that has not changed - skipping it.', key, value);
return {};
}
const settings = Object.assign({}, state.settings);
const changedSettingKeys = state.changedSettingKeys.slice();
settings[key] = Setting.formatValue(key, value);