self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2024-12-30 10:36:35 +02:00
Code Issues Releases Activity

Desktop: Regression: Fixed issue with note being needlessly reloaded in WYSIWYG editor

Browse Source
This commit is contained in:
Laurent Cozic 2020-06-07 11:01:33 +01:00
parent c9f1715899
commit 30b3f3190b
1 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
ElectronClient/gui/NoteEditor/utils/useFormNote.ts
View File

@ -41,6 +41,22 @@ function uninstallResourceChangeHandler(onResourceChangeHandler: Function) {
ResourceEditWatcher.instance().off('resourceChange', onResourceChangeHandler);
}
function resourceInfosChanged(a:ResourceInfos, b:ResourceInfos):boolean {
if (Object.keys(a).length !== Object.keys(b).length) return true;
for (const id in a) {
const r1 = a[id];
const r2 = b[id];
if (!r2) return true;
if (r1.item.updated_time !== r2.item.updated_time) return true;
if (r1.item.encryption_applied !== r2.item.encryption_applied) return true;
if (r1.item.is_shared !== r2.item.is_shared) return true;
if (r1.localState.fetch_status !== r2.localState.fetch_status) return true;
}
return false;
}
export default function useFormNote(dependencies:HookDependencies) {
const { syncStarted, noteId, isProvisional, titleInputRef, editorRef, onBeforeLoad, onAfterLoad } = dependencies;
@ -197,7 +213,9 @@ export default function useFormNote(dependencies:HookDependencies) {
async function runEffect() {
const r = await attachedResources(formNote.body);
if (cancelled) return;
setResourceInfos(r);
setResourceInfos((previous:ResourceInfos) => {
return resourceInfosChanged(previous, r) ? r : previous;
});
}
runEffect();