1
0
mirror of https://github.com/laurent22/joplin.git synced 2025-01-11 18:24:43 +02:00

Desktop: Resolves #8028: Remove custom PDF viewer to reduce application size

This commit is contained in:
Laurent Cozic 2023-04-26 21:43:56 +01:00
parent 6c1820edc0
commit 31897581d3
6 changed files with 17 additions and 19 deletions

View File

@ -631,7 +631,7 @@ const mapStateToProps = (state: AppState) => {
], whenClauseContext)[0],
contentMaxWidth: state.settings['style.editor.contentMaxWidth'],
isSafeMode: state.settings.isSafeMode,
useCustomPdfViewer: state.settings.useCustomPdfViewer,
useCustomPdfViewer: false, // state.settings.useCustomPdfViewer,
};
};

View File

@ -138,7 +138,6 @@
"@fortawesome/fontawesome-free": "5.15.4",
"@joeattardi/emoji-button": "4.6.4",
"@joplin/lib": "~2.11",
"@joplin/pdf-viewer": "~2.11",
"@joplin/renderer": "~2.11",
"async-mutex": "0.4.0",
"codemirror": "5.65.9",

View File

@ -72,10 +72,10 @@ async function main() {
src: langSourceDir,
dest: `${buildLibDir}/tinymce/langs`,
},
{
src: resolve(__dirname, '../../pdf-viewer/dist'),
dest: `${buildLibDir}/@joplin/pdf-viewer`,
},
// {
// src: resolve(__dirname, '../../pdf-viewer/dist'),
// dest: `${buildLibDir}/@joplin/pdf-viewer`,
// },
];
const files = [
@ -93,10 +93,10 @@ async function main() {
src: resolve(__dirname, '../../lib/services/plugins/sandboxProxy.js'),
dest: `${buildLibDir}/@joplin/lib/services/plugins/sandboxProxy.js`,
},
{
src: resolve(__dirname, '../../pdf-viewer/index.html'),
dest: `${buildLibDir}/@joplin/pdf-viewer/index.html`,
},
// {
// src: resolve(__dirname, '../../pdf-viewer/index.html'),
// dest: `${buildLibDir}/@joplin/pdf-viewer/index.html`,
// },
];
// First we delete all the destination directories, then we copy the files.

View File

@ -1395,7 +1395,7 @@ class Setting extends BaseModel {
useCustomPdfViewer: {
value: false,
type: SettingItemType.Bool,
public: true,
public: false,
advanced: true,
appTypes: [AppType.Desktop],
label: () => 'Use custom PDF viewer (Beta)',

View File

@ -9,12 +9,12 @@
"access": "restricted"
},
"scripts": {
"tsc": "tsc --project tsconfig.json",
"watch": "webpack --watch --config webpack.config.js --mode=development",
"build": "webpack --config webpack.config.js --mode=production",
"test": "jest",
"test-ci": "yarn test",
"postinstall": "yarn build"
"tsc_DISABLED": "tsc --project tsconfig.json",
"watch_DISABLED": "webpack --watch --config webpack.config.js --mode=development",
"build_DISABLED": "webpack --config webpack.config.js --mode=production",
"test_DISABLED": "jest",
"test-ci_DISABLED": "yarn test",
"postinstall_DISABLED": "yarn build"
},
"author": "Joplin",
"license": "AGPL-3.0-or-later",

View File

@ -4839,7 +4839,6 @@ __metadata:
"@fortawesome/fontawesome-free": 5.15.4
"@joeattardi/emoji-button": 4.6.4
"@joplin/lib": ~2.11
"@joplin/pdf-viewer": ~2.11
"@joplin/renderer": ~2.11
"@joplin/tools": ~2.11
"@testing-library/react-hooks": 8.0.1
@ -5144,7 +5143,7 @@ __metadata:
languageName: unknown
linkType: soft
"@joplin/pdf-viewer@workspace:packages/pdf-viewer, @joplin/pdf-viewer@~2.11":
"@joplin/pdf-viewer@workspace:packages/pdf-viewer":
version: 0.0.0-use.local
resolution: "@joplin/pdf-viewer@workspace:packages/pdf-viewer"
dependencies: