Desktop: Fixes #2334: MD importer handle special chars in linked image name (#2346)

* md importer: decode uri encoded links to cover case of special chars in linked image names

* md importer: temp debug logs for linux test pipeline

* md importer: more temp debug logs

* md importer: tests, add special char image name on linux

* md importer: tests, use const not let

* md importer: remove debug logs

CliClient/tests/MdToMd.js

@@ -38,4 +38,9 @@ describe('InteropService_Importer_Md: importLocalImages', function() {
 		expect(items.length).toBe(0);
 		expect(note.body).toContain('Unidentified vessel travelling at sub warp speed, bearing 235.7. Fluctuations in energy readings from it, Captain. All transporters off.');
 	});
+	it('should import linked image with special characters in name', async function() {
+		const note = await importer.importFile(`${__dirname}/md_to_md/sample-special-chars.md`, 'notebook');
+		const items = await Note.linkedItems(note.body);
+		expect(items.length).toBe(1);
+	});
 });

CliClient/tests/md_to_md/sample-special-chars.md

@@ -0,0 +1 @@
+![link special chars](../support/photo-åäö.jpg)

ReactNativeClient/lib/services/InteropService_Importer_Md.js

@@ -63,7 +63,8 @@ class InteropService_Importer_Md extends InteropService_Importer_Base {
 	async importLocalImages(filePath, md) {
 		let updated = md;
 		const imageLinks = unique(extractImageUrls(md));
-		await Promise.all(imageLinks.map(async (link) => {
+		await Promise.all(imageLinks.map(async (encodedLink) => {
+			const link = decodeURI(encodedLink);
 			const attachmentPath = filename(`${dirname(filePath)}/${link}`, true);
 			const pathWithExtension =  `${attachmentPath}.${fileExtension(link)}`;
 			const stat = await shim.fsDriver().stat(pathWithExtension);