Desktop: Simplified and improve command service, and added command palette

- Commands "enabled" state is now expressed using a "when-clause" like in VSCode
- A command palette has been added to the Tools menu

ReactNativeClient/lib/commands/historyBackward.ts

@@ -4,27 +4,16 @@ import { _ } from 'lib/locale';
 export const declaration:CommandDeclaration = {
 	name: 'historyBackward',
 	label: () => _('Back'),
-	// iconName: 'fa-arrow-left',
 	iconName: 'icon-back',
 };
 
-interface Props {
-	hasBackwardNotes: boolean,
-}
-
 export const runtime = ():CommandRuntime => {
 	return {
-		execute: async (props:Props) => {
-			if (!props.hasBackwardNotes) return;
+		execute: async () => {
 			utils.store.dispatch({
 				type: 'HISTORY_BACKWARD',
 			});
 		},
-		isEnabled: (props:Props) => {
-			return props.hasBackwardNotes;
-		},
-		mapStateToProps: (state:any) => {
-			return { hasBackwardNotes: state.backwardHistoryNotes.length > 0 };
-		},
+		enabledCondition: 'historyhasBackwardNotes',
 	};
 };

ReactNativeClient/lib/commands/historyForward.ts

@@ -7,23 +7,13 @@ export const declaration:CommandDeclaration = {
 	iconName: 'icon-forward',
 };
 
-interface Props {
-	hasForwardNotes: boolean,
-}
-
 export const runtime = ():CommandRuntime => {
 	return {
-		execute: async (props:Props) => {
-			if (!props.hasForwardNotes) return;
+		execute: async () => {
 			utils.store.dispatch({
 				type: 'HISTORY_FORWARD',
 			});
 		},
-		isEnabled: (props:Props) => {
-			return props.hasForwardNotes;
-		},
-		mapStateToProps: (state:any) => {
-			return { hasForwardNotes: state.forwardHistoryNotes.length > 0 };
-		},
+		enabledCondition: 'historyhasForwardNotes',
 	};
 };

ReactNativeClient/lib/commands/synchronize.ts

@@ -1,4 +1,4 @@
-import { utils, CommandRuntime, CommandDeclaration } from '../services/CommandService';
+import { utils, CommandRuntime, CommandDeclaration, CommandContext } from '../services/CommandService';
 import { _ } from 'lib/locale';
 const { reg } = require('lib/registry.js');
 
@@ -8,9 +8,11 @@ export const declaration:CommandDeclaration = {
 	iconName: 'fa-sync-alt',
 };
 
+// Note that this command actually acts as a toggle - it starts or cancels
+// synchronisation depending on the "syncStarted" parameter
 export const runtime = ():CommandRuntime => {
 	return {
-		execute: async ({ syncStarted }:any) => {
+		execute: async (_context:CommandContext, syncStarted:boolean = false) => {
 			const action = syncStarted ? 'cancel' : 'start';
 
 			if (!(await reg.syncTarget().isAuthenticated())) {
@@ -43,13 +45,5 @@ export const runtime = ():CommandRuntime => {
 				return 'sync';
 			}
 		},
-		isEnabled: (props:any) => {
-			return !props.syncStarted;
-		},
-		mapStateToProps: (state:any):any => {
-			return {
-				syncStarted: state.syncStarted,
-			};
-		},
 	};
 };