self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2025-03-29 21:21:15 +02:00
Code Issues Releases Activity

Desktop: Fixes #7920: List enabled plugins only in About Joplin and in alphabetical order (#7923)

Browse Source
This commit is contained in:
Julien 2023-03-17 16:41:33 +08:00 committed by GitHub
parent 37995b9ec7
commit 3a744c79ae
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 29 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/app-desktop/gui/MenuBar.tsx
View File

@ -489,7 +489,6 @@ function useMenu(props: Props) {
function _showAbout() { function _showAbout() {
const v = versionInfo(packageInfo, PluginService.instance().plugins); const v = versionInfo(packageInfo, PluginService.instance().plugins);
const copyToClipboard = bridge().showMessageBox(v.message, { const copyToClipboard = bridge().showMessageBox(v.message, {
icon: `${bridge().electronApp().buildDir()}/icons/128x128.png`, icon: `${bridge().electronApp().buildDir()}/icons/128x128.png`,
buttons: [_('Copy'), _('OK')], buttons: [_('Copy'), _('OK')],

20
packages/lib/versionInfo.test.ts
View File

@ -2,6 +2,8 @@ import versionInfo from './versionInfo';
import { reg } from './registry'; import { reg } from './registry';
import { Plugins } from './services/plugins/PluginService'; import { Plugins } from './services/plugins/PluginService';
import Plugin from './services/plugins/Plugin'; import Plugin from './services/plugins/Plugin';
import Setting from './models/Setting';
import { PluginSettings } from './services/plugins/PluginService';
jest.mock('./registry'); jest.mock('./registry');
@ -64,6 +66,10 @@ describe('getPluginLists', () => {
const plugins: Plugins = {}; const plugins: Plugins = {};
plugins[plugin.manifest.id] = plugin; plugins[plugin.manifest.id] = plugin;
const pluginSettings: PluginSettings = {};
pluginSettings[plugin.id] = { enabled: true, deleted: false, hasBeenUpdated: false };
Setting.setValue('plugins.states', pluginSettings);
const v = versionInfo(packageInfo, plugins); const v = versionInfo(packageInfo, plugins);
expect(v.body).toMatch(/\n\nPlugin1: 1/); expect(v.body).toMatch(/\n\nPlugin1: 1/);
expect(v.message).toMatch(/\n\nPlugin1: 1/); expect(v.message).toMatch(/\n\nPlugin1: 1/);
@ -86,6 +92,13 @@ describe('getPluginLists', () => {
); );
plugins[plugin.manifest.id] = plugin; plugins[plugin.manifest.id] = plugin;
} }
const pluginSettings: PluginSettings = {};
for (const key of Object.keys(plugins)) {
pluginSettings[key] = { enabled: true, deleted: false, hasBeenUpdated: false };
}
Setting.setValue('plugins.states', pluginSettings);
const v = versionInfo(packageInfo, plugins); const v = versionInfo(packageInfo, plugins);
expect(v.body).toMatch(/\n\nPlugin1: 1\nPlugin2: 1\nPlugin3: 1/); expect(v.body).toMatch(/\n\nPlugin1: 1\nPlugin2: 1\nPlugin3: 1/);
@ -110,6 +123,13 @@ describe('getPluginLists', () => {
plugins[plugin.manifest.id] = plugin; plugins[plugin.manifest.id] = plugin;
} }
const pluginSettings: PluginSettings = {};
for (const key of Object.keys(plugins)) {
pluginSettings[key] = { enabled: true, deleted: false, hasBeenUpdated: false };
}
Setting.setValue('plugins.states', pluginSettings);
const v = versionInfo(packageInfo, plugins); const v = versionInfo(packageInfo, plugins);
const body = '\n'; const body = '\n';

12
packages/lib/versionInfo.ts
View File

@ -2,6 +2,7 @@ import { _ } from './locale';
import Setting from './models/Setting'; import Setting from './models/Setting';
import { reg } from './registry'; import { reg } from './registry';
import { Plugins } from './services/plugins/PluginService'; import { Plugins } from './services/plugins/PluginService';
import PluginService from './services/plugins/PluginService';
interface PluginList { interface PluginList {
completeList: string; completeList: string;
@ -10,12 +11,17 @@ interface PluginList {
function getPluginLists(plugins: Plugins): PluginList { function getPluginLists(plugins: Plugins): PluginList {
const pluginList = []; const pluginList = [];
if (Object.keys(plugins).length > 0) { const pluginSettings = PluginService.instance().unserializePluginSettings(Setting.value('plugins.states'));
for (const pluginId in plugins) { const enabledPlugins = Object.fromEntries(Object.entries(plugins).filter((p) => pluginSettings[p[0]] && pluginSettings[p[0]].enabled === true));
pluginList.push(`${plugins[pluginId].manifest.name}: ${plugins[pluginId].manifest.version}`);
if (Object.keys(enabledPlugins).length > 0) {
for (const pluginId in enabledPlugins) {
pluginList.push(`${enabledPlugins[pluginId].manifest.name}: ${enabledPlugins[pluginId].manifest.version}`);
} }
} }
pluginList.sort();
let completeList = ''; let completeList = '';
let summary = ''; let summary = '';
if (pluginList.length > 0) { if (pluginList.length > 0) {