self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2024-12-24 10:27:10 +02:00
Code Issues Releases Activity

Desktop, Cli: Fixes #2085: Fix escaping of title when generating a markdown link (#2456)

Browse Source 
Previously a title with brackets was escaped incorrectly. The brackets were replaced by underscores.

The following title `title [square] (round)` looked like this:

[title _square_ _round_](:/c54794f53e5e4b1aa558699e255d5f95)

Now it looks like this:

[title \[square\] (round)](:/c54794f53e5e4b1aa558699e255d5f95)

fixes #2085
This commit is contained in:
Helmut K. C. Tessarek 2020-02-07 17:15:41 -05:00 committed by GitHub
parent 8cbb0d03e8
commit 3f23d8ed06
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
CliClient/tests/markdownUtils.js
View File

@ -49,4 +49,19 @@ describe('markdownUtils', function() {
}
}));
it('escape a markdown link (title)', asyncTest(async () => {
const testCases = [
['Helmut K. C. Tessarek', 'Helmut K. C. Tessarek'],
['Helmut (K. C.) Tessarek', 'Helmut (K. C.) Tessarek'],
['Helmut [K. C.] Tessarek', 'Helmut \\[K. C.\\] Tessarek'],
];
for (let i = 0; i < testCases.length; i++) {
const md = testCases[i][0];
const expected = testCases[i][1];
expect(markdownUtils.escapeTitleText(md)).toBe(expected);
}
}));
});

5
ReactNativeClient/lib/markdownUtils.js
View File

@ -9,6 +9,11 @@ const markdownUtils = {
return text.replace(/(\[|\]|\(|\))/g, '_');
},
// Titles for markdown links only need escaping for [ and ]
escapeTitleText(text) {
return text.replace(/(\[|\])/g, '\\$1');
},
escapeLinkUrl(url) {
url = url.replace(/\(/g, '%28');
url = url.replace(/\)/g, '%29');

2
ReactNativeClient/lib/models/BaseItem.js
View File

@ -761,7 +761,7 @@ class BaseItem extends BaseModel {
const output = [];
output.push('[');
output.push(markdownUtils.escapeLinkText(item.title));
output.push(markdownUtils.escapeTitleText(item.title));
output.push(']');
output.push(`(:/${item.id})`);
return output.join('');