self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2024-12-24 10:27:10 +02:00
Code Issues Releases Activity

Desktop: Fixed plugin panel issue that could crash app in rare case

Browse Source 
Ref: https://discourse.joplinapp.org/t/rearranging-the-pannels-crushed-the-app-and-generated-fatal-error/14373
This commit is contained in:
Laurent Cozic 2021-01-27 22:52:54 +00:00
parent 18dfc5a987
commit 4156b13c32
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/app-desktop/gui/MainScreen/MainScreen.tsx
View File

@ -572,6 +572,15 @@ class MainScreenComponent extends React.Component<Props, State> {
}
resizableLayout_renderItem(key: string, event: any) {
// Key should never be undefined but somehow it can happen, also not
// clear how. For now in this case render nothing so that the app
// doesn't crash.
// https://discourse.joplinapp.org/t/rearranging-the-pannels-crushed-the-app-and-generated-fatal-error/14373?u=laurent
if (!key) {
console.error('resizableLayout_renderItem: Trying to render an item using an empty key. Full layout is:', this.props.mainLayout);
return null;
}
const eventEmitter = event.eventEmitter;
// const viewsToRemove:string[] = [];