self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2026-06-18 20:16:34 +02:00
Code Issues Releases Activity

Desktop: Fixes #11485: Fix pressing enter during composition in the title input moves focus (#11491)

Browse Source
This commit is contained in:
Henry Heino
2024-12-12 22:30:20 +01:00
committed by GitHub
parent 30dbacc1a1
commit 421edb6691
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/app-desktop/gui/NoteEditor/NoteTitle/NoteTitleBar.tsx
+6 -1
View File
@@ -85,7 +85,12 @@ export default function NoteTitleBar(props: Props) {
const onTitleKeydown: React.KeyboardEventHandler<HTMLInputElement> = useCallback((event) => {
const titleElement = event.currentTarget;
const selectionAtEnd = titleElement.selectionEnd === titleElement.value.length;
if ((event.key === 'ArrowDown' && selectionAtEnd) || (event.key === 'Enter' && !event.shiftKey)) {
const isNavigationShortcut = (event.key === 'ArrowDown' && selectionAtEnd) || (event.key === 'Enter' && !event.shiftKey);
const composing = event.nativeEvent.isComposing;
// Don't change focus if the navigation shortcut is fired during composition. See
// https://github.com/laurent22/joplin/issues/11485.
if (!composing && isNavigationShortcut) {
event.preventDefault();
const moveCursorToStart = event.key === 'ArrowDown';
void CommandService.instance().execute('focusElement', 'noteBody', { moveCursorToStart });