From 53e7b672b03890bfeea830045fb88f7821ac461b Mon Sep 17 00:00:00 2001 From: Laurent Cozic Date: Mon, 28 Apr 2025 09:55:35 +0100 Subject: [PATCH] Chore: Recorded CLA consent documents --- packages/tools/saveClaConsentRecords.ts | 3 +- .../ARYPROGRAMMER_75311742.json | 362 +++++++++ .../consent_records/AdrienPoupa_15086425.json | 542 +++++++++++++ .../consent_records/CGHoussem_18559408.json | 272 +++++++ .../cla/consent_records/DMClVG_48882585.json | 272 +++++++ .../consent_records/GGpifas_103130352.json | 452 +++++++++++ .../consent_records/LEVIII007_132750919.json | 452 +++++++++++ .../cla/consent_records/MietVdh_20527357.json | 687 ++++++++++++++++ .../MorbidMiyako_57117884.json | 477 +++++++++++ .../Paramesh-T-S_42896229.json | 407 ++++++++++ .../RajwardhanSinghUmath_170418104.json | 362 +++++++++ .../Sabin-Gheorghiu_31973154.json | 362 +++++++++ .../consent_records/Schmeilen_114296635.json | 317 ++++++++ .../SilverGreen93_24845602.json | 282 +++++++ .../consent_records/Vortrix5_30868937.json | 497 ++++++++++++ .../consent_records/alan-null_6848691.json | 272 +++++++ .../awesome-pro_147910430.json | 272 +++++++ .../consent_records/azurelunatic_7589142.json | 317 ++++++++ .../consent_records/balaraz_134877893.json | 452 +++++++++++ readme/cla/consent_records/c-n-c_1103228.json | 272 +++++++ .../consent_records/camilajenny_17968722.json | 317 ++++++++ readme/cla/consent_records/ckant_1410453.json | 317 ++++++++ readme/cla/consent_records/click0_396824.json | 452 +++++++++++ .../cla/consent_records/clsty_129247596.json | 462 +++++++++++ .../creationsofm7_29347949.json | 362 +++++++++ .../consent_records/d4m14n-gh_87342969.json | 407 ++++++++++ readme/cla/consent_records/dandv_33569.json | 362 +++++++++ .../cla/consent_records/danobot_7984567.json | 362 +++++++++ .../cla/consent_records/deftdawg_4991612.json | 542 +++++++++++++ .../dhakarRaghu_149622456.json | 317 ++++++++ readme/cla/consent_records/dodog_976639.json | 597 ++++++++++++++ .../cla/consent_records/ericdq_27959252.json | 282 +++++++ .../consent_records/executed_36827253.json | 362 +++++++++ .../consent_records/forsaken628_18322364.json | 317 ++++++++ .../consent_records/harshil048_74892092.json | 272 +++++++ .../consent_records/itsanmol27_143805969.json | 272 +++++++ .../j-scheitler1_158077662.json | 497 ++++++++++++ readme/cla/consent_records/jrb80_1820167.json | 452 +++++++++++ .../cla/consent_records/klxiang_39042920.json | 282 +++++++ readme/cla/consent_records/looi_1855766.json | 452 +++++++++++ .../consent_records/mshibanami_1333214.json | 317 ++++++++ .../cla/consent_records/narFnarF_3538115.json | 317 ++++++++ .../cla/consent_records/ost-ch_98581972.json | 317 ++++++++ .../consent_records/outrodani_134531018.json | 387 +++++++++ .../consent_records/pectum83_11873289.json | 272 +++++++ .../consent_records/rabbabansh_31804810.json | 767 ++++++++++++++++++ .../rathoreSahil_90506484.json | 317 ++++++++ .../consent_records/rcrisanti_27363609.json | 362 +++++++++ .../consent_records/redrathnure_643360.json | 317 ++++++++ .../sudokillnine_46093340.json | 507 ++++++++++++ .../consent_records/summoner001_11212632.json | 362 +++++++++ .../consent_records/tbjgolden_8162045.json | 542 +++++++++++++ .../teardroponfire_1015199.json | 362 +++++++++ .../consent_records/tnshgarg_91324988.json | 272 +++++++ .../consent_records/ttcchhmm_60962195.json | 702 ++++++++++++++++ .../tue-AqielOostenbrug_104417251.json | 432 ++++++++++ .../cla/consent_records/tuliogit_4997388.json | 362 +++++++++ 57 files changed, 21929 insertions(+), 1 deletion(-) create mode 100644 readme/cla/consent_records/ARYPROGRAMMER_75311742.json create mode 100644 readme/cla/consent_records/AdrienPoupa_15086425.json create mode 100644 readme/cla/consent_records/CGHoussem_18559408.json create mode 100644 readme/cla/consent_records/DMClVG_48882585.json create mode 100644 readme/cla/consent_records/GGpifas_103130352.json create mode 100644 readme/cla/consent_records/LEVIII007_132750919.json create mode 100644 readme/cla/consent_records/MietVdh_20527357.json create mode 100644 readme/cla/consent_records/MorbidMiyako_57117884.json create mode 100644 readme/cla/consent_records/Paramesh-T-S_42896229.json create mode 100644 readme/cla/consent_records/RajwardhanSinghUmath_170418104.json create mode 100644 readme/cla/consent_records/Sabin-Gheorghiu_31973154.json create mode 100644 readme/cla/consent_records/Schmeilen_114296635.json create mode 100644 readme/cla/consent_records/SilverGreen93_24845602.json create mode 100644 readme/cla/consent_records/Vortrix5_30868937.json create mode 100644 readme/cla/consent_records/alan-null_6848691.json create mode 100644 readme/cla/consent_records/awesome-pro_147910430.json create mode 100644 readme/cla/consent_records/azurelunatic_7589142.json create mode 100644 readme/cla/consent_records/balaraz_134877893.json create mode 100644 readme/cla/consent_records/c-n-c_1103228.json create mode 100644 readme/cla/consent_records/camilajenny_17968722.json create mode 100644 readme/cla/consent_records/ckant_1410453.json create mode 100644 readme/cla/consent_records/click0_396824.json create mode 100644 readme/cla/consent_records/clsty_129247596.json create mode 100644 readme/cla/consent_records/creationsofm7_29347949.json create mode 100644 readme/cla/consent_records/d4m14n-gh_87342969.json create mode 100644 readme/cla/consent_records/dandv_33569.json create mode 100644 readme/cla/consent_records/danobot_7984567.json create mode 100644 readme/cla/consent_records/deftdawg_4991612.json create mode 100644 readme/cla/consent_records/dhakarRaghu_149622456.json create mode 100644 readme/cla/consent_records/dodog_976639.json create mode 100644 readme/cla/consent_records/ericdq_27959252.json create mode 100644 readme/cla/consent_records/executed_36827253.json create mode 100644 readme/cla/consent_records/forsaken628_18322364.json create mode 100644 readme/cla/consent_records/harshil048_74892092.json create mode 100644 readme/cla/consent_records/itsanmol27_143805969.json create mode 100644 readme/cla/consent_records/j-scheitler1_158077662.json create mode 100644 readme/cla/consent_records/jrb80_1820167.json create mode 100644 readme/cla/consent_records/klxiang_39042920.json create mode 100644 readme/cla/consent_records/looi_1855766.json create mode 100644 readme/cla/consent_records/mshibanami_1333214.json create mode 100644 readme/cla/consent_records/narFnarF_3538115.json create mode 100644 readme/cla/consent_records/ost-ch_98581972.json create mode 100644 readme/cla/consent_records/outrodani_134531018.json create mode 100644 readme/cla/consent_records/pectum83_11873289.json create mode 100644 readme/cla/consent_records/rabbabansh_31804810.json create mode 100644 readme/cla/consent_records/rathoreSahil_90506484.json create mode 100644 readme/cla/consent_records/rcrisanti_27363609.json create mode 100644 readme/cla/consent_records/redrathnure_643360.json create mode 100644 readme/cla/consent_records/sudokillnine_46093340.json create mode 100644 readme/cla/consent_records/summoner001_11212632.json create mode 100644 readme/cla/consent_records/tbjgolden_8162045.json create mode 100644 readme/cla/consent_records/teardroponfire_1015199.json create mode 100644 readme/cla/consent_records/tnshgarg_91324988.json create mode 100644 readme/cla/consent_records/ttcchhmm_60962195.json create mode 100644 readme/cla/consent_records/tue-AqielOostenbrug_104417251.json create mode 100644 readme/cla/consent_records/tuliogit_4997388.json diff --git a/packages/tools/saveClaConsentRecords.ts b/packages/tools/saveClaConsentRecords.ts index 58880418bf..00f4be39e3 100644 --- a/packages/tools/saveClaConsentRecords.ts +++ b/packages/tools/saveClaConsentRecords.ts @@ -50,7 +50,7 @@ const runRequest = async (path: string) => { }; const response = await fetch(url, { headers }); - if (!response.ok) throw new Error(`Error fetching issue: ${await response.text()}`); + if (!response.ok) throw new Error(`Error: ${path}: ${await response.text()}`); return response.json(); }; @@ -86,6 +86,7 @@ const main = async () => { const excludedIssueIds = [ 7785, // Not merged 8531, // Not merged + 11567, // Changed year on license file: https://github.com/laurent22/joplin/commit/2b43a9a4d667fe6b81bc97b66e0b3700688ec3cf ]; const signedContributors = await getSignedContributors(); diff --git a/readme/cla/consent_records/ARYPROGRAMMER_75311742.json b/readme/cla/consent_records/ARYPROGRAMMER_75311742.json new file mode 100644 index 0000000000..3bb2bb3e1a --- /dev/null +++ b/readme/cla/consent_records/ARYPROGRAMMER_75311742.json @@ -0,0 +1,362 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11551", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11551/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11551/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11551/events", + "html_url": "https://github.com/laurent22/joplin/pull/11551", + "id": 2754360092, + "node_id": "PR_kwDOBLftOs6F__Ty", + "number": 11551, + "title": "Desktop: Fixes #11538: Fixed Strikethrough text in markdown editor", + "user": { + "login": "ARYPROGRAMMER", + "id": 75311742, + "node_id": "MDQ6VXNlcjc1MzExNzQy", + "avatar_url": "https://avatars.githubusercontent.com/u/75311742?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/ARYPROGRAMMER", + "html_url": "https://github.com/ARYPROGRAMMER", + "followers_url": "https://api.github.com/users/ARYPROGRAMMER/followers", + "following_url": "https://api.github.com/users/ARYPROGRAMMER/following{/other_user}", + "gists_url": "https://api.github.com/users/ARYPROGRAMMER/gists{/gist_id}", + "starred_url": "https://api.github.com/users/ARYPROGRAMMER/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/ARYPROGRAMMER/subscriptions", + "organizations_url": "https://api.github.com/users/ARYPROGRAMMER/orgs", + "repos_url": "https://api.github.com/users/ARYPROGRAMMER/repos", + "events_url": "https://api.github.com/users/ARYPROGRAMMER/events{/privacy}", + "received_events_url": "https://api.github.com/users/ARYPROGRAMMER/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": true, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 4, + "created_at": "2024-12-21T20:57:25Z", + "updated_at": "2024-12-21T23:45:09Z", + "closed_at": "2024-12-21T23:44:57Z", + "author_association": "NONE", + "active_lock_reason": "off-topic", + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11551", + "html_url": "https://github.com/laurent22/joplin/pull/11551", + "diff_url": "https://github.com/laurent22/joplin/pull/11551.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11551.patch", + "merged_at": null + }, + "body": "This PR attempts to solve #11538 and closes it.\r\n\r\nAdded support for strikethrough text preview in markdown editor , just like bold and italic previews. \r\nAdded shortcut key \"Alt-Shift-5\" for the same.\r\nAdded relevant docs to the needed files.", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11551/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11551/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2558238920", + "html_url": "https://github.com/laurent22/joplin/pull/11551#issuecomment-2558238920", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11551", + "id": 2558238920, + "node_id": "IC_kwDOBLftOs6Ye6DI", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-21T20:57:40Z", + "updated_at": "2024-12-21T22:38:28Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2558238920/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2558239091", + "html_url": "https://github.com/laurent22/joplin/pull/11551#issuecomment-2558239091", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11551", + "id": 2558239091, + "node_id": "IC_kwDOBLftOs6Ye6Fz", + "user": { + "login": "ARYPROGRAMMER", + "id": 75311742, + "node_id": "MDQ6VXNlcjc1MzExNzQy", + "avatar_url": "https://avatars.githubusercontent.com/u/75311742?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/ARYPROGRAMMER", + "html_url": "https://github.com/ARYPROGRAMMER", + "followers_url": "https://api.github.com/users/ARYPROGRAMMER/followers", + "following_url": "https://api.github.com/users/ARYPROGRAMMER/following{/other_user}", + "gists_url": "https://api.github.com/users/ARYPROGRAMMER/gists{/gist_id}", + "starred_url": "https://api.github.com/users/ARYPROGRAMMER/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/ARYPROGRAMMER/subscriptions", + "organizations_url": "https://api.github.com/users/ARYPROGRAMMER/orgs", + "repos_url": "https://api.github.com/users/ARYPROGRAMMER/repos", + "events_url": "https://api.github.com/users/ARYPROGRAMMER/events{/privacy}", + "received_events_url": "https://api.github.com/users/ARYPROGRAMMER/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-21T20:58:32Z", + "updated_at": "2024-12-21T20:58:32Z", + "author_association": "NONE", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2558239091/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2558239115", + "html_url": "https://github.com/laurent22/joplin/pull/11551#issuecomment-2558239115", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11551", + "id": 2558239115, + "node_id": "IC_kwDOBLftOs6Ye6GL", + "user": { + "login": "ARYPROGRAMMER", + "id": 75311742, + "node_id": "MDQ6VXNlcjc1MzExNzQy", + "avatar_url": "https://avatars.githubusercontent.com/u/75311742?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/ARYPROGRAMMER", + "html_url": "https://github.com/ARYPROGRAMMER", + "followers_url": "https://api.github.com/users/ARYPROGRAMMER/followers", + "following_url": "https://api.github.com/users/ARYPROGRAMMER/following{/other_user}", + "gists_url": "https://api.github.com/users/ARYPROGRAMMER/gists{/gist_id}", + "starred_url": "https://api.github.com/users/ARYPROGRAMMER/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/ARYPROGRAMMER/subscriptions", + "organizations_url": "https://api.github.com/users/ARYPROGRAMMER/orgs", + "repos_url": "https://api.github.com/users/ARYPROGRAMMER/repos", + "events_url": "https://api.github.com/users/ARYPROGRAMMER/events{/privacy}", + "received_events_url": "https://api.github.com/users/ARYPROGRAMMER/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-21T20:58:41Z", + "updated_at": "2024-12-21T20:58:41Z", + "author_association": "NONE", + "body": "recheck", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2558239115/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2558270005", + "html_url": "https://github.com/laurent22/joplin/pull/11551#issuecomment-2558270005", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11551", + "id": 2558270005, + "node_id": "IC_kwDOBLftOs6YfBo1", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-21T23:44:57Z", + "updated_at": "2024-12-21T23:44:57Z", + "author_association": "OWNER", + "body": "There was no discussion over what should be done for this issue, so it's too early for a pr", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2558270005/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/AdrienPoupa_15086425.json b/readme/cla/consent_records/AdrienPoupa_15086425.json new file mode 100644 index 0000000000..1fa82a0018 --- /dev/null +++ b/readme/cla/consent_records/AdrienPoupa_15086425.json @@ -0,0 +1,542 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11372", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11372/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11372/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11372/events", + "html_url": "https://github.com/laurent22/joplin/pull/11372", + "id": 2647866401, + "node_id": "PR_kwDOBLftOs6Bch0k", + "number": 11372, + "title": "Server: Resolves #9931: Add task to delete events older than a week", + "user": { + "login": "AdrienPoupa", + "id": 15086425, + "node_id": "MDQ6VXNlcjE1MDg2NDI1", + "avatar_url": "https://avatars.githubusercontent.com/u/15086425?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/AdrienPoupa", + "html_url": "https://github.com/AdrienPoupa", + "followers_url": "https://api.github.com/users/AdrienPoupa/followers", + "following_url": "https://api.github.com/users/AdrienPoupa/following{/other_user}", + "gists_url": "https://api.github.com/users/AdrienPoupa/gists{/gist_id}", + "starred_url": "https://api.github.com/users/AdrienPoupa/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/AdrienPoupa/subscriptions", + "organizations_url": "https://api.github.com/users/AdrienPoupa/orgs", + "repos_url": "https://api.github.com/users/AdrienPoupa/repos", + "events_url": "https://api.github.com/users/AdrienPoupa/events{/privacy}", + "received_events_url": "https://api.github.com/users/AdrienPoupa/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 8, + "created_at": "2024-11-11T01:14:39Z", + "updated_at": "2025-01-15T20:43:28Z", + "closed_at": "2024-12-09T15:48:21Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11372", + "html_url": "https://github.com/laurent22/joplin/pull/11372", + "diff_url": "https://github.com/laurent22/joplin/pull/11372.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11372.patch", + "merged_at": "2024-12-09T15:48:21Z" + }, + "body": "Revisiting https://github.com/laurent22/joplin/pull/9988/files as I had the same issue this week (my Joplin DB grew to 600mb while I only have a few notes...).\r\n\r\nI'm using mostly the same code, but I tried to match other patterns found in the codebase (using a TTL attribute in the class, not requiring arguments in the event function).\r\n\r\nI also handled Laurent's review to use fake timers for the test.", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11372/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11372/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2467048300", + "html_url": "https://github.com/laurent22/joplin/pull/11372#issuecomment-2467048300", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11372", + "id": 2467048300, + "node_id": "IC_kwDOBLftOs6TDCts", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-11T01:14:52Z", + "updated_at": "2024-12-09T15:48:38Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2467048300/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2467048814", + "html_url": "https://github.com/laurent22/joplin/pull/11372#issuecomment-2467048814", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11372", + "id": 2467048814, + "node_id": "IC_kwDOBLftOs6TDC1u", + "user": { + "login": "AdrienPoupa", + "id": 15086425, + "node_id": "MDQ6VXNlcjE1MDg2NDI1", + "avatar_url": "https://avatars.githubusercontent.com/u/15086425?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/AdrienPoupa", + "html_url": "https://github.com/AdrienPoupa", + "followers_url": "https://api.github.com/users/AdrienPoupa/followers", + "following_url": "https://api.github.com/users/AdrienPoupa/following{/other_user}", + "gists_url": "https://api.github.com/users/AdrienPoupa/gists{/gist_id}", + "starred_url": "https://api.github.com/users/AdrienPoupa/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/AdrienPoupa/subscriptions", + "organizations_url": "https://api.github.com/users/AdrienPoupa/orgs", + "repos_url": "https://api.github.com/users/AdrienPoupa/repos", + "events_url": "https://api.github.com/users/AdrienPoupa/events{/privacy}", + "received_events_url": "https://api.github.com/users/AdrienPoupa/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-11T01:15:35Z", + "updated_at": "2024-11-11T01:15:35Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2467048814/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2468481664", + "html_url": "https://github.com/laurent22/joplin/pull/11372#issuecomment-2468481664", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11372", + "id": 2468481664, + "node_id": "IC_kwDOBLftOs6TIgqA", + "user": { + "login": "AdrienPoupa", + "id": 15086425, + "node_id": "MDQ6VXNlcjE1MDg2NDI1", + "avatar_url": "https://avatars.githubusercontent.com/u/15086425?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/AdrienPoupa", + "html_url": "https://github.com/AdrienPoupa", + "followers_url": "https://api.github.com/users/AdrienPoupa/followers", + "following_url": "https://api.github.com/users/AdrienPoupa/following{/other_user}", + "gists_url": "https://api.github.com/users/AdrienPoupa/gists{/gist_id}", + "starred_url": "https://api.github.com/users/AdrienPoupa/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/AdrienPoupa/subscriptions", + "organizations_url": "https://api.github.com/users/AdrienPoupa/orgs", + "repos_url": "https://api.github.com/users/AdrienPoupa/repos", + "events_url": "https://api.github.com/users/AdrienPoupa/events{/privacy}", + "received_events_url": "https://api.github.com/users/AdrienPoupa/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-11T15:45:32Z", + "updated_at": "2024-11-11T15:46:46Z", + "author_association": "CONTRIBUTOR", + "body": "Hi Laurent, thanks for the review.\r\n\r\n> The TTL should be configurable via an env variable\r\n\r\nWhat would we gain from this? The `DeleteExpiredTokens` task that I'm using as a reference does not have this logic. \r\n\r\nIf we need to implement it, do you have a preferred approach? I see the `UserDeletionService` uses the `USER_DATA_AUTO_DELETE_AFTER_DAYS` environment variable, I could use the same mechanism.\r\n\r\n> What's the impact of deleting old events - what service or function could be affected by it?\r\n\r\nI don't know, sorry. It is the approach you suggested here however: https://github.com/laurent22/joplin/issues/9931#issuecomment-1941780582", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2468481664/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2468811114", + "html_url": "https://github.com/laurent22/joplin/pull/11372#issuecomment-2468811114", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11372", + "id": 2468811114, + "node_id": "IC_kwDOBLftOs6TJxFq", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-11T18:39:56Z", + "updated_at": "2024-11-11T18:39:56Z", + "author_association": "OWNER", + "body": "> What would we gain from this? \r\n\r\nFor audit purposes for example.\r\n\r\n> I don't know, sorry. It is the approach you suggested here however: [#9931 (comment)](https://github.com/laurent22/joplin/issues/9931#issuecomment-1941780582)\r\n\r\nIf you can check please post here", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2468811114/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2469373474", + "html_url": "https://github.com/laurent22/joplin/pull/11372#issuecomment-2469373474", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11372", + "id": 2469373474, + "node_id": "IC_kwDOBLftOs6TL6Yi", + "user": { + "login": "AdrienPoupa", + "id": 15086425, + "node_id": "MDQ6VXNlcjE1MDg2NDI1", + "avatar_url": "https://avatars.githubusercontent.com/u/15086425?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/AdrienPoupa", + "html_url": "https://github.com/AdrienPoupa", + "followers_url": "https://api.github.com/users/AdrienPoupa/followers", + "following_url": "https://api.github.com/users/AdrienPoupa/following{/other_user}", + "gists_url": "https://api.github.com/users/AdrienPoupa/gists{/gist_id}", + "starred_url": "https://api.github.com/users/AdrienPoupa/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/AdrienPoupa/subscriptions", + "organizations_url": "https://api.github.com/users/AdrienPoupa/orgs", + "repos_url": "https://api.github.com/users/AdrienPoupa/repos", + "events_url": "https://api.github.com/users/AdrienPoupa/events{/privacy}", + "received_events_url": "https://api.github.com/users/AdrienPoupa/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-12T00:58:50Z", + "updated_at": "2024-11-12T00:58:50Z", + "author_association": "CONTRIBUTOR", + "body": "I analyzed events and their usages, I found that we're creating events in TaskService's runTask just before and after the task is handled:\r\n```\r\nawait this.models.event().create(EventType.TaskStarted, id.toString());\r\n```\r\nand\r\n```\r\nawait this.models.event().create(EventType.TaskCompleted, id.toString());\r\n```\r\n\r\nIn `taskLastEvents`, we retrieve the last events for a given task:\r\n\r\n```\r\n\tpublic async taskLastEvents(id: TaskId): Promise {\r\n\t\treturn {\r\n\t\t\ttaskStarted: await this.models.event().lastEventByTypeAndName(EventType.TaskStarted, id.toString()),\r\n\t\t\ttaskCompleted: await this.models.event().lastEventByTypeAndName(EventType.TaskCompleted, id.toString()),\r\n\t\t};\r\n\t}\r\n```\r\n\r\nThis function, in turn, is used in the `admin/tasks` route to show task events (columns `Last Run` and `Last Completion`).\r\n\r\nThose were the only usages I could find, so they're here for auditing/debugging purposes, they have no impact on the behaviour of the application.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2469373474/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2469427219", + "html_url": "https://github.com/laurent22/joplin/pull/11372#issuecomment-2469427219", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11372", + "id": 2469427219, + "node_id": "IC_kwDOBLftOs6TMHgT", + "user": { + "login": "AdrienPoupa", + "id": 15086425, + "node_id": "MDQ6VXNlcjE1MDg2NDI1", + "avatar_url": "https://avatars.githubusercontent.com/u/15086425?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/AdrienPoupa", + "html_url": "https://github.com/AdrienPoupa", + "followers_url": "https://api.github.com/users/AdrienPoupa/followers", + "following_url": "https://api.github.com/users/AdrienPoupa/following{/other_user}", + "gists_url": "https://api.github.com/users/AdrienPoupa/gists{/gist_id}", + "starred_url": "https://api.github.com/users/AdrienPoupa/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/AdrienPoupa/subscriptions", + "organizations_url": "https://api.github.com/users/AdrienPoupa/orgs", + "repos_url": "https://api.github.com/users/AdrienPoupa/repos", + "events_url": "https://api.github.com/users/AdrienPoupa/events{/privacy}", + "received_events_url": "https://api.github.com/users/AdrienPoupa/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-12T01:48:15Z", + "updated_at": "2024-11-12T01:48:15Z", + "author_association": "CONTRIBUTOR", + "body": "I added two environment variables to enable the deletion and control the cut off period, and improved the test coverage. Hopefully that should do it :)", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2469427219/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2480835121", + "html_url": "https://github.com/laurent22/joplin/pull/11372#issuecomment-2480835121", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11372", + "id": 2480835121, + "node_id": "IC_kwDOBLftOs6T3oox", + "user": { + "login": "AdrienPoupa", + "id": 15086425, + "node_id": "MDQ6VXNlcjE1MDg2NDI1", + "avatar_url": "https://avatars.githubusercontent.com/u/15086425?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/AdrienPoupa", + "html_url": "https://github.com/AdrienPoupa", + "followers_url": "https://api.github.com/users/AdrienPoupa/followers", + "following_url": "https://api.github.com/users/AdrienPoupa/following{/other_user}", + "gists_url": "https://api.github.com/users/AdrienPoupa/gists{/gist_id}", + "starred_url": "https://api.github.com/users/AdrienPoupa/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/AdrienPoupa/subscriptions", + "organizations_url": "https://api.github.com/users/AdrienPoupa/orgs", + "repos_url": "https://api.github.com/users/AdrienPoupa/repos", + "events_url": "https://api.github.com/users/AdrienPoupa/events{/privacy}", + "received_events_url": "https://api.github.com/users/AdrienPoupa/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-16T22:40:28Z", + "updated_at": "2024-11-16T22:40:28Z", + "author_association": "CONTRIBUTOR", + "body": "> What's the meaning of setting EVENTS_AUTO_DELETE_AFTER_DAYS to 0? It deletes everything immediately?\r\n\r\nIt will delete events older than the current timestamp, so yes. I don't think that's an issue given you'd have to go ahead and actively set the config as such.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2480835121/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2593896192", + "html_url": "https://github.com/laurent22/joplin/pull/11372#issuecomment-2593896192", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11372", + "id": 2593896192, + "node_id": "IC_kwDOBLftOs6am7cA", + "user": { + "login": "ahayzen", + "id": 3669750, + "node_id": "MDQ6VXNlcjM2Njk3NTA=", + "avatar_url": "https://avatars.githubusercontent.com/u/3669750?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/ahayzen", + "html_url": "https://github.com/ahayzen", + "followers_url": "https://api.github.com/users/ahayzen/followers", + "following_url": "https://api.github.com/users/ahayzen/following{/other_user}", + "gists_url": "https://api.github.com/users/ahayzen/gists{/gist_id}", + "starred_url": "https://api.github.com/users/ahayzen/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/ahayzen/subscriptions", + "organizations_url": "https://api.github.com/users/ahayzen/orgs", + "repos_url": "https://api.github.com/users/ahayzen/repos", + "events_url": "https://api.github.com/users/ahayzen/events{/privacy}", + "received_events_url": "https://api.github.com/users/ahayzen/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-01-15T20:43:27Z", + "updated_at": "2025-01-15T20:43:27Z", + "author_association": "NONE", + "body": "Is there a timeframe for when there be a tagged server release that includes this fix on docker hub ? As it would be great to make use of this change. https://hub.docker.com/r/joplin/server/tags", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2593896192/reactions", + "total_count": 2, + "+1": 2, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/CGHoussem_18559408.json b/readme/cla/consent_records/CGHoussem_18559408.json new file mode 100644 index 0000000000..c0632d4a61 --- /dev/null +++ b/readme/cla/consent_records/CGHoussem_18559408.json @@ -0,0 +1,272 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11609", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11609/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11609/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11609/events", + "html_url": "https://github.com/laurent22/joplin/pull/11609", + "id": 2776312898, + "node_id": "PR_kwDOBLftOs6HIB4n", + "number": 11609, + "title": "Feature/fix GitHub action", + "user": { + "login": "CGHoussem", + "id": 18559408, + "node_id": "MDQ6VXNlcjE4NTU5NDA4", + "avatar_url": "https://avatars.githubusercontent.com/u/18559408?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/CGHoussem", + "html_url": "https://github.com/CGHoussem", + "followers_url": "https://api.github.com/users/CGHoussem/followers", + "following_url": "https://api.github.com/users/CGHoussem/following{/other_user}", + "gists_url": "https://api.github.com/users/CGHoussem/gists{/gist_id}", + "starred_url": "https://api.github.com/users/CGHoussem/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/CGHoussem/subscriptions", + "organizations_url": "https://api.github.com/users/CGHoussem/orgs", + "repos_url": "https://api.github.com/users/CGHoussem/repos", + "events_url": "https://api.github.com/users/CGHoussem/events{/privacy}", + "received_events_url": "https://api.github.com/users/CGHoussem/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 2, + "created_at": "2025-01-08T20:44:28Z", + "updated_at": "2025-01-08T20:59:51Z", + "closed_at": "2025-01-08T20:59:36Z", + "author_association": "NONE", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11609", + "html_url": "https://github.com/laurent22/joplin/pull/11609", + "diff_url": "https://github.com/laurent22/joplin/pull/11609.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11609.patch", + "merged_at": null + }, + "body": "", + "closed_by": { + "login": "CGHoussem", + "id": 18559408, + "node_id": "MDQ6VXNlcjE4NTU5NDA4", + "avatar_url": "https://avatars.githubusercontent.com/u/18559408?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/CGHoussem", + "html_url": "https://github.com/CGHoussem", + "followers_url": "https://api.github.com/users/CGHoussem/followers", + "following_url": "https://api.github.com/users/CGHoussem/following{/other_user}", + "gists_url": "https://api.github.com/users/CGHoussem/gists{/gist_id}", + "starred_url": "https://api.github.com/users/CGHoussem/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/CGHoussem/subscriptions", + "organizations_url": "https://api.github.com/users/CGHoussem/orgs", + "repos_url": "https://api.github.com/users/CGHoussem/repos", + "events_url": "https://api.github.com/users/CGHoussem/events{/privacy}", + "received_events_url": "https://api.github.com/users/CGHoussem/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11609/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11609/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2578628975", + "html_url": "https://github.com/laurent22/joplin/pull/11609#issuecomment-2578628975", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11609", + "id": 2578628975, + "node_id": "IC_kwDOBLftOs6ZssFv", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-01-08T20:44:43Z", + "updated_at": "2025-01-08T20:59:51Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2578628975/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2578647061", + "html_url": "https://github.com/laurent22/joplin/pull/11609#issuecomment-2578647061", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11609", + "id": 2578647061, + "node_id": "IC_kwDOBLftOs6ZswgV", + "user": { + "login": "CGHoussem", + "id": 18559408, + "node_id": "MDQ6VXNlcjE4NTU5NDA4", + "avatar_url": "https://avatars.githubusercontent.com/u/18559408?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/CGHoussem", + "html_url": "https://github.com/CGHoussem", + "followers_url": "https://api.github.com/users/CGHoussem/followers", + "following_url": "https://api.github.com/users/CGHoussem/following{/other_user}", + "gists_url": "https://api.github.com/users/CGHoussem/gists{/gist_id}", + "starred_url": "https://api.github.com/users/CGHoussem/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/CGHoussem/subscriptions", + "organizations_url": "https://api.github.com/users/CGHoussem/orgs", + "repos_url": "https://api.github.com/users/CGHoussem/repos", + "events_url": "https://api.github.com/users/CGHoussem/events{/privacy}", + "received_events_url": "https://api.github.com/users/CGHoussem/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-01-08T20:54:28Z", + "updated_at": "2025-01-08T20:54:28Z", + "author_association": "NONE", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2578647061/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/DMClVG_48882585.json b/readme/cla/consent_records/DMClVG_48882585.json new file mode 100644 index 0000000000..ba68964584 --- /dev/null +++ b/readme/cla/consent_records/DMClVG_48882585.json @@ -0,0 +1,272 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11938", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11938/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11938/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11938/events", + "html_url": "https://github.com/laurent22/joplin/pull/11938", + "id": 2900335784, + "node_id": "PR_kwDOBLftOs6Nosqh", + "number": 11938, + "title": "All: add giflib to devbox dependencies", + "user": { + "login": "DMClVG", + "id": 48882585, + "node_id": "MDQ6VXNlcjQ4ODgyNTg1", + "avatar_url": "https://avatars.githubusercontent.com/u/48882585?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/DMClVG", + "html_url": "https://github.com/DMClVG", + "followers_url": "https://api.github.com/users/DMClVG/followers", + "following_url": "https://api.github.com/users/DMClVG/following{/other_user}", + "gists_url": "https://api.github.com/users/DMClVG/gists{/gist_id}", + "starred_url": "https://api.github.com/users/DMClVG/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/DMClVG/subscriptions", + "organizations_url": "https://api.github.com/users/DMClVG/orgs", + "repos_url": "https://api.github.com/users/DMClVG/repos", + "events_url": "https://api.github.com/users/DMClVG/events{/privacy}", + "received_events_url": "https://api.github.com/users/DMClVG/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 2, + "created_at": "2025-03-06T12:53:23Z", + "updated_at": "2025-03-08T11:52:00Z", + "closed_at": "2025-03-08T11:51:49Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11938", + "html_url": "https://github.com/laurent22/joplin/pull/11938", + "diff_url": "https://github.com/laurent22/joplin/pull/11938.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11938.patch", + "merged_at": "2025-03-08T11:51:49Z" + }, + "body": "**Operating System**: Linux Mint\r\n\r\nThe dependency canvas@npm:2.11.2 wouldn't compile because of a missing header file, namely . See [build.log](https://github.com/user-attachments/files/19108490/canvas-build.log).\r\nThis PR adds giflib@latest to devbox, which resolves this issue.", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11938/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11938/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2703768530", + "html_url": "https://github.com/laurent22/joplin/pull/11938#issuecomment-2703768530", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11938", + "id": 2703768530, + "node_id": "IC_kwDOBLftOs6hKDvS", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-06T12:53:38Z", + "updated_at": "2025-03-08T11:52:00Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2703768530/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2703769566", + "html_url": "https://github.com/laurent22/joplin/pull/11938#issuecomment-2703769566", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11938", + "id": 2703769566, + "node_id": "IC_kwDOBLftOs6hKD_e", + "user": { + "login": "DMClVG", + "id": 48882585, + "node_id": "MDQ6VXNlcjQ4ODgyNTg1", + "avatar_url": "https://avatars.githubusercontent.com/u/48882585?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/DMClVG", + "html_url": "https://github.com/DMClVG", + "followers_url": "https://api.github.com/users/DMClVG/followers", + "following_url": "https://api.github.com/users/DMClVG/following{/other_user}", + "gists_url": "https://api.github.com/users/DMClVG/gists{/gist_id}", + "starred_url": "https://api.github.com/users/DMClVG/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/DMClVG/subscriptions", + "organizations_url": "https://api.github.com/users/DMClVG/orgs", + "repos_url": "https://api.github.com/users/DMClVG/repos", + "events_url": "https://api.github.com/users/DMClVG/events{/privacy}", + "received_events_url": "https://api.github.com/users/DMClVG/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-06T12:54:04Z", + "updated_at": "2025-03-06T12:54:04Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2703769566/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/GGpifas_103130352.json b/readme/cla/consent_records/GGpifas_103130352.json new file mode 100644 index 0000000000..1b25a7890b --- /dev/null +++ b/readme/cla/consent_records/GGpifas_103130352.json @@ -0,0 +1,452 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12060", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/12060/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/12060/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/12060/events", + "html_url": "https://github.com/laurent22/joplin/pull/12060", + "id": 2974193049, + "node_id": "PR_kwDOBLftOs6RgOYU", + "number": 12060, + "title": "Desktop: Fix #10403: size displayed wrong in attachements tab", + "user": { + "login": "GGpifas", + "id": 103130352, + "node_id": "U_kgDOBiWk8A", + "avatar_url": "https://avatars.githubusercontent.com/u/103130352?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/GGpifas", + "html_url": "https://github.com/GGpifas", + "followers_url": "https://api.github.com/users/GGpifas/followers", + "following_url": "https://api.github.com/users/GGpifas/following{/other_user}", + "gists_url": "https://api.github.com/users/GGpifas/gists{/gist_id}", + "starred_url": "https://api.github.com/users/GGpifas/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/GGpifas/subscriptions", + "organizations_url": "https://api.github.com/users/GGpifas/orgs", + "repos_url": "https://api.github.com/users/GGpifas/repos", + "events_url": "https://api.github.com/users/GGpifas/events{/privacy}", + "received_events_url": "https://api.github.com/users/GGpifas/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 6, + "created_at": "2025-04-05T13:10:13Z", + "updated_at": "2025-04-07T19:16:36Z", + "closed_at": "2025-04-07T19:00:32Z", + "author_association": "NONE", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/12060", + "html_url": "https://github.com/laurent22/joplin/pull/12060", + "diff_url": "https://github.com/laurent22/joplin/pull/12060.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/12060.patch", + "merged_at": null + }, + "body": "Whenever an attachment was modified and its size changes, the table and the database were not being updated. So the fix was to watch the resources who have been changed, immediately update the database and\r\nthe table. This assuming you are editing\r\nthe file while the app is open.\r\nIf you edit it while the app is closed,\r\ni made sure that when the table is loaded, it's updated.\r\n\r\nHere is a video for the fix:\r\nhttps://www.youtube.com/watch?v=LoLRCkLlxd4", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12060/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/12060/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780717352", + "html_url": "https://github.com/laurent22/joplin/pull/12060#issuecomment-2780717352", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12060", + "id": 2780717352, + "node_id": "IC_kwDOBLftOs6lvmEo", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-05T13:10:24Z", + "updated_at": "2025-04-07T19:02:28Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780717352/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780718340", + "html_url": "https://github.com/laurent22/joplin/pull/12060#issuecomment-2780718340", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12060", + "id": 2780718340, + "node_id": "IC_kwDOBLftOs6lvmUE", + "user": { + "login": "GGpifas", + "id": 103130352, + "node_id": "U_kgDOBiWk8A", + "avatar_url": "https://avatars.githubusercontent.com/u/103130352?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/GGpifas", + "html_url": "https://github.com/GGpifas", + "followers_url": "https://api.github.com/users/GGpifas/followers", + "following_url": "https://api.github.com/users/GGpifas/following{/other_user}", + "gists_url": "https://api.github.com/users/GGpifas/gists{/gist_id}", + "starred_url": "https://api.github.com/users/GGpifas/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/GGpifas/subscriptions", + "organizations_url": "https://api.github.com/users/GGpifas/orgs", + "repos_url": "https://api.github.com/users/GGpifas/repos", + "events_url": "https://api.github.com/users/GGpifas/events{/privacy}", + "received_events_url": "https://api.github.com/users/GGpifas/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-05T13:12:43Z", + "updated_at": "2025-04-05T13:12:43Z", + "author_association": "NONE", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780718340/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780789035", + "html_url": "https://github.com/laurent22/joplin/pull/12060#issuecomment-2780789035", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12060", + "id": 2780789035, + "node_id": "IC_kwDOBLftOs6lv3kr", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-05T14:49:59Z", + "updated_at": "2025-04-05T14:49:59Z", + "author_association": "OWNER", + "body": "I think the file size should be updated whenever the resource itself is being updated? In `ResourceEditWatcher` it's already watching the resources", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780789035/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2784282716", + "html_url": "https://github.com/laurent22/joplin/pull/12060#issuecomment-2784282716", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12060", + "id": 2784282716, + "node_id": "IC_kwDOBLftOs6l9Mhc", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-07T19:00:32Z", + "updated_at": "2025-04-07T19:00:32Z", + "author_association": "OWNER", + "body": "Please see above comment. For now I'm closing the PR but feel free to let me know if you're willing to address the above issue", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2784282716/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2784332963", + "html_url": "https://github.com/laurent22/joplin/pull/12060#issuecomment-2784332963", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12060", + "id": 2784332963, + "node_id": "IC_kwDOBLftOs6l9Yyj", + "user": { + "login": "GGpifas", + "id": 103130352, + "node_id": "U_kgDOBiWk8A", + "avatar_url": "https://avatars.githubusercontent.com/u/103130352?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/GGpifas", + "html_url": "https://github.com/GGpifas", + "followers_url": "https://api.github.com/users/GGpifas/followers", + "following_url": "https://api.github.com/users/GGpifas/following{/other_user}", + "gists_url": "https://api.github.com/users/GGpifas/gists{/gist_id}", + "starred_url": "https://api.github.com/users/GGpifas/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/GGpifas/subscriptions", + "organizations_url": "https://api.github.com/users/GGpifas/orgs", + "repos_url": "https://api.github.com/users/GGpifas/repos", + "events_url": "https://api.github.com/users/GGpifas/events{/privacy}", + "received_events_url": "https://api.github.com/users/GGpifas/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-07T19:13:47Z", + "updated_at": "2025-04-07T19:13:47Z", + "author_association": "NONE", + "body": "I'm so sorry for the time it took me to reply. I intend to address the issue, i haven't been able to work on it these days, but i will come back to it. I tried to change it on ResourceEditWatcher but the size wasn't changing on the table so i opted to do it on when the table is created.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2784332963/reactions", + "total_count": 1, + "+1": 1, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2784364496", + "html_url": "https://github.com/laurent22/joplin/pull/12060#issuecomment-2784364496", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12060", + "id": 2784364496, + "node_id": "IC_kwDOBLftOs6l9gfQ", + "user": { + "login": "GGpifas", + "id": 103130352, + "node_id": "U_kgDOBiWk8A", + "avatar_url": "https://avatars.githubusercontent.com/u/103130352?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/GGpifas", + "html_url": "https://github.com/GGpifas", + "followers_url": "https://api.github.com/users/GGpifas/followers", + "following_url": "https://api.github.com/users/GGpifas/following{/other_user}", + "gists_url": "https://api.github.com/users/GGpifas/gists{/gist_id}", + "starred_url": "https://api.github.com/users/GGpifas/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/GGpifas/subscriptions", + "organizations_url": "https://api.github.com/users/GGpifas/orgs", + "repos_url": "https://api.github.com/users/GGpifas/repos", + "events_url": "https://api.github.com/users/GGpifas/events{/privacy}", + "received_events_url": "https://api.github.com/users/GGpifas/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-07T19:16:35Z", + "updated_at": "2025-04-07T19:16:35Z", + "author_association": "NONE", + "body": "I'm so sorry for the time it took me to reply, I intend to work on it, and\r\nI messaged you on the closed pull request.\r\nHave a good one\r\n\r\nLaurent Cozic ***@***.***> escreveu (segunda, 7/04/2025 à(s)\r\n20:00):\r\n\r\n> Please see above comment. For now I'm closing the PR but feel free to let\r\n> me know if you're willing to address the above issue\r\n>\r\n> —\r\n> Reply to this email directly, view it on GitHub\r\n> ,\r\n> or unsubscribe\r\n> \r\n> .\r\n> You are receiving this because you authored the thread.Message ID:\r\n> ***@***.***>\r\n> [image: laurent22]*laurent22* left a comment (laurent22/joplin#12060)\r\n> \r\n>\r\n> Please see above comment. For now I'm closing the PR but feel free to let\r\n> me know if you're willing to address the above issue\r\n>\r\n> —\r\n> Reply to this email directly, view it on GitHub\r\n> ,\r\n> or unsubscribe\r\n> \r\n> .\r\n> You are receiving this because you authored the thread.Message ID:\r\n> ***@***.***>\r\n>\r\n", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2784364496/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/LEVIII007_132750919.json b/readme/cla/consent_records/LEVIII007_132750919.json new file mode 100644 index 0000000000..1612398dc4 --- /dev/null +++ b/readme/cla/consent_records/LEVIII007_132750919.json @@ -0,0 +1,452 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11345", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11345/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11345/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11345/events", + "html_url": "https://github.com/laurent22/joplin/pull/11345", + "id": 2644028682, + "node_id": "PR_kwDOBLftOs6BUgzN", + "number": 11345, + "title": "Desktop: Fix drop cursor styling issue (#11336)", + "user": { + "login": "LEVIII007", + "id": 132750919, + "node_id": "U_kgDOB-meRw", + "avatar_url": "https://avatars.githubusercontent.com/u/132750919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/LEVIII007", + "html_url": "https://github.com/LEVIII007", + "followers_url": "https://api.github.com/users/LEVIII007/followers", + "following_url": "https://api.github.com/users/LEVIII007/following{/other_user}", + "gists_url": "https://api.github.com/users/LEVIII007/gists{/gist_id}", + "starred_url": "https://api.github.com/users/LEVIII007/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/LEVIII007/subscriptions", + "organizations_url": "https://api.github.com/users/LEVIII007/orgs", + "repos_url": "https://api.github.com/users/LEVIII007/repos", + "events_url": "https://api.github.com/users/LEVIII007/events{/privacy}", + "received_events_url": "https://api.github.com/users/LEVIII007/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 6, + "created_at": "2024-11-08T13:14:06Z", + "updated_at": "2024-11-10T14:07:06Z", + "closed_at": "2024-11-10T14:06:54Z", + "author_association": "NONE", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11345", + "html_url": "https://github.com/laurent22/joplin/pull/11345", + "diff_url": "https://github.com/laurent22/joplin/pull/11345.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11345.patch", + "merged_at": "2024-11-10T14:06:54Z" + }, + "body": "# Summary\r\nThis pull request fixes the drop cursor styling issue in the desktop editor. Previously, the drop cursor's color was inconsistent and difficult to configure. This change ensures the drop cursor's color is directly customizable and aligns with the app's theme settings.\r\n\r\nFixes #11336\r\n \r\nNote\r\nThis pull request targets release-3.1.23\r\n\r\n\r\nDemo after change : \r\nScreenshot showing the drop cursor in white colour while dragging a file in dark mode: \r\n\r\nhttps://github.com/user-attachments/assets/1046bf18-2f3d-4d2d-a1e9-9e967469266e\r\n\r\n", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11345/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11345/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2464755597", + "html_url": "https://github.com/laurent22/joplin/pull/11345#issuecomment-2464755597", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11345", + "id": 2464755597, + "node_id": "IC_kwDOBLftOs6S6S-N", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-08T13:20:41Z", + "updated_at": "2024-11-10T14:07:06Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2464755597/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2464781840", + "html_url": "https://github.com/laurent22/joplin/pull/11345#issuecomment-2464781840", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11345", + "id": 2464781840, + "node_id": "IC_kwDOBLftOs6S6ZYQ", + "user": { + "login": "LEVIII007", + "id": 132750919, + "node_id": "U_kgDOB-meRw", + "avatar_url": "https://avatars.githubusercontent.com/u/132750919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/LEVIII007", + "html_url": "https://github.com/LEVIII007", + "followers_url": "https://api.github.com/users/LEVIII007/followers", + "following_url": "https://api.github.com/users/LEVIII007/following{/other_user}", + "gists_url": "https://api.github.com/users/LEVIII007/gists{/gist_id}", + "starred_url": "https://api.github.com/users/LEVIII007/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/LEVIII007/subscriptions", + "organizations_url": "https://api.github.com/users/LEVIII007/orgs", + "repos_url": "https://api.github.com/users/LEVIII007/repos", + "events_url": "https://api.github.com/users/LEVIII007/events{/privacy}", + "received_events_url": "https://api.github.com/users/LEVIII007/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-08T13:34:00Z", + "updated_at": "2024-11-08T13:34:00Z", + "author_association": "NONE", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2464781840/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2465058136", + "html_url": "https://github.com/laurent22/joplin/pull/11345#issuecomment-2465058136", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11345", + "id": 2465058136, + "node_id": "IC_kwDOBLftOs6S7c1Y", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-08T15:35:01Z", + "updated_at": "2024-11-08T15:35:01Z", + "author_association": "OWNER", + "body": "recheck", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2465058136/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2465521983", + "html_url": "https://github.com/laurent22/joplin/pull/11345#issuecomment-2465521983", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11345", + "id": 2465521983, + "node_id": "IC_kwDOBLftOs6S9OE_", + "user": { + "login": "LEVIII007", + "id": 132750919, + "node_id": "U_kgDOB-meRw", + "avatar_url": "https://avatars.githubusercontent.com/u/132750919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/LEVIII007", + "html_url": "https://github.com/LEVIII007", + "followers_url": "https://api.github.com/users/LEVIII007/followers", + "following_url": "https://api.github.com/users/LEVIII007/following{/other_user}", + "gists_url": "https://api.github.com/users/LEVIII007/gists{/gist_id}", + "starred_url": "https://api.github.com/users/LEVIII007/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/LEVIII007/subscriptions", + "organizations_url": "https://api.github.com/users/LEVIII007/orgs", + "repos_url": "https://api.github.com/users/LEVIII007/repos", + "events_url": "https://api.github.com/users/LEVIII007/events{/privacy}", + "received_events_url": "https://api.github.com/users/LEVIII007/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-08T18:46:36Z", + "updated_at": "2024-11-08T18:46:36Z", + "author_association": "NONE", + "body": "@laurent22 It seems the action is unable to update the readme/cla_signatures.json file due to required status checks. All contributors, including myself, have signed the CLA as indicated in the comments, but this error is still blocking the checks.\r\n\r\nCould you please take a look or advise on how to resolve this?\r\n\r\nThank you for your time and help!", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2465521983/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2466461432", + "html_url": "https://github.com/laurent22/joplin/pull/11345#issuecomment-2466461432", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11345", + "id": 2466461432, + "node_id": "IC_kwDOBLftOs6TAzb4", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-09T21:12:52Z", + "updated_at": "2024-11-09T21:12:52Z", + "author_association": "OWNER", + "body": "recheck", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2466461432/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2466750410", + "html_url": "https://github.com/laurent22/joplin/pull/11345#issuecomment-2466750410", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11345", + "id": 2466750410, + "node_id": "IC_kwDOBLftOs6TB5_K", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-10T14:07:02Z", + "updated_at": "2024-11-10T14:07:02Z", + "author_association": "OWNER", + "body": "Looks good, thanks for the fix", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2466750410/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/MietVdh_20527357.json b/readme/cla/consent_records/MietVdh_20527357.json new file mode 100644 index 0000000000..78dc837fac --- /dev/null +++ b/readme/cla/consent_records/MietVdh_20527357.json @@ -0,0 +1,687 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12080", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/12080/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/12080/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/12080/events", + "html_url": "https://github.com/laurent22/joplin/pull/12080", + "id": 2983954109, + "node_id": "PR_kwDOBLftOs6SAka8", + "number": 12080, + "title": "Completed Dutch (Belgium) translation", + "user": { + "login": "MietVdh", + "id": 20527357, + "node_id": "MDQ6VXNlcjIwNTI3MzU3", + "avatar_url": "https://avatars.githubusercontent.com/u/20527357?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/MietVdh", + "html_url": "https://github.com/MietVdh", + "followers_url": "https://api.github.com/users/MietVdh/followers", + "following_url": "https://api.github.com/users/MietVdh/following{/other_user}", + "gists_url": "https://api.github.com/users/MietVdh/gists{/gist_id}", + "starred_url": "https://api.github.com/users/MietVdh/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/MietVdh/subscriptions", + "organizations_url": "https://api.github.com/users/MietVdh/orgs", + "repos_url": "https://api.github.com/users/MietVdh/repos", + "events_url": "https://api.github.com/users/MietVdh/events{/privacy}", + "received_events_url": "https://api.github.com/users/MietVdh/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [ + { + "id": 1091621259, + "node_id": "MDU6TGFiZWwxMDkxNjIxMjU5", + "url": "https://api.github.com/repos/laurent22/joplin/labels/translation", + "name": "translation", + "color": "91ca55", + "default": false, + "description": "i18n and l10n" + } + ], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 11, + "created_at": "2025-04-09T21:29:21Z", + "updated_at": "2025-04-10T00:51:31Z", + "closed_at": "2025-04-10T00:51:17Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/12080", + "html_url": "https://github.com/laurent22/joplin/pull/12080", + "diff_url": "https://github.com/laurent22/joplin/pull/12080.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/12080.patch", + "merged_at": "2025-04-10T00:51:17Z" + }, + "body": "Completed the Dutch (Belgium) translation. ", + "closed_by": { + "login": "tessus", + "id": 223439, + "node_id": "MDQ6VXNlcjIyMzQzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tessus", + "html_url": "https://github.com/tessus", + "followers_url": "https://api.github.com/users/tessus/followers", + "following_url": "https://api.github.com/users/tessus/following{/other_user}", + "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", + "organizations_url": "https://api.github.com/users/tessus/orgs", + "repos_url": "https://api.github.com/users/tessus/repos", + "events_url": "https://api.github.com/users/tessus/events{/privacy}", + "received_events_url": "https://api.github.com/users/tessus/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12080/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/12080/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2791037892", + "html_url": "https://github.com/laurent22/joplin/pull/12080#issuecomment-2791037892", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12080", + "id": 2791037892, + "node_id": "IC_kwDOBLftOs6mW9vE", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-09T21:29:34Z", + "updated_at": "2025-04-10T00:51:30Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2791037892/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2791040562", + "html_url": "https://github.com/laurent22/joplin/pull/12080#issuecomment-2791040562", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12080", + "id": 2791040562, + "node_id": "IC_kwDOBLftOs6mW-Yy", + "user": { + "login": "MietVdh", + "id": 20527357, + "node_id": "MDQ6VXNlcjIwNTI3MzU3", + "avatar_url": "https://avatars.githubusercontent.com/u/20527357?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/MietVdh", + "html_url": "https://github.com/MietVdh", + "followers_url": "https://api.github.com/users/MietVdh/followers", + "following_url": "https://api.github.com/users/MietVdh/following{/other_user}", + "gists_url": "https://api.github.com/users/MietVdh/gists{/gist_id}", + "starred_url": "https://api.github.com/users/MietVdh/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/MietVdh/subscriptions", + "organizations_url": "https://api.github.com/users/MietVdh/orgs", + "repos_url": "https://api.github.com/users/MietVdh/repos", + "events_url": "https://api.github.com/users/MietVdh/events{/privacy}", + "received_events_url": "https://api.github.com/users/MietVdh/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-09T21:31:17Z", + "updated_at": "2025-04-09T21:31:17Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2791040562/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2791090381", + "html_url": "https://github.com/laurent22/joplin/pull/12080#issuecomment-2791090381", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12080", + "id": 2791090381, + "node_id": "IC_kwDOBLftOs6mXKjN", + "user": { + "login": "tessus", + "id": 223439, + "node_id": "MDQ6VXNlcjIyMzQzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tessus", + "html_url": "https://github.com/tessus", + "followers_url": "https://api.github.com/users/tessus/followers", + "following_url": "https://api.github.com/users/tessus/following{/other_user}", + "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", + "organizations_url": "https://api.github.com/users/tessus/orgs", + "repos_url": "https://api.github.com/users/tessus/repos", + "events_url": "https://api.github.com/users/tessus/events{/privacy}", + "received_events_url": "https://api.github.com/users/tessus/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-09T22:05:51Z", + "updated_at": "2025-04-09T22:05:51Z", + "author_association": "COLLABORATOR", + "body": "recheck", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2791090381/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2791125401", + "html_url": "https://github.com/laurent22/joplin/pull/12080#issuecomment-2791125401", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12080", + "id": 2791125401, + "node_id": "IC_kwDOBLftOs6mXTGZ", + "user": { + "login": "MietVdh", + "id": 20527357, + "node_id": "MDQ6VXNlcjIwNTI3MzU3", + "avatar_url": "https://avatars.githubusercontent.com/u/20527357?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/MietVdh", + "html_url": "https://github.com/MietVdh", + "followers_url": "https://api.github.com/users/MietVdh/followers", + "following_url": "https://api.github.com/users/MietVdh/following{/other_user}", + "gists_url": "https://api.github.com/users/MietVdh/gists{/gist_id}", + "starred_url": "https://api.github.com/users/MietVdh/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/MietVdh/subscriptions", + "organizations_url": "https://api.github.com/users/MietVdh/orgs", + "repos_url": "https://api.github.com/users/MietVdh/repos", + "events_url": "https://api.github.com/users/MietVdh/events{/privacy}", + "received_events_url": "https://api.github.com/users/MietVdh/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-09T22:32:18Z", + "updated_at": "2025-04-09T22:32:18Z", + "author_association": "CONTRIBUTOR", + "body": "> Hmm, there is a validation error for the .po file:\r\n> \r\n> ```\r\n> Step: Validating translations...\r\n> Error: Command failed: msgfmt -v \"/home/runner/work/joplin/joplin/packages/tools/../../packages/tools/locales/nl_BE.po\"\r\n> /home/runner/work/joplin/joplin/packages/tools/../../packages/tools/locales/nl_BE.po:14: end-of-line within string\r\n> msgfmt: found 1 fatal error\r\n> ```\r\n> \r\n> Did you use Poedit?\r\n\r\nI did, then pasted it into VS Code to update the Last Translator name, since I couldn't figure out how to do that in Poedit. \r\nSorry, this is my first time working with Poedit (and attempting to contribute).", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2791125401/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2791132991", + "html_url": "https://github.com/laurent22/joplin/pull/12080#issuecomment-2791132991", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12080", + "id": 2791132991, + "node_id": "IC_kwDOBLftOs6mXU8_", + "user": { + "login": "tessus", + "id": 223439, + "node_id": "MDQ6VXNlcjIyMzQzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tessus", + "html_url": "https://github.com/tessus", + "followers_url": "https://api.github.com/users/tessus/followers", + "following_url": "https://api.github.com/users/tessus/following{/other_user}", + "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", + "organizations_url": "https://api.github.com/users/tessus/orgs", + "repos_url": "https://api.github.com/users/tessus/repos", + "events_url": "https://api.github.com/users/tessus/events{/privacy}", + "received_events_url": "https://api.github.com/users/tessus/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-09T22:38:33Z", + "updated_at": "2025-04-09T22:38:33Z", + "author_association": "COLLABORATOR", + "body": "I think the translator name is added when you add your info in poedit in the settings.\r\n\r\n\"image\"\r\n\r\nTry to set your info there and see what happens. No worries, we'll figure it out.\r\nI also know how to fix this, but we should try to make it work with Poedit. As you can see manual changes are pretty error prone.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2791132991/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2791142141", + "html_url": "https://github.com/laurent22/joplin/pull/12080#issuecomment-2791142141", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12080", + "id": 2791142141, + "node_id": "IC_kwDOBLftOs6mXXL9", + "user": { + "login": "MietVdh", + "id": 20527357, + "node_id": "MDQ6VXNlcjIwNTI3MzU3", + "avatar_url": "https://avatars.githubusercontent.com/u/20527357?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/MietVdh", + "html_url": "https://github.com/MietVdh", + "followers_url": "https://api.github.com/users/MietVdh/followers", + "following_url": "https://api.github.com/users/MietVdh/following{/other_user}", + "gists_url": "https://api.github.com/users/MietVdh/gists{/gist_id}", + "starred_url": "https://api.github.com/users/MietVdh/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/MietVdh/subscriptions", + "organizations_url": "https://api.github.com/users/MietVdh/orgs", + "repos_url": "https://api.github.com/users/MietVdh/repos", + "events_url": "https://api.github.com/users/MietVdh/events{/privacy}", + "received_events_url": "https://api.github.com/users/MietVdh/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-09T22:46:28Z", + "updated_at": "2025-04-09T22:46:28Z", + "author_association": "CONTRIBUTOR", + "body": "So I replaced the file I had with the one I originally worked on in Poedit and did not make any changes to using other software, and I noticed I'm still getting a warning from Git that \"in the working copy of 'packages/tools/locales/nl_BE.po', LF will be replaced by CRLF the next time Git touches it\". Might that be causing the issue? ", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2791142141/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2791142578", + "html_url": "https://github.com/laurent22/joplin/pull/12080#issuecomment-2791142578", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12080", + "id": 2791142578, + "node_id": "IC_kwDOBLftOs6mXXSy", + "user": { + "login": "tessus", + "id": 223439, + "node_id": "MDQ6VXNlcjIyMzQzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tessus", + "html_url": "https://github.com/tessus", + "followers_url": "https://api.github.com/users/tessus/followers", + "following_url": "https://api.github.com/users/tessus/following{/other_user}", + "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", + "organizations_url": "https://api.github.com/users/tessus/orgs", + "repos_url": "https://api.github.com/users/tessus/repos", + "events_url": "https://api.github.com/users/tessus/events{/privacy}", + "received_events_url": "https://api.github.com/users/tessus/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-09T22:46:51Z", + "updated_at": "2025-04-09T22:46:51Z", + "author_association": "COLLABORATOR", + "body": "Btw, thanks a bunch for the extensive translation work. Also, welcome to the Joplin project! ", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2791142578/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2791152039", + "html_url": "https://github.com/laurent22/joplin/pull/12080#issuecomment-2791152039", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12080", + "id": 2791152039, + "node_id": "IC_kwDOBLftOs6mXZmn", + "user": { + "login": "tessus", + "id": 223439, + "node_id": "MDQ6VXNlcjIyMzQzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tessus", + "html_url": "https://github.com/tessus", + "followers_url": "https://api.github.com/users/tessus/followers", + "following_url": "https://api.github.com/users/tessus/following{/other_user}", + "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", + "organizations_url": "https://api.github.com/users/tessus/orgs", + "repos_url": "https://api.github.com/users/tessus/repos", + "events_url": "https://api.github.com/users/tessus/events{/privacy}", + "received_events_url": "https://api.github.com/users/tessus/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-09T22:55:29Z", + "updated_at": "2025-04-09T22:55:29Z", + "author_association": "COLLABORATOR", + "body": "No, the issue you are seeing is about line ending characters.\r\n\r\n\"image\"\r\n\r\nIt might be possible that you are using git on windows that translates unix to windows line endings. At least on your end. It should translate it back when you push the file. Unless there are some weird git settings active.\r\nI haven't touched windows for over 20 years, so I am not really going to be of much help here.\r\n\r\nBut, if you set the line endings in poedit ro unix, all should be good.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2791152039/reactions", + "total_count": 1, + "+1": 1, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2791154112", + "html_url": "https://github.com/laurent22/joplin/pull/12080#issuecomment-2791154112", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12080", + "id": 2791154112, + "node_id": "IC_kwDOBLftOs6mXaHA", + "user": { + "login": "tessus", + "id": 223439, + "node_id": "MDQ6VXNlcjIyMzQzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tessus", + "html_url": "https://github.com/tessus", + "followers_url": "https://api.github.com/users/tessus/followers", + "following_url": "https://api.github.com/users/tessus/following{/other_user}", + "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", + "organizations_url": "https://api.github.com/users/tessus/orgs", + "repos_url": "https://api.github.com/users/tessus/repos", + "events_url": "https://api.github.com/users/tessus/events{/privacy}", + "received_events_url": "https://api.github.com/users/tessus/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-09T22:57:19Z", + "updated_at": "2025-04-09T22:57:19Z", + "author_association": "COLLABORATOR", + "body": "The issue was that you did not end line 13 with a double quote when you manually edited the file. ", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2791154112/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2791158484", + "html_url": "https://github.com/laurent22/joplin/pull/12080#issuecomment-2791158484", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12080", + "id": 2791158484, + "node_id": "IC_kwDOBLftOs6mXbLU", + "user": { + "login": "tessus", + "id": 223439, + "node_id": "MDQ6VXNlcjIyMzQzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tessus", + "html_url": "https://github.com/tessus", + "followers_url": "https://api.github.com/users/tessus/followers", + "following_url": "https://api.github.com/users/tessus/following{/other_user}", + "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", + "organizations_url": "https://api.github.com/users/tessus/orgs", + "repos_url": "https://api.github.com/users/tessus/repos", + "events_url": "https://api.github.com/users/tessus/events{/privacy}", + "received_events_url": "https://api.github.com/users/tessus/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-09T23:01:18Z", + "updated_at": "2025-04-09T23:01:18Z", + "author_association": "COLLABORATOR", + "body": "I am just trying to get you up and running with Poedit, so that future updates are easier. Manually hacking po files is not a good idea. It's easy to miss an escape character or in yuor case a double quote.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2791158484/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2791201665", + "html_url": "https://github.com/laurent22/joplin/pull/12080#issuecomment-2791201665", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12080", + "id": 2791201665, + "node_id": "IC_kwDOBLftOs6mXluB", + "user": { + "login": "MietVdh", + "id": 20527357, + "node_id": "MDQ6VXNlcjIwNTI3MzU3", + "avatar_url": "https://avatars.githubusercontent.com/u/20527357?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/MietVdh", + "html_url": "https://github.com/MietVdh", + "followers_url": "https://api.github.com/users/MietVdh/followers", + "following_url": "https://api.github.com/users/MietVdh/following{/other_user}", + "gists_url": "https://api.github.com/users/MietVdh/gists{/gist_id}", + "starred_url": "https://api.github.com/users/MietVdh/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/MietVdh/subscriptions", + "organizations_url": "https://api.github.com/users/MietVdh/orgs", + "repos_url": "https://api.github.com/users/MietVdh/repos", + "events_url": "https://api.github.com/users/MietVdh/events{/privacy}", + "received_events_url": "https://api.github.com/users/MietVdh/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-09T23:39:55Z", + "updated_at": "2025-04-09T23:39:55Z", + "author_association": "CONTRIBUTOR", + "body": "> I am just trying to get you up and running with Poedit, so that future updates are easier. Manually hacking po files is not a good idea. It's easy to miss an escape character or in yuor case a double quote.\r\n\r\nI appreciate it; thank you!", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2791201665/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/MorbidMiyako_57117884.json b/readme/cla/consent_records/MorbidMiyako_57117884.json new file mode 100644 index 0000000000..8d124ccd84 --- /dev/null +++ b/readme/cla/consent_records/MorbidMiyako_57117884.json @@ -0,0 +1,477 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12051", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/12051/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/12051/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/12051/events", + "html_url": "https://github.com/laurent22/joplin/pull/12051", + "id": 2970682651, + "node_id": "PR_kwDOBLftOs6RUYKf", + "number": 12051, + "title": "Desktop: Resolves issue #12039: Checks whether there exists a deleted folder in order to determine if Trash is collapsible", + "user": { + "login": "MorbidMiyako", + "id": 57117884, + "node_id": "MDQ6VXNlcjU3MTE3ODg0", + "avatar_url": "https://avatars.githubusercontent.com/u/57117884?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/MorbidMiyako", + "html_url": "https://github.com/MorbidMiyako", + "followers_url": "https://api.github.com/users/MorbidMiyako/followers", + "following_url": "https://api.github.com/users/MorbidMiyako/following{/other_user}", + "gists_url": "https://api.github.com/users/MorbidMiyako/gists{/gist_id}", + "starred_url": "https://api.github.com/users/MorbidMiyako/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/MorbidMiyako/subscriptions", + "organizations_url": "https://api.github.com/users/MorbidMiyako/orgs", + "repos_url": "https://api.github.com/users/MorbidMiyako/repos", + "events_url": "https://api.github.com/users/MorbidMiyako/events{/privacy}", + "received_events_url": "https://api.github.com/users/MorbidMiyako/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "open", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 7, + "created_at": "2025-04-03T21:02:01Z", + "updated_at": "2025-04-18T14:58:28Z", + "closed_at": null, + "author_association": "FIRST_TIME_CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/12051", + "html_url": "https://github.com/laurent22/joplin/pull/12051", + "diff_url": "https://github.com/laurent22/joplin/pull/12051.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/12051.patch", + "merged_at": null + }, + "body": "The new approach simply checks if there exists a folder with a deleted_time.\r\nIt seems that the only aspect influencing whether Trash is collapsible is the presence of a folder.\r\nIf this is to change, then its likely this information can be found in the store.\r\nThere are also a few safeguards implemented.\r\nFIrstly, if the issue of the Trash folder.childern.size reporting 0 regardless is resolved, it will simply skip over this addition.\r\nSecondly, by breaking as soon as proof is found Trash contains a folder any unnecessary iterations are prevented.\r\n\r\nUsing the store might allow for determining the number of items in the Trash, something that was commented to be considered tricky. Although I assume communication regarding this subject should be moved to the forum.\r\n\r\nFollowing is a visual explanation of the new behaviour: \r\n\r\nBy clicking the collapse all button its now possible to go between the following two states:\r\n![image](https://github.com/user-attachments/assets/176e2f6a-cc20-4091-b50c-d6e4b72fcf2d)\r\n![image](https://github.com/user-attachments/assets/757f70b6-9d32-4674-a42a-abfcc275cbfa)\r\n\r\nSee issue #12039 for more information regarding the bug that's resolved.\r\n\r\n", + "closed_by": null, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12051/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/12051/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2776911669", + "html_url": "https://github.com/laurent22/joplin/pull/12051#issuecomment-2776911669", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12051", + "id": 2776911669, + "node_id": "IC_kwDOBLftOs6lhE81", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-03T21:02:14Z", + "updated_at": "2025-04-18T14:58:27Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2776911669/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2776912066", + "html_url": "https://github.com/laurent22/joplin/pull/12051#issuecomment-2776912066", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12051", + "id": 2776912066, + "node_id": "IC_kwDOBLftOs6lhFDC", + "user": { + "login": "MorbidMiyako", + "id": 57117884, + "node_id": "MDQ6VXNlcjU3MTE3ODg0", + "avatar_url": "https://avatars.githubusercontent.com/u/57117884?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/MorbidMiyako", + "html_url": "https://github.com/MorbidMiyako", + "followers_url": "https://api.github.com/users/MorbidMiyako/followers", + "following_url": "https://api.github.com/users/MorbidMiyako/following{/other_user}", + "gists_url": "https://api.github.com/users/MorbidMiyako/gists{/gist_id}", + "starred_url": "https://api.github.com/users/MorbidMiyako/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/MorbidMiyako/subscriptions", + "organizations_url": "https://api.github.com/users/MorbidMiyako/orgs", + "repos_url": "https://api.github.com/users/MorbidMiyako/repos", + "events_url": "https://api.github.com/users/MorbidMiyako/events{/privacy}", + "received_events_url": "https://api.github.com/users/MorbidMiyako/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-03T21:02:26Z", + "updated_at": "2025-04-03T21:02:26Z", + "author_association": "NONE", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2776912066/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2779041640", + "html_url": "https://github.com/laurent22/joplin/pull/12051#issuecomment-2779041640", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12051", + "id": 2779041640, + "node_id": "IC_kwDOBLftOs6lpM9o", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-04T15:18:42Z", + "updated_at": "2025-04-04T15:18:42Z", + "author_association": "OWNER", + "body": "Thanks for looking into it. Does that also collapse/expand the nested notebooks inside the trash folder?", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2779041640/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2779046378", + "html_url": "https://github.com/laurent22/joplin/pull/12051#issuecomment-2779046378", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12051", + "id": 2779046378, + "node_id": "IC_kwDOBLftOs6lpOHq", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-04T15:19:36Z", + "updated_at": "2025-04-04T15:19:36Z", + "author_association": "OWNER", + "body": "Also it would be good to add tests if possible. I seem to remember I've added some for the collapse/expand logic", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2779046378/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2779633639", + "html_url": "https://github.com/laurent22/joplin/pull/12051#issuecomment-2779633639", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12051", + "id": 2779633639, + "node_id": "IC_kwDOBLftOs6lrdfn", + "user": { + "login": "MorbidMiyako", + "id": 57117884, + "node_id": "MDQ6VXNlcjU3MTE3ODg0", + "avatar_url": "https://avatars.githubusercontent.com/u/57117884?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/MorbidMiyako", + "html_url": "https://github.com/MorbidMiyako", + "followers_url": "https://api.github.com/users/MorbidMiyako/followers", + "following_url": "https://api.github.com/users/MorbidMiyako/following{/other_user}", + "gists_url": "https://api.github.com/users/MorbidMiyako/gists{/gist_id}", + "starred_url": "https://api.github.com/users/MorbidMiyako/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/MorbidMiyako/subscriptions", + "organizations_url": "https://api.github.com/users/MorbidMiyako/orgs", + "repos_url": "https://api.github.com/users/MorbidMiyako/repos", + "events_url": "https://api.github.com/users/MorbidMiyako/events{/privacy}", + "received_events_url": "https://api.github.com/users/MorbidMiyako/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-04T20:03:44Z", + "updated_at": "2025-04-04T20:03:44Z", + "author_association": "NONE", + "body": "In response to your first question, yes all folders inside of Trash are also collapsed/expanded.\r\nI did not find a test for this file yet, but I've made one. \r\nIt works on the same assumption that if there is a folder in Trash then Trash should be collapsable/expandable.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2779633639/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2805081290", + "html_url": "https://github.com/laurent22/joplin/pull/12051#issuecomment-2805081290", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12051", + "id": 2805081290, + "node_id": "IC_kwDOBLftOs6nMiTK", + "user": { + "login": "MorbidMiyako", + "id": 57117884, + "node_id": "MDQ6VXNlcjU3MTE3ODg0", + "avatar_url": "https://avatars.githubusercontent.com/u/57117884?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/MorbidMiyako", + "html_url": "https://github.com/MorbidMiyako", + "followers_url": "https://api.github.com/users/MorbidMiyako/followers", + "following_url": "https://api.github.com/users/MorbidMiyako/following{/other_user}", + "gists_url": "https://api.github.com/users/MorbidMiyako/gists{/gist_id}", + "starred_url": "https://api.github.com/users/MorbidMiyako/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/MorbidMiyako/subscriptions", + "organizations_url": "https://api.github.com/users/MorbidMiyako/orgs", + "repos_url": "https://api.github.com/users/MorbidMiyako/repos", + "events_url": "https://api.github.com/users/MorbidMiyako/events{/privacy}", + "received_events_url": "https://api.github.com/users/MorbidMiyako/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-15T13:35:05Z", + "updated_at": "2025-04-15T13:35:05Z", + "author_association": "NONE", + "body": "All issues should now be resolved, let me know if there is anything else", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2805081290/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2812642158", + "html_url": "https://github.com/laurent22/joplin/pull/12051#issuecomment-2812642158", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12051", + "id": 2812642158, + "node_id": "IC_kwDOBLftOs6npYNu", + "user": { + "login": "MorbidMiyako", + "id": 57117884, + "node_id": "MDQ6VXNlcjU3MTE3ODg0", + "avatar_url": "https://avatars.githubusercontent.com/u/57117884?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/MorbidMiyako", + "html_url": "https://github.com/MorbidMiyako", + "followers_url": "https://api.github.com/users/MorbidMiyako/followers", + "following_url": "https://api.github.com/users/MorbidMiyako/following{/other_user}", + "gists_url": "https://api.github.com/users/MorbidMiyako/gists{/gist_id}", + "starred_url": "https://api.github.com/users/MorbidMiyako/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/MorbidMiyako/subscriptions", + "organizations_url": "https://api.github.com/users/MorbidMiyako/orgs", + "repos_url": "https://api.github.com/users/MorbidMiyako/repos", + "events_url": "https://api.github.com/users/MorbidMiyako/events{/privacy}", + "received_events_url": "https://api.github.com/users/MorbidMiyako/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-17T11:59:15Z", + "updated_at": "2025-04-17T11:59:15Z", + "author_association": "NONE", + "body": "@personalizedrefrigerator Please let me know if there are any other changes needed/desired.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2812642158/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/Paramesh-T-S_42896229.json b/readme/cla/consent_records/Paramesh-T-S_42896229.json new file mode 100644 index 0000000000..921812aa01 --- /dev/null +++ b/readme/cla/consent_records/Paramesh-T-S_42896229.json @@ -0,0 +1,407 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11932", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11932/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11932/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11932/events", + "html_url": "https://github.com/laurent22/joplin/pull/11932", + "id": 2898302671, + "node_id": "PR_kwDOBLftOs6NhuI7", + "number": 11932, + "title": "All : Fix for Share with Nobody : Added proper error message", + "user": { + "login": "Paramesh-T-S", + "id": 42896229, + "node_id": "MDQ6VXNlcjQyODk2MjI5", + "avatar_url": "https://avatars.githubusercontent.com/u/42896229?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/Paramesh-T-S", + "html_url": "https://github.com/Paramesh-T-S", + "followers_url": "https://api.github.com/users/Paramesh-T-S/followers", + "following_url": "https://api.github.com/users/Paramesh-T-S/following{/other_user}", + "gists_url": "https://api.github.com/users/Paramesh-T-S/gists{/gist_id}", + "starred_url": "https://api.github.com/users/Paramesh-T-S/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/Paramesh-T-S/subscriptions", + "organizations_url": "https://api.github.com/users/Paramesh-T-S/orgs", + "repos_url": "https://api.github.com/users/Paramesh-T-S/repos", + "events_url": "https://api.github.com/users/Paramesh-T-S/events{/privacy}", + "received_events_url": "https://api.github.com/users/Paramesh-T-S/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 5, + "created_at": "2025-03-05T19:44:59Z", + "updated_at": "2025-03-06T15:58:24Z", + "closed_at": "2025-03-06T15:58:11Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11932", + "html_url": "https://github.com/laurent22/joplin/pull/11932", + "diff_url": "https://github.com/laurent22/joplin/pull/11932.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11932.patch", + "merged_at": "2025-03-06T15:58:11Z" + }, + "body": "**Summary :** \r\n\r\n- All: Resolves #11923 - Fix added with Proper error message - \"Kindly provide proper recipient address\"\r\n\r\nThis pull request contains fix which throws error with message \"Kindly provide proper recipient address\", so that user will know the issue and act accordingly. Added screenshots below.\r\n\r\n![image](https://github.com/user-attachments/assets/3d723d2d-83fb-4a26-87ba-6b418b8aee91)\r\n\r\nManual Test Process :\r\n1. Configure Synchronization target as Joplin server.\r\n2. Click and open \"Share notebook\" dialog under \"Notebook\" menu.\r\n3. Enter nothing under \"Add recipient\" Text box, Click share.\r\n4. You will see the proper message associated with it.\r\n", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11932/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11932/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2701906757", + "html_url": "https://github.com/laurent22/joplin/pull/11932#issuecomment-2701906757", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11932", + "id": 2701906757, + "node_id": "IC_kwDOBLftOs6hC9NF", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-05T19:45:12Z", + "updated_at": "2025-03-06T15:58:24Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2701906757/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2701911147", + "html_url": "https://github.com/laurent22/joplin/pull/11932#issuecomment-2701911147", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11932", + "id": 2701911147, + "node_id": "IC_kwDOBLftOs6hC-Rr", + "user": { + "login": "Paramesh-T-S", + "id": 42896229, + "node_id": "MDQ6VXNlcjQyODk2MjI5", + "avatar_url": "https://avatars.githubusercontent.com/u/42896229?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/Paramesh-T-S", + "html_url": "https://github.com/Paramesh-T-S", + "followers_url": "https://api.github.com/users/Paramesh-T-S/followers", + "following_url": "https://api.github.com/users/Paramesh-T-S/following{/other_user}", + "gists_url": "https://api.github.com/users/Paramesh-T-S/gists{/gist_id}", + "starred_url": "https://api.github.com/users/Paramesh-T-S/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/Paramesh-T-S/subscriptions", + "organizations_url": "https://api.github.com/users/Paramesh-T-S/orgs", + "repos_url": "https://api.github.com/users/Paramesh-T-S/repos", + "events_url": "https://api.github.com/users/Paramesh-T-S/events{/privacy}", + "received_events_url": "https://api.github.com/users/Paramesh-T-S/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-05T19:47:18Z", + "updated_at": "2025-03-05T19:47:18Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2701911147/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2701911737", + "html_url": "https://github.com/laurent22/joplin/pull/11932#issuecomment-2701911737", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11932", + "id": 2701911737, + "node_id": "IC_kwDOBLftOs6hC-a5", + "user": { + "login": "Paramesh-T-S", + "id": 42896229, + "node_id": "MDQ6VXNlcjQyODk2MjI5", + "avatar_url": "https://avatars.githubusercontent.com/u/42896229?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/Paramesh-T-S", + "html_url": "https://github.com/Paramesh-T-S", + "followers_url": "https://api.github.com/users/Paramesh-T-S/followers", + "following_url": "https://api.github.com/users/Paramesh-T-S/following{/other_user}", + "gists_url": "https://api.github.com/users/Paramesh-T-S/gists{/gist_id}", + "starred_url": "https://api.github.com/users/Paramesh-T-S/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/Paramesh-T-S/subscriptions", + "organizations_url": "https://api.github.com/users/Paramesh-T-S/orgs", + "repos_url": "https://api.github.com/users/Paramesh-T-S/repos", + "events_url": "https://api.github.com/users/Paramesh-T-S/events{/privacy}", + "received_events_url": "https://api.github.com/users/Paramesh-T-S/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-05T19:47:36Z", + "updated_at": "2025-03-05T19:47:36Z", + "author_association": "CONTRIBUTOR", + "body": "recheck", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2701911737/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2702184418", + "html_url": "https://github.com/laurent22/joplin/pull/11932#issuecomment-2702184418", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11932", + "id": 2702184418, + "node_id": "IC_kwDOBLftOs6hEA_i", + "user": { + "login": "personalizedrefrigerator", + "id": 46334387, + "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", + "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/personalizedrefrigerator", + "html_url": "https://github.com/personalizedrefrigerator", + "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", + "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", + "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", + "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", + "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", + "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", + "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", + "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-05T22:04:50Z", + "updated_at": "2025-03-05T22:04:50Z", + "author_association": "COLLABORATOR", + "body": "Thank you for the pull request! Be sure to fix the linter errors (see [the relevant documentation on Joplin's website](https://joplinapp.org/help/dev/coding_style#enforcing-rules-using-eslint)).", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2702184418/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2703982395", + "html_url": "https://github.com/laurent22/joplin/pull/11932#issuecomment-2703982395", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11932", + "id": 2703982395, + "node_id": "IC_kwDOBLftOs6hK387", + "user": { + "login": "Paramesh-T-S", + "id": 42896229, + "node_id": "MDQ6VXNlcjQyODk2MjI5", + "avatar_url": "https://avatars.githubusercontent.com/u/42896229?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/Paramesh-T-S", + "html_url": "https://github.com/Paramesh-T-S", + "followers_url": "https://api.github.com/users/Paramesh-T-S/followers", + "following_url": "https://api.github.com/users/Paramesh-T-S/following{/other_user}", + "gists_url": "https://api.github.com/users/Paramesh-T-S/gists{/gist_id}", + "starred_url": "https://api.github.com/users/Paramesh-T-S/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/Paramesh-T-S/subscriptions", + "organizations_url": "https://api.github.com/users/Paramesh-T-S/orgs", + "repos_url": "https://api.github.com/users/Paramesh-T-S/repos", + "events_url": "https://api.github.com/users/Paramesh-T-S/events{/privacy}", + "received_events_url": "https://api.github.com/users/Paramesh-T-S/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-06T14:17:49Z", + "updated_at": "2025-03-06T14:22:59Z", + "author_association": "CONTRIBUTOR", + "body": "Kindly review this PR and let me if any know if any updation or changes have to be done.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2703982395/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/RajwardhanSinghUmath_170418104.json b/readme/cla/consent_records/RajwardhanSinghUmath_170418104.json new file mode 100644 index 0000000000..5bbe2af864 --- /dev/null +++ b/readme/cla/consent_records/RajwardhanSinghUmath_170418104.json @@ -0,0 +1,362 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11480", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11480/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11480/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11480/events", + "html_url": "https://github.com/laurent22/joplin/pull/11480", + "id": 2726145735, + "node_id": "PR_kwDOBLftOs6EfVMk", + "number": 11480, + "title": "Desktop: Resolves #11478 - Bold or italic text in markdown viewer", + "user": { + "login": "RajwardhanSinghUmath", + "id": 170418104, + "node_id": "U_kgDOCihfuA", + "avatar_url": "https://avatars.githubusercontent.com/u/170418104?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/RajwardhanSinghUmath", + "html_url": "https://github.com/RajwardhanSinghUmath", + "followers_url": "https://api.github.com/users/RajwardhanSinghUmath/followers", + "following_url": "https://api.github.com/users/RajwardhanSinghUmath/following{/other_user}", + "gists_url": "https://api.github.com/users/RajwardhanSinghUmath/gists{/gist_id}", + "starred_url": "https://api.github.com/users/RajwardhanSinghUmath/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/RajwardhanSinghUmath/subscriptions", + "organizations_url": "https://api.github.com/users/RajwardhanSinghUmath/orgs", + "repos_url": "https://api.github.com/users/RajwardhanSinghUmath/repos", + "events_url": "https://api.github.com/users/RajwardhanSinghUmath/events{/privacy}", + "received_events_url": "https://api.github.com/users/RajwardhanSinghUmath/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 4, + "created_at": "2024-12-09T06:42:26Z", + "updated_at": "2024-12-10T23:11:00Z", + "closed_at": "2024-12-09T09:40:59Z", + "author_association": "FIRST_TIMER", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11480", + "html_url": "https://github.com/laurent22/joplin/pull/11480", + "diff_url": "https://github.com/laurent22/joplin/pull/11480.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11480.patch", + "merged_at": null + }, + "body": "…matting in markdown viewer\r\n\r\nFixes the issue with bold and italic text in markdown viewer which is addressed in the issue #11478\r\n\r\n", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11480/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11480/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2527069043", + "html_url": "https://github.com/laurent22/joplin/pull/11480#issuecomment-2527069043", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11480", + "id": 2527069043, + "node_id": "IC_kwDOBLftOs6WoANz", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-09T06:42:41Z", + "updated_at": "2024-12-09T09:41:14Z", + "author_association": "CONTRIBUTOR", + "body": "**CLA Assistant Lite bot:**
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our [Contributor License Agreement](https://github.com/laurent22/joplin/blob/dev/readme/cla.md) before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.
\n - - -\n I have read the CLA Document and I hereby sign the CLA\n - - -\n **RajwardhanSinghUmath** seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please [add the email address used for this commit to your account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).
You can retrigger this bot by commenting **recheck** in this Pull Request", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2527069043/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2527083065", + "html_url": "https://github.com/laurent22/joplin/pull/11480#issuecomment-2527083065", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11480", + "id": 2527083065, + "node_id": "IC_kwDOBLftOs6WoDo5", + "user": { + "login": "RajwardhanSinghUmath", + "id": 170418104, + "node_id": "U_kgDOCihfuA", + "avatar_url": "https://avatars.githubusercontent.com/u/170418104?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/RajwardhanSinghUmath", + "html_url": "https://github.com/RajwardhanSinghUmath", + "followers_url": "https://api.github.com/users/RajwardhanSinghUmath/followers", + "following_url": "https://api.github.com/users/RajwardhanSinghUmath/following{/other_user}", + "gists_url": "https://api.github.com/users/RajwardhanSinghUmath/gists{/gist_id}", + "starred_url": "https://api.github.com/users/RajwardhanSinghUmath/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/RajwardhanSinghUmath/subscriptions", + "organizations_url": "https://api.github.com/users/RajwardhanSinghUmath/orgs", + "repos_url": "https://api.github.com/users/RajwardhanSinghUmath/repos", + "events_url": "https://api.github.com/users/RajwardhanSinghUmath/events{/privacy}", + "received_events_url": "https://api.github.com/users/RajwardhanSinghUmath/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-09T06:52:40Z", + "updated_at": "2024-12-09T06:53:03Z", + "author_association": "NONE", + "body": " I have read the CLA Document and I hereby sign the CLA\r\n\r\n\r\n", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2527083065/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2527084532", + "html_url": "https://github.com/laurent22/joplin/pull/11480#issuecomment-2527084532", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11480", + "id": 2527084532, + "node_id": "IC_kwDOBLftOs6WoD_0", + "user": { + "login": "RajwardhanSinghUmath", + "id": 170418104, + "node_id": "U_kgDOCihfuA", + "avatar_url": "https://avatars.githubusercontent.com/u/170418104?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/RajwardhanSinghUmath", + "html_url": "https://github.com/RajwardhanSinghUmath", + "followers_url": "https://api.github.com/users/RajwardhanSinghUmath/followers", + "following_url": "https://api.github.com/users/RajwardhanSinghUmath/following{/other_user}", + "gists_url": "https://api.github.com/users/RajwardhanSinghUmath/gists{/gist_id}", + "starred_url": "https://api.github.com/users/RajwardhanSinghUmath/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/RajwardhanSinghUmath/subscriptions", + "organizations_url": "https://api.github.com/users/RajwardhanSinghUmath/orgs", + "repos_url": "https://api.github.com/users/RajwardhanSinghUmath/repos", + "events_url": "https://api.github.com/users/RajwardhanSinghUmath/events{/privacy}", + "received_events_url": "https://api.github.com/users/RajwardhanSinghUmath/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-09T06:53:41Z", + "updated_at": "2024-12-09T06:53:41Z", + "author_association": "NONE", + "body": "recheck", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2527084532/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2533180239", + "html_url": "https://github.com/laurent22/joplin/pull/11480#issuecomment-2533180239", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11480", + "id": 2533180239, + "node_id": "IC_kwDOBLftOs6W_UNP", + "user": { + "login": "personalizedrefrigerator", + "id": 46334387, + "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", + "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/personalizedrefrigerator", + "html_url": "https://github.com/personalizedrefrigerator", + "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", + "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", + "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", + "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", + "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", + "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", + "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", + "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-10T23:10:59Z", + "updated_at": "2024-12-10T23:10:59Z", + "author_association": "COLLABORATOR", + "body": "Resolved in https://github.com/laurent22/joplin/commit/9373c334b3b1b9481710d2e9189639c664472077", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2533180239/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/Sabin-Gheorghiu_31973154.json b/readme/cla/consent_records/Sabin-Gheorghiu_31973154.json new file mode 100644 index 0000000000..fd9ada10ea --- /dev/null +++ b/readme/cla/consent_records/Sabin-Gheorghiu_31973154.json @@ -0,0 +1,362 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11610", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11610/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11610/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11610/events", + "html_url": "https://github.com/laurent22/joplin/pull/11610", + "id": 2776449223, + "node_id": "PR_kwDOBLftOs6HIgNR", + "number": 11610, + "title": "Update docker-compose.server.yml", + "user": { + "login": "Sabin-Gheorghiu", + "id": 31973154, + "node_id": "MDQ6VXNlcjMxOTczMTU0", + "avatar_url": "https://avatars.githubusercontent.com/u/31973154?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/Sabin-Gheorghiu", + "html_url": "https://github.com/Sabin-Gheorghiu", + "followers_url": "https://api.github.com/users/Sabin-Gheorghiu/followers", + "following_url": "https://api.github.com/users/Sabin-Gheorghiu/following{/other_user}", + "gists_url": "https://api.github.com/users/Sabin-Gheorghiu/gists{/gist_id}", + "starred_url": "https://api.github.com/users/Sabin-Gheorghiu/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/Sabin-Gheorghiu/subscriptions", + "organizations_url": "https://api.github.com/users/Sabin-Gheorghiu/orgs", + "repos_url": "https://api.github.com/users/Sabin-Gheorghiu/repos", + "events_url": "https://api.github.com/users/Sabin-Gheorghiu/events{/privacy}", + "received_events_url": "https://api.github.com/users/Sabin-Gheorghiu/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 4, + "created_at": "2025-01-08T22:15:08Z", + "updated_at": "2025-01-13T10:20:06Z", + "closed_at": "2025-01-11T12:15:55Z", + "author_association": "NONE", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11610", + "html_url": "https://github.com/laurent22/joplin/pull/11610", + "diff_url": "https://github.com/laurent22/joplin/pull/11610.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11610.patch", + "merged_at": null + }, + "body": "Docs: \r\nVersion attribute is obsolete since the yml format no longer uses it. Also added clarification on fields and how to pass them more elegantly down to the docker template\r\n", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11610/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11610/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2578776095", + "html_url": "https://github.com/laurent22/joplin/pull/11610#issuecomment-2578776095", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11610", + "id": 2578776095, + "node_id": "IC_kwDOBLftOs6ZtQAf", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-01-08T22:15:24Z", + "updated_at": "2025-01-13T10:20:06Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2578776095/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2580840208", + "html_url": "https://github.com/laurent22/joplin/pull/11610#issuecomment-2580840208", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11610", + "id": 2580840208, + "node_id": "IC_kwDOBLftOs6Z1H8Q", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-01-09T17:09:02Z", + "updated_at": "2025-01-09T17:09:02Z", + "author_association": "OWNER", + "body": "Hello, we'll need the CLA signature", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2580840208/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2586708810", + "html_url": "https://github.com/laurent22/joplin/pull/11610#issuecomment-2586708810", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11610", + "id": 2586708810, + "node_id": "IC_kwDOBLftOs6aLgtK", + "user": { + "login": "Sabin-Gheorghiu", + "id": 31973154, + "node_id": "MDQ6VXNlcjMxOTczMTU0", + "avatar_url": "https://avatars.githubusercontent.com/u/31973154?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/Sabin-Gheorghiu", + "html_url": "https://github.com/Sabin-Gheorghiu", + "followers_url": "https://api.github.com/users/Sabin-Gheorghiu/followers", + "following_url": "https://api.github.com/users/Sabin-Gheorghiu/following{/other_user}", + "gists_url": "https://api.github.com/users/Sabin-Gheorghiu/gists{/gist_id}", + "starred_url": "https://api.github.com/users/Sabin-Gheorghiu/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/Sabin-Gheorghiu/subscriptions", + "organizations_url": "https://api.github.com/users/Sabin-Gheorghiu/orgs", + "repos_url": "https://api.github.com/users/Sabin-Gheorghiu/repos", + "events_url": "https://api.github.com/users/Sabin-Gheorghiu/events{/privacy}", + "received_events_url": "https://api.github.com/users/Sabin-Gheorghiu/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-01-13T10:19:36Z", + "updated_at": "2025-01-13T10:19:36Z", + "author_association": "NONE", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2586708810/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2586709292", + "html_url": "https://github.com/laurent22/joplin/pull/11610#issuecomment-2586709292", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11610", + "id": 2586709292, + "node_id": "IC_kwDOBLftOs6aLg0s", + "user": { + "login": "Sabin-Gheorghiu", + "id": 31973154, + "node_id": "MDQ6VXNlcjMxOTczMTU0", + "avatar_url": "https://avatars.githubusercontent.com/u/31973154?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/Sabin-Gheorghiu", + "html_url": "https://github.com/Sabin-Gheorghiu", + "followers_url": "https://api.github.com/users/Sabin-Gheorghiu/followers", + "following_url": "https://api.github.com/users/Sabin-Gheorghiu/following{/other_user}", + "gists_url": "https://api.github.com/users/Sabin-Gheorghiu/gists{/gist_id}", + "starred_url": "https://api.github.com/users/Sabin-Gheorghiu/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/Sabin-Gheorghiu/subscriptions", + "organizations_url": "https://api.github.com/users/Sabin-Gheorghiu/orgs", + "repos_url": "https://api.github.com/users/Sabin-Gheorghiu/repos", + "events_url": "https://api.github.com/users/Sabin-Gheorghiu/events{/privacy}", + "received_events_url": "https://api.github.com/users/Sabin-Gheorghiu/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-01-13T10:19:49Z", + "updated_at": "2025-01-13T10:19:49Z", + "author_association": "NONE", + "body": "recheck\r\n", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2586709292/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/Schmeilen_114296635.json b/readme/cla/consent_records/Schmeilen_114296635.json new file mode 100644 index 0000000000..349949a044 --- /dev/null +++ b/readme/cla/consent_records/Schmeilen_114296635.json @@ -0,0 +1,317 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12038", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/12038/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/12038/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/12038/events", + "html_url": "https://github.com/laurent22/joplin/pull/12038", + "id": 2960161050, + "node_id": "PR_kwDOBLftOs6QwliI", + "number": 12038, + "title": "Desktop: Fixes #9291: A note scrolls to top if reached by following a link to a section", + "user": { + "login": "Schmeilen", + "id": 114296635, + "node_id": "U_kgDOBtAHOw", + "avatar_url": "https://avatars.githubusercontent.com/u/114296635?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/Schmeilen", + "html_url": "https://github.com/Schmeilen", + "followers_url": "https://api.github.com/users/Schmeilen/followers", + "following_url": "https://api.github.com/users/Schmeilen/following{/other_user}", + "gists_url": "https://api.github.com/users/Schmeilen/gists{/gist_id}", + "starred_url": "https://api.github.com/users/Schmeilen/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/Schmeilen/subscriptions", + "organizations_url": "https://api.github.com/users/Schmeilen/orgs", + "repos_url": "https://api.github.com/users/Schmeilen/repos", + "events_url": "https://api.github.com/users/Schmeilen/events{/privacy}", + "received_events_url": "https://api.github.com/users/Schmeilen/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 3, + "created_at": "2025-03-31T10:54:49Z", + "updated_at": "2025-04-02T09:22:47Z", + "closed_at": "2025-04-02T09:22:33Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/12038", + "html_url": "https://github.com/laurent22/joplin/pull/12038", + "diff_url": "https://github.com/laurent22/joplin/pull/12038.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/12038.patch", + "merged_at": "2025-04-02T09:22:33Z" + }, + "body": "# Summary\r\nThis pull request should fix issue #9291 by changing the index.html file in note-viewer. In the code, there was another issue referenced, issue #7617, however, I've ran the test case indicated in the bug report and wasn't able to reproduce it, the behaviour of the application was the same before and after the changes. I've uploaded a video showing the fix so it's easier to detect any unwanted modifications to the application: https://youtu.be/ndEz3OySuTs.\r\n# Testing plan\r\n1. Open the markdown editor with text view next to it\r\n2. Create two notes\r\n3. Write some text to fill more than the length of the monitor\r\n4. Below that text, write a header (or sub-header)\r\n5. Include a reference to the target header in the other note\r\n6. On the note that doesn't include the header, click on the link to it\r\n7. Verify that the markdown editor now scrolls to the correct section and is synchronized with the text view instead of staying at the top of the note, disconnected from it", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12038/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/12038/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2765869818", + "html_url": "https://github.com/laurent22/joplin/pull/12038#issuecomment-2765869818", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12038", + "id": 2765869818, + "node_id": "IC_kwDOBLftOs6k29L6", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-31T10:55:00Z", + "updated_at": "2025-04-02T09:22:46Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2765869818/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2765874538", + "html_url": "https://github.com/laurent22/joplin/pull/12038#issuecomment-2765874538", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12038", + "id": 2765874538, + "node_id": "IC_kwDOBLftOs6k2-Vq", + "user": { + "login": "Schmeilen", + "id": 114296635, + "node_id": "U_kgDOBtAHOw", + "avatar_url": "https://avatars.githubusercontent.com/u/114296635?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/Schmeilen", + "html_url": "https://github.com/Schmeilen", + "followers_url": "https://api.github.com/users/Schmeilen/followers", + "following_url": "https://api.github.com/users/Schmeilen/following{/other_user}", + "gists_url": "https://api.github.com/users/Schmeilen/gists{/gist_id}", + "starred_url": "https://api.github.com/users/Schmeilen/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/Schmeilen/subscriptions", + "organizations_url": "https://api.github.com/users/Schmeilen/orgs", + "repos_url": "https://api.github.com/users/Schmeilen/repos", + "events_url": "https://api.github.com/users/Schmeilen/events{/privacy}", + "received_events_url": "https://api.github.com/users/Schmeilen/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-31T10:57:31Z", + "updated_at": "2025-03-31T10:57:31Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2765874538/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2771961410", + "html_url": "https://github.com/laurent22/joplin/pull/12038#issuecomment-2771961410", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12038", + "id": 2771961410, + "node_id": "IC_kwDOBLftOs6lOMZC", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-02T09:22:29Z", + "updated_at": "2025-04-02T09:22:29Z", + "author_association": "OWNER", + "body": "Ok thank you, that seems reasonable.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2771961410/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/SilverGreen93_24845602.json b/readme/cla/consent_records/SilverGreen93_24845602.json new file mode 100644 index 0000000000..d02bd92b8c --- /dev/null +++ b/readme/cla/consent_records/SilverGreen93_24845602.json @@ -0,0 +1,282 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12134", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/12134/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/12134/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/12134/events", + "html_url": "https://github.com/laurent22/joplin/pull/12134", + "id": 3006499048, + "node_id": "PR_kwDOBLftOs6TM9MO", + "number": 12134, + "title": "All: Translation: Update ro.po", + "user": { + "login": "SilverGreen93", + "id": 24845602, + "node_id": "MDQ6VXNlcjI0ODQ1NjAy", + "avatar_url": "https://avatars.githubusercontent.com/u/24845602?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/SilverGreen93", + "html_url": "https://github.com/SilverGreen93", + "followers_url": "https://api.github.com/users/SilverGreen93/followers", + "following_url": "https://api.github.com/users/SilverGreen93/following{/other_user}", + "gists_url": "https://api.github.com/users/SilverGreen93/gists{/gist_id}", + "starred_url": "https://api.github.com/users/SilverGreen93/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/SilverGreen93/subscriptions", + "organizations_url": "https://api.github.com/users/SilverGreen93/orgs", + "repos_url": "https://api.github.com/users/SilverGreen93/repos", + "events_url": "https://api.github.com/users/SilverGreen93/events{/privacy}", + "received_events_url": "https://api.github.com/users/SilverGreen93/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [ + { + "id": 1091621259, + "node_id": "MDU6TGFiZWwxMDkxNjIxMjU5", + "url": "https://api.github.com/repos/laurent22/joplin/labels/translation", + "name": "translation", + "color": "91ca55", + "default": false, + "description": "i18n and l10n" + } + ], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 2, + "created_at": "2025-04-19T15:29:36Z", + "updated_at": "2025-04-21T17:58:23Z", + "closed_at": "2025-04-19T16:04:35Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/12134", + "html_url": "https://github.com/laurent22/joplin/pull/12134", + "diff_url": "https://github.com/laurent22/joplin/pull/12134.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/12134.patch", + "merged_at": "2025-04-19T16:04:35Z" + }, + "body": "- Translate all strings\r\n- Change 2nd person plural to 2nd person singular for better, personal feel when using the app. (in line with other projects)\r\n- Fix wrong `% s` instead of `%s` specifiers\r\n\r\n- Tested translations on a Linux desktop build.\r\n\r\n", + "closed_by": { + "login": "tessus", + "id": 223439, + "node_id": "MDQ6VXNlcjIyMzQzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tessus", + "html_url": "https://github.com/tessus", + "followers_url": "https://api.github.com/users/tessus/followers", + "following_url": "https://api.github.com/users/tessus/following{/other_user}", + "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", + "organizations_url": "https://api.github.com/users/tessus/orgs", + "repos_url": "https://api.github.com/users/tessus/repos", + "events_url": "https://api.github.com/users/tessus/events{/privacy}", + "received_events_url": "https://api.github.com/users/tessus/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12134/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/12134/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2816753556", + "html_url": "https://github.com/laurent22/joplin/pull/12134#issuecomment-2816753556", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12134", + "id": 2816753556, + "node_id": "IC_kwDOBLftOs6n5D-U", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-19T15:29:50Z", + "updated_at": "2025-04-19T16:04:48Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2816753556/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2816754053", + "html_url": "https://github.com/laurent22/joplin/pull/12134#issuecomment-2816754053", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12134", + "id": 2816754053, + "node_id": "IC_kwDOBLftOs6n5EGF", + "user": { + "login": "SilverGreen93", + "id": 24845602, + "node_id": "MDQ6VXNlcjI0ODQ1NjAy", + "avatar_url": "https://avatars.githubusercontent.com/u/24845602?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/SilverGreen93", + "html_url": "https://github.com/SilverGreen93", + "followers_url": "https://api.github.com/users/SilverGreen93/followers", + "following_url": "https://api.github.com/users/SilverGreen93/following{/other_user}", + "gists_url": "https://api.github.com/users/SilverGreen93/gists{/gist_id}", + "starred_url": "https://api.github.com/users/SilverGreen93/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/SilverGreen93/subscriptions", + "organizations_url": "https://api.github.com/users/SilverGreen93/orgs", + "repos_url": "https://api.github.com/users/SilverGreen93/repos", + "events_url": "https://api.github.com/users/SilverGreen93/events{/privacy}", + "received_events_url": "https://api.github.com/users/SilverGreen93/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-19T15:31:26Z", + "updated_at": "2025-04-19T15:31:26Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2816754053/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/Vortrix5_30868937.json b/readme/cla/consent_records/Vortrix5_30868937.json new file mode 100644 index 0000000000..7ff2f69ec9 --- /dev/null +++ b/readme/cla/consent_records/Vortrix5_30868937.json @@ -0,0 +1,497 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11705", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11705/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11705/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11705/events", + "html_url": "https://github.com/laurent22/joplin/pull/11705", + "id": 2804617730, + "node_id": "PR_kwDOBLftOs6IpAj-", + "number": 11705, + "title": "Desktop: Add \"Disable synchronisation\" to Joplin Cloud prompt message #11696", + "user": { + "login": "Vortrix5", + "id": 30868937, + "node_id": "MDQ6VXNlcjMwODY4OTM3", + "avatar_url": "https://avatars.githubusercontent.com/u/30868937?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/Vortrix5", + "html_url": "https://github.com/Vortrix5", + "followers_url": "https://api.github.com/users/Vortrix5/followers", + "following_url": "https://api.github.com/users/Vortrix5/following{/other_user}", + "gists_url": "https://api.github.com/users/Vortrix5/gists{/gist_id}", + "starred_url": "https://api.github.com/users/Vortrix5/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/Vortrix5/subscriptions", + "organizations_url": "https://api.github.com/users/Vortrix5/orgs", + "repos_url": "https://api.github.com/users/Vortrix5/repos", + "events_url": "https://api.github.com/users/Vortrix5/events{/privacy}", + "received_events_url": "https://api.github.com/users/Vortrix5/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 7, + "created_at": "2025-01-22T14:59:05Z", + "updated_at": "2025-03-08T11:50:42Z", + "closed_at": "2025-03-08T11:50:31Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11705", + "html_url": "https://github.com/laurent22/joplin/pull/11705", + "diff_url": "https://github.com/laurent22/joplin/pull/11705.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11705.patch", + "merged_at": "2025-03-08T11:50:31Z" + }, + "body": "\"Screenshot\r\n", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11705/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11705/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2607477292", + "html_url": "https://github.com/laurent22/joplin/pull/11705#issuecomment-2607477292", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11705", + "id": 2607477292, + "node_id": "IC_kwDOBLftOs6bavIs", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-01-22T14:59:19Z", + "updated_at": "2025-03-08T11:50:42Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2607477292/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2607480569", + "html_url": "https://github.com/laurent22/joplin/pull/11705#issuecomment-2607480569", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11705", + "id": 2607480569, + "node_id": "IC_kwDOBLftOs6bav75", + "user": { + "login": "Vortrix5", + "id": 30868937, + "node_id": "MDQ6VXNlcjMwODY4OTM3", + "avatar_url": "https://avatars.githubusercontent.com/u/30868937?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/Vortrix5", + "html_url": "https://github.com/Vortrix5", + "followers_url": "https://api.github.com/users/Vortrix5/followers", + "following_url": "https://api.github.com/users/Vortrix5/following{/other_user}", + "gists_url": "https://api.github.com/users/Vortrix5/gists{/gist_id}", + "starred_url": "https://api.github.com/users/Vortrix5/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/Vortrix5/subscriptions", + "organizations_url": "https://api.github.com/users/Vortrix5/orgs", + "repos_url": "https://api.github.com/users/Vortrix5/repos", + "events_url": "https://api.github.com/users/Vortrix5/events{/privacy}", + "received_events_url": "https://api.github.com/users/Vortrix5/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-01-22T15:00:31Z", + "updated_at": "2025-01-22T15:00:31Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2607480569/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2616433725", + "html_url": "https://github.com/laurent22/joplin/pull/11705#issuecomment-2616433725", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11705", + "id": 2616433725, + "node_id": "IC_kwDOBLftOs6b85w9", + "user": { + "login": "Vortrix5", + "id": 30868937, + "node_id": "MDQ6VXNlcjMwODY4OTM3", + "avatar_url": "https://avatars.githubusercontent.com/u/30868937?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/Vortrix5", + "html_url": "https://github.com/Vortrix5", + "followers_url": "https://api.github.com/users/Vortrix5/followers", + "following_url": "https://api.github.com/users/Vortrix5/following{/other_user}", + "gists_url": "https://api.github.com/users/Vortrix5/gists{/gist_id}", + "starred_url": "https://api.github.com/users/Vortrix5/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/Vortrix5/subscriptions", + "organizations_url": "https://api.github.com/users/Vortrix5/orgs", + "repos_url": "https://api.github.com/users/Vortrix5/repos", + "events_url": "https://api.github.com/users/Vortrix5/events{/privacy}", + "received_events_url": "https://api.github.com/users/Vortrix5/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-01-27T17:24:38Z", + "updated_at": "2025-01-27T17:24:38Z", + "author_association": "CONTRIBUTOR", + "body": "@laurent22 How should we proceed with the merging? This is my first contribution and I still unsure on what should be happening next.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2616433725/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2646146918", + "html_url": "https://github.com/laurent22/joplin/pull/11705#issuecomment-2646146918", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11705", + "id": 2646146918, + "node_id": "IC_kwDOBLftOs6duP9m", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-09T09:34:14Z", + "updated_at": "2025-02-09T09:35:34Z", + "author_association": "OWNER", + "body": "Still not done. You mark my comments as resolved but you don't even read them properly. ", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2646146918/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2649413916", + "html_url": "https://github.com/laurent22/joplin/pull/11705#issuecomment-2649413916", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11705", + "id": 2649413916, + "node_id": "IC_kwDOBLftOs6d6tkc", + "user": { + "login": "Vortrix5", + "id": 30868937, + "node_id": "MDQ6VXNlcjMwODY4OTM3", + "avatar_url": "https://avatars.githubusercontent.com/u/30868937?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/Vortrix5", + "html_url": "https://github.com/Vortrix5", + "followers_url": "https://api.github.com/users/Vortrix5/followers", + "following_url": "https://api.github.com/users/Vortrix5/following{/other_user}", + "gists_url": "https://api.github.com/users/Vortrix5/gists{/gist_id}", + "starred_url": "https://api.github.com/users/Vortrix5/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/Vortrix5/subscriptions", + "organizations_url": "https://api.github.com/users/Vortrix5/orgs", + "repos_url": "https://api.github.com/users/Vortrix5/repos", + "events_url": "https://api.github.com/users/Vortrix5/events{/privacy}", + "received_events_url": "https://api.github.com/users/Vortrix5/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-10T22:37:08Z", + "updated_at": "2025-02-10T22:37:08Z", + "author_association": "CONTRIBUTOR", + "body": "> Still not done. You mark my comments as resolved but you don't even read them properly.\r\n\r\nApologies for that, should be done now.\r\n", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2649413916/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2672671376", + "html_url": "https://github.com/laurent22/joplin/pull/11705#issuecomment-2672671376", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11705", + "id": 2672671376, + "node_id": "IC_kwDOBLftOs6fTbqQ", + "user": { + "login": "Vortrix5", + "id": 30868937, + "node_id": "MDQ6VXNlcjMwODY4OTM3", + "avatar_url": "https://avatars.githubusercontent.com/u/30868937?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/Vortrix5", + "html_url": "https://github.com/Vortrix5", + "followers_url": "https://api.github.com/users/Vortrix5/followers", + "following_url": "https://api.github.com/users/Vortrix5/following{/other_user}", + "gists_url": "https://api.github.com/users/Vortrix5/gists{/gist_id}", + "starred_url": "https://api.github.com/users/Vortrix5/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/Vortrix5/subscriptions", + "organizations_url": "https://api.github.com/users/Vortrix5/orgs", + "repos_url": "https://api.github.com/users/Vortrix5/repos", + "events_url": "https://api.github.com/users/Vortrix5/events{/privacy}", + "received_events_url": "https://api.github.com/users/Vortrix5/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-20T21:01:42Z", + "updated_at": "2025-02-20T21:01:42Z", + "author_association": "CONTRIBUTOR", + "body": "Is this PR still pending?", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2672671376/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2700540748", + "html_url": "https://github.com/laurent22/joplin/pull/11705#issuecomment-2700540748", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11705", + "id": 2700540748, + "node_id": "IC_kwDOBLftOs6g9vtM", + "user": { + "login": "Vortrix5", + "id": 30868937, + "node_id": "MDQ6VXNlcjMwODY4OTM3", + "avatar_url": "https://avatars.githubusercontent.com/u/30868937?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/Vortrix5", + "html_url": "https://github.com/Vortrix5", + "followers_url": "https://api.github.com/users/Vortrix5/followers", + "following_url": "https://api.github.com/users/Vortrix5/following{/other_user}", + "gists_url": "https://api.github.com/users/Vortrix5/gists{/gist_id}", + "starred_url": "https://api.github.com/users/Vortrix5/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/Vortrix5/subscriptions", + "organizations_url": "https://api.github.com/users/Vortrix5/orgs", + "repos_url": "https://api.github.com/users/Vortrix5/repos", + "events_url": "https://api.github.com/users/Vortrix5/events{/privacy}", + "received_events_url": "https://api.github.com/users/Vortrix5/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-05T10:44:17Z", + "updated_at": "2025-03-05T10:44:17Z", + "author_association": "CONTRIBUTOR", + "body": "@laurent22 Any update on this PR?", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2700540748/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/alan-null_6848691.json b/readme/cla/consent_records/alan-null_6848691.json new file mode 100644 index 0000000000..aa34a41b97 --- /dev/null +++ b/readme/cla/consent_records/alan-null_6848691.json @@ -0,0 +1,272 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11585", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11585/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11585/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11585/events", + "html_url": "https://github.com/laurent22/joplin/pull/11585", + "id": 2769485810, + "node_id": "PR_kwDOBLftOs6GwteU", + "number": 11585, + "title": "Polish translation", + "user": { + "login": "alan-null", + "id": 6848691, + "node_id": "MDQ6VXNlcjY4NDg2OTE=", + "avatar_url": "https://avatars.githubusercontent.com/u/6848691?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/alan-null", + "html_url": "https://github.com/alan-null", + "followers_url": "https://api.github.com/users/alan-null/followers", + "following_url": "https://api.github.com/users/alan-null/following{/other_user}", + "gists_url": "https://api.github.com/users/alan-null/gists{/gist_id}", + "starred_url": "https://api.github.com/users/alan-null/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/alan-null/subscriptions", + "organizations_url": "https://api.github.com/users/alan-null/orgs", + "repos_url": "https://api.github.com/users/alan-null/repos", + "events_url": "https://api.github.com/users/alan-null/events{/privacy}", + "received_events_url": "https://api.github.com/users/alan-null/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 2, + "created_at": "2025-01-05T22:45:26Z", + "updated_at": "2025-01-06T11:12:26Z", + "closed_at": "2025-01-06T10:55:02Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11585", + "html_url": "https://github.com/laurent22/joplin/pull/11585", + "diff_url": "https://github.com/laurent22/joplin/pull/11585.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11585.patch", + "merged_at": "2025-01-06T10:55:02Z" + }, + "body": "Added missing translations and fixed some of the existing ones.", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11585/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11585/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2571778358", + "html_url": "https://github.com/laurent22/joplin/pull/11585#issuecomment-2571778358", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11585", + "id": 2571778358, + "node_id": "IC_kwDOBLftOs6ZSjk2", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-01-05T22:54:01Z", + "updated_at": "2025-01-06T11:12:26Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2571778358/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2572468812", + "html_url": "https://github.com/laurent22/joplin/pull/11585#issuecomment-2572468812", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11585", + "id": 2572468812, + "node_id": "IC_kwDOBLftOs6ZVMJM", + "user": { + "login": "alan-null", + "id": 6848691, + "node_id": "MDQ6VXNlcjY4NDg2OTE=", + "avatar_url": "https://avatars.githubusercontent.com/u/6848691?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/alan-null", + "html_url": "https://github.com/alan-null", + "followers_url": "https://api.github.com/users/alan-null/followers", + "following_url": "https://api.github.com/users/alan-null/following{/other_user}", + "gists_url": "https://api.github.com/users/alan-null/gists{/gist_id}", + "starred_url": "https://api.github.com/users/alan-null/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/alan-null/subscriptions", + "organizations_url": "https://api.github.com/users/alan-null/orgs", + "repos_url": "https://api.github.com/users/alan-null/repos", + "events_url": "https://api.github.com/users/alan-null/events{/privacy}", + "received_events_url": "https://api.github.com/users/alan-null/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-01-06T07:34:11Z", + "updated_at": "2025-01-06T07:34:11Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2572468812/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/awesome-pro_147910430.json b/readme/cla/consent_records/awesome-pro_147910430.json new file mode 100644 index 0000000000..0cf562b7df --- /dev/null +++ b/readme/cla/consent_records/awesome-pro_147910430.json @@ -0,0 +1,272 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11435", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11435/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11435/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11435/events", + "html_url": "https://github.com/laurent22/joplin/pull/11435", + "id": 2685766235, + "node_id": "PR_kwDOBLftOs6C5vVl", + "number": 11435, + "title": "Lib: Fixed metadata link URL", + "user": { + "login": "awesome-pro", + "id": 147910430, + "node_id": "U_kgDOCNDvHg", + "avatar_url": "https://avatars.githubusercontent.com/u/147910430?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/awesome-pro", + "html_url": "https://github.com/awesome-pro", + "followers_url": "https://api.github.com/users/awesome-pro/followers", + "following_url": "https://api.github.com/users/awesome-pro/following{/other_user}", + "gists_url": "https://api.github.com/users/awesome-pro/gists{/gist_id}", + "starred_url": "https://api.github.com/users/awesome-pro/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/awesome-pro/subscriptions", + "organizations_url": "https://api.github.com/users/awesome-pro/orgs", + "repos_url": "https://api.github.com/users/awesome-pro/repos", + "events_url": "https://api.github.com/users/awesome-pro/events{/privacy}", + "received_events_url": "https://api.github.com/users/awesome-pro/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 2, + "created_at": "2024-11-23T09:53:43Z", + "updated_at": "2024-11-23T13:27:45Z", + "closed_at": "2024-11-23T13:27:29Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11435", + "html_url": "https://github.com/laurent22/joplin/pull/11435", + "diff_url": "https://github.com/laurent22/joplin/pull/11435.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11435.patch", + "merged_at": "2024-11-23T13:27:29Z" + }, + "body": "\r\n\r\n# Summary\r\nThis PR fixes the wrong link in the metadata link in libs \r\n\r\n## Before this PR: \r\n> https://https://joplinapp.org/help/api/references/mobile_plugin_debugging/\r\n## After this PR: \r\n> https://joplinapp.org/help/api/references/mobile_plugin_debugging/", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11435/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11435/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2495421726", + "html_url": "https://github.com/laurent22/joplin/pull/11435#issuecomment-2495421726", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11435", + "id": 2495421726, + "node_id": "IC_kwDOBLftOs6UvR0e", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-23T09:53:59Z", + "updated_at": "2024-11-23T13:27:45Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2495421726/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2495423117", + "html_url": "https://github.com/laurent22/joplin/pull/11435#issuecomment-2495423117", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11435", + "id": 2495423117, + "node_id": "IC_kwDOBLftOs6UvSKN", + "user": { + "login": "awesome-pro", + "id": 147910430, + "node_id": "U_kgDOCNDvHg", + "avatar_url": "https://avatars.githubusercontent.com/u/147910430?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/awesome-pro", + "html_url": "https://github.com/awesome-pro", + "followers_url": "https://api.github.com/users/awesome-pro/followers", + "following_url": "https://api.github.com/users/awesome-pro/following{/other_user}", + "gists_url": "https://api.github.com/users/awesome-pro/gists{/gist_id}", + "starred_url": "https://api.github.com/users/awesome-pro/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/awesome-pro/subscriptions", + "organizations_url": "https://api.github.com/users/awesome-pro/orgs", + "repos_url": "https://api.github.com/users/awesome-pro/repos", + "events_url": "https://api.github.com/users/awesome-pro/events{/privacy}", + "received_events_url": "https://api.github.com/users/awesome-pro/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-23T09:59:37Z", + "updated_at": "2024-11-23T09:59:37Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2495423117/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/azurelunatic_7589142.json b/readme/cla/consent_records/azurelunatic_7589142.json new file mode 100644 index 0000000000..f4bc85e1ab --- /dev/null +++ b/readme/cla/consent_records/azurelunatic_7589142.json @@ -0,0 +1,317 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11527", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11527/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11527/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11527/events", + "html_url": "https://github.com/laurent22/joplin/pull/11527", + "id": 2744218068, + "node_id": "PR_kwDOBLftOs6FdIaW", + "number": 11527, + "title": "Update clipper.md: more specific location for Web Clipper options", + "user": { + "login": "azurelunatic", + "id": 7589142, + "node_id": "MDQ6VXNlcjc1ODkxNDI=", + "avatar_url": "https://avatars.githubusercontent.com/u/7589142?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/azurelunatic", + "html_url": "https://github.com/azurelunatic", + "followers_url": "https://api.github.com/users/azurelunatic/followers", + "following_url": "https://api.github.com/users/azurelunatic/following{/other_user}", + "gists_url": "https://api.github.com/users/azurelunatic/gists{/gist_id}", + "starred_url": "https://api.github.com/users/azurelunatic/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/azurelunatic/subscriptions", + "organizations_url": "https://api.github.com/users/azurelunatic/orgs", + "repos_url": "https://api.github.com/users/azurelunatic/repos", + "events_url": "https://api.github.com/users/azurelunatic/events{/privacy}", + "received_events_url": "https://api.github.com/users/azurelunatic/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 3, + "created_at": "2024-12-17T08:14:26Z", + "updated_at": "2024-12-17T18:21:13Z", + "closed_at": "2024-12-17T18:04:23Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11527", + "html_url": "https://github.com/laurent22/joplin/pull/11527", + "diff_url": "https://github.com/laurent22/joplin/pull/11527.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11527.patch", + "merged_at": "2024-12-17T18:04:23Z" + }, + "body": "A more precisely described location to find the Web Clipper options; I tripped over this just now as a new user but eventually found it.\r\n\r\n", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11527/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11527/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2547764081", + "html_url": "https://github.com/laurent22/joplin/pull/11527#issuecomment-2547764081", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11527", + "id": 2547764081, + "node_id": "IC_kwDOBLftOs6X28tx", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-17T08:14:43Z", + "updated_at": "2024-12-17T18:21:13Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2547764081/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2547770198", + "html_url": "https://github.com/laurent22/joplin/pull/11527#issuecomment-2547770198", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11527", + "id": 2547770198, + "node_id": "IC_kwDOBLftOs6X2-NW", + "user": { + "login": "azurelunatic", + "id": 7589142, + "node_id": "MDQ6VXNlcjc1ODkxNDI=", + "avatar_url": "https://avatars.githubusercontent.com/u/7589142?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/azurelunatic", + "html_url": "https://github.com/azurelunatic", + "followers_url": "https://api.github.com/users/azurelunatic/followers", + "following_url": "https://api.github.com/users/azurelunatic/following{/other_user}", + "gists_url": "https://api.github.com/users/azurelunatic/gists{/gist_id}", + "starred_url": "https://api.github.com/users/azurelunatic/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/azurelunatic/subscriptions", + "organizations_url": "https://api.github.com/users/azurelunatic/orgs", + "repos_url": "https://api.github.com/users/azurelunatic/repos", + "events_url": "https://api.github.com/users/azurelunatic/events{/privacy}", + "received_events_url": "https://api.github.com/users/azurelunatic/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-17T08:17:52Z", + "updated_at": "2024-12-17T08:17:52Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2547770198/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2549216961", + "html_url": "https://github.com/laurent22/joplin/pull/11527#issuecomment-2549216961", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11527", + "id": 2549216961, + "node_id": "IC_kwDOBLftOs6X8fbB", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-17T18:04:14Z", + "updated_at": "2024-12-17T18:04:14Z", + "author_association": "OWNER", + "body": "Thank you for the update. Since access to the config screen is different depending on the OS, we now link to a general help page for this which I've added to your PR. We can indeed mention the Web Clipper section however.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2549216961/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/balaraz_134877893.json b/readme/cla/consent_records/balaraz_134877893.json new file mode 100644 index 0000000000..e797d44ec1 --- /dev/null +++ b/readme/cla/consent_records/balaraz_134877893.json @@ -0,0 +1,452 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11824", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11824/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11824/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11824/events", + "html_url": "https://github.com/laurent22/joplin/pull/11824", + "id": 2844701899, + "node_id": "PR_kwDOBLftOs6KxEdk", + "number": 11824, + "title": "Update Ukrainian translation", + "user": { + "login": "balaraz", + "id": 134877893, + "node_id": "U_kgDOCAoSxQ", + "avatar_url": "https://avatars.githubusercontent.com/u/134877893?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/balaraz", + "html_url": "https://github.com/balaraz", + "followers_url": "https://api.github.com/users/balaraz/followers", + "following_url": "https://api.github.com/users/balaraz/following{/other_user}", + "gists_url": "https://api.github.com/users/balaraz/gists{/gist_id}", + "starred_url": "https://api.github.com/users/balaraz/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/balaraz/subscriptions", + "organizations_url": "https://api.github.com/users/balaraz/orgs", + "repos_url": "https://api.github.com/users/balaraz/repos", + "events_url": "https://api.github.com/users/balaraz/events{/privacy}", + "received_events_url": "https://api.github.com/users/balaraz/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 6, + "created_at": "2025-02-11T08:52:17Z", + "updated_at": "2025-02-12T12:11:30Z", + "closed_at": "2025-02-12T08:55:29Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11824", + "html_url": "https://github.com/laurent22/joplin/pull/11824", + "diff_url": "https://github.com/laurent22/joplin/pull/11824.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11824.patch", + "merged_at": "2025-02-12T08:55:29Z" + }, + "body": "## App\r\n\r\n- Fix exist translations\r\n- Updated outdated strings\r\n- Translated untranslated lines\r\n\r\n> Currently, 99% translated. 9 lines left to complete.\r\n\r\n## Metadata\r\n\r\nAdd translation of short description.", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11824/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11824/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2650168990", + "html_url": "https://github.com/laurent22/joplin/pull/11824#issuecomment-2650168990", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11824", + "id": 2650168990, + "node_id": "IC_kwDOBLftOs6d9l6e", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-11T08:52:34Z", + "updated_at": "2025-02-12T08:55:43Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2650168990/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2650674995", + "html_url": "https://github.com/laurent22/joplin/pull/11824#issuecomment-2650674995", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11824", + "id": 2650674995, + "node_id": "IC_kwDOBLftOs6d_hcz", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-11T12:27:32Z", + "updated_at": "2025-02-11T12:27:32Z", + "author_association": "OWNER", + "body": "recheck", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2650674995/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2650696848", + "html_url": "https://github.com/laurent22/joplin/pull/11824#issuecomment-2650696848", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11824", + "id": 2650696848, + "node_id": "IC_kwDOBLftOs6d_myQ", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-11T12:35:46Z", + "updated_at": "2025-02-11T12:35:46Z", + "author_association": "OWNER", + "body": "The CLAAssistant script doesn't seem to find your signature. Please try again but don't include the quote - just \"I have read the CLA Document and I hereby sign the CLA\"", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2650696848/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2651193924", + "html_url": "https://github.com/laurent22/joplin/pull/11824#issuecomment-2651193924", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11824", + "id": 2651193924, + "node_id": "IC_kwDOBLftOs6eBgJE", + "user": { + "login": "balaraz", + "id": 134877893, + "node_id": "U_kgDOCAoSxQ", + "avatar_url": "https://avatars.githubusercontent.com/u/134877893?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/balaraz", + "html_url": "https://github.com/balaraz", + "followers_url": "https://api.github.com/users/balaraz/followers", + "following_url": "https://api.github.com/users/balaraz/following{/other_user}", + "gists_url": "https://api.github.com/users/balaraz/gists{/gist_id}", + "starred_url": "https://api.github.com/users/balaraz/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/balaraz/subscriptions", + "organizations_url": "https://api.github.com/users/balaraz/orgs", + "repos_url": "https://api.github.com/users/balaraz/repos", + "events_url": "https://api.github.com/users/balaraz/events{/privacy}", + "received_events_url": "https://api.github.com/users/balaraz/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-11T15:38:01Z", + "updated_at": "2025-02-11T15:38:01Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2651193924/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2653036140", + "html_url": "https://github.com/laurent22/joplin/pull/11824#issuecomment-2653036140", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11824", + "id": 2653036140, + "node_id": "IC_kwDOBLftOs6eIh5s", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-12T08:55:26Z", + "updated_at": "2025-02-12T08:55:26Z", + "author_association": "OWNER", + "body": "That looks good, thank you for updating this!", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2653036140/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2653536002", + "html_url": "https://github.com/laurent22/joplin/pull/11824#issuecomment-2653536002", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11824", + "id": 2653536002, + "node_id": "IC_kwDOBLftOs6eKb8C", + "user": { + "login": "balaraz", + "id": 134877893, + "node_id": "U_kgDOCAoSxQ", + "avatar_url": "https://avatars.githubusercontent.com/u/134877893?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/balaraz", + "html_url": "https://github.com/balaraz", + "followers_url": "https://api.github.com/users/balaraz/followers", + "following_url": "https://api.github.com/users/balaraz/following{/other_user}", + "gists_url": "https://api.github.com/users/balaraz/gists{/gist_id}", + "starred_url": "https://api.github.com/users/balaraz/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/balaraz/subscriptions", + "organizations_url": "https://api.github.com/users/balaraz/orgs", + "repos_url": "https://api.github.com/users/balaraz/repos", + "events_url": "https://api.github.com/users/balaraz/events{/privacy}", + "received_events_url": "https://api.github.com/users/balaraz/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-12T12:11:28Z", + "updated_at": "2025-02-12T12:11:28Z", + "author_association": "CONTRIBUTOR", + "body": "There were such mistakes that I couldn't watch after laughing.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2653536002/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/c-n-c_1103228.json b/readme/cla/consent_records/c-n-c_1103228.json new file mode 100644 index 0000000000..604a54a354 --- /dev/null +++ b/readme/cla/consent_records/c-n-c_1103228.json @@ -0,0 +1,272 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11572", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11572/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11572/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11572/events", + "html_url": "https://github.com/laurent22/joplin/pull/11572", + "id": 2766917354, + "node_id": "PR_kwDOBLftOs6GoHs_", + "number": 11572, + "title": "Update s3.md for provider Tebi", + "user": { + "login": "c-n-c", + "id": 1103228, + "node_id": "MDQ6VXNlcjExMDMyMjg=", + "avatar_url": "https://avatars.githubusercontent.com/u/1103228?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/c-n-c", + "html_url": "https://github.com/c-n-c", + "followers_url": "https://api.github.com/users/c-n-c/followers", + "following_url": "https://api.github.com/users/c-n-c/following{/other_user}", + "gists_url": "https://api.github.com/users/c-n-c/gists{/gist_id}", + "starred_url": "https://api.github.com/users/c-n-c/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/c-n-c/subscriptions", + "organizations_url": "https://api.github.com/users/c-n-c/orgs", + "repos_url": "https://api.github.com/users/c-n-c/repos", + "events_url": "https://api.github.com/users/c-n-c/events{/privacy}", + "received_events_url": "https://api.github.com/users/c-n-c/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 2, + "created_at": "2025-01-03T03:21:16Z", + "updated_at": "2025-01-07T12:15:54Z", + "closed_at": "2025-01-06T17:35:36Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11572", + "html_url": "https://github.com/laurent22/joplin/pull/11572", + "diff_url": "https://github.com/laurent22/joplin/pull/11572.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11572.patch", + "merged_at": "2025-01-06T17:35:36Z" + }, + "body": "Tebi is innovative s3-compatible geo-distributed object storage with extremely high speed and 99.99% reliability.\r\n\r\nCheckout - https://tebi.io/\r\n\r\n", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11572/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11572/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2568646631", + "html_url": "https://github.com/laurent22/joplin/pull/11572#issuecomment-2568646631", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11572", + "id": 2568646631, + "node_id": "IC_kwDOBLftOs6ZGm_n", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-01-03T03:21:31Z", + "updated_at": "2025-01-06T18:04:35Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2568646631/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2568648323", + "html_url": "https://github.com/laurent22/joplin/pull/11572#issuecomment-2568648323", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11572", + "id": 2568648323, + "node_id": "IC_kwDOBLftOs6ZGnaD", + "user": { + "login": "c-n-c", + "id": 1103228, + "node_id": "MDQ6VXNlcjExMDMyMjg=", + "avatar_url": "https://avatars.githubusercontent.com/u/1103228?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/c-n-c", + "html_url": "https://github.com/c-n-c", + "followers_url": "https://api.github.com/users/c-n-c/followers", + "following_url": "https://api.github.com/users/c-n-c/following{/other_user}", + "gists_url": "https://api.github.com/users/c-n-c/gists{/gist_id}", + "starred_url": "https://api.github.com/users/c-n-c/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/c-n-c/subscriptions", + "organizations_url": "https://api.github.com/users/c-n-c/orgs", + "repos_url": "https://api.github.com/users/c-n-c/repos", + "events_url": "https://api.github.com/users/c-n-c/events{/privacy}", + "received_events_url": "https://api.github.com/users/c-n-c/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-01-03T03:24:42Z", + "updated_at": "2025-01-03T03:24:42Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2568648323/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/camilajenny_17968722.json b/readme/cla/consent_records/camilajenny_17968722.json new file mode 100644 index 0000000000..b277286809 --- /dev/null +++ b/readme/cla/consent_records/camilajenny_17968722.json @@ -0,0 +1,317 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11853", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11853/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11853/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11853/events", + "html_url": "https://github.com/laurent22/joplin/pull/11853", + "id": 2858921955, + "node_id": "PR_kwDOBLftOs6LhGal", + "number": 11853, + "title": "Resolves #11842: Updated faq.md", + "user": { + "login": "camilajenny", + "id": 17968722, + "node_id": "MDQ6VXNlcjE3OTY4NzIy", + "avatar_url": "https://avatars.githubusercontent.com/u/17968722?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/camilajenny", + "html_url": "https://github.com/camilajenny", + "followers_url": "https://api.github.com/users/camilajenny/followers", + "following_url": "https://api.github.com/users/camilajenny/following{/other_user}", + "gists_url": "https://api.github.com/users/camilajenny/gists{/gist_id}", + "starred_url": "https://api.github.com/users/camilajenny/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/camilajenny/subscriptions", + "organizations_url": "https://api.github.com/users/camilajenny/orgs", + "repos_url": "https://api.github.com/users/camilajenny/repos", + "events_url": "https://api.github.com/users/camilajenny/events{/privacy}", + "received_events_url": "https://api.github.com/users/camilajenny/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 3, + "created_at": "2025-02-17T22:44:11Z", + "updated_at": "2025-02-18T18:14:25Z", + "closed_at": "2025-02-18T18:14:10Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11853", + "html_url": "https://github.com/laurent22/joplin/pull/11853", + "diff_url": "https://github.com/laurent22/joplin/pull/11853.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11853.patch", + "merged_at": "2025-02-18T18:14:10Z" + }, + "body": "improve the wording\r\n\r\n", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11853/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11853/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2664183296", + "html_url": "https://github.com/laurent22/joplin/pull/11853#issuecomment-2664183296", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11853", + "id": 2664183296, + "node_id": "IC_kwDOBLftOs6ezDYA", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-17T22:44:21Z", + "updated_at": "2025-02-18T18:14:25Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2664183296/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2664184849", + "html_url": "https://github.com/laurent22/joplin/pull/11853#issuecomment-2664184849", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11853", + "id": 2664184849, + "node_id": "IC_kwDOBLftOs6ezDwR", + "user": { + "login": "camilajenny", + "id": 17968722, + "node_id": "MDQ6VXNlcjE3OTY4NzIy", + "avatar_url": "https://avatars.githubusercontent.com/u/17968722?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/camilajenny", + "html_url": "https://github.com/camilajenny", + "followers_url": "https://api.github.com/users/camilajenny/followers", + "following_url": "https://api.github.com/users/camilajenny/following{/other_user}", + "gists_url": "https://api.github.com/users/camilajenny/gists{/gist_id}", + "starred_url": "https://api.github.com/users/camilajenny/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/camilajenny/subscriptions", + "organizations_url": "https://api.github.com/users/camilajenny/orgs", + "repos_url": "https://api.github.com/users/camilajenny/repos", + "events_url": "https://api.github.com/users/camilajenny/events{/privacy}", + "received_events_url": "https://api.github.com/users/camilajenny/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-17T22:45:53Z", + "updated_at": "2025-02-17T22:45:53Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2664184849/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2664212282", + "html_url": "https://github.com/laurent22/joplin/pull/11853#issuecomment-2664212282", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11853", + "id": 2664212282, + "node_id": "IC_kwDOBLftOs6ezKc6", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-17T23:14:57Z", + "updated_at": "2025-02-17T23:14:57Z", + "author_association": "OWNER", + "body": "Thanks for the improved wording. CI however says this:\r\n\r\n> /home/runner/work/joplin/joplin/readme/faq.md:162:29 - Unknown word (honor)\r\n\r\nMaybe try \"honour\"? (we use British English)", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2664212282/reactions", + "total_count": 1, + "+1": 1, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/ckant_1410453.json b/readme/cla/consent_records/ckant_1410453.json new file mode 100644 index 0000000000..646ff7696f --- /dev/null +++ b/readme/cla/consent_records/ckant_1410453.json @@ -0,0 +1,317 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11474", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11474/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11474/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11474/events", + "html_url": "https://github.com/laurent22/joplin/pull/11474", + "id": 2722157849, + "node_id": "PR_kwDOBLftOs6ERzO2", + "number": 11474, + "title": "Desktop: Remove Better Code Blocks from the list of plugins incompatible with the new editor", + "user": { + "login": "ckant", + "id": 1410453, + "node_id": "MDQ6VXNlcjE0MTA0NTM=", + "avatar_url": "https://avatars.githubusercontent.com/u/1410453?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/ckant", + "html_url": "https://github.com/ckant", + "followers_url": "https://api.github.com/users/ckant/followers", + "following_url": "https://api.github.com/users/ckant/following{/other_user}", + "gists_url": "https://api.github.com/users/ckant/gists{/gist_id}", + "starred_url": "https://api.github.com/users/ckant/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/ckant/subscriptions", + "organizations_url": "https://api.github.com/users/ckant/orgs", + "repos_url": "https://api.github.com/users/ckant/repos", + "events_url": "https://api.github.com/users/ckant/events{/privacy}", + "received_events_url": "https://api.github.com/users/ckant/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 3, + "created_at": "2024-12-06T06:13:16Z", + "updated_at": "2024-12-10T06:14:10Z", + "closed_at": "2024-12-09T15:58:01Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11474", + "html_url": "https://github.com/laurent22/joplin/pull/11474", + "diff_url": "https://github.com/laurent22/joplin/pull/11474.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11474.patch", + "merged_at": "2024-12-09T15:58:01Z" + }, + "body": "# Summary\r\n\r\nThe Better Code Blocks plugin [now supports CodeMirror 6](https://discourse.joplinapp.org/t/plugin-better-code-blocks/32613/14?u=ckant) (as of v2.0.0).\r\n\r\nThis pull request removes `'com.ckant.joplin-plugin-better-code-blocks` from the list of plugins incompatible with CodeMirror 6.\r\n# Testing plan\r\n\r\n 1. Start Joplin (before compiling the changed files from this PR to JavaScript).\r\n\r\n 2. Install the Better Code Blocks plugin and restart.\r\n\r\n 3. Verify that an incompatibility warning is shown for the Better Code Blocks plugin\r\n\r\n 4. Quit Joplin\r\n\r\n 5. Run `yarn tsc` from `packages/app-desktop`.\r\n\r\n 6. Start Joplin\r\n\r\n 7. Verify that the incompatibility warning is no longer shown.\r\n\r\n---\r\n\r\nSame as #11143 which removed the Math Mode plugin", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11474/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11474/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2522225884", + "html_url": "https://github.com/laurent22/joplin/pull/11474#issuecomment-2522225884", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11474", + "id": 2522225884, + "node_id": "IC_kwDOBLftOs6WVhzc", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-06T06:13:30Z", + "updated_at": "2024-12-09T16:15:30Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2522225884/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2522226286", + "html_url": "https://github.com/laurent22/joplin/pull/11474#issuecomment-2522226286", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11474", + "id": 2522226286, + "node_id": "IC_kwDOBLftOs6WVh5u", + "user": { + "login": "ckant", + "id": 1410453, + "node_id": "MDQ6VXNlcjE0MTA0NTM=", + "avatar_url": "https://avatars.githubusercontent.com/u/1410453?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/ckant", + "html_url": "https://github.com/ckant", + "followers_url": "https://api.github.com/users/ckant/followers", + "following_url": "https://api.github.com/users/ckant/following{/other_user}", + "gists_url": "https://api.github.com/users/ckant/gists{/gist_id}", + "starred_url": "https://api.github.com/users/ckant/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/ckant/subscriptions", + "organizations_url": "https://api.github.com/users/ckant/orgs", + "repos_url": "https://api.github.com/users/ckant/repos", + "events_url": "https://api.github.com/users/ckant/events{/privacy}", + "received_events_url": "https://api.github.com/users/ckant/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-06T06:13:55Z", + "updated_at": "2024-12-06T06:13:55Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2522226286/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2522226414", + "html_url": "https://github.com/laurent22/joplin/pull/11474#issuecomment-2522226414", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11474", + "id": 2522226414, + "node_id": "IC_kwDOBLftOs6WVh7u", + "user": { + "login": "ckant", + "id": 1410453, + "node_id": "MDQ6VXNlcjE0MTA0NTM=", + "avatar_url": "https://avatars.githubusercontent.com/u/1410453?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/ckant", + "html_url": "https://github.com/ckant", + "followers_url": "https://api.github.com/users/ckant/followers", + "following_url": "https://api.github.com/users/ckant/following{/other_user}", + "gists_url": "https://api.github.com/users/ckant/gists{/gist_id}", + "starred_url": "https://api.github.com/users/ckant/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/ckant/subscriptions", + "organizations_url": "https://api.github.com/users/ckant/orgs", + "repos_url": "https://api.github.com/users/ckant/repos", + "events_url": "https://api.github.com/users/ckant/events{/privacy}", + "received_events_url": "https://api.github.com/users/ckant/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-06T06:14:03Z", + "updated_at": "2024-12-06T06:14:03Z", + "author_association": "CONTRIBUTOR", + "body": "recheck", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2522226414/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/click0_396824.json b/readme/cla/consent_records/click0_396824.json new file mode 100644 index 0000000000..1aa91eae6d --- /dev/null +++ b/readme/cla/consent_records/click0_396824.json @@ -0,0 +1,452 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11559", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11559/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11559/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11559/events", + "html_url": "https://github.com/laurent22/joplin/pull/11559", + "id": 2759078266, + "node_id": "PR_kwDOBLftOs6GOCDM", + "number": 11559, + "title": "Mobile, Desktop: Ukrainian translation", + "user": { + "login": "click0", + "id": 396824, + "node_id": "MDQ6VXNlcjM5NjgyNA==", + "avatar_url": "https://avatars.githubusercontent.com/u/396824?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/click0", + "html_url": "https://github.com/click0", + "followers_url": "https://api.github.com/users/click0/followers", + "following_url": "https://api.github.com/users/click0/following{/other_user}", + "gists_url": "https://api.github.com/users/click0/gists{/gist_id}", + "starred_url": "https://api.github.com/users/click0/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/click0/subscriptions", + "organizations_url": "https://api.github.com/users/click0/orgs", + "repos_url": "https://api.github.com/users/click0/repos", + "events_url": "https://api.github.com/users/click0/events{/privacy}", + "received_events_url": "https://api.github.com/users/click0/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 6, + "created_at": "2024-12-25T20:08:21Z", + "updated_at": "2024-12-30T16:07:05Z", + "closed_at": "2024-12-30T16:06:51Z", + "author_association": "NONE", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11559", + "html_url": "https://github.com/laurent22/joplin/pull/11559", + "diff_url": "https://github.com/laurent22/joplin/pull/11559.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11559.patch", + "merged_at": null + }, + "body": "1. Minor translation errors have been fixed.\r\n2. Added missing translation phrases.\r\n3. Added translation for Android application.\r\n", + "closed_by": { + "login": "click0", + "id": 396824, + "node_id": "MDQ6VXNlcjM5NjgyNA==", + "avatar_url": "https://avatars.githubusercontent.com/u/396824?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/click0", + "html_url": "https://github.com/click0", + "followers_url": "https://api.github.com/users/click0/followers", + "following_url": "https://api.github.com/users/click0/following{/other_user}", + "gists_url": "https://api.github.com/users/click0/gists{/gist_id}", + "starred_url": "https://api.github.com/users/click0/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/click0/subscriptions", + "organizations_url": "https://api.github.com/users/click0/orgs", + "repos_url": "https://api.github.com/users/click0/repos", + "events_url": "https://api.github.com/users/click0/events{/privacy}", + "received_events_url": "https://api.github.com/users/click0/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11559/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11559/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2561990382", + "html_url": "https://github.com/laurent22/joplin/pull/11559#issuecomment-2561990382", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11559", + "id": 2561990382, + "node_id": "IC_kwDOBLftOs6YtN7u", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-25T20:08:35Z", + "updated_at": "2024-12-30T16:07:05Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2561990382/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2561991202", + "html_url": "https://github.com/laurent22/joplin/pull/11559#issuecomment-2561991202", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11559", + "id": 2561991202, + "node_id": "IC_kwDOBLftOs6YtOIi", + "user": { + "login": "click0", + "id": 396824, + "node_id": "MDQ6VXNlcjM5NjgyNA==", + "avatar_url": "https://avatars.githubusercontent.com/u/396824?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/click0", + "html_url": "https://github.com/click0", + "followers_url": "https://api.github.com/users/click0/followers", + "following_url": "https://api.github.com/users/click0/following{/other_user}", + "gists_url": "https://api.github.com/users/click0/gists{/gist_id}", + "starred_url": "https://api.github.com/users/click0/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/click0/subscriptions", + "organizations_url": "https://api.github.com/users/click0/orgs", + "repos_url": "https://api.github.com/users/click0/repos", + "events_url": "https://api.github.com/users/click0/events{/privacy}", + "received_events_url": "https://api.github.com/users/click0/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-25T20:13:09Z", + "updated_at": "2024-12-25T20:13:09Z", + "author_association": "NONE", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2561991202/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2564694764", + "html_url": "https://github.com/laurent22/joplin/pull/11559#issuecomment-2564694764", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11559", + "id": 2564694764, + "node_id": "IC_kwDOBLftOs6Y3iLs", + "user": { + "login": "click0", + "id": 396824, + "node_id": "MDQ6VXNlcjM5NjgyNA==", + "avatar_url": "https://avatars.githubusercontent.com/u/396824?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/click0", + "html_url": "https://github.com/click0", + "followers_url": "https://api.github.com/users/click0/followers", + "following_url": "https://api.github.com/users/click0/following{/other_user}", + "gists_url": "https://api.github.com/users/click0/gists{/gist_id}", + "starred_url": "https://api.github.com/users/click0/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/click0/subscriptions", + "organizations_url": "https://api.github.com/users/click0/orgs", + "repos_url": "https://api.github.com/users/click0/repos", + "events_url": "https://api.github.com/users/click0/events{/privacy}", + "received_events_url": "https://api.github.com/users/click0/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-29T11:32:05Z", + "updated_at": "2024-12-29T11:32:05Z", + "author_association": "NONE", + "body": "> As explained in the docs https://joplinapp.org/help/dev/localisation the .po file has to be changed with Poedit.\r\n> \r\n> The json files are generated and thus must not be edited.\r\n\r\nToo bad.\r\nWe'll have to convert the data from .json to .po ...", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2564694764/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2564832904", + "html_url": "https://github.com/laurent22/joplin/pull/11559#issuecomment-2564832904", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11559", + "id": 2564832904, + "node_id": "IC_kwDOBLftOs6Y4D6I", + "user": { + "login": "tessus", + "id": 223439, + "node_id": "MDQ6VXNlcjIyMzQzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tessus", + "html_url": "https://github.com/tessus", + "followers_url": "https://api.github.com/users/tessus/followers", + "following_url": "https://api.github.com/users/tessus/following{/other_user}", + "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", + "organizations_url": "https://api.github.com/users/tessus/orgs", + "repos_url": "https://api.github.com/users/tessus/repos", + "events_url": "https://api.github.com/users/tessus/events{/privacy}", + "received_events_url": "https://api.github.com/users/tessus/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-29T20:36:07Z", + "updated_at": "2024-12-29T20:37:12Z", + "author_association": "COLLABORATOR", + "body": "I am also not so sure about the 2 text files. I have never seen them added by a translation PR. Did you talk to Laurent or clarify that in the forum?\r\n\r\nYou can have a look at previous translation PRs: https://github.com/laurent22/joplin/pulls?q=is%3Apr+label%3Atranslation+is%3Aclosed", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2564832904/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2564856022", + "html_url": "https://github.com/laurent22/joplin/pull/11559#issuecomment-2564856022", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11559", + "id": 2564856022, + "node_id": "IC_kwDOBLftOs6Y4JjW", + "user": { + "login": "click0", + "id": 396824, + "node_id": "MDQ6VXNlcjM5NjgyNA==", + "avatar_url": "https://avatars.githubusercontent.com/u/396824?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/click0", + "html_url": "https://github.com/click0", + "followers_url": "https://api.github.com/users/click0/followers", + "following_url": "https://api.github.com/users/click0/following{/other_user}", + "gists_url": "https://api.github.com/users/click0/gists{/gist_id}", + "starred_url": "https://api.github.com/users/click0/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/click0/subscriptions", + "organizations_url": "https://api.github.com/users/click0/orgs", + "repos_url": "https://api.github.com/users/click0/repos", + "events_url": "https://api.github.com/users/click0/events{/privacy}", + "received_events_url": "https://api.github.com/users/click0/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-29T22:37:28Z", + "updated_at": "2024-12-29T22:37:28Z", + "author_association": "NONE", + "body": "I still see discrepancies in the original phrases between the .json and .po files. \r\nIt seems that they were not added to the .po files.\r\n\r\n> Did you talk to Laurent or clarify that in the forum?\r\nI try not to communicate on forums.\r\n\r\nP.S. I switched to other projects for translation.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2564856022/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2564861376", + "html_url": "https://github.com/laurent22/joplin/pull/11559#issuecomment-2564861376", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11559", + "id": 2564861376, + "node_id": "IC_kwDOBLftOs6Y4K3A", + "user": { + "login": "tessus", + "id": 223439, + "node_id": "MDQ6VXNlcjIyMzQzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tessus", + "html_url": "https://github.com/tessus", + "followers_url": "https://api.github.com/users/tessus/followers", + "following_url": "https://api.github.com/users/tessus/following{/other_user}", + "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", + "organizations_url": "https://api.github.com/users/tessus/orgs", + "repos_url": "https://api.github.com/users/tessus/repos", + "events_url": "https://api.github.com/users/tessus/events{/privacy}", + "received_events_url": "https://api.github.com/users/tessus/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-29T23:06:07Z", + "updated_at": "2024-12-29T23:06:07Z", + "author_association": "COLLABORATOR", + "body": "> I still see discrepancies in the original phrases between the .json and .po files.\r\n> It seems that they were not added to the .po files.\r\n\r\nI think you got it backwards. The .po files are the source. The json files are generated from the .po files. If there are phrases in the json files that are not in the .po file, iy means those have been removed in newer code. ", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2564861376/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/clsty_129247596.json b/readme/cla/consent_records/clsty_129247596.json new file mode 100644 index 0000000000..b4f7c26d54 --- /dev/null +++ b/readme/cla/consent_records/clsty_129247596.json @@ -0,0 +1,462 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11922", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11922/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11922/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11922/events", + "html_url": "https://github.com/laurent22/joplin/pull/11922", + "id": 2893344130, + "node_id": "PR_kwDOBLftOs6NQ4f9", + "number": 11922, + "title": "Translation improvement for zh_CN", + "user": { + "login": "clsty", + "id": 129247596, + "node_id": "U_kgDOB7QpbA", + "avatar_url": "https://avatars.githubusercontent.com/u/129247596?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/clsty", + "html_url": "https://github.com/clsty", + "followers_url": "https://api.github.com/users/clsty/followers", + "following_url": "https://api.github.com/users/clsty/following{/other_user}", + "gists_url": "https://api.github.com/users/clsty/gists{/gist_id}", + "starred_url": "https://api.github.com/users/clsty/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/clsty/subscriptions", + "organizations_url": "https://api.github.com/users/clsty/orgs", + "repos_url": "https://api.github.com/users/clsty/repos", + "events_url": "https://api.github.com/users/clsty/events{/privacy}", + "received_events_url": "https://api.github.com/users/clsty/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [ + { + "id": 1091621259, + "node_id": "MDU6TGFiZWwxMDkxNjIxMjU5", + "url": "https://api.github.com/repos/laurent22/joplin/labels/translation", + "name": "translation", + "color": "91ca55", + "default": false, + "description": "i18n and l10n" + } + ], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 6, + "created_at": "2025-03-04T08:11:08Z", + "updated_at": "2025-03-06T00:16:28Z", + "closed_at": "2025-03-04T23:52:12Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11922", + "html_url": "https://github.com/laurent22/joplin/pull/11922", + "diff_url": "https://github.com/laurent22/joplin/pull/11922.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11922.patch", + "merged_at": "2025-03-04T23:52:12Z" + }, + "body": "- Improve simplified Chinese translation for corrections, readability and corrections, etc.", + "closed_by": { + "login": "tessus", + "id": 223439, + "node_id": "MDQ6VXNlcjIyMzQzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tessus", + "html_url": "https://github.com/tessus", + "followers_url": "https://api.github.com/users/tessus/followers", + "following_url": "https://api.github.com/users/tessus/following{/other_user}", + "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", + "organizations_url": "https://api.github.com/users/tessus/orgs", + "repos_url": "https://api.github.com/users/tessus/repos", + "events_url": "https://api.github.com/users/tessus/events{/privacy}", + "received_events_url": "https://api.github.com/users/tessus/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11922/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11922/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2696576049", + "html_url": "https://github.com/laurent22/joplin/pull/11922#issuecomment-2696576049", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11922", + "id": 2696576049, + "node_id": "IC_kwDOBLftOs6gunwx", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-04T08:11:23Z", + "updated_at": "2025-03-04T23:52:23Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2696576049/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2696584996", + "html_url": "https://github.com/laurent22/joplin/pull/11922#issuecomment-2696584996", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11922", + "id": 2696584996, + "node_id": "IC_kwDOBLftOs6gup8k", + "user": { + "login": "tessus", + "id": 223439, + "node_id": "MDQ6VXNlcjIyMzQzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tessus", + "html_url": "https://github.com/tessus", + "followers_url": "https://api.github.com/users/tessus/followers", + "following_url": "https://api.github.com/users/tessus/following{/other_user}", + "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", + "organizations_url": "https://api.github.com/users/tessus/orgs", + "repos_url": "https://api.github.com/users/tessus/repos", + "events_url": "https://api.github.com/users/tessus/events{/privacy}", + "received_events_url": "https://api.github.com/users/tessus/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-04T08:15:01Z", + "updated_at": "2025-03-04T08:15:01Z", + "author_association": "COLLABORATOR", + "body": "Oh, and you have to sign the CLA. see https://github.com/laurent22/joplin/pull/11922#issuecomment-2696576049", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2696584996/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2696593013", + "html_url": "https://github.com/laurent22/joplin/pull/11922#issuecomment-2696593013", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11922", + "id": 2696593013, + "node_id": "IC_kwDOBLftOs6gur51", + "user": { + "login": "tessus", + "id": 223439, + "node_id": "MDQ6VXNlcjIyMzQzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tessus", + "html_url": "https://github.com/tessus", + "followers_url": "https://api.github.com/users/tessus/followers", + "following_url": "https://api.github.com/users/tessus/following{/other_user}", + "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", + "organizations_url": "https://api.github.com/users/tessus/orgs", + "repos_url": "https://api.github.com/users/tessus/repos", + "events_url": "https://api.github.com/users/tessus/events{/privacy}", + "received_events_url": "https://api.github.com/users/tessus/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-04T08:18:46Z", + "updated_at": "2025-03-04T08:18:46Z", + "author_association": "COLLABORATOR", + "body": "I'm heading to bed. I'm going to look at it tomorrow.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2696593013/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2696597451", + "html_url": "https://github.com/laurent22/joplin/pull/11922#issuecomment-2696597451", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11922", + "id": 2696597451, + "node_id": "IC_kwDOBLftOs6gus_L", + "user": { + "login": "clsty", + "id": 129247596, + "node_id": "U_kgDOB7QpbA", + "avatar_url": "https://avatars.githubusercontent.com/u/129247596?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/clsty", + "html_url": "https://github.com/clsty", + "followers_url": "https://api.github.com/users/clsty/followers", + "following_url": "https://api.github.com/users/clsty/following{/other_user}", + "gists_url": "https://api.github.com/users/clsty/gists{/gist_id}", + "starred_url": "https://api.github.com/users/clsty/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/clsty/subscriptions", + "organizations_url": "https://api.github.com/users/clsty/orgs", + "repos_url": "https://api.github.com/users/clsty/repos", + "events_url": "https://api.github.com/users/clsty/events{/privacy}", + "received_events_url": "https://api.github.com/users/clsty/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-04T08:20:54Z", + "updated_at": "2025-03-04T08:20:54Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2696597451/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2696644884", + "html_url": "https://github.com/laurent22/joplin/pull/11922#issuecomment-2696644884", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11922", + "id": 2696644884, + "node_id": "IC_kwDOBLftOs6gu4kU", + "user": { + "login": "clsty", + "id": 129247596, + "node_id": "U_kgDOB7QpbA", + "avatar_url": "https://avatars.githubusercontent.com/u/129247596?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/clsty", + "html_url": "https://github.com/clsty", + "followers_url": "https://api.github.com/users/clsty/followers", + "following_url": "https://api.github.com/users/clsty/following{/other_user}", + "gists_url": "https://api.github.com/users/clsty/gists{/gist_id}", + "starred_url": "https://api.github.com/users/clsty/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/clsty/subscriptions", + "organizations_url": "https://api.github.com/users/clsty/orgs", + "repos_url": "https://api.github.com/users/clsty/repos", + "events_url": "https://api.github.com/users/clsty/events{/privacy}", + "received_events_url": "https://api.github.com/users/clsty/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-04T08:39:23Z", + "updated_at": "2025-03-06T00:16:28Z", + "author_association": "CONTRIBUTOR", + "body": "> see inline comment\r\n> \r\n> Other than that, LGTM. Thanks for the update\r\n\r\nThat's a really quick response. Thanks for reviewing.\r\n\r\nI've added the comments back. However may I ask why they are still needed btw?", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2696644884/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2699270516", + "html_url": "https://github.com/laurent22/joplin/pull/11922#issuecomment-2699270516", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11922", + "id": 2699270516, + "node_id": "IC_kwDOBLftOs6g45l0", + "user": { + "login": "tessus", + "id": 223439, + "node_id": "MDQ6VXNlcjIyMzQzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tessus", + "html_url": "https://github.com/tessus", + "followers_url": "https://api.github.com/users/tessus/followers", + "following_url": "https://api.github.com/users/tessus/following{/other_user}", + "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", + "organizations_url": "https://api.github.com/users/tessus/orgs", + "repos_url": "https://api.github.com/users/tessus/repos", + "events_url": "https://api.github.com/users/tessus/events{/privacy}", + "received_events_url": "https://api.github.com/users/tessus/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-04T23:41:24Z", + "updated_at": "2025-03-04T23:41:24Z", + "author_association": "COLLABORATOR", + "body": "Thank you for adding the comments back.\r\n\r\nThe reason for keeping them around is as follows: The translation files are generated from the source code. It is quite possible that a change in the code will be reverted at a later point or a similar text is used as what was previously used and translated.\r\nWe also do not use annotations in translation files, which would help in certain situations to understand the meaning of the text and to translate it properly. Literal translations are often wrong and need correction. If there are a valid translations in the comments, they can help a translator.\r\nI'm not sure but Poedit might make use of them for translation suggestions.\r\n\r\nAdditionally, the .po file are not used in the product. They are converted to JSON files and all comments are stripped out anyway. \r\n", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2699270516/reactions", + "total_count": 1, + "+1": 1, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/creationsofm7_29347949.json b/readme/cla/consent_records/creationsofm7_29347949.json new file mode 100644 index 0000000000..d832a861eb --- /dev/null +++ b/readme/cla/consent_records/creationsofm7_29347949.json @@ -0,0 +1,362 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11680", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11680/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11680/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11680/events", + "html_url": "https://github.com/laurent22/joplin/pull/11680", + "id": 2797516973, + "node_id": "PR_kwDOBLftOs6IQ18U", + "number": 11680, + "title": "Desktop: Resolves #11662: Fixed Rich Text Editor:   included in title text ", + "user": { + "login": "creationsofm7", + "id": 29347949, + "node_id": "MDQ6VXNlcjI5MzQ3OTQ5", + "avatar_url": "https://avatars.githubusercontent.com/u/29347949?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/creationsofm7", + "html_url": "https://github.com/creationsofm7", + "followers_url": "https://api.github.com/users/creationsofm7/followers", + "following_url": "https://api.github.com/users/creationsofm7/following{/other_user}", + "gists_url": "https://api.github.com/users/creationsofm7/gists{/gist_id}", + "starred_url": "https://api.github.com/users/creationsofm7/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/creationsofm7/subscriptions", + "organizations_url": "https://api.github.com/users/creationsofm7/orgs", + "repos_url": "https://api.github.com/users/creationsofm7/repos", + "events_url": "https://api.github.com/users/creationsofm7/events{/privacy}", + "received_events_url": "https://api.github.com/users/creationsofm7/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": true, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 4, + "created_at": "2025-01-19T09:09:55Z", + "updated_at": "2025-01-19T15:27:15Z", + "closed_at": "2025-01-19T15:27:05Z", + "author_association": "NONE", + "active_lock_reason": "resolved", + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11680", + "html_url": "https://github.com/laurent22/joplin/pull/11680", + "diff_url": "https://github.com/laurent22/joplin/pull/11680.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11680.patch", + "merged_at": null + }, + "body": "", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11680/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11680/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2600770691", + "html_url": "https://github.com/laurent22/joplin/pull/11680#issuecomment-2600770691", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11680", + "id": 2600770691, + "node_id": "IC_kwDOBLftOs6bBJyD", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-01-19T09:10:09Z", + "updated_at": "2025-01-19T10:31:26Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2600770691/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2600798645", + "html_url": "https://github.com/laurent22/joplin/pull/11680#issuecomment-2600798645", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11680", + "id": 2600798645, + "node_id": "IC_kwDOBLftOs6bBQm1", + "user": { + "login": "creationsofm7", + "id": 29347949, + "node_id": "MDQ6VXNlcjI5MzQ3OTQ5", + "avatar_url": "https://avatars.githubusercontent.com/u/29347949?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/creationsofm7", + "html_url": "https://github.com/creationsofm7", + "followers_url": "https://api.github.com/users/creationsofm7/followers", + "following_url": "https://api.github.com/users/creationsofm7/following{/other_user}", + "gists_url": "https://api.github.com/users/creationsofm7/gists{/gist_id}", + "starred_url": "https://api.github.com/users/creationsofm7/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/creationsofm7/subscriptions", + "organizations_url": "https://api.github.com/users/creationsofm7/orgs", + "repos_url": "https://api.github.com/users/creationsofm7/repos", + "events_url": "https://api.github.com/users/creationsofm7/events{/privacy}", + "received_events_url": "https://api.github.com/users/creationsofm7/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-01-19T10:24:53Z", + "updated_at": "2025-01-19T10:32:01Z", + "author_association": "NONE", + "body": "I have read the CLA Document and I hereby sign the CLA\r\n\r\n\r\n", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2600798645/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2600800647", + "html_url": "https://github.com/laurent22/joplin/pull/11680#issuecomment-2600800647", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11680", + "id": 2600800647, + "node_id": "IC_kwDOBLftOs6bBRGH", + "user": { + "login": "creationsofm7", + "id": 29347949, + "node_id": "MDQ6VXNlcjI5MzQ3OTQ5", + "avatar_url": "https://avatars.githubusercontent.com/u/29347949?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/creationsofm7", + "html_url": "https://github.com/creationsofm7", + "followers_url": "https://api.github.com/users/creationsofm7/followers", + "following_url": "https://api.github.com/users/creationsofm7/following{/other_user}", + "gists_url": "https://api.github.com/users/creationsofm7/gists{/gist_id}", + "starred_url": "https://api.github.com/users/creationsofm7/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/creationsofm7/subscriptions", + "organizations_url": "https://api.github.com/users/creationsofm7/orgs", + "repos_url": "https://api.github.com/users/creationsofm7/repos", + "events_url": "https://api.github.com/users/creationsofm7/events{/privacy}", + "received_events_url": "https://api.github.com/users/creationsofm7/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-01-19T10:31:01Z", + "updated_at": "2025-01-19T10:31:50Z", + "author_association": "NONE", + "body": "recheck", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2600800647/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2600909350", + "html_url": "https://github.com/laurent22/joplin/pull/11680#issuecomment-2600909350", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11680", + "id": 2600909350, + "node_id": "IC_kwDOBLftOs6bBrom", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-01-19T15:27:06Z", + "updated_at": "2025-01-19T15:27:06Z", + "author_association": "OWNER", + "body": "nbsp shouldn't just be removed, it shouldn't be there to begin with", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2600909350/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/d4m14n-gh_87342969.json b/readme/cla/consent_records/d4m14n-gh_87342969.json new file mode 100644 index 0000000000..bf8b9b337c --- /dev/null +++ b/readme/cla/consent_records/d4m14n-gh_87342969.json @@ -0,0 +1,407 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12043", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/12043/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/12043/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/12043/events", + "html_url": "https://github.com/laurent22/joplin/pull/12043", + "id": 2964587386, + "node_id": "PR_kwDOBLftOs6Q_r4y", + "number": 12043, + "title": "All: Resolves minor bug: Fixed absoluteUrl and baseUrl functions", + "user": { + "login": "d4m14n-gh", + "id": 87342969, + "node_id": "MDQ6VXNlcjg3MzQyOTY5", + "avatar_url": "https://avatars.githubusercontent.com/u/87342969?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/d4m14n-gh", + "html_url": "https://github.com/d4m14n-gh", + "followers_url": "https://api.github.com/users/d4m14n-gh/followers", + "following_url": "https://api.github.com/users/d4m14n-gh/following{/other_user}", + "gists_url": "https://api.github.com/users/d4m14n-gh/gists{/gist_id}", + "starred_url": "https://api.github.com/users/d4m14n-gh/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/d4m14n-gh/subscriptions", + "organizations_url": "https://api.github.com/users/d4m14n-gh/orgs", + "repos_url": "https://api.github.com/users/d4m14n-gh/repos", + "events_url": "https://api.github.com/users/d4m14n-gh/events{/privacy}", + "received_events_url": "https://api.github.com/users/d4m14n-gh/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 5, + "created_at": "2025-04-01T21:13:09Z", + "updated_at": "2025-04-07T19:25:41Z", + "closed_at": "2025-04-07T19:05:37Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/12043", + "html_url": "https://github.com/laurent22/joplin/pull/12043", + "diff_url": "https://github.com/laurent22/joplin/pull/12043.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/12043.patch", + "merged_at": "2025-04-07T19:05:37Z" + }, + "body": "# All: Resolves minor bug: Fixed absoluteUrl function (/packages/lib/clipperUtils.ts)\r\n\r\nFixes an issue with the absoluteUrl function, which occurs when the function is invoked with a relative URL (a path-only URL).\r\nI found this bug while running my own white-box unit tests.\r\n\r\n\r\n\r\n### My own test result screen:\r\n![image](https://github.com/user-attachments/assets/639b2832-1e91-4ea9-b5cf-9935e23e34e3)\r\n\r\n### Old code with my comment:\r\n```typescript\r\nfunction absoluteUrl(url: string) {\r\n\tif (!url) return url;\r\n\tconst protocol = url.toLowerCase().split(':')[0];\r\n\tif (['http', 'https', 'file', 'data'].indexOf(protocol) >= 0) return url;\r\n\r\n\tif (url.indexOf('//') === 0) {\r\n\t\treturn location.protocol + url;\r\n\t} else if (url[0] === '/') {\r\n\t\treturn `${location.protocol}//${location.host}${url}`;\r\n\t} else {\r\n\t\treturn `${baseUrl()}/${url}`; //double '/' here: baseUrl() can ends with '/'\r\n\t}\r\n}\r\n```\r\n\r\n```typescript\r\nfunction baseUrl() {\r\n\tlet output = pageLocationOrigin() + location.pathname; //location.pathname can be \"/\" or can ends with \"/\"\r\n\tif (output[output.length - 1] !== '/') {\r\n\t\tconst output2 = output.split('/');\r\n\t\toutput2.pop();\r\n\t\toutput = output2.join('/');\r\n\t}\r\n\treturn output;\r\n}\r\n```\r\n\r\n\r\n### New version of baseUrl():\r\n```typescript\r\nfunction baseUrl() {\r\n\tlet output = pageLocationOrigin() + location.pathname;\r\n\tif (output[output.length - 1] !== '/') {\r\n\t\t\tconst output2 = output.split('/');\r\n\t\t\toutput2.pop();\r\n\t\t\toutput = output2.join('/');\r\n\t}\r\n\tif (output[output.length - 1] === '/') {\r\n\t\t\toutput = output.slice(0, -1);\r\n\t}\r\n\treturn output;\r\n}\r\n", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12043/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/12043/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2770699318", + "html_url": "https://github.com/laurent22/joplin/pull/12043#issuecomment-2770699318", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12043", + "id": 2770699318, + "node_id": "IC_kwDOBLftOs6lJYQ2", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-01T21:13:21Z", + "updated_at": "2025-04-07T19:25:40Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2770699318/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2770702602", + "html_url": "https://github.com/laurent22/joplin/pull/12043#issuecomment-2770702602", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12043", + "id": 2770702602, + "node_id": "IC_kwDOBLftOs6lJZEK", + "user": { + "login": "d4m14n-gh", + "id": 87342969, + "node_id": "MDQ6VXNlcjg3MzQyOTY5", + "avatar_url": "https://avatars.githubusercontent.com/u/87342969?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/d4m14n-gh", + "html_url": "https://github.com/d4m14n-gh", + "followers_url": "https://api.github.com/users/d4m14n-gh/followers", + "following_url": "https://api.github.com/users/d4m14n-gh/following{/other_user}", + "gists_url": "https://api.github.com/users/d4m14n-gh/gists{/gist_id}", + "starred_url": "https://api.github.com/users/d4m14n-gh/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/d4m14n-gh/subscriptions", + "organizations_url": "https://api.github.com/users/d4m14n-gh/orgs", + "repos_url": "https://api.github.com/users/d4m14n-gh/repos", + "events_url": "https://api.github.com/users/d4m14n-gh/events{/privacy}", + "received_events_url": "https://api.github.com/users/d4m14n-gh/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-01T21:15:08Z", + "updated_at": "2025-04-01T21:15:08Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2770702602/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2771960341", + "html_url": "https://github.com/laurent22/joplin/pull/12043#issuecomment-2771960341", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12043", + "id": 2771960341, + "node_id": "IC_kwDOBLftOs6lOMIV", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-02T09:22:04Z", + "updated_at": "2025-04-02T09:22:04Z", + "author_association": "OWNER", + "body": "Thank you, but normally it's the base URL that shouldn't have a trailing slash, so it's `baseUrl()` that should be fixed", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2771960341/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2772120315", + "html_url": "https://github.com/laurent22/joplin/pull/12043#issuecomment-2772120315", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12043", + "id": 2772120315, + "node_id": "IC_kwDOBLftOs6lOzL7", + "user": { + "login": "d4m14n-gh", + "id": 87342969, + "node_id": "MDQ6VXNlcjg3MzQyOTY5", + "avatar_url": "https://avatars.githubusercontent.com/u/87342969?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/d4m14n-gh", + "html_url": "https://github.com/d4m14n-gh", + "followers_url": "https://api.github.com/users/d4m14n-gh/followers", + "following_url": "https://api.github.com/users/d4m14n-gh/following{/other_user}", + "gists_url": "https://api.github.com/users/d4m14n-gh/gists{/gist_id}", + "starred_url": "https://api.github.com/users/d4m14n-gh/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/d4m14n-gh/subscriptions", + "organizations_url": "https://api.github.com/users/d4m14n-gh/orgs", + "repos_url": "https://api.github.com/users/d4m14n-gh/repos", + "events_url": "https://api.github.com/users/d4m14n-gh/events{/privacy}", + "received_events_url": "https://api.github.com/users/d4m14n-gh/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-02T10:23:21Z", + "updated_at": "2025-04-02T10:23:21Z", + "author_association": "CONTRIBUTOR", + "body": "> Thank you, but normally it's the base URL that shouldn't have a trailing slash, so it's `baseUrl()` that should be fixed\r\n\r\nYou're right, my mistake. I've corrected it.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2772120315/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2784293772", + "html_url": "https://github.com/laurent22/joplin/pull/12043#issuecomment-2784293772", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12043", + "id": 2784293772, + "node_id": "IC_kwDOBLftOs6l9POM", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-07T19:05:25Z", + "updated_at": "2025-04-07T19:05:25Z", + "author_association": "OWNER", + "body": "That looks good now, thank you!", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2784293772/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/dandv_33569.json b/readme/cla/consent_records/dandv_33569.json new file mode 100644 index 0000000000..a5a6d68f22 --- /dev/null +++ b/readme/cla/consent_records/dandv_33569.json @@ -0,0 +1,362 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11834", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11834/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11834/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11834/events", + "html_url": "https://github.com/laurent22/joplin/pull/11834", + "id": 2851660366, + "node_id": "PR_kwDOBLftOs6LI1Pf", + "number": 11834, + "title": "Docs: update note tagging instructions in 1_welcome_to_joplin.md", + "user": { + "login": "dandv", + "id": 33569, + "node_id": "MDQ6VXNlcjMzNTY5", + "avatar_url": "https://avatars.githubusercontent.com/u/33569?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/dandv", + "html_url": "https://github.com/dandv", + "followers_url": "https://api.github.com/users/dandv/followers", + "following_url": "https://api.github.com/users/dandv/following{/other_user}", + "gists_url": "https://api.github.com/users/dandv/gists{/gist_id}", + "starred_url": "https://api.github.com/users/dandv/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/dandv/subscriptions", + "organizations_url": "https://api.github.com/users/dandv/orgs", + "repos_url": "https://api.github.com/users/dandv/repos", + "events_url": "https://api.github.com/users/dandv/events{/privacy}", + "received_events_url": "https://api.github.com/users/dandv/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 4, + "created_at": "2025-02-13T17:20:15Z", + "updated_at": "2025-02-17T12:12:06Z", + "closed_at": "2025-02-17T12:11:45Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11834", + "html_url": "https://github.com/laurent22/joplin/pull/11834", + "diff_url": "https://github.com/laurent22/joplin/pull/11834.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11834.patch", + "merged_at": "2025-02-17T12:11:45Z" + }, + "body": null, + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11834/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11834/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2657269156", + "html_url": "https://github.com/laurent22/joplin/pull/11834#issuecomment-2657269156", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11834", + "id": 2657269156, + "node_id": "IC_kwDOBLftOs6eYrWk", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-13T17:20:32Z", + "updated_at": "2025-02-17T12:11:58Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2657269156/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2658343928", + "html_url": "https://github.com/laurent22/joplin/pull/11834#issuecomment-2658343928", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11834", + "id": 2658343928, + "node_id": "IC_kwDOBLftOs6ecxv4", + "user": { + "login": "dandv", + "id": 33569, + "node_id": "MDQ6VXNlcjMzNTY5", + "avatar_url": "https://avatars.githubusercontent.com/u/33569?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/dandv", + "html_url": "https://github.com/dandv", + "followers_url": "https://api.github.com/users/dandv/followers", + "following_url": "https://api.github.com/users/dandv/following{/other_user}", + "gists_url": "https://api.github.com/users/dandv/gists{/gist_id}", + "starred_url": "https://api.github.com/users/dandv/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/dandv/subscriptions", + "organizations_url": "https://api.github.com/users/dandv/orgs", + "repos_url": "https://api.github.com/users/dandv/repos", + "events_url": "https://api.github.com/users/dandv/events{/privacy}", + "received_events_url": "https://api.github.com/users/dandv/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-14T05:50:13Z", + "updated_at": "2025-02-14T05:50:13Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2658343928/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2658344194", + "html_url": "https://github.com/laurent22/joplin/pull/11834#issuecomment-2658344194", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11834", + "id": 2658344194, + "node_id": "IC_kwDOBLftOs6ecx0C", + "user": { + "login": "dandv", + "id": 33569, + "node_id": "MDQ6VXNlcjMzNTY5", + "avatar_url": "https://avatars.githubusercontent.com/u/33569?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/dandv", + "html_url": "https://github.com/dandv", + "followers_url": "https://api.github.com/users/dandv/followers", + "following_url": "https://api.github.com/users/dandv/following{/other_user}", + "gists_url": "https://api.github.com/users/dandv/gists{/gist_id}", + "starred_url": "https://api.github.com/users/dandv/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/dandv/subscriptions", + "organizations_url": "https://api.github.com/users/dandv/orgs", + "repos_url": "https://api.github.com/users/dandv/repos", + "events_url": "https://api.github.com/users/dandv/events{/privacy}", + "received_events_url": "https://api.github.com/users/dandv/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-14T05:50:28Z", + "updated_at": "2025-02-14T05:50:28Z", + "author_association": "CONTRIBUTOR", + "body": "recheck", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2658344194/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2662938019", + "html_url": "https://github.com/laurent22/joplin/pull/11834#issuecomment-2662938019", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11834", + "id": 2662938019, + "node_id": "IC_kwDOBLftOs6euTWj", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-17T12:12:04Z", + "updated_at": "2025-02-17T12:12:04Z", + "author_association": "OWNER", + "body": "Thanks for fixing this!", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2662938019/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/danobot_7984567.json b/readme/cla/consent_records/danobot_7984567.json new file mode 100644 index 0000000000..3187832c7b --- /dev/null +++ b/readme/cla/consent_records/danobot_7984567.json @@ -0,0 +1,362 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12065", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/12065/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/12065/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/12065/events", + "html_url": "https://github.com/laurent22/joplin/pull/12065", + "id": 2974834340, + "node_id": "PR_kwDOBLftOs6Rh2ej", + "number": 12065, + "title": "Add healthcheck options to docker-compose file", + "user": { + "login": "danobot", + "id": 7984567, + "node_id": "MDQ6VXNlcjc5ODQ1Njc=", + "avatar_url": "https://avatars.githubusercontent.com/u/7984567?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/danobot", + "html_url": "https://github.com/danobot", + "followers_url": "https://api.github.com/users/danobot/followers", + "following_url": "https://api.github.com/users/danobot/following{/other_user}", + "gists_url": "https://api.github.com/users/danobot/gists{/gist_id}", + "starred_url": "https://api.github.com/users/danobot/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/danobot/subscriptions", + "organizations_url": "https://api.github.com/users/danobot/orgs", + "repos_url": "https://api.github.com/users/danobot/repos", + "events_url": "https://api.github.com/users/danobot/events{/privacy}", + "received_events_url": "https://api.github.com/users/danobot/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 4, + "created_at": "2025-04-06T09:41:23Z", + "updated_at": "2025-04-06T10:51:30Z", + "closed_at": "2025-04-06T10:51:16Z", + "author_association": "NONE", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/12065", + "html_url": "https://github.com/laurent22/joplin/pull/12065", + "diff_url": "https://github.com/laurent22/joplin/pull/12065.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/12065.patch", + "merged_at": null + }, + "body": "Add healthcheck options to ensure postgres container is ready before starting the Joplin server container.\r\n\r\nThis is to avoid the database connection errors in server logs.", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12065/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/12065/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2781333891", + "html_url": "https://github.com/laurent22/joplin/pull/12065#issuecomment-2781333891", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12065", + "id": 2781333891, + "node_id": "IC_kwDOBLftOs6lx8mD", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-06T09:41:35Z", + "updated_at": "2025-04-06T10:51:29Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2781333891/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2781334600", + "html_url": "https://github.com/laurent22/joplin/pull/12065#issuecomment-2781334600", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12065", + "id": 2781334600, + "node_id": "IC_kwDOBLftOs6lx8xI", + "user": { + "login": "danobot", + "id": 7984567, + "node_id": "MDQ6VXNlcjc5ODQ1Njc=", + "avatar_url": "https://avatars.githubusercontent.com/u/7984567?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/danobot", + "html_url": "https://github.com/danobot", + "followers_url": "https://api.github.com/users/danobot/followers", + "following_url": "https://api.github.com/users/danobot/following{/other_user}", + "gists_url": "https://api.github.com/users/danobot/gists{/gist_id}", + "starred_url": "https://api.github.com/users/danobot/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/danobot/subscriptions", + "organizations_url": "https://api.github.com/users/danobot/orgs", + "repos_url": "https://api.github.com/users/danobot/repos", + "events_url": "https://api.github.com/users/danobot/events{/privacy}", + "received_events_url": "https://api.github.com/users/danobot/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-06T09:43:49Z", + "updated_at": "2025-04-06T09:43:49Z", + "author_association": "NONE", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2781334600/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2781334740", + "html_url": "https://github.com/laurent22/joplin/pull/12065#issuecomment-2781334740", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12065", + "id": 2781334740, + "node_id": "IC_kwDOBLftOs6lx8zU", + "user": { + "login": "danobot", + "id": 7984567, + "node_id": "MDQ6VXNlcjc5ODQ1Njc=", + "avatar_url": "https://avatars.githubusercontent.com/u/7984567?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/danobot", + "html_url": "https://github.com/danobot", + "followers_url": "https://api.github.com/users/danobot/followers", + "following_url": "https://api.github.com/users/danobot/following{/other_user}", + "gists_url": "https://api.github.com/users/danobot/gists{/gist_id}", + "starred_url": "https://api.github.com/users/danobot/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/danobot/subscriptions", + "organizations_url": "https://api.github.com/users/danobot/orgs", + "repos_url": "https://api.github.com/users/danobot/repos", + "events_url": "https://api.github.com/users/danobot/events{/privacy}", + "received_events_url": "https://api.github.com/users/danobot/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-06T09:44:10Z", + "updated_at": "2025-04-06T09:44:10Z", + "author_association": "NONE", + "body": "recheck", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2781334740/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2781360538", + "html_url": "https://github.com/laurent22/joplin/pull/12065#issuecomment-2781360538", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12065", + "id": 2781360538, + "node_id": "IC_kwDOBLftOs6lyDGa", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-06T10:51:16Z", + "updated_at": "2025-04-06T10:51:25Z", + "author_association": "OWNER", + "body": "Thanks for the pull request, but we're trying to keep the docker-compose as a minimal example to get started. Also in this particular case Joplin Server will refuse to start anyway if the database is not ready, so it's not a huge issue that it hasn't been detected earlier", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2781360538/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/deftdawg_4991612.json b/readme/cla/consent_records/deftdawg_4991612.json new file mode 100644 index 0000000000..d3d657a089 --- /dev/null +++ b/readme/cla/consent_records/deftdawg_4991612.json @@ -0,0 +1,542 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11406", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11406/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11406/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11406/events", + "html_url": "https://github.com/laurent22/joplin/pull/11406", + "id": 2669244846, + "node_id": "PR_kwDOBLftOs6CRqWY", + "number": 11406, + "title": "Add Devbox+DirEnv integration to simplify build tool setup", + "user": { + "login": "deftdawg", + "id": 4991612, + "node_id": "MDQ6VXNlcjQ5OTE2MTI=", + "avatar_url": "https://avatars.githubusercontent.com/u/4991612?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/deftdawg", + "html_url": "https://github.com/deftdawg", + "followers_url": "https://api.github.com/users/deftdawg/followers", + "following_url": "https://api.github.com/users/deftdawg/following{/other_user}", + "gists_url": "https://api.github.com/users/deftdawg/gists{/gist_id}", + "starred_url": "https://api.github.com/users/deftdawg/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/deftdawg/subscriptions", + "organizations_url": "https://api.github.com/users/deftdawg/orgs", + "repos_url": "https://api.github.com/users/deftdawg/repos", + "events_url": "https://api.github.com/users/deftdawg/events{/privacy}", + "received_events_url": "https://api.github.com/users/deftdawg/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 8, + "created_at": "2024-11-18T17:03:10Z", + "updated_at": "2024-11-20T14:01:43Z", + "closed_at": "2024-11-20T14:01:31Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11406", + "html_url": "https://github.com/laurent22/joplin/pull/11406", + "diff_url": "https://github.com/laurent22/joplin/pull/11406.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11406.patch", + "merged_at": "2024-11-20T14:01:31Z" + }, + "body": "[Devbox](https://github.com/jetify-com/devbox) is a tool that codifies and satisfies OS-specific dependencies using [Nix](https://nixos.org/); [DirEnv](https://direnv.net/) auto-loads `devbox` when entering a directory (must run `direnv allow` once to prevent hacks).\r\n\r\nWhen devbox+direnv are enabled together, the user need only checkout the repo and change into the directory and a full build environment will be automatically downloaded & configured.\r\n\r\nThis devbox.json has successfully built and run Joplin Desktop & CLI on MacOS (Apple Silicon) and Linux (NixOS); it should also work on any Linux distro including WSL.\r\n\r\n## MacOS / Apple Silicon\r\n\"Joplin-Devbox-OSX\"\r\n\r\n## Linux / X86-64\r\n![image](https://github.com/user-attachments/assets/545f0fde-be37-4001-8dd8-faf87ac19724)\r\n(Electron override message appears only on NixOS where it is required)\r\n\r\n## Setting Up Devbox + DirEnv (this a one-time setup for all projects using devbox configurations)\r\n\r\nThere are a number of ways to setup devbox+direnv, the general requirements are:\r\n1. Install [DirEnv](https://direnv.net/docs/installation.html) + [Devbox](https://www.jetify.com/docs/devbox/installing_devbox/) + [Nix](https://github.com/DeterminateSystems/nix-installer?tab=readme-ov-file#determinate-nix-installer) (devbox will install nix, if not present)\r\n - These can be installed via package manager or direct download or after installing nix via `nix profile install nixpkgs#{direnv,devbox}`\r\n2. Add direnv hooks to your shell `~/.bash_profile` or `~/.zshrc` (i.e. append `direnv hook bash` or `direnv hook zsh`) and source or restart your shell. \r\n", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11406/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11406/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2483612660", + "html_url": "https://github.com/laurent22/joplin/pull/11406#issuecomment-2483612660", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11406", + "id": 2483612660, + "node_id": "IC_kwDOBLftOs6UCOv0", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-18T17:03:25Z", + "updated_at": "2024-11-20T14:01:43Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2483612660/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2483623341", + "html_url": "https://github.com/laurent22/joplin/pull/11406#issuecomment-2483623341", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11406", + "id": 2483623341, + "node_id": "IC_kwDOBLftOs6UCRWt", + "user": { + "login": "deftdawg", + "id": 4991612, + "node_id": "MDQ6VXNlcjQ5OTE2MTI=", + "avatar_url": "https://avatars.githubusercontent.com/u/4991612?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/deftdawg", + "html_url": "https://github.com/deftdawg", + "followers_url": "https://api.github.com/users/deftdawg/followers", + "following_url": "https://api.github.com/users/deftdawg/following{/other_user}", + "gists_url": "https://api.github.com/users/deftdawg/gists{/gist_id}", + "starred_url": "https://api.github.com/users/deftdawg/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/deftdawg/subscriptions", + "organizations_url": "https://api.github.com/users/deftdawg/orgs", + "repos_url": "https://api.github.com/users/deftdawg/repos", + "events_url": "https://api.github.com/users/deftdawg/events{/privacy}", + "received_events_url": "https://api.github.com/users/deftdawg/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-18T17:07:29Z", + "updated_at": "2024-11-18T17:07:29Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2483623341/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2483630038", + "html_url": "https://github.com/laurent22/joplin/pull/11406#issuecomment-2483630038", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11406", + "id": 2483630038, + "node_id": "IC_kwDOBLftOs6UCS_W", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-18T17:10:29Z", + "updated_at": "2024-11-18T17:10:29Z", + "author_association": "OWNER", + "body": "Thank you but I don't think we'd want to maintain this as part of this repository. Isn't it possible to post the solution to its own repository and then maybe link to it from BUILD.md?", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2483630038/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2483694884", + "html_url": "https://github.com/laurent22/joplin/pull/11406#issuecomment-2483694884", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11406", + "id": 2483694884, + "node_id": "IC_kwDOBLftOs6UCi0k", + "user": { + "login": "deftdawg", + "id": 4991612, + "node_id": "MDQ6VXNlcjQ5OTE2MTI=", + "avatar_url": "https://avatars.githubusercontent.com/u/4991612?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/deftdawg", + "html_url": "https://github.com/deftdawg", + "followers_url": "https://api.github.com/users/deftdawg/followers", + "following_url": "https://api.github.com/users/deftdawg/following{/other_user}", + "gists_url": "https://api.github.com/users/deftdawg/gists{/gist_id}", + "starred_url": "https://api.github.com/users/deftdawg/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/deftdawg/subscriptions", + "organizations_url": "https://api.github.com/users/deftdawg/orgs", + "repos_url": "https://api.github.com/users/deftdawg/repos", + "events_url": "https://api.github.com/users/deftdawg/events{/privacy}", + "received_events_url": "https://api.github.com/users/deftdawg/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-18T17:34:00Z", + "updated_at": "2024-11-18T17:34:00Z", + "author_association": "CONTRIBUTOR", + "body": "> Thank you but I don't think we'd want to maintain this as part of this repository. Isn't it possible to post the solution to its own repository and then maybe link to it from BUILD.md?\r\n\r\nWhen I first tried to build Joplin a few years back on Ubuntu, I failed at the build deps stage... Perhaps with a bunch of extra time and effort grinding at it (this was pre-ChatGPT), I could've eventually got it to build. Instead I gave up and just hoped someone else would eventually fix the issue that frustrated me - fortunately they eventually did.\r\n\r\nHaving to read build docs or fetch external code to build defeats the purpose of codifying the build tools and dependencies into the project itself with this method.\r\n\r\nThat being said, I understand the desire to not to clutter up your project, it's probably best not to confuse folks with a link to some magical alternative way to configure in the BUILD.md either, so feel free to close this PR.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2483694884/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2483818991", + "html_url": "https://github.com/laurent22/joplin/pull/11406#issuecomment-2483818991", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11406", + "id": 2483818991, + "node_id": "IC_kwDOBLftOs6UDBHv", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-18T18:32:17Z", + "updated_at": "2024-11-18T18:32:17Z", + "author_association": "OWNER", + "body": "Thanks for the explanation, I see your point and this is indeed a good way to encode properly what is currently only documented in BUILD.md.\r\n\r\nIn that case, would you mind also updating BUILD.md? To avoid the duplicated info I'd suggest adding something like \"The required dependencies are listed in (path/to/devbox.json), or you can automatically install them using devbox: (Here you add your instructions)\"\r\n\r\nIsn't not possible to run the devbox.json script without having to modify direnv?", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2483818991/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2483914514", + "html_url": "https://github.com/laurent22/joplin/pull/11406#issuecomment-2483914514", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11406", + "id": 2483914514, + "node_id": "IC_kwDOBLftOs6UDYcS", + "user": { + "login": "deftdawg", + "id": 4991612, + "node_id": "MDQ6VXNlcjQ5OTE2MTI=", + "avatar_url": "https://avatars.githubusercontent.com/u/4991612?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/deftdawg", + "html_url": "https://github.com/deftdawg", + "followers_url": "https://api.github.com/users/deftdawg/followers", + "following_url": "https://api.github.com/users/deftdawg/following{/other_user}", + "gists_url": "https://api.github.com/users/deftdawg/gists{/gist_id}", + "starred_url": "https://api.github.com/users/deftdawg/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/deftdawg/subscriptions", + "organizations_url": "https://api.github.com/users/deftdawg/orgs", + "repos_url": "https://api.github.com/users/deftdawg/repos", + "events_url": "https://api.github.com/users/deftdawg/events{/privacy}", + "received_events_url": "https://api.github.com/users/deftdawg/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-18T19:23:09Z", + "updated_at": "2024-11-18T19:23:09Z", + "author_association": "CONTRIBUTOR", + "body": "> In that case, would you mind also updating BUILD.md? To avoid the duplicated info I'd suggest adding something like \"The required dependencies are listed in (path/to/devbox.json), or you can automatically install them using devbox: (Here you add your instructions)\"\r\n\r\nSure, I'll write something up and add it to BUILD.md and amend the PR\r\n\r\n> Isn't not possible to run the devbox.json script without having to modify direnv?\r\n\r\nThat's a good shout, it's absolutely possible to start a devbox environment up without direnv by entering the directory and typing `devbox shell`. I'll add that to the notes in BUILD.md", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2483914514/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2486115517", + "html_url": "https://github.com/laurent22/joplin/pull/11406#issuecomment-2486115517", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11406", + "id": 2486115517, + "node_id": "IC_kwDOBLftOs6ULxy9", + "user": { + "login": "deftdawg", + "id": 4991612, + "node_id": "MDQ6VXNlcjQ5OTE2MTI=", + "avatar_url": "https://avatars.githubusercontent.com/u/4991612?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/deftdawg", + "html_url": "https://github.com/deftdawg", + "followers_url": "https://api.github.com/users/deftdawg/followers", + "following_url": "https://api.github.com/users/deftdawg/following{/other_user}", + "gists_url": "https://api.github.com/users/deftdawg/gists{/gist_id}", + "starred_url": "https://api.github.com/users/deftdawg/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/deftdawg/subscriptions", + "organizations_url": "https://api.github.com/users/deftdawg/orgs", + "repos_url": "https://api.github.com/users/deftdawg/repos", + "events_url": "https://api.github.com/users/deftdawg/events{/privacy}", + "received_events_url": "https://api.github.com/users/deftdawg/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-19T16:00:05Z", + "updated_at": "2024-11-19T16:00:05Z", + "author_association": "CONTRIBUTOR", + "body": "I wanted to validate the configuration a bit more on a clean install, so I created a new Ubuntu VM from an old ISO I had in my Downloads (KDE Neon / Bionic 18.04)... \r\n\r\nTLDR; it works and I'll add `git` to the devbox config and commit that with the updated BUILD.md\r\n\r\n```sh\r\nsudo apt-get -y install git\r\ngit clone https://github.com/deftdawg/joplin\r\ncd joplin\r\ncurl -fsSL https://get.jetify.com/devbox | bash # Installed devbox and nix\r\ndevbox shell\r\nyarn install # git (2.17.1) is so old on Bionic it doesn't handle `git switch`\r\ndevbox add git # add git latest (2.47.0) to fix error and so we have git if the user were to install from source tarball\r\nyarn install\r\ncd packages/app-desktop && yarn start\r\n# works!\r\n```\r\n![joplin-devbox-empty-neon](https://github.com/user-attachments/assets/6d850098-de56-40bf-880e-e044ce7a925e)\r\n\r\n![kde-neon-5 19-18 04-bionic](https://github.com/user-attachments/assets/64cb6c32-4473-437e-8801-2dece8541cab)\r\n\r\n", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2486115517/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2488663695", + "html_url": "https://github.com/laurent22/joplin/pull/11406#issuecomment-2488663695", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11406", + "id": 2488663695, + "node_id": "IC_kwDOBLftOs6UVf6P", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-20T14:01:21Z", + "updated_at": "2024-11-20T14:01:21Z", + "author_association": "OWNER", + "body": "That's great, thanks @deftdawg. I made a few more tweaks to BUILD.md and it's ready to merge now", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2488663695/reactions", + "total_count": 1, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 1, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/dhakarRaghu_149622456.json b/readme/cla/consent_records/dhakarRaghu_149622456.json new file mode 100644 index 0000000000..e921c73200 --- /dev/null +++ b/readme/cla/consent_records/dhakarRaghu_149622456.json @@ -0,0 +1,317 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11388", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11388/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11388/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11388/events", + "html_url": "https://github.com/laurent22/joplin/pull/11388", + "id": 2656236918, + "node_id": "PR_kwDOBLftOs6B0Sdi", + "number": 11388, + "title": " Desktop: Fixes #11261 : Ensure spell-check toggle works on macOS", + "user": { + "login": "dhakarRaghu", + "id": 149622456, + "node_id": "U_kgDOCOsOuA", + "avatar_url": "https://avatars.githubusercontent.com/u/149622456?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/dhakarRaghu", + "html_url": "https://github.com/dhakarRaghu", + "followers_url": "https://api.github.com/users/dhakarRaghu/followers", + "following_url": "https://api.github.com/users/dhakarRaghu/following{/other_user}", + "gists_url": "https://api.github.com/users/dhakarRaghu/gists{/gist_id}", + "starred_url": "https://api.github.com/users/dhakarRaghu/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/dhakarRaghu/subscriptions", + "organizations_url": "https://api.github.com/users/dhakarRaghu/orgs", + "repos_url": "https://api.github.com/users/dhakarRaghu/repos", + "events_url": "https://api.github.com/users/dhakarRaghu/events{/privacy}", + "received_events_url": "https://api.github.com/users/dhakarRaghu/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 3, + "created_at": "2024-11-13T17:27:29Z", + "updated_at": "2024-12-09T15:49:08Z", + "closed_at": "2024-12-09T15:48:52Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11388", + "html_url": "https://github.com/laurent22/joplin/pull/11388", + "diff_url": "https://github.com/laurent22/joplin/pull/11388.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11388.patch", + "merged_at": "2024-12-09T15:48:52Z" + }, + "body": "# Desktop: Fixes #11261 : Ensure spell-check can be toggled off on macOS\r\n\r\nThis pull request addresses an issue where spell-check could not be fully disabled on the macOS desktop app, even when explicitly turned off in the settings.\r\n\r\n## Problem\r\nOn macOS, users encountered a problem when trying to disable spell-check. Although the setting was turned off, spell-check continued to underline words, suggesting that it wasn't fully disabled.\r\n\r\n## Solution\r\nThe fix ensures that:\r\n- When users toggle spell-check off, the language list is set to an empty array, and the spell-checker is explicitly disabled in the session.\r\n- When re-enabling, the spell-checker applies the correct languages and confirms that it is enabled in the session.\r\n\r\n## Technical Summary\r\n- Updated the `SpellCheckerServiceDriverNative.ts` file to explicitly call `setSpellCheckerEnabled(false)` when disabling and `setSpellCheckerEnabled(true)` when enabling.\r\n- Improved logging in `setLanguages` to track the session's state after each toggle and confirm that the changes have taken effect.\r\n\r\n## Testing\r\n- Manually tested the toggling of spell-check on and off on the macOS desktop app to confirm that spell-check does not underline words when disabled.\r\n- Verified that the correct language settings are applied upon re-enabling.\r\n\r\nThis PR resolves the underlying issue and provides a more consistent spell-check toggle experience on the macOS platform.\r\n\r\n**Reference**: Fixes #11261 \r\n\r\ndemo : \r\n\r\nhttps://github.com/user-attachments/assets/a63392ed-3038-481d-95ce-eca052c1f7df\r\n\r\n\r\n", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11388/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11388/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2474282479", + "html_url": "https://github.com/laurent22/joplin/pull/11388#issuecomment-2474282479", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11388", + "id": 2474282479, + "node_id": "IC_kwDOBLftOs6Teo3v", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-13T17:27:46Z", + "updated_at": "2024-12-09T15:49:08Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2474282479/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2474283042", + "html_url": "https://github.com/laurent22/joplin/pull/11388#issuecomment-2474283042", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11388", + "id": 2474283042, + "node_id": "IC_kwDOBLftOs6TepAi", + "user": { + "login": "dhakarRaghu", + "id": 149622456, + "node_id": "U_kgDOCOsOuA", + "avatar_url": "https://avatars.githubusercontent.com/u/149622456?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/dhakarRaghu", + "html_url": "https://github.com/dhakarRaghu", + "followers_url": "https://api.github.com/users/dhakarRaghu/followers", + "following_url": "https://api.github.com/users/dhakarRaghu/following{/other_user}", + "gists_url": "https://api.github.com/users/dhakarRaghu/gists{/gist_id}", + "starred_url": "https://api.github.com/users/dhakarRaghu/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/dhakarRaghu/subscriptions", + "organizations_url": "https://api.github.com/users/dhakarRaghu/orgs", + "repos_url": "https://api.github.com/users/dhakarRaghu/repos", + "events_url": "https://api.github.com/users/dhakarRaghu/events{/privacy}", + "received_events_url": "https://api.github.com/users/dhakarRaghu/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-13T17:28:00Z", + "updated_at": "2024-11-13T17:28:00Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2474283042/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2480811692", + "html_url": "https://github.com/laurent22/joplin/pull/11388#issuecomment-2480811692", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11388", + "id": 2480811692, + "node_id": "IC_kwDOBLftOs6T3i6s", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-16T21:14:32Z", + "updated_at": "2024-11-16T21:14:32Z", + "author_association": "OWNER", + "body": "Too many white space changes, deleted comments and log statements in this pull request. We can't merge it as it is", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2480811692/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/dodog_976639.json b/readme/cla/consent_records/dodog_976639.json new file mode 100644 index 0000000000..e08eacb4e2 --- /dev/null +++ b/readme/cla/consent_records/dodog_976639.json @@ -0,0 +1,597 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11433", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11433/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11433/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11433/events", + "html_url": "https://github.com/laurent22/joplin/pull/11433", + "id": 2680896607, + "node_id": "PR_kwDOBLftOs6CuZSY", + "number": 11433, + "title": "ALL: Added Slovak translation", + "user": { + "login": "dodog", + "id": 976639, + "node_id": "MDQ6VXNlcjk3NjYzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/976639?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/dodog", + "html_url": "https://github.com/dodog", + "followers_url": "https://api.github.com/users/dodog/followers", + "following_url": "https://api.github.com/users/dodog/following{/other_user}", + "gists_url": "https://api.github.com/users/dodog/gists{/gist_id}", + "starred_url": "https://api.github.com/users/dodog/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/dodog/subscriptions", + "organizations_url": "https://api.github.com/users/dodog/orgs", + "repos_url": "https://api.github.com/users/dodog/repos", + "events_url": "https://api.github.com/users/dodog/events{/privacy}", + "received_events_url": "https://api.github.com/users/dodog/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [ + { + "id": 1091621259, + "node_id": "MDU6TGFiZWwxMDkxNjIxMjU5", + "url": "https://api.github.com/repos/laurent22/joplin/labels/translation", + "name": "translation", + "color": "91ca55", + "default": false, + "description": "i18n and l10n" + } + ], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 9, + "created_at": "2024-11-21T20:45:00Z", + "updated_at": "2024-12-26T20:47:17Z", + "closed_at": "2024-11-23T20:41:14Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11433", + "html_url": "https://github.com/laurent22/joplin/pull/11433", + "diff_url": "https://github.com/laurent22/joplin/pull/11433.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11433.patch", + "merged_at": "2024-11-23T20:41:14Z" + }, + "body": "Added Slovak language translation\r\n\r\n", + "closed_by": { + "login": "tessus", + "id": 223439, + "node_id": "MDQ6VXNlcjIyMzQzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tessus", + "html_url": "https://github.com/tessus", + "followers_url": "https://api.github.com/users/tessus/followers", + "following_url": "https://api.github.com/users/tessus/following{/other_user}", + "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", + "organizations_url": "https://api.github.com/users/tessus/orgs", + "repos_url": "https://api.github.com/users/tessus/repos", + "events_url": "https://api.github.com/users/tessus/events{/privacy}", + "received_events_url": "https://api.github.com/users/tessus/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11433/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11433/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2492290686", + "html_url": "https://github.com/laurent22/joplin/pull/11433#issuecomment-2492290686", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11433", + "id": 2492290686, + "node_id": "IC_kwDOBLftOs6UjVZ-", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-21T20:45:13Z", + "updated_at": "2024-11-23T20:42:17Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2492290686/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2492293790", + "html_url": "https://github.com/laurent22/joplin/pull/11433#issuecomment-2492293790", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11433", + "id": 2492293790, + "node_id": "IC_kwDOBLftOs6UjWKe", + "user": { + "login": "dodog", + "id": 976639, + "node_id": "MDQ6VXNlcjk3NjYzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/976639?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/dodog", + "html_url": "https://github.com/dodog", + "followers_url": "https://api.github.com/users/dodog/followers", + "following_url": "https://api.github.com/users/dodog/following{/other_user}", + "gists_url": "https://api.github.com/users/dodog/gists{/gist_id}", + "starred_url": "https://api.github.com/users/dodog/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/dodog/subscriptions", + "organizations_url": "https://api.github.com/users/dodog/orgs", + "repos_url": "https://api.github.com/users/dodog/repos", + "events_url": "https://api.github.com/users/dodog/events{/privacy}", + "received_events_url": "https://api.github.com/users/dodog/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-21T20:46:24Z", + "updated_at": "2024-11-21T20:46:24Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2492293790/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2492829935", + "html_url": "https://github.com/laurent22/joplin/pull/11433#issuecomment-2492829935", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11433", + "id": 2492829935, + "node_id": "IC_kwDOBLftOs6UlZDv", + "user": { + "login": "tessus", + "id": 223439, + "node_id": "MDQ6VXNlcjIyMzQzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tessus", + "html_url": "https://github.com/tessus", + "followers_url": "https://api.github.com/users/tessus/followers", + "following_url": "https://api.github.com/users/tessus/following{/other_user}", + "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", + "organizations_url": "https://api.github.com/users/tessus/orgs", + "repos_url": "https://api.github.com/users/tessus/repos", + "events_url": "https://api.github.com/users/tessus/events{/privacy}", + "received_events_url": "https://api.github.com/users/tessus/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-22T04:00:13Z", + "updated_at": "2024-11-22T04:00:13Z", + "author_association": "COLLABORATOR", + "body": "Thanks for the translation. May I ask how this was done? I'm asking this because we had people submit automated translations and a lot of the translations won't be correct without knowing the context.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2492829935/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2493606016", + "html_url": "https://github.com/laurent22/joplin/pull/11433#issuecomment-2493606016", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11433", + "id": 2493606016, + "node_id": "IC_kwDOBLftOs6UoWiA", + "user": { + "login": "dodog", + "id": 976639, + "node_id": "MDQ6VXNlcjk3NjYzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/976639?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/dodog", + "html_url": "https://github.com/dodog", + "followers_url": "https://api.github.com/users/dodog/followers", + "following_url": "https://api.github.com/users/dodog/following{/other_user}", + "gists_url": "https://api.github.com/users/dodog/gists{/gist_id}", + "starred_url": "https://api.github.com/users/dodog/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/dodog/subscriptions", + "organizations_url": "https://api.github.com/users/dodog/orgs", + "repos_url": "https://api.github.com/users/dodog/repos", + "events_url": "https://api.github.com/users/dodog/events{/privacy}", + "received_events_url": "https://api.github.com/users/dodog/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-22T12:06:06Z", + "updated_at": "2024-11-22T12:06:06Z", + "author_association": "CONTRIBUTOR", + "body": "I translated everything by myself. I use Joplin on my computer and iPhone with its own Joplin server. I really like the app and wanted to contribute my bit. I only tested the translation strings visually because I was not able to load the translation file to the app and test it that way. If there is some simple way to do this, please let me know. ", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2493606016/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2494441968", + "html_url": "https://github.com/laurent22/joplin/pull/11433#issuecomment-2494441968", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11433", + "id": 2494441968, + "node_id": "IC_kwDOBLftOs6Urinw", + "user": { + "login": "tessus", + "id": 223439, + "node_id": "MDQ6VXNlcjIyMzQzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tessus", + "html_url": "https://github.com/tessus", + "followers_url": "https://api.github.com/users/tessus/followers", + "following_url": "https://api.github.com/users/tessus/following{/other_user}", + "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", + "organizations_url": "https://api.github.com/users/tessus/orgs", + "repos_url": "https://api.github.com/users/tessus/repos", + "events_url": "https://api.github.com/users/tessus/events{/privacy}", + "received_events_url": "https://api.github.com/users/tessus/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-22T18:00:54Z", + "updated_at": "2024-11-22T18:00:54Z", + "author_association": "COLLABORATOR", + "body": "Awesome, thanks for the info.\r\n\r\n@laurent22 I can't recall, whether we have to do something in particular for new translations. But I believe no extra steps have to be taken, correct? There were extra steps way in the past, but now I think we should be good. am I correct?", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2494441968/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2495479973", + "html_url": "https://github.com/laurent22/joplin/pull/11433#issuecomment-2495479973", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11433", + "id": 2495479973, + "node_id": "IC_kwDOBLftOs6UvgCl", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-23T13:27:57Z", + "updated_at": "2024-11-23T13:27:57Z", + "author_association": "OWNER", + "body": "No it should just work if we add a language file, there's not special script to run", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2495479973/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2495648994", + "html_url": "https://github.com/laurent22/joplin/pull/11433#issuecomment-2495648994", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11433", + "id": 2495648994, + "node_id": "IC_kwDOBLftOs6UwJTi", + "user": { + "login": "tessus", + "id": 223439, + "node_id": "MDQ6VXNlcjIyMzQzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tessus", + "html_url": "https://github.com/tessus", + "followers_url": "https://api.github.com/users/tessus/followers", + "following_url": "https://api.github.com/users/tessus/following{/other_user}", + "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", + "organizations_url": "https://api.github.com/users/tessus/orgs", + "repos_url": "https://api.github.com/users/tessus/repos", + "events_url": "https://api.github.com/users/tessus/events{/privacy}", + "received_events_url": "https://api.github.com/users/tessus/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-11-23T20:42:22Z", + "updated_at": "2024-11-23T20:42:22Z", + "author_association": "COLLABORATOR", + "body": "Thanks a bunch for your contribution @dodog. Must have been a lot of work.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2495648994/reactions", + "total_count": 2, + "+1": 2, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2562757785", + "html_url": "https://github.com/laurent22/joplin/pull/11433#issuecomment-2562757785", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11433", + "id": 2562757785, + "node_id": "IC_kwDOBLftOs6YwJSZ", + "user": { + "login": "dodog", + "id": 976639, + "node_id": "MDQ6VXNlcjk3NjYzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/976639?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/dodog", + "html_url": "https://github.com/dodog", + "followers_url": "https://api.github.com/users/dodog/followers", + "following_url": "https://api.github.com/users/dodog/following{/other_user}", + "gists_url": "https://api.github.com/users/dodog/gists{/gist_id}", + "starred_url": "https://api.github.com/users/dodog/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/dodog/subscriptions", + "organizations_url": "https://api.github.com/users/dodog/orgs", + "repos_url": "https://api.github.com/users/dodog/repos", + "events_url": "https://api.github.com/users/dodog/events{/privacy}", + "received_events_url": "https://api.github.com/users/dodog/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-26T13:48:44Z", + "updated_at": "2024-12-26T13:48:44Z", + "author_association": "CONTRIBUTOR", + "body": "@tessus I think some extra steps should have been taken after all, because the json files were not generated and the language is not available to select in menu.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2562757785/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2563090424", + "html_url": "https://github.com/laurent22/joplin/pull/11433#issuecomment-2563090424", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11433", + "id": 2563090424, + "node_id": "IC_kwDOBLftOs6Yxaf4", + "user": { + "login": "tessus", + "id": 223439, + "node_id": "MDQ6VXNlcjIyMzQzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tessus", + "html_url": "https://github.com/tessus", + "followers_url": "https://api.github.com/users/tessus/followers", + "following_url": "https://api.github.com/users/tessus/following{/other_user}", + "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", + "organizations_url": "https://api.github.com/users/tessus/orgs", + "repos_url": "https://api.github.com/users/tessus/repos", + "events_url": "https://api.github.com/users/tessus/events{/privacy}", + "received_events_url": "https://api.github.com/users/tessus/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-26T20:47:16Z", + "updated_at": "2024-12-26T20:47:16Z", + "author_association": "COLLABORATOR", + "body": "Hmm, I thought that creating the translation files was added to the CI workflow at one point. But maybe not. ", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2563090424/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/ericdq_27959252.json b/readme/cla/consent_records/ericdq_27959252.json new file mode 100644 index 0000000000..56cbd35e45 --- /dev/null +++ b/readme/cla/consent_records/ericdq_27959252.json @@ -0,0 +1,282 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11913", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11913/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11913/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11913/events", + "html_url": "https://github.com/laurent22/joplin/pull/11913", + "id": 2891980510, + "node_id": "PR_kwDOBLftOs6NMRXj", + "number": 11913, + "title": "updating Spanish translation strings", + "user": { + "login": "ericdq", + "id": 27959252, + "node_id": "MDQ6VXNlcjI3OTU5MjUy", + "avatar_url": "https://avatars.githubusercontent.com/u/27959252?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/ericdq", + "html_url": "https://github.com/ericdq", + "followers_url": "https://api.github.com/users/ericdq/followers", + "following_url": "https://api.github.com/users/ericdq/following{/other_user}", + "gists_url": "https://api.github.com/users/ericdq/gists{/gist_id}", + "starred_url": "https://api.github.com/users/ericdq/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/ericdq/subscriptions", + "organizations_url": "https://api.github.com/users/ericdq/orgs", + "repos_url": "https://api.github.com/users/ericdq/repos", + "events_url": "https://api.github.com/users/ericdq/events{/privacy}", + "received_events_url": "https://api.github.com/users/ericdq/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [ + { + "id": 1091621259, + "node_id": "MDU6TGFiZWwxMDkxNjIxMjU5", + "url": "https://api.github.com/repos/laurent22/joplin/labels/translation", + "name": "translation", + "color": "91ca55", + "default": false, + "description": "i18n and l10n" + } + ], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 2, + "created_at": "2025-03-03T18:26:01Z", + "updated_at": "2025-03-04T01:43:41Z", + "closed_at": "2025-03-04T01:43:27Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11913", + "html_url": "https://github.com/laurent22/joplin/pull/11913", + "diff_url": "https://github.com/laurent22/joplin/pull/11913.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11913.patch", + "merged_at": "2025-03-04T01:43:27Z" + }, + "body": "", + "closed_by": { + "login": "tessus", + "id": 223439, + "node_id": "MDQ6VXNlcjIyMzQzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tessus", + "html_url": "https://github.com/tessus", + "followers_url": "https://api.github.com/users/tessus/followers", + "following_url": "https://api.github.com/users/tessus/following{/other_user}", + "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", + "organizations_url": "https://api.github.com/users/tessus/orgs", + "repos_url": "https://api.github.com/users/tessus/repos", + "events_url": "https://api.github.com/users/tessus/events{/privacy}", + "received_events_url": "https://api.github.com/users/tessus/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11913/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11913/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2695218918", + "html_url": "https://github.com/laurent22/joplin/pull/11913#issuecomment-2695218918", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11913", + "id": 2695218918, + "node_id": "IC_kwDOBLftOs6gpcbm", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-03T18:26:16Z", + "updated_at": "2025-03-04T01:43:41Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2695218918/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2695221840", + "html_url": "https://github.com/laurent22/joplin/pull/11913#issuecomment-2695221840", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11913", + "id": 2695221840, + "node_id": "IC_kwDOBLftOs6gpdJQ", + "user": { + "login": "ericdq", + "id": 27959252, + "node_id": "MDQ6VXNlcjI3OTU5MjUy", + "avatar_url": "https://avatars.githubusercontent.com/u/27959252?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/ericdq", + "html_url": "https://github.com/ericdq", + "followers_url": "https://api.github.com/users/ericdq/followers", + "following_url": "https://api.github.com/users/ericdq/following{/other_user}", + "gists_url": "https://api.github.com/users/ericdq/gists{/gist_id}", + "starred_url": "https://api.github.com/users/ericdq/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/ericdq/subscriptions", + "organizations_url": "https://api.github.com/users/ericdq/orgs", + "repos_url": "https://api.github.com/users/ericdq/repos", + "events_url": "https://api.github.com/users/ericdq/events{/privacy}", + "received_events_url": "https://api.github.com/users/ericdq/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-03T18:27:49Z", + "updated_at": "2025-03-03T18:27:49Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2695221840/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/executed_36827253.json b/readme/cla/consent_records/executed_36827253.json new file mode 100644 index 0000000000..751d18df1f --- /dev/null +++ b/readme/cla/consent_records/executed_36827253.json @@ -0,0 +1,362 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12094", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/12094/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/12094/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/12094/events", + "html_url": "https://github.com/laurent22/joplin/pull/12094", + "id": 2991784629, + "node_id": "PR_kwDOBLftOs6Sa3U5", + "number": 12094, + "title": "Plugin API: expose hash from clicked cross-note link", + "user": { + "login": "executed", + "id": 36827253, + "node_id": "MDQ6VXNlcjM2ODI3MjUz", + "avatar_url": "https://avatars.githubusercontent.com/u/36827253?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/executed", + "html_url": "https://github.com/executed", + "followers_url": "https://api.github.com/users/executed/followers", + "following_url": "https://api.github.com/users/executed/following{/other_user}", + "gists_url": "https://api.github.com/users/executed/gists{/gist_id}", + "starred_url": "https://api.github.com/users/executed/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/executed/subscriptions", + "organizations_url": "https://api.github.com/users/executed/orgs", + "repos_url": "https://api.github.com/users/executed/repos", + "events_url": "https://api.github.com/users/executed/events{/privacy}", + "received_events_url": "https://api.github.com/users/executed/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 4, + "created_at": "2025-04-14T03:34:22Z", + "updated_at": "2025-04-14T12:44:02Z", + "closed_at": "2025-04-14T12:42:25Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/12094", + "html_url": "https://github.com/laurent22/joplin/pull/12094", + "diff_url": "https://github.com/laurent22/joplin/pull/12094.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/12094.patch", + "merged_at": "2025-04-14T12:42:25Z" + }, + "body": "## 📌 Description\r\n\r\nThis PR adds a new method to the plugin API:\r\n\r\n```ts\r\npublic async selectedNoteHash(): Promise\r\n```\r\n\r\nThis method returns the **section hash** (i.e., the anchor ID) from a cross-note link, such as in the following format:\r\n\r\n```\r\n[Other Note Title](:/note-id#section-id)\r\n```\r\n\r\nIf the note was navigated via a cross-note link that includes a valid section hash, the method returns that hash (e.g., `\"section-id\"`). Otherwise, it returns an empty string.\r\n\r\n---\r\n\r\n## ✅ Motivation\r\n- **Cross-note navigation awareness**: Helps plugins differentiate between a standard note switch and a targeted jump to a section.\r\n- Currently, plugins can detect when a note changes, but not **which specific section** was targeted within that note. This enhancement makes that distinction possible by exposing the last navigated hash value via a stable method.\r\n\r\n## 🧠 Notes\r\n\r\n- The hash is updated after `onNoteSelectionChange()` is triggered.\r\n- It complements existing navigation APIs by adding **section-level granularity**.", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12094/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/12094/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2800387547", + "html_url": "https://github.com/laurent22/joplin/pull/12094#issuecomment-2800387547", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12094", + "id": 2800387547, + "node_id": "IC_kwDOBLftOs6m6oXb", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-14T03:34:36Z", + "updated_at": "2025-04-14T12:42:37Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2800387547/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2800387987", + "html_url": "https://github.com/laurent22/joplin/pull/12094#issuecomment-2800387987", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12094", + "id": 2800387987, + "node_id": "IC_kwDOBLftOs6m6oeT", + "user": { + "login": "executed", + "id": 36827253, + "node_id": "MDQ6VXNlcjM2ODI3MjUz", + "avatar_url": "https://avatars.githubusercontent.com/u/36827253?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/executed", + "html_url": "https://github.com/executed", + "followers_url": "https://api.github.com/users/executed/followers", + "following_url": "https://api.github.com/users/executed/following{/other_user}", + "gists_url": "https://api.github.com/users/executed/gists{/gist_id}", + "starred_url": "https://api.github.com/users/executed/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/executed/subscriptions", + "organizations_url": "https://api.github.com/users/executed/orgs", + "repos_url": "https://api.github.com/users/executed/repos", + "events_url": "https://api.github.com/users/executed/events{/privacy}", + "received_events_url": "https://api.github.com/users/executed/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-14T03:35:03Z", + "updated_at": "2025-04-14T03:35:03Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2800387987/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2801587411", + "html_url": "https://github.com/laurent22/joplin/pull/12094#issuecomment-2801587411", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12094", + "id": 2801587411, + "node_id": "IC_kwDOBLftOs6m_NTT", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-14T12:42:17Z", + "updated_at": "2025-04-14T12:42:17Z", + "author_association": "OWNER", + "body": "That looks good to me, thank you for adding this!", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2801587411/reactions", + "total_count": 1, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 1, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2801591952", + "html_url": "https://github.com/laurent22/joplin/pull/12094#issuecomment-2801591952", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12094", + "id": 2801591952, + "node_id": "IC_kwDOBLftOs6m_OaQ", + "user": { + "login": "executed", + "id": 36827253, + "node_id": "MDQ6VXNlcjM2ODI3MjUz", + "avatar_url": "https://avatars.githubusercontent.com/u/36827253?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/executed", + "html_url": "https://github.com/executed", + "followers_url": "https://api.github.com/users/executed/followers", + "following_url": "https://api.github.com/users/executed/following{/other_user}", + "gists_url": "https://api.github.com/users/executed/gists{/gist_id}", + "starred_url": "https://api.github.com/users/executed/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/executed/subscriptions", + "organizations_url": "https://api.github.com/users/executed/orgs", + "repos_url": "https://api.github.com/users/executed/repos", + "events_url": "https://api.github.com/users/executed/events{/privacy}", + "received_events_url": "https://api.github.com/users/executed/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-14T12:44:01Z", + "updated_at": "2025-04-14T12:44:01Z", + "author_association": "CONTRIBUTOR", + "body": "@laurent22 thank you for review!", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2801591952/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/forsaken628_18322364.json b/readme/cla/consent_records/forsaken628_18322364.json new file mode 100644 index 0000000000..7f35e1dd57 --- /dev/null +++ b/readme/cla/consent_records/forsaken628_18322364.json @@ -0,0 +1,317 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12032", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/12032/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/12032/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/12032/events", + "html_url": "https://github.com/laurent22/joplin/pull/12032", + "id": 2958798438, + "node_id": "PR_kwDOBLftOs6QsJsf", + "number": 12032, + "title": "Server: Added endpoint configuration for StorageDriverS3", + "user": { + "login": "forsaken628", + "id": 18322364, + "node_id": "MDQ6VXNlcjE4MzIyMzY0", + "avatar_url": "https://avatars.githubusercontent.com/u/18322364?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/forsaken628", + "html_url": "https://github.com/forsaken628", + "followers_url": "https://api.github.com/users/forsaken628/followers", + "following_url": "https://api.github.com/users/forsaken628/following{/other_user}", + "gists_url": "https://api.github.com/users/forsaken628/gists{/gist_id}", + "starred_url": "https://api.github.com/users/forsaken628/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/forsaken628/subscriptions", + "organizations_url": "https://api.github.com/users/forsaken628/orgs", + "repos_url": "https://api.github.com/users/forsaken628/repos", + "events_url": "https://api.github.com/users/forsaken628/events{/privacy}", + "received_events_url": "https://api.github.com/users/forsaken628/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 3, + "created_at": "2025-03-30T10:45:31Z", + "updated_at": "2025-04-27T09:03:35Z", + "closed_at": "2025-04-24T19:07:04Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/12032", + "html_url": "https://github.com/laurent22/joplin/pull/12032", + "diff_url": "https://github.com/laurent22/joplin/pull/12032.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/12032.patch", + "merged_at": "2025-04-24T19:07:04Z" + }, + "body": "I would like to be able to use some s3 compatible object store as a storage driver, which requires support for configuring endpoint.\r\n", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12032/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/12032/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2764498008", + "html_url": "https://github.com/laurent22/joplin/pull/12032#issuecomment-2764498008", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12032", + "id": 2764498008, + "node_id": "IC_kwDOBLftOs6kxuRY", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-30T10:45:43Z", + "updated_at": "2025-04-24T19:07:23Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2764498008/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2764498548", + "html_url": "https://github.com/laurent22/joplin/pull/12032#issuecomment-2764498548", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12032", + "id": 2764498548, + "node_id": "IC_kwDOBLftOs6kxuZ0", + "user": { + "login": "forsaken628", + "id": 18322364, + "node_id": "MDQ6VXNlcjE4MzIyMzY0", + "avatar_url": "https://avatars.githubusercontent.com/u/18322364?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/forsaken628", + "html_url": "https://github.com/forsaken628", + "followers_url": "https://api.github.com/users/forsaken628/followers", + "following_url": "https://api.github.com/users/forsaken628/following{/other_user}", + "gists_url": "https://api.github.com/users/forsaken628/gists{/gist_id}", + "starred_url": "https://api.github.com/users/forsaken628/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/forsaken628/subscriptions", + "organizations_url": "https://api.github.com/users/forsaken628/orgs", + "repos_url": "https://api.github.com/users/forsaken628/repos", + "events_url": "https://api.github.com/users/forsaken628/events{/privacy}", + "received_events_url": "https://api.github.com/users/forsaken628/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-30T10:47:18Z", + "updated_at": "2025-03-30T10:47:18Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2764498548/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2764499044", + "html_url": "https://github.com/laurent22/joplin/pull/12032#issuecomment-2764499044", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12032", + "id": 2764499044, + "node_id": "IC_kwDOBLftOs6kxuhk", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-30T10:48:52Z", + "updated_at": "2025-03-30T10:48:52Z", + "author_association": "OWNER", + "body": "We'll need a bit more than zero information and no linked issue", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2764499044/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/harshil048_74892092.json b/readme/cla/consent_records/harshil048_74892092.json new file mode 100644 index 0000000000..962efbcb3a --- /dev/null +++ b/readme/cla/consent_records/harshil048_74892092.json @@ -0,0 +1,272 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11695", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11695/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11695/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11695/events", + "html_url": "https://github.com/laurent22/joplin/pull/11695", + "id": 2801683327, + "node_id": "PR_kwDOBLftOs6IfDIA", + "number": 11695, + "title": "Desktop: fix: Remove '...' in Rich Text editor toolbar #11663", + "user": { + "login": "harshil048", + "id": 74892092, + "node_id": "MDQ6VXNlcjc0ODkyMDky", + "avatar_url": "https://avatars.githubusercontent.com/u/74892092?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/harshil048", + "html_url": "https://github.com/harshil048", + "followers_url": "https://api.github.com/users/harshil048/followers", + "following_url": "https://api.github.com/users/harshil048/following{/other_user}", + "gists_url": "https://api.github.com/users/harshil048/gists{/gist_id}", + "starred_url": "https://api.github.com/users/harshil048/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/harshil048/subscriptions", + "organizations_url": "https://api.github.com/users/harshil048/orgs", + "repos_url": "https://api.github.com/users/harshil048/repos", + "events_url": "https://api.github.com/users/harshil048/events{/privacy}", + "received_events_url": "https://api.github.com/users/harshil048/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 2, + "created_at": "2025-01-21T12:18:25Z", + "updated_at": "2025-01-21T12:27:39Z", + "closed_at": "2025-01-21T12:24:45Z", + "author_association": "NONE", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11695", + "html_url": "https://github.com/laurent22/joplin/pull/11695", + "diff_url": "https://github.com/laurent22/joplin/pull/11695.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11695.patch", + "merged_at": null + }, + "body": "", + "closed_by": { + "login": "harshil048", + "id": 74892092, + "node_id": "MDQ6VXNlcjc0ODkyMDky", + "avatar_url": "https://avatars.githubusercontent.com/u/74892092?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/harshil048", + "html_url": "https://github.com/harshil048", + "followers_url": "https://api.github.com/users/harshil048/followers", + "following_url": "https://api.github.com/users/harshil048/following{/other_user}", + "gists_url": "https://api.github.com/users/harshil048/gists{/gist_id}", + "starred_url": "https://api.github.com/users/harshil048/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/harshil048/subscriptions", + "organizations_url": "https://api.github.com/users/harshil048/orgs", + "repos_url": "https://api.github.com/users/harshil048/repos", + "events_url": "https://api.github.com/users/harshil048/events{/privacy}", + "received_events_url": "https://api.github.com/users/harshil048/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11695/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11695/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2604575561", + "html_url": "https://github.com/laurent22/joplin/pull/11695#issuecomment-2604575561", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11695", + "id": 2604575561, + "node_id": "IC_kwDOBLftOs6bPqtJ", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-01-21T12:18:42Z", + "updated_at": "2025-01-21T12:27:39Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2604575561/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2604580570", + "html_url": "https://github.com/laurent22/joplin/pull/11695#issuecomment-2604580570", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11695", + "id": 2604580570, + "node_id": "IC_kwDOBLftOs6bPr7a", + "user": { + "login": "harshil048", + "id": 74892092, + "node_id": "MDQ6VXNlcjc0ODkyMDky", + "avatar_url": "https://avatars.githubusercontent.com/u/74892092?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/harshil048", + "html_url": "https://github.com/harshil048", + "followers_url": "https://api.github.com/users/harshil048/followers", + "following_url": "https://api.github.com/users/harshil048/following{/other_user}", + "gists_url": "https://api.github.com/users/harshil048/gists{/gist_id}", + "starred_url": "https://api.github.com/users/harshil048/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/harshil048/subscriptions", + "organizations_url": "https://api.github.com/users/harshil048/orgs", + "repos_url": "https://api.github.com/users/harshil048/repos", + "events_url": "https://api.github.com/users/harshil048/events{/privacy}", + "received_events_url": "https://api.github.com/users/harshil048/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-01-21T12:20:24Z", + "updated_at": "2025-01-21T12:20:24Z", + "author_association": "NONE", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2604580570/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/itsanmol27_143805969.json b/readme/cla/consent_records/itsanmol27_143805969.json new file mode 100644 index 0000000000..3f60cc7217 --- /dev/null +++ b/readme/cla/consent_records/itsanmol27_143805969.json @@ -0,0 +1,272 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11886", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11886/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11886/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11886/events", + "html_url": "https://github.com/laurent22/joplin/pull/11886", + "id": 2877326893, + "node_id": "PR_kwDOBLftOs6MafFm", + "number": 11886, + "title": "Update POSTGRES_HOST in docker-compose.server-dev.yml to 'db' for pro…", + "user": { + "login": "itsanmol27", + "id": 143805969, + "node_id": "U_kgDOCJJOEQ", + "avatar_url": "https://avatars.githubusercontent.com/u/143805969?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/itsanmol27", + "html_url": "https://github.com/itsanmol27", + "followers_url": "https://api.github.com/users/itsanmol27/followers", + "following_url": "https://api.github.com/users/itsanmol27/following{/other_user}", + "gists_url": "https://api.github.com/users/itsanmol27/gists{/gist_id}", + "starred_url": "https://api.github.com/users/itsanmol27/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/itsanmol27/subscriptions", + "organizations_url": "https://api.github.com/users/itsanmol27/orgs", + "repos_url": "https://api.github.com/users/itsanmol27/repos", + "events_url": "https://api.github.com/users/itsanmol27/events{/privacy}", + "received_events_url": "https://api.github.com/users/itsanmol27/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 2, + "created_at": "2025-02-25T07:11:01Z", + "updated_at": "2025-02-27T18:26:38Z", + "closed_at": "2025-02-27T18:26:21Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11886", + "html_url": "https://github.com/laurent22/joplin/pull/11886", + "diff_url": "https://github.com/laurent22/joplin/pull/11886.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11886.patch", + "merged_at": "2025-02-27T18:26:21Z" + }, + "body": "Description:\r\nThis PR updates the docker-compose.server-dev.yml file to fix a connection issue between the app and the database.\r\n\r\nCurrent Behavior:\r\n\r\nThe POSTGRES_HOST environment variable is set to localhost, which causes connection failure between the app and db services in Docker Compose since both are running in different containers. Docker services cannot communicate via localhost.\r\n\r\nExpected Behavior:\r\n\r\nThe POSTGRES_HOST is updated to db (the service name for the PostgreSQL container), allowing proper service-to-service communication via Docker’s internal network.\r\nChanges:\r\nModify POSTGRES_HOST in the app service environment to db.\r\nThis will resolve the connection issue and ensure proper communication between the app and db services.\r\n\r\nFixes issue: #11885 ", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11886/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11886/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2680889342", + "html_url": "https://github.com/laurent22/joplin/pull/11886#issuecomment-2680889342", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11886", + "id": 2680889342, + "node_id": "IC_kwDOBLftOs6fyx_-", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-25T07:11:16Z", + "updated_at": "2025-02-27T18:26:38Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2680889342/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2685505851", + "html_url": "https://github.com/laurent22/joplin/pull/11886#issuecomment-2685505851", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11886", + "id": 2685505851, + "node_id": "IC_kwDOBLftOs6gEZE7", + "user": { + "login": "itsanmol27", + "id": 143805969, + "node_id": "U_kgDOCJJOEQ", + "avatar_url": "https://avatars.githubusercontent.com/u/143805969?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/itsanmol27", + "html_url": "https://github.com/itsanmol27", + "followers_url": "https://api.github.com/users/itsanmol27/followers", + "following_url": "https://api.github.com/users/itsanmol27/following{/other_user}", + "gists_url": "https://api.github.com/users/itsanmol27/gists{/gist_id}", + "starred_url": "https://api.github.com/users/itsanmol27/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/itsanmol27/subscriptions", + "organizations_url": "https://api.github.com/users/itsanmol27/orgs", + "repos_url": "https://api.github.com/users/itsanmol27/repos", + "events_url": "https://api.github.com/users/itsanmol27/events{/privacy}", + "received_events_url": "https://api.github.com/users/itsanmol27/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-26T16:02:27Z", + "updated_at": "2025-02-26T16:02:27Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2685505851/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/j-scheitler1_158077662.json b/readme/cla/consent_records/j-scheitler1_158077662.json new file mode 100644 index 0000000000..f313706fd6 --- /dev/null +++ b/readme/cla/consent_records/j-scheitler1_158077662.json @@ -0,0 +1,497 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11862", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11862/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11862/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11862/events", + "html_url": "https://github.com/laurent22/joplin/pull/11862", + "id": 2864348864, + "node_id": "PR_kwDOBLftOs6LzZ-3", + "number": 11862, + "title": "Fix #11663 - Formatting extra buttons now appear on Rich Text Toobar", + "user": { + "login": "j-scheitler1", + "id": 158077662, + "node_id": "U_kgDOCWwS3g", + "avatar_url": "https://avatars.githubusercontent.com/u/158077662?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/j-scheitler1", + "html_url": "https://github.com/j-scheitler1", + "followers_url": "https://api.github.com/users/j-scheitler1/followers", + "following_url": "https://api.github.com/users/j-scheitler1/following{/other_user}", + "gists_url": "https://api.github.com/users/j-scheitler1/gists{/gist_id}", + "starred_url": "https://api.github.com/users/j-scheitler1/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/j-scheitler1/subscriptions", + "organizations_url": "https://api.github.com/users/j-scheitler1/orgs", + "repos_url": "https://api.github.com/users/j-scheitler1/repos", + "events_url": "https://api.github.com/users/j-scheitler1/events{/privacy}", + "received_events_url": "https://api.github.com/users/j-scheitler1/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 7, + "created_at": "2025-02-19T20:35:13Z", + "updated_at": "2025-02-20T19:18:50Z", + "closed_at": "2025-02-20T15:40:55Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11862", + "html_url": "https://github.com/laurent22/joplin/pull/11862", + "diff_url": "https://github.com/laurent22/joplin/pull/11862.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11862.patch", + "merged_at": null + }, + "body": "Desktop: Resolves #11663: Improved TinyMCE Toolbar Structure (Rich Text)\r\n\r\nThis pull request refactors the TinyMCE toolbar configuration in Joplin’s desktop application to improve button accessibility and appearance when users resize the notes window.\r\n\r\nKey Changes:\r\n- Decoupled formattingExtras buttons: Removed unnecessary grouping to prevent duplicate dropdowns.\r\n- Modified TinyMCE toolbar structure: Placed buttons individually in the toolbar for better visibility.\r\n- Applied CSS adjustments: Fixed height inconsistencies for the forecolor button to keep uniform height.\r\n\r\nBefore\r\n![before_02](https://github.com/user-attachments/assets/6e8ccac3-5e90-4e1b-a1f6-394bcab19c59)\r\n![before_01](https://github.com/user-attachments/assets/1ccdd9ff-6615-47af-b810-0d422f7d3bab)\r\n\r\nAfter\r\n![after_02](https://github.com/user-attachments/assets/9971201e-827c-421c-97af-e53297d165d3)\r\n![after_01](https://github.com/user-attachments/assets/18796d3f-0404-413d-b4a3-afd585fd4177)\r\n\r\n\r\n", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11862/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11862/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2669702229", + "html_url": "https://github.com/laurent22/joplin/pull/11862#issuecomment-2669702229", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11862", + "id": 2669702229, + "node_id": "IC_kwDOBLftOs6fIGxV", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-19T20:35:29Z", + "updated_at": "2025-02-20T00:33:03Z", + "author_association": "CONTRIBUTOR", + "body": "**CLA Assistant Lite bot:**
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our [Contributor License Agreement](https://github.com/laurent22/joplin/blob/dev/readme/cla.md) before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.
\n - - -\n I have read the CLA Document and I hereby sign the CLA\n - - -\n **2** out of **3** committers have signed the CLA.
:white_check_mark: (personalizedrefrigerator)[https://github.com/personalizedrefrigerator]
:white_check_mark: (j-scheitler1)[https://github.com/j-scheitler1]
:x: @j-scheitler
You can retrigger this bot by commenting **recheck** in this Pull Request", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2669702229/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2669703024", + "html_url": "https://github.com/laurent22/joplin/pull/11862#issuecomment-2669703024", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11862", + "id": 2669703024, + "node_id": "IC_kwDOBLftOs6fIG9w", + "user": { + "login": "j-scheitler1", + "id": 158077662, + "node_id": "U_kgDOCWwS3g", + "avatar_url": "https://avatars.githubusercontent.com/u/158077662?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/j-scheitler1", + "html_url": "https://github.com/j-scheitler1", + "followers_url": "https://api.github.com/users/j-scheitler1/followers", + "following_url": "https://api.github.com/users/j-scheitler1/following{/other_user}", + "gists_url": "https://api.github.com/users/j-scheitler1/gists{/gist_id}", + "starred_url": "https://api.github.com/users/j-scheitler1/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/j-scheitler1/subscriptions", + "organizations_url": "https://api.github.com/users/j-scheitler1/orgs", + "repos_url": "https://api.github.com/users/j-scheitler1/repos", + "events_url": "https://api.github.com/users/j-scheitler1/events{/privacy}", + "received_events_url": "https://api.github.com/users/j-scheitler1/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-19T20:35:56Z", + "updated_at": "2025-02-19T20:35:56Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2669703024/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2670063523", + "html_url": "https://github.com/laurent22/joplin/pull/11862#issuecomment-2670063523", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11862", + "id": 2670063523, + "node_id": "IC_kwDOBLftOs6fJe-j", + "user": { + "login": "personalizedrefrigerator", + "id": 46334387, + "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", + "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/personalizedrefrigerator", + "html_url": "https://github.com/personalizedrefrigerator", + "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", + "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", + "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", + "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", + "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", + "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", + "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", + "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-20T00:12:19Z", + "updated_at": "2025-02-20T00:13:41Z", + "author_association": "COLLABORATOR", + "body": "Thank you for contributing!\r\n\r\nIt looks like the email that authored https://github.com/laurent22/joplin/pull/11862/commits/bb243db7653a2e4f22dbc423b5bcf958478eeaea is associated with a [different GitHub account](https://github.com/j-scheitler) from the one that created this pull request. After [changing the email address globally](https://stackoverflow.com/a/37805844), it should be possible to [fix the email address associated with the commit using `git commit --amend --reset-author`](https://github.com/orgs/community/discussions/38097#discussioncomment-4041234).\r\n\r\nSee also: [GitHub: Setting your commit email address](https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address).", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2670063523/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2670093028", + "html_url": "https://github.com/laurent22/joplin/pull/11862#issuecomment-2670093028", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11862", + "id": 2670093028, + "node_id": "IC_kwDOBLftOs6fJmLk", + "user": { + "login": "j-scheitler1", + "id": 158077662, + "node_id": "U_kgDOCWwS3g", + "avatar_url": "https://avatars.githubusercontent.com/u/158077662?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/j-scheitler1", + "html_url": "https://github.com/j-scheitler1", + "followers_url": "https://api.github.com/users/j-scheitler1/followers", + "following_url": "https://api.github.com/users/j-scheitler1/following{/other_user}", + "gists_url": "https://api.github.com/users/j-scheitler1/gists{/gist_id}", + "starred_url": "https://api.github.com/users/j-scheitler1/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/j-scheitler1/subscriptions", + "organizations_url": "https://api.github.com/users/j-scheitler1/orgs", + "repos_url": "https://api.github.com/users/j-scheitler1/repos", + "events_url": "https://api.github.com/users/j-scheitler1/events{/privacy}", + "received_events_url": "https://api.github.com/users/j-scheitler1/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-20T00:33:39Z", + "updated_at": "2025-02-20T00:33:39Z", + "author_association": "CONTRIBUTOR", + "body": "@personalizedrefrigerator I believe it should be updated, sorry for the mix up.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2670093028/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2670830435", + "html_url": "https://github.com/laurent22/joplin/pull/11862#issuecomment-2670830435", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11862", + "id": 2670830435, + "node_id": "IC_kwDOBLftOs6fMaNj", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-20T08:49:01Z", + "updated_at": "2025-02-20T08:49:01Z", + "author_association": "OWNER", + "body": "recheck", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2670830435/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2671827592", + "html_url": "https://github.com/laurent22/joplin/pull/11862#issuecomment-2671827592", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11862", + "id": 2671827592, + "node_id": "IC_kwDOBLftOs6fQNqI", + "user": { + "login": "j-scheitler1", + "id": 158077662, + "node_id": "U_kgDOCWwS3g", + "avatar_url": "https://avatars.githubusercontent.com/u/158077662?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/j-scheitler1", + "html_url": "https://github.com/j-scheitler1", + "followers_url": "https://api.github.com/users/j-scheitler1/followers", + "following_url": "https://api.github.com/users/j-scheitler1/following{/other_user}", + "gists_url": "https://api.github.com/users/j-scheitler1/gists{/gist_id}", + "starred_url": "https://api.github.com/users/j-scheitler1/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/j-scheitler1/subscriptions", + "organizations_url": "https://api.github.com/users/j-scheitler1/orgs", + "repos_url": "https://api.github.com/users/j-scheitler1/repos", + "events_url": "https://api.github.com/users/j-scheitler1/events{/privacy}", + "received_events_url": "https://api.github.com/users/j-scheitler1/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-20T15:23:21Z", + "updated_at": "2025-02-20T15:23:21Z", + "author_association": "CONTRIBUTOR", + "body": "@laurent22 It seems that I pushed the original commit from my university GitHub email that I no longer can log into. I followed the instructions to change the commit author from @personalizedrefrigerator to the account that I am leaving this comment with, but it seems the CLA check is still looking for that other account as well. Would you like me to close this pull request and open a new one or could you possibly bypass the CLA check? Sorry again for the inconvenience. ", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2671827592/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2671879236", + "html_url": "https://github.com/laurent22/joplin/pull/11862#issuecomment-2671879236", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11862", + "id": 2671879236, + "node_id": "IC_kwDOBLftOs6fQaRE", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-20T15:40:55Z", + "updated_at": "2025-02-20T15:40:55Z", + "author_association": "OWNER", + "body": "yes please", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2671879236/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/jrb80_1820167.json b/readme/cla/consent_records/jrb80_1820167.json new file mode 100644 index 0000000000..d2ffbbc86b --- /dev/null +++ b/readme/cla/consent_records/jrb80_1820167.json @@ -0,0 +1,452 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11948", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11948/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11948/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11948/events", + "html_url": "https://github.com/laurent22/joplin/pull/11948", + "id": 2906893498, + "node_id": "PR_kwDOBLftOs6N-Xu2", + "number": 11948, + "title": "Update webdav.md", + "user": { + "login": "jrb80", + "id": 1820167, + "node_id": "MDQ6VXNlcjE4MjAxNjc=", + "avatar_url": "https://avatars.githubusercontent.com/u/1820167?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/jrb80", + "html_url": "https://github.com/jrb80", + "followers_url": "https://api.github.com/users/jrb80/followers", + "following_url": "https://api.github.com/users/jrb80/following{/other_user}", + "gists_url": "https://api.github.com/users/jrb80/gists{/gist_id}", + "starred_url": "https://api.github.com/users/jrb80/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/jrb80/subscriptions", + "organizations_url": "https://api.github.com/users/jrb80/orgs", + "repos_url": "https://api.github.com/users/jrb80/repos", + "events_url": "https://api.github.com/users/jrb80/events{/privacy}", + "received_events_url": "https://api.github.com/users/jrb80/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 6, + "created_at": "2025-03-10T11:04:18Z", + "updated_at": "2025-03-13T13:20:09Z", + "closed_at": "2025-03-13T11:51:47Z", + "author_association": "NONE", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11948", + "html_url": "https://github.com/laurent22/joplin/pull/11948", + "diff_url": "https://github.com/laurent22/joplin/pull/11948.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11948.patch", + "merged_at": null + }, + "body": "Included QNAP NAS server in list.\r\n\r\n", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11948/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11948/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2710207020", + "html_url": "https://github.com/laurent22/joplin/pull/11948#issuecomment-2710207020", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11948", + "id": 2710207020, + "node_id": "IC_kwDOBLftOs6hinos", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-10T11:04:32Z", + "updated_at": "2025-03-13T11:52:02Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2710207020/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2711242584", + "html_url": "https://github.com/laurent22/joplin/pull/11948#issuecomment-2711242584", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11948", + "id": 2711242584, + "node_id": "IC_kwDOBLftOs6hmkdY", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-10T16:55:59Z", + "updated_at": "2025-03-10T16:55:59Z", + "author_association": "OWNER", + "body": "hello, you need to sign the cra", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2711242584/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2711309502", + "html_url": "https://github.com/laurent22/joplin/pull/11948#issuecomment-2711309502", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11948", + "id": 2711309502, + "node_id": "IC_kwDOBLftOs6hm0y-", + "user": { + "login": "jrb80", + "id": 1820167, + "node_id": "MDQ6VXNlcjE4MjAxNjc=", + "avatar_url": "https://avatars.githubusercontent.com/u/1820167?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/jrb80", + "html_url": "https://github.com/jrb80", + "followers_url": "https://api.github.com/users/jrb80/followers", + "following_url": "https://api.github.com/users/jrb80/following{/other_user}", + "gists_url": "https://api.github.com/users/jrb80/gists{/gist_id}", + "starred_url": "https://api.github.com/users/jrb80/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/jrb80/subscriptions", + "organizations_url": "https://api.github.com/users/jrb80/orgs", + "repos_url": "https://api.github.com/users/jrb80/repos", + "events_url": "https://api.github.com/users/jrb80/events{/privacy}", + "received_events_url": "https://api.github.com/users/jrb80/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-10T17:20:58Z", + "updated_at": "2025-03-10T17:20:58Z", + "author_association": "NONE", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2711309502/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2711363154", + "html_url": "https://github.com/laurent22/joplin/pull/11948#issuecomment-2711363154", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11948", + "id": 2711363154, + "node_id": "IC_kwDOBLftOs6hnB5S", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-10T17:42:23Z", + "updated_at": "2025-03-10T17:42:23Z", + "author_association": "OWNER", + "body": "```\r\nStep: Spellchecking...\r\n> yarn cspell --no-progress --no-summary --config cspell.json **/*.{ts,tsx,md,mdx}\r\nThe following spelling mistakes were found. Please check https://joplinapp.org/help/dev/spellcheck for\r\ninformation on how to deal with spelling mistakes.\r\n\r\n/home/runner/work/joplin/joplin/readme/apps/sync/webdav.md:17:4 - Unknown word (QNAP)\r\nError: Process completed with exit code 1.\r\n```", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2711363154/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2720994487", + "html_url": "https://github.com/laurent22/joplin/pull/11948#issuecomment-2720994487", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11948", + "id": 2720994487, + "node_id": "IC_kwDOBLftOs6iLxS3", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-13T11:51:47Z", + "updated_at": "2025-03-13T11:51:47Z", + "author_association": "OWNER", + "body": "Closed stale PR", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2720994487/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2721237660", + "html_url": "https://github.com/laurent22/joplin/pull/11948#issuecomment-2721237660", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11948", + "id": 2721237660, + "node_id": "IC_kwDOBLftOs6iMsqc", + "user": { + "login": "jrb80", + "id": 1820167, + "node_id": "MDQ6VXNlcjE4MjAxNjc=", + "avatar_url": "https://avatars.githubusercontent.com/u/1820167?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/jrb80", + "html_url": "https://github.com/jrb80", + "followers_url": "https://api.github.com/users/jrb80/followers", + "following_url": "https://api.github.com/users/jrb80/following{/other_user}", + "gists_url": "https://api.github.com/users/jrb80/gists{/gist_id}", + "starred_url": "https://api.github.com/users/jrb80/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/jrb80/subscriptions", + "organizations_url": "https://api.github.com/users/jrb80/orgs", + "repos_url": "https://api.github.com/users/jrb80/repos", + "events_url": "https://api.github.com/users/jrb80/events{/privacy}", + "received_events_url": "https://api.github.com/users/jrb80/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-13T13:20:07Z", + "updated_at": "2025-03-13T13:20:07Z", + "author_association": "NONE", + "body": "?", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2721237660/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/klxiang_39042920.json b/readme/cla/consent_records/klxiang_39042920.json new file mode 100644 index 0000000000..f69c76724e --- /dev/null +++ b/readme/cla/consent_records/klxiang_39042920.json @@ -0,0 +1,282 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11920", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11920/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11920/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11920/events", + "html_url": "https://github.com/laurent22/joplin/pull/11920", + "id": 2892691494, + "node_id": "PR_kwDOBLftOs6NOrlb", + "number": 11920, + "title": "Update zh_CN.po", + "user": { + "login": "klxiang", + "id": 39042920, + "node_id": "MDQ6VXNlcjM5MDQyOTIw", + "avatar_url": "https://avatars.githubusercontent.com/u/39042920?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/klxiang", + "html_url": "https://github.com/klxiang", + "followers_url": "https://api.github.com/users/klxiang/followers", + "following_url": "https://api.github.com/users/klxiang/following{/other_user}", + "gists_url": "https://api.github.com/users/klxiang/gists{/gist_id}", + "starred_url": "https://api.github.com/users/klxiang/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/klxiang/subscriptions", + "organizations_url": "https://api.github.com/users/klxiang/orgs", + "repos_url": "https://api.github.com/users/klxiang/repos", + "events_url": "https://api.github.com/users/klxiang/events{/privacy}", + "received_events_url": "https://api.github.com/users/klxiang/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [ + { + "id": 1091621259, + "node_id": "MDU6TGFiZWwxMDkxNjIxMjU5", + "url": "https://api.github.com/repos/laurent22/joplin/labels/translation", + "name": "translation", + "color": "91ca55", + "default": false, + "description": "i18n and l10n" + } + ], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 2, + "created_at": "2025-03-04T01:34:42Z", + "updated_at": "2025-03-04T02:02:08Z", + "closed_at": "2025-03-04T02:01:55Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11920", + "html_url": "https://github.com/laurent22/joplin/pull/11920", + "diff_url": "https://github.com/laurent22/joplin/pull/11920.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11920.patch", + "merged_at": "2025-03-04T02:01:55Z" + }, + "body": "Update translation content\r\n\r\n", + "closed_by": { + "login": "tessus", + "id": 223439, + "node_id": "MDQ6VXNlcjIyMzQzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tessus", + "html_url": "https://github.com/tessus", + "followers_url": "https://api.github.com/users/tessus/followers", + "following_url": "https://api.github.com/users/tessus/following{/other_user}", + "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", + "organizations_url": "https://api.github.com/users/tessus/orgs", + "repos_url": "https://api.github.com/users/tessus/repos", + "events_url": "https://api.github.com/users/tessus/events{/privacy}", + "received_events_url": "https://api.github.com/users/tessus/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11920/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11920/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2695960586", + "html_url": "https://github.com/laurent22/joplin/pull/11920#issuecomment-2695960586", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11920", + "id": 2695960586, + "node_id": "IC_kwDOBLftOs6gsRgK", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-04T01:34:56Z", + "updated_at": "2025-03-04T02:02:08Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2695960586/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2695961665", + "html_url": "https://github.com/laurent22/joplin/pull/11920#issuecomment-2695961665", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11920", + "id": 2695961665, + "node_id": "IC_kwDOBLftOs6gsRxB", + "user": { + "login": "klxiang", + "id": 39042920, + "node_id": "MDQ6VXNlcjM5MDQyOTIw", + "avatar_url": "https://avatars.githubusercontent.com/u/39042920?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/klxiang", + "html_url": "https://github.com/klxiang", + "followers_url": "https://api.github.com/users/klxiang/followers", + "following_url": "https://api.github.com/users/klxiang/following{/other_user}", + "gists_url": "https://api.github.com/users/klxiang/gists{/gist_id}", + "starred_url": "https://api.github.com/users/klxiang/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/klxiang/subscriptions", + "organizations_url": "https://api.github.com/users/klxiang/orgs", + "repos_url": "https://api.github.com/users/klxiang/repos", + "events_url": "https://api.github.com/users/klxiang/events{/privacy}", + "received_events_url": "https://api.github.com/users/klxiang/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-04T01:35:55Z", + "updated_at": "2025-03-04T01:35:55Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2695961665/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/looi_1855766.json b/readme/cla/consent_records/looi_1855766.json new file mode 100644 index 0000000000..2fce4cd1d6 --- /dev/null +++ b/readme/cla/consent_records/looi_1855766.json @@ -0,0 +1,452 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12127", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/12127/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/12127/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/12127/events", + "html_url": "https://github.com/laurent22/joplin/pull/12127", + "id": 3003281572, + "node_id": "PR_kwDOBLftOs6TCEDf", + "number": 12127, + "title": "Web: fix webdav", + "user": { + "login": "looi", + "id": 1855766, + "node_id": "MDQ6VXNlcjE4NTU3NjY=", + "avatar_url": "https://avatars.githubusercontent.com/u/1855766?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/looi", + "html_url": "https://github.com/looi", + "followers_url": "https://api.github.com/users/looi/followers", + "following_url": "https://api.github.com/users/looi/following{/other_user}", + "gists_url": "https://api.github.com/users/looi/gists{/gist_id}", + "starred_url": "https://api.github.com/users/looi/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/looi/subscriptions", + "organizations_url": "https://api.github.com/users/looi/orgs", + "repos_url": "https://api.github.com/users/looi/repos", + "events_url": "https://api.github.com/users/looi/events{/privacy}", + "received_events_url": "https://api.github.com/users/looi/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 6, + "created_at": "2025-04-17T19:27:29Z", + "updated_at": "2025-04-24T21:23:42Z", + "closed_at": "2025-04-24T07:55:10Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/12127", + "html_url": "https://github.com/laurent22/joplin/pull/12127", + "diff_url": "https://github.com/laurent22/joplin/pull/12127.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/12127.patch", + "merged_at": "2025-04-24T07:55:10Z" + }, + "body": "* Currently, webdav PUT/DELETE requests fail due to \"Response with null body status cannot have body\"\r\n* This code uses the logic that chrome uses: https://chromium.googlesource.com/chromium/src/+/c631f71be2e78da5d3ca2cb4dc1a05e08ac5930c/third_party/WebKit/Source/core/fetch/Response.cpp#106\r\n* Also fixes fastDeepEqual import, consistent with other uses in the repo: https://github.com/search?q=repo%3Alaurent22%2Fjoplin%20fastDeepEqual&type=code", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12127/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/12127/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2813839155", + "html_url": "https://github.com/laurent22/joplin/pull/12127#issuecomment-2813839155", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12127", + "id": 2813839155, + "node_id": "IC_kwDOBLftOs6nt8cz", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-17T19:27:40Z", + "updated_at": "2025-04-24T09:00:02Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2813839155/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2814865794", + "html_url": "https://github.com/laurent22/joplin/pull/12127#issuecomment-2814865794", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12127", + "id": 2814865794, + "node_id": "IC_kwDOBLftOs6nx3GC", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-18T07:59:13Z", + "updated_at": "2025-04-18T07:59:13Z", + "author_association": "OWNER", + "body": "> Also fixes fastDeepEqual import, consistent with other uses in the repo: https://github.com/search?q=repo%3Alaurent22%2Fjoplin%20fastDeepEqual&type=code\r\n\r\nIsn't the import syntax better because it provides types? But in any case unless it causes some problem with your change it should be changed in a separate PR (or maybe not changed at all if it doesn't impact anything)", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2814865794/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2815079594", + "html_url": "https://github.com/laurent22/joplin/pull/12127#issuecomment-2815079594", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12127", + "id": 2815079594, + "node_id": "IC_kwDOBLftOs6nyrSq", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-18T09:34:12Z", + "updated_at": "2025-04-18T09:34:12Z", + "author_association": "OWNER", + "body": "Also please sign the CLA when you have a moment", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2815079594/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2816251177", + "html_url": "https://github.com/laurent22/joplin/pull/12127#issuecomment-2816251177", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12127", + "id": 2816251177, + "node_id": "IC_kwDOBLftOs6n3JUp", + "user": { + "login": "looi", + "id": 1855766, + "node_id": "MDQ6VXNlcjE4NTU3NjY=", + "avatar_url": "https://avatars.githubusercontent.com/u/1855766?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/looi", + "html_url": "https://github.com/looi", + "followers_url": "https://api.github.com/users/looi/followers", + "following_url": "https://api.github.com/users/looi/following{/other_user}", + "gists_url": "https://api.github.com/users/looi/gists{/gist_id}", + "starred_url": "https://api.github.com/users/looi/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/looi/subscriptions", + "organizations_url": "https://api.github.com/users/looi/orgs", + "repos_url": "https://api.github.com/users/looi/repos", + "events_url": "https://api.github.com/users/looi/events{/privacy}", + "received_events_url": "https://api.github.com/users/looi/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-18T21:54:51Z", + "updated_at": "2025-04-18T21:54:51Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2816251177/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2816257134", + "html_url": "https://github.com/laurent22/joplin/pull/12127#issuecomment-2816257134", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12127", + "id": 2816257134, + "node_id": "IC_kwDOBLftOs6n3Kxu", + "user": { + "login": "looi", + "id": 1855766, + "node_id": "MDQ6VXNlcjE4NTU3NjY=", + "avatar_url": "https://avatars.githubusercontent.com/u/1855766?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/looi", + "html_url": "https://github.com/looi", + "followers_url": "https://api.github.com/users/looi/followers", + "following_url": "https://api.github.com/users/looi/following{/other_user}", + "gists_url": "https://api.github.com/users/looi/gists{/gist_id}", + "starred_url": "https://api.github.com/users/looi/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/looi/subscriptions", + "organizations_url": "https://api.github.com/users/looi/orgs", + "repos_url": "https://api.github.com/users/looi/repos", + "events_url": "https://api.github.com/users/looi/events{/privacy}", + "received_events_url": "https://api.github.com/users/looi/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-18T21:57:30Z", + "updated_at": "2025-04-18T21:57:30Z", + "author_association": "CONTRIBUTOR", + "body": "> > Also fixes fastDeepEqual import, consistent with other uses in the repo: https://github.com/search?q=repo%3Alaurent22%2Fjoplin%20fastDeepEqual&type=code\r\n> \r\n> Isn't the import syntax better because it provides types? But in any case unless it causes some problem with your change it should be changed in a separate PR (or maybe not changed at all if it doesn't impact anything)\r\n\r\nSure i reverted that change for now. It was causing some build problems for me earlier but I think it is ok now.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2816257134/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2828891904", + "html_url": "https://github.com/laurent22/joplin/pull/12127#issuecomment-2828891904", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12127", + "id": 2828891904, + "node_id": "IC_kwDOBLftOs6onXcA", + "user": { + "login": "personalizedrefrigerator", + "id": 46334387, + "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", + "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/personalizedrefrigerator", + "html_url": "https://github.com/personalizedrefrigerator", + "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", + "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", + "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", + "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", + "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", + "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", + "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", + "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-24T21:23:41Z", + "updated_at": "2025-04-24T21:23:41Z", + "author_association": "COLLABORATOR", + "body": "I'm linking to the relevant deployment workflow run: https://github.com/joplin/web-app/actions/runs/14651938648\r\n\r\nThank you for contributing!", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2828891904/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/mshibanami_1333214.json b/readme/cla/consent_records/mshibanami_1333214.json new file mode 100644 index 0000000000..680a689a81 --- /dev/null +++ b/readme/cla/consent_records/mshibanami_1333214.json @@ -0,0 +1,317 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11471", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11471/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11471/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11471/events", + "html_url": "https://github.com/laurent22/joplin/pull/11471", + "id": 2720085914, + "node_id": "PR_kwDOBLftOs6EKnOO", + "number": 11471, + "title": "All: Fix the error caused by undefined isCodeBlock_ (turndown-plugin-gfm)", + "user": { + "login": "mshibanami", + "id": 1333214, + "node_id": "MDQ6VXNlcjEzMzMyMTQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1333214?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/mshibanami", + "html_url": "https://github.com/mshibanami", + "followers_url": "https://api.github.com/users/mshibanami/followers", + "following_url": "https://api.github.com/users/mshibanami/following{/other_user}", + "gists_url": "https://api.github.com/users/mshibanami/gists{/gist_id}", + "starred_url": "https://api.github.com/users/mshibanami/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/mshibanami/subscriptions", + "organizations_url": "https://api.github.com/users/mshibanami/orgs", + "repos_url": "https://api.github.com/users/mshibanami/repos", + "events_url": "https://api.github.com/users/mshibanami/events{/privacy}", + "received_events_url": "https://api.github.com/users/mshibanami/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 3, + "created_at": "2024-12-05T11:00:47Z", + "updated_at": "2024-12-09T16:07:37Z", + "closed_at": "2024-12-09T15:57:34Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11471", + "html_url": "https://github.com/laurent22/joplin/pull/11471", + "diff_url": "https://github.com/laurent22/joplin/pull/11471.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11471.patch", + "merged_at": "2024-12-09T15:57:33Z" + }, + "body": "Fixes #10328\r\n\r\nThis is a follow-up pull request to another pull request, https://github.com/laurent22/joplin/pull/10931, which was closed due to a build failure caused by the syntax `?.`, introduced in ES 2020.\r\n\r\nInstead, I chose a more backward-compatible approach.\r\n\r\n----\r\n\r\nUnfortunately, I couldn't run `yarn test` because `npm install` failed as shown below. However, the code is simple, and I'm confident it won't cause any issues:\r\n\r\n
\r\nThe log of `npm install`\r\n\r\n% npm install\r\nnpm error code ERESOLVE\r\nnpm error ERESOLVE unable to resolve dependency tree\r\nnpm error\r\nnpm error While resolving: @joplin/app-desktop@3.2.3\r\nnpm error Found: react@18.3.1\r\nnpm error node_modules/react\r\nnpm error react@\"18.3.1\" from @joplin/app-desktop@3.2.3\r\nnpm error packages/app-desktop\r\nnpm error @joplin/app-desktop@3.2.3\r\nnpm error node_modules/@joplin/app-desktop\r\nnpm error workspace packages/app-desktop from the root project\r\nnpm error\r\nnpm error Could not resolve dependency:\r\nnpm error peer react@\"^16.9.0 || ^17.0.0\" from @testing-library/react-hooks@8.0.1\r\nnpm error node_modules/@testing-library/react-hooks\r\nnpm error dev @testing-library/react-hooks@\"8.0.1\" from @joplin/app-desktop@3.2.3\r\nnpm error packages/app-desktop\r\nnpm error @joplin/app-desktop@3.2.3\r\nnpm error node_modules/@joplin/app-desktop\r\nnpm error workspace packages/app-desktop from the root project\r\nnpm error\r\nnpm error Fix the upstream dependency conflict, or retry\r\nnpm error this command with --force or --legacy-peer-deps\r\nnpm error to accept an incorrect (and potentially broken) dependency resolution.\r\nnpm error\r\nnpm error\r\nnpm error For a full report see:\r\nnpm error /Users/manabu/.npm/_logs/2024-12-05T10_28_09_324Z-eresolve-report.txt\r\nnpm error A complete log of this run can be found in: /Users/manabu/.npm/_logs/2024-12-05T10_28_09_324Z-debug-0.log\r\n実行時間: 59.974秒 (起動:1.900秒 処理:7.369秒 CPU15%)\r\n~/workplace/joplin fix-undefined-in-turndown-plugin-gfm [!] is 📦 v(independent) via ⬢ v22.9.0 via myenv took 1m 0s\r\n% npm install --force\r\nnpm warn using --force Recommended protections disabled.\r\nnpm warn ERESOLVE overriding peer dependency\r\nnpm warn ERESOLVE overriding peer dependency\r\nnpm warn While resolving: @testing-library/react-hooks@8.0.1\r\nnpm warn Found: @types/react@18.3.3\r\nnpm warn node_modules/@types/react\r\nnpm warn dev @types/react@\"18.3.3\" from @joplin/app-desktop@3.2.3\r\nnpm warn packages/app-desktop\r\nnpm warn @joplin/app-desktop@3.2.3\r\nnpm warn node_modules/@joplin/app-desktop\r\nnpm warn 23 more (@joplin/app-mobile, @joplin/editor, @joplin/lib, ...)\r\nnpm warn\r\nnpm warn Could not resolve dependency:\r\nnpm warn peerOptional @types/react@\"^16.9.0 || ^17.0.0\" from @testing-library/react-hooks@8.0.1\r\nnpm warn packages/app-desktop/node_modules/@testing-library/react-hooks\r\nnpm warn dev @testing-library/react-hooks@\"8.0.1\" from @joplin/app-desktop@3.2.3\r\nnpm warn packages/app-desktop\r\nnpm warn\r\nnpm warn Conflicting peer dependency: @types/react@17.0.83\r\nnpm warn node_modules/@types/react\r\nnpm warn peerOptional @types/react@\"^16.9.0 || ^17.0.0\" from @testing-library/react-hooks@8.0.1\r\nnpm warn packages/app-desktop/node_modules/@testing-library/react-hooks\r\nnpm warn dev @testing-library/react-hooks@\"8.0.1\" from @joplin/app-desktop@3.2.3\r\nnpm warn packages/app-desktop\r\nnpm warn ERESOLVE overriding peer dependency\r\nnpm warn While resolving: @testing-library/react-hooks@8.0.1\r\nnpm warn Found: react@18.3.1\r\nnpm warn packages/app-desktop/node_modules/react\r\nnpm warn react@\"18.3.1\" from @joplin/app-desktop@3.2.3\r\nnpm warn packages/app-desktop\r\nnpm warn @joplin/app-desktop@3.2.3\r\nnpm warn node_modules/@joplin/app-desktop\r\nnpm warn 3 more (react-dom, react-redux, react-test-renderer)\r\nnpm warn\r\nnpm warn Could not resolve dependency:\r\nnpm warn peer react@\"^16.9.0 || ^17.0.0\" from @testing-library/react-hooks@8.0.1\r\nnpm warn packages/app-desktop/node_modules/@testing-library/react-hooks\r\nnpm warn dev @testing-library/react-hooks@\"8.0.1\" from @joplin/app-desktop@3.2.3\r\nnpm warn packages/app-desktop\r\nnpm warn\r\nnpm warn Conflicting peer dependency: react@17.0.2\r\nnpm warn node_modules/react\r\nnpm warn peer react@\"^16.9.0 || ^17.0.0\" from @testing-library/react-hooks@8.0.1\r\nnpm warn packages/app-desktop/node_modules/@testing-library/react-hooks\r\nnpm warn dev @testing-library/react-hooks@\"8.0.1\" from @joplin/app-desktop@3.2.3\r\nnpm warn packages/app-desktop\r\nnpm warn ERESOLVE overriding peer dependency\r\nnpm warn While resolving: @testing-library/react-hooks@8.0.1\r\nnpm warn Found: react-dom@18.3.1\r\nnpm warn packages/app-desktop/node_modules/react-dom\r\nnpm warn react-dom@\"18.3.1\" from @joplin/app-desktop@3.2.3\r\nnpm warn packages/app-desktop\r\nnpm warn @joplin/app-desktop@3.2.3\r\nnpm warn node_modules/@joplin/app-desktop\r\nnpm warn 1 more (react-redux)\r\nnpm warn\r\nnpm warn Could not resolve dependency:\r\nnpm warn peerOptional react-dom@\"^16.9.0 || ^17.0.0\" from @testing-library/react-hooks@8.0.1\r\nnpm warn packages/app-desktop/node_modules/@testing-library/react-hooks\r\nnpm warn dev @testing-library/react-hooks@\"8.0.1\" from @joplin/app-desktop@3.2.3\r\nnpm warn packages/app-desktop\r\nnpm warn\r\nnpm warn Conflicting peer dependency: react-dom@17.0.2\r\nnpm warn node_modules/react-dom\r\nnpm warn peerOptional react-dom@\"^16.9.0 || ^17.0.0\" from @testing-library/react-hooks@8.0.1\r\nnpm warn packages/app-desktop/node_modules/@testing-library/react-hooks\r\nnpm warn dev @testing-library/react-hooks@\"8.0.1\" from @joplin/app-desktop@3.2.3\r\nnpm warn packages/app-desktop\r\nnpm warn ERESOLVE overriding peer dependency\r\nnpm warn While resolving: @testing-library/react-hooks@8.0.1\r\nnpm warn Found: react-test-renderer@18.3.1\r\nnpm warn packages/app-desktop/node_modules/react-test-renderer\r\nnpm warn dev react-test-renderer@\"18.3.1\" from @joplin/app-desktop@3.2.3\r\nnpm warn packages/app-desktop\r\nnpm warn @joplin/app-desktop@3.2.3\r\nnpm warn node_modules/@joplin/app-desktop\r\nnpm warn\r\nnpm warn Could not resolve dependency:\r\nnpm warn peerOptional react-test-renderer@\"^16.9.0 || ^17.0.0\" from @testing-library/react-hooks@8.0.1\r\nnpm warn packages/app-desktop/node_modules/@testing-library/react-hooks\r\nnpm warn dev @testing-library/react-hooks@\"8.0.1\" from @joplin/app-desktop@3.2.3\r\nnpm warn packages/app-desktop\r\nnpm warn\r\nnpm warn Conflicting peer dependency: react-test-renderer@17.0.2\r\nnpm warn node_modules/react-test-renderer\r\nnpm warn peerOptional react-test-renderer@\"^16.9.0 || ^17.0.0\" from @testing-library/react-hooks@8.0.1\r\nnpm warn packages/app-desktop/node_modules/@testing-library/react-hooks\r\nnpm warn dev @testing-library/react-hooks@\"8.0.1\" from @joplin/app-desktop@3.2.3\r\nnpm warn packages/app-desktop\r\nnpm warn ERESOLVE overriding peer dependency\r\nnpm warn While resolving: @react-native-clipboard/clipboard@1.14.1\r\nnpm warn Found: react@18.3.1\r\nnpm warn packages/app-mobile/node_modules/react\r\nnpm warn react@\"18.3.1\" from @joplin/app-mobile@3.2.0\r\nnpm warn packages/app-mobile\r\nnpm warn @joplin/app-mobile@3.2.0\r\nnpm warn node_modules/@joplin/app-mobile\r\nnpm warn 19 more (@bam.tech/react-native-image-resizer, ...)\r\nnpm warn\r\nnpm warn Could not resolve dependency:\r\nnpm warn peer react@\"16.9.0 || 16.11.0 || 16.13.1 || 17.0.1 || 17.0.2 || 18.0.0 || 18.1.0 || 18.2.0\" from @react-native-clipboard/clipboard@1.14.1\r\nnpm warn packages/app-mobile/node_modules/@react-native-clipboard/clipboard\r\nnpm warn @react-native-clipboard/clipboard@\"1.14.1\" from @joplin/app-mobile@3.2.0\r\nnpm warn packages/app-mobile\r\nnpm warn\r\nnpm warn Conflicting peer dependency: react@18.2.0\r\nnpm warn node_modules/react\r\nnpm warn peer react@\"16.9.0 || 16.11.0 || 16.13.1 || 17.0.1 || 17.0.2 || 18.0.0 || 18.1.0 || 18.2.0\" from @react-native-clipboard/clipboard@1.14.1\r\nnpm warn packages/app-mobile/node_modules/@react-native-clipboard/clipboard\r\nnpm warn @react-native-clipboard/clipboard@\"1.14.1\" from @joplin/app-mobile@3.2.0\r\nnpm warn packages/app-mobile\r\nnpm warn ERESOLVE overriding peer dependency\r\nnpm warn While resolving: @react-native-clipboard/clipboard@1.14.1\r\nnpm warn Found: react-native@0.74.1\r\nnpm warn packages/app-mobile/node_modules/react-native\r\nnpm warn react-native@\"0.74.1\" from @joplin/app-mobile@3.2.0\r\nnpm warn packages/app-mobile\r\nnpm warn @joplin/app-mobile@3.2.0\r\nnpm warn node_modules/@joplin/app-mobile\r\nnpm warn 27 more (@bam.tech/react-native-image-resizer, ...)\r\nnpm warn\r\nnpm warn Could not resolve dependency:\r\nnpm warn peer react-native@\"^0.61.5 || ^0.62.3 || ^0.63.2 || ^0.64.2 || ^0.65.0 || ^0.66.0 || ^0.67.0 || ^0.68.0 || ^0.69.0 || ^0.70.0 || ^0.71.0 || ^0.72.0 || ^0.73.0\" from @react-native-clipboard/clipboard@1.14.1\r\nnpm warn packages/app-mobile/node_modules/@react-native-clipboard/clipboard\r\nnpm warn @react-native-clipboard/clipboard@\"1.14.1\" from @joplin/app-mobile@3.2.0\r\nnpm warn packages/app-mobile\r\nnpm warn\r\nnpm warn Conflicting peer dependency: react-native@0.73.11\r\nnpm warn node_modules/react-native\r\nnpm warn peer react-native@\"^0.61.5 || ^0.62.3 || ^0.63.2 || ^0.64.2 || ^0.65.0 || ^0.66.0 || ^0.67.0 || ^0.68.0 || ^0.69.0 || ^0.70.0 || ^0.71.0 || ^0.72.0 || ^0.73.0\" from @react-native-clipboard/clipboard@1.14.1\r\nnpm warn packages/app-mobile/node_modules/@react-native-clipboard/clipboard\r\nnpm warn @react-native-clipboard/clipboard@\"1.14.1\" from @joplin/app-mobile@3.2.0\r\nnpm warn packages/app-mobile\r\nnpm warn ERESOLVE overriding peer dependency\r\nnpm warn While resolving: react-native@0.74.1\r\nnpm warn Found: react@18.3.1\r\nnpm warn packages/app-mobile/node_modules/react\r\nnpm warn react@\"18.3.1\" from @joplin/app-mobile@3.2.0\r\nnpm warn packages/app-mobile\r\nnpm warn @joplin/app-mobile@3.2.0\r\nnpm warn node_modules/@joplin/app-mobile\r\nnpm warn 19 more (@bam.tech/react-native-image-resizer, ...)\r\nnpm warn\r\nnpm warn Could not resolve dependency:\r\nnpm warn peer react@\"18.2.0\" from react-native@0.74.1\r\nnpm warn packages/app-mobile/node_modules/react-native\r\nnpm warn react-native@\"0.74.1\" from @joplin/app-mobile@3.2.0\r\nnpm warn packages/app-mobile\r\nnpm warn 27 more (@bam.tech/react-native-image-resizer, ...)\r\nnpm warn\r\nnpm warn Conflicting peer dependency: react@18.2.0\r\nnpm warn node_modules/react\r\nnpm warn peer react@\"18.2.0\" from react-native@0.74.1\r\nnpm warn packages/app-mobile/node_modules/react-native\r\nnpm warn react-native@\"0.74.1\" from @joplin/app-mobile@3.2.0\r\nnpm warn packages/app-mobile\r\nnpm warn 27 more (@bam.tech/react-native-image-resizer, ...)\r\nnpm warn ERESOLVE overriding peer dependency\r\nnpm warn While resolving: react-native-macos@0.73.35\r\nnpm warn Found: react@18.3.1\r\nnpm warn packages/app-mobile/node_modules/react\r\nnpm warn react@\"18.3.1\" from @joplin/app-mobile@3.2.0\r\nnpm warn packages/app-mobile\r\nnpm warn @joplin/app-mobile@3.2.0\r\nnpm warn node_modules/@joplin/app-mobile\r\nnpm warn 19 more (@bam.tech/react-native-image-resizer, ...)\r\nnpm warn\r\nnpm warn Could not resolve dependency:\r\nnpm warn peer react@\"18.2.0\" from react-native-macos@0.73.35\r\nnpm warn packages/app-mobile/node_modules/react-native-macos\r\nnpm warn peer react-native-macos@\"^0.61.0 || ^0.62.0 || ^0.63.0 || ^0.64.0 || ^0.65.0 || ^0.66.0 || ^0.67.0 || ^0.68.0 || ^0.69.0 || ^0.70.0 || ^0.71.0 || ^0.72.0 || ^0.73.0\" from @react-native-clipboard/clipboard@1.14.1\r\nnpm warn packages/app-mobile/node_modules/@react-native-clipboard/clipboard\r\nnpm warn 1 more (react-native-localize)\r\nnpm warn\r\nnpm warn Conflicting peer dependency: react@18.2.0\r\nnpm warn node_modules/react\r\nnpm warn peer react@\"18.2.0\" from react-native-macos@0.73.35\r\nnpm warn packages/app-mobile/node_modules/react-native-macos\r\nnpm warn peer react-native-macos@\"^0.61.0 || ^0.62.0 || ^0.63.0 || ^0.64.0 || ^0.65.0 || ^0.66.0 || ^0.67.0 || ^0.68.0 || ^0.69.0 || ^0.70.0 || ^0.71.0 || ^0.72.0 || ^0.73.0\" from @react-native-clipboard/clipboard@1.14.1\r\nnpm warn packages/app-mobile/node_modules/@react-native-clipboard/clipboard\r\nnpm warn 1 more (react-native-localize)\r\nnpm warn ERESOLVE overriding peer dependency\r\nnpm warn While resolving: react-native-windows@0.73.21\r\nnpm warn Found: react@18.3.1\r\nnpm warn packages/app-mobile/node_modules/react\r\nnpm warn react@\"18.3.1\" from @joplin/app-mobile@3.2.0\r\nnpm warn packages/app-mobile\r\nnpm warn @joplin/app-mobile@3.2.0\r\nnpm warn node_modules/@joplin/app-mobile\r\nnpm warn 19 more (@bam.tech/react-native-image-resizer, ...)\r\nnpm warn\r\nnpm warn Could not resolve dependency:\r\nnpm warn peer react@\"18.2.0\" from react-native-windows@0.73.21\r\nnpm warn packages/app-mobile/node_modules/react-native-windows\r\nnpm warn peer react-native-windows@\"^0.61.0 || ^0.62.0 || ^0.63.0 || ^0.64.0 || ^0.65.0 || ^0.66.0 || ^0.67.0 || ^0.68.0 || ^0.69.0 || ^0.70.0 || ^0.71.0 || ^0.72.0 || ^0.73.0\" from @react-native-clipboard/clipboard@1.14.1\r\nnpm warn packages/app-mobile/node_modules/@react-native-clipboard/clipboard\r\nnpm warn 3 more (@react-native-community/datetimepicker, ...)\r\nnpm warn\r\nnpm warn Conflicting peer dependency: react@18.2.0\r\nnpm warn node_modules/react\r\nnpm warn peer react@\"18.2.0\" from react-native-windows@0.73.21\r\nnpm warn packages/app-mobile/node_modules/react-native-windows\r\nnpm warn peer react-native-windows@\"^0.61.0 || ^0.62.0 || ^0.63.0 || ^0.64.0 || ^0.65.0 || ^0.66.0 || ^0.67.0 || ^0.68.0 || ^0.69.0 || ^0.70.0 || ^0.71.0 || ^0.72.0 || ^0.73.0\" from @react-native-clipboard/clipboard@1.14.1\r\nnpm warn packages/app-mobile/node_modules/@react-native-clipboard/clipboard\r\nnpm warn 3 more (@react-native-community/datetimepicker, ...)\r\nnpm warn ERESOLVE overriding peer dependency\r\nnpm warn While resolving: react-native-windows@0.73.21\r\nnpm warn Found: react-native@0.74.1\r\nnpm warn packages/app-mobile/node_modules/react-native\r\nnpm warn react-native@\"0.74.1\" from @joplin/app-mobile@3.2.0\r\nnpm warn packages/app-mobile\r\nnpm warn @joplin/app-mobile@3.2.0\r\nnpm warn node_modules/@joplin/app-mobile\r\nnpm warn 27 more (@bam.tech/react-native-image-resizer, ...)\r\nnpm warn\r\nnpm warn Could not resolve dependency:\r\nnpm warn peer react-native@\"^0.73.0\" from react-native-windows@0.73.21\r\nnpm warn packages/app-mobile/node_modules/react-native-windows\r\nnpm warn peer react-native-windows@\"^0.61.0 || ^0.62.0 || ^0.63.0 || ^0.64.0 || ^0.65.0 || ^0.66.0 || ^0.67.0 || ^0.68.0 || ^0.69.0 || ^0.70.0 || ^0.71.0 || ^0.72.0 || ^0.73.0\" from @react-native-clipboard/clipboard@1.14.1\r\nnpm warn packages/app-mobile/node_modules/@react-native-clipboard/clipboard\r\nnpm warn 3 more (@react-native-community/datetimepicker, ...)\r\nnpm warn\r\nnpm warn Conflicting peer dependency: react-native@0.73.11\r\nnpm warn node_modules/react-native\r\nnpm warn peer react-native@\"^0.73.0\" from react-native-windows@0.73.21\r\nnpm warn packages/app-mobile/node_modules/react-native-windows\r\nnpm warn peer react-native-windows@\"^0.61.0 || ^0.62.0 || ^0.63.0 || ^0.64.0 || ^0.65.0 || ^0.66.0 || ^0.67.0 || ^0.68.0 || ^0.69.0 || ^0.70.0 || ^0.71.0 || ^0.72.0 || ^0.73.0\" from @react-native-clipboard/clipboard@1.14.1\r\nnpm warn packages/app-mobile/node_modules/@react-native-clipboard/clipboard\r\nnpm warn 3 more (@react-native-community/datetimepicker, ...)\r\nnpm warn ERESOLVE overriding peer dependency\r\nnpm warn While resolving: @testing-library/react-hooks@8.0.1\r\nnpm warn Found: @types/react@18.3.3\r\nnpm warn node_modules/@types/react\r\nnpm warn dev @types/react@\"18.3.3\" from @joplin/app-desktop@3.2.3\r\nnpm warn packages/app-desktop\r\nnpm warn @joplin/app-desktop@3.2.3\r\nnpm warn node_modules/@joplin/app-desktop\r\nnpm warn 23 more (@joplin/app-mobile, @joplin/editor, @joplin/lib, ...)\r\nnpm warn\r\nnpm warn Could not resolve dependency:\r\nnpm warn peerOptional @types/react@\"^16.9.0 || ^17.0.0\" from @testing-library/react-hooks@8.0.1\r\nnpm warn packages/lib/node_modules/@testing-library/react-hooks\r\nnpm warn dev @testing-library/react-hooks@\"8.0.1\" from @joplin/lib@3.2.0\r\nnpm warn packages/lib\r\nnpm warn\r\nnpm warn Conflicting peer dependency: @types/react@17.0.83\r\nnpm warn node_modules/@types/react\r\nnpm warn peerOptional @types/react@\"^16.9.0 || ^17.0.0\" from @testing-library/react-hooks@8.0.1\r\nnpm warn packages/lib/node_modules/@testing-library/react-hooks\r\nnpm warn dev @testing-library/react-hooks@\"8.0.1\" from @joplin/lib@3.2.0\r\nnpm warn packages/lib\r\nnpm warn ERESOLVE overriding peer dependency\r\nnpm warn While resolving: @testing-library/react-hooks@8.0.1\r\nnpm warn Found: react@18.3.1\r\nnpm warn packages/lib/node_modules/react\r\nnpm warn dev react@\"18.3.1\" from @joplin/lib@3.2.0\r\nnpm warn packages/lib\r\nnpm warn @joplin/lib@3.2.0\r\nnpm warn node_modules/@joplin/lib\r\nnpm warn 1 more (react-test-renderer)\r\nnpm warn\r\nnpm warn Could not resolve dependency:\r\nnpm warn peer react@\"^16.9.0 || ^17.0.0\" from @testing-library/react-hooks@8.0.1\r\nnpm warn packages/lib/node_modules/@testing-library/react-hooks\r\nnpm warn dev @testing-library/react-hooks@\"8.0.1\" from @joplin/lib@3.2.0\r\nnpm warn packages/lib\r\nnpm warn\r\nnpm warn Conflicting peer dependency: react@17.0.2\r\nnpm warn node_modules/react\r\nnpm warn peer react@\"^16.9.0 || ^17.0.0\" from @testing-library/react-hooks@8.0.1\r\nnpm warn packages/lib/node_modules/@testing-library/react-hooks\r\nnpm warn dev @testing-library/react-hooks@\"8.0.1\" from @joplin/lib@3.2.0\r\nnpm warn packages/lib\r\nnpm warn ERESOLVE overriding peer dependency\r\nnpm warn While resolving: @testing-library/react-hooks@8.0.1\r\nnpm warn Found: react-test-renderer@18.3.1\r\nnpm warn packages/lib/node_modules/react-test-renderer\r\nnpm warn dev react-test-renderer@\"18.3.1\" from @joplin/lib@3.2.0\r\nnpm warn packages/lib\r\nnpm warn @joplin/lib@3.2.0\r\nnpm warn node_modules/@joplin/lib\r\nnpm warn\r\nnpm warn Could not resolve dependency:\r\nnpm warn peerOptional react-test-renderer@\"^16.9.0 || ^17.0.0\" from @testing-library/react-hooks@8.0.1\r\nnpm warn packages/lib/node_modules/@testing-library/react-hooks\r\nnpm warn dev @testing-library/react-hooks@\"8.0.1\" from @joplin/lib@3.2.0\r\nnpm warn packages/lib\r\nnpm warn\r\nnpm warn Conflicting peer dependency: react-test-renderer@17.0.2\r\nnpm warn node_modules/react-test-renderer\r\nnpm warn peerOptional react-test-renderer@\"^16.9.0 || ^17.0.0\" from @testing-library/react-hooks@8.0.1\r\nnpm warn packages/lib/node_modules/@testing-library/react-hooks\r\nnpm warn dev @testing-library/react-hooks@\"8.0.1\" from @joplin/lib@3.2.0\r\nnpm warn packages/lib\r\nnpm warn ERESOLVE overriding peer dependency\r\nnpm warn While resolving: react-native@0.70.6\r\nnpm warn Found: react@18.3.1\r\nnpm warn packages/react-native-alarm-notification/node_modules/react\r\nnpm warn dev react@\"18.3.1\" from @joplin/react-native-alarm-notification@3.2.0\r\nnpm warn packages/react-native-alarm-notification\r\nnpm warn @joplin/react-native-alarm-notification@3.2.0\r\nnpm warn node_modules/@joplin/react-native-alarm-notification\r\nnpm warn\r\nnpm warn Could not resolve dependency:\r\nnpm warn peer react@\"18.1.0\" from react-native@0.70.6\r\nnpm warn packages/react-native-alarm-notification/node_modules/react-native\r\nnpm warn dev react-native@\"0.70.6\" from @joplin/react-native-alarm-notification@3.2.0\r\nnpm warn packages/react-native-alarm-notification\r\nnpm warn\r\nnpm warn Conflicting peer dependency: react@18.1.0\r\nnpm warn node_modules/react\r\nnpm warn peer react@\"18.1.0\" from react-native@0.70.6\r\nnpm warn packages/react-native-alarm-notification/node_modules/react-native\r\nnpm warn dev react-native@\"0.70.6\" from @joplin/react-native-alarm-notification@3.2.0\r\nnpm warn packages/react-native-alarm-notification\r\nnpm warn ERESOLVE overriding peer dependency\r\nnpm warn While resolving: react-native@0.70.6\r\nnpm warn Found: react@18.3.1\r\nnpm warn packages/react-native-saf-x/node_modules/react\r\nnpm warn dev react@\"18.3.1\" from @joplin/react-native-saf-x@3.2.0\r\nnpm warn packages/react-native-saf-x\r\nnpm warn @joplin/react-native-saf-x@3.2.0\r\nnpm warn node_modules/@joplin/react-native-saf-x\r\nnpm warn\r\nnpm warn Could not resolve dependency:\r\nnpm warn peer react@\"18.1.0\" from react-native@0.70.6\r\nnpm warn packages/react-native-saf-x/node_modules/react-native\r\nnpm warn dev react-native@\"0.70.6\" from @joplin/react-native-saf-x@3.2.0\r\nnpm warn packages/react-native-saf-x\r\nnpm warn\r\nnpm warn Conflicting peer dependency: react@18.1.0\r\nnpm warn node_modules/react\r\nnpm warn peer react@\"18.1.0\" from react-native@0.70.6\r\nnpm warn packages/react-native-saf-x/node_modules/react-native\r\nnpm warn dev react-native@\"0.70.6\" from @joplin/react-native-saf-x@3.2.0\r\nnpm warn packages/react-native-saf-x\r\nnpm warn deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.\r\nnpm warn deprecated @npmcli/move-file@1.1.2: This functionality has been moved to @npmcli/fs\r\nnpm warn deprecated source-map-url@0.4.1: See https://github.com/lydell/source-map-url#deprecated\r\nnpm warn deprecated move-concurrently@1.0.1: This package is no longer supported.\r\nnpm warn deprecated stable@0.1.8: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility\r\nnpm warn deprecated npmlog@5.0.1: This package is no longer supported.\r\nnpm warn deprecated @babel/plugin-proposal-numeric-separator@7.18.6: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-numeric-separator instead.\r\nnpm warn deprecated @babel/plugin-proposal-class-properties@7.18.6: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-class-properties instead.\r\nnpm warn deprecated @babel/plugin-proposal-nullish-coalescing-operator@7.18.6: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-nullish-coalescing-operator instead.\r\nnpm warn deprecated rimraf@2.6.3: Rimraf versions prior to v4 are no longer supported\r\nnpm warn deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported\r\nnpm warn deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported\r\nnpm warn deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported\r\nnpm warn deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported\r\nnpm warn deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported\r\nnpm warn deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported\r\nnpm warn deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported\r\nnpm warn deprecated figgy-pudding@3.5.2: This module is no longer supported.\r\nnpm warn deprecated rimraf@2.6.3: Rimraf versions prior to v4 are no longer supported\r\nnpm warn deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported\r\nnpm warn deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated\r\nnpm warn deprecated har-validator@5.1.5: this library is no longer supported\r\nnpm warn deprecated @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead\r\nnpm warn deprecated abab@2.0.6: Use your platform's native atob() and btoa() methods instead\r\nnpm warn deprecated copy-concurrently@1.0.5: This package is no longer supported.\r\nnpm warn deprecated rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported\r\nnpm warn deprecated @babel/plugin-proposal-optional-chaining@7.21.0: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-optional-chaining instead.\r\nnpm warn deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated\r\nnpm warn deprecated are-we-there-yet@2.0.0: This package is no longer supported.\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@8.1.0: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@8.1.0: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@8.1.0: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated domexception@2.0.1: Use your platform's native DOMException instead\r\nnpm warn deprecated source-map-resolve@0.5.3: See https://github.com/lydell/source-map-resolve#deprecated\r\nnpm warn deprecated querystring@0.2.1: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.\r\nnpm warn deprecated @babel/plugin-proposal-object-rest-spread@7.20.7: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-object-rest-spread instead.\r\nnpm warn deprecated w3c-hr-time@1.0.2: Use your platform's native performance.now() and performance.timeOrigin.\r\nnpm warn deprecated q@1.5.1: You or someone you depend on is using Q, the JavaScript Promise library that gave JavaScript developers strong feelings about promises. They can almost certainly migrate to the native JavaScript promise now. Thank you literally everyone for joining me in this bet against the odds. Be excellent to each other.\r\nnpm warn deprecated\r\nnpm warn deprecated (For a CapTP with native promises, see @endo/eventual-send and @endo/captp)\r\nnpm warn deprecated fs-write-stream-atomic@1.0.10: This package is no longer supported.\r\nnpm warn deprecated fsevents@1.2.13: Upgrade to fsevents v2 to mitigate potential security issues\r\nnpm warn deprecated querystring@0.2.0: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.\r\nnpm warn deprecated mkdirp@0.3.0: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)\r\nnpm warn deprecated gauge@3.0.2: This package is no longer supported.\r\nnpm warn deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.\r\nnpm warn deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.\r\nnpm warn deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.\r\nnpm warn deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142\r\nnpm warn deprecated eslint@8.57.0: This version is no longer supported. Please see https://eslint.org/version-support for other options.\r\nnpm warn deprecated @npmcli/move-file@2.0.1: This functionality has been moved to @npmcli/fs\r\nnpm warn deprecated domexception@4.0.0: Use your platform's native DOMException instead\r\nnpm warn deprecated uglify-es@3.3.10: support for ECMAScript is superseded by `uglify-js` as of v3.13.0\r\nnpm warn deprecated rimraf@2.2.8: Rimraf versions prior to v4 are no longer supported\r\nnpm warn deprecated dommatrix@1.0.3: dommatrix is no longer maintained. Please use @thednp/dommatrix.\r\nnpm warn deprecated read-package-json@6.0.4: This package is no longer supported. Please use @npmcli/package-json instead.\r\nnpm warn deprecated acorn-import-assertions@1.9.0: package has been renamed to acorn-import-attributes\r\nnpm warn deprecated highlight.js@9.12.0: Version no longer supported. Upgrade to @latest\r\nnpm warn deprecated highlight.js@9.12.0: Version no longer supported. Upgrade to @latest\r\nnpm warn deprecated trim@0.0.1: Use String.prototype.trim() instead\r\nnpm warn deprecated readdir-scoped-modules@1.1.0: This functionality has been moved to @npmcli/fs\r\nnpm warn deprecated debuglog@1.0.1: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated later@1.2.0: Please upgrade to the maintained and new drop-in replacement @breejs/later at https://github.com/breejs/later 🚀 Thanks and happy hacking! 🚀 @niftylettuce\r\nnpm warn deprecated uid-number@0.0.6: This package is no longer supported.\r\nnpm warn deprecated node-fetch-npm@2.0.4: This module is not used anymore, npm uses minipass-fetch for its fetch implementation now\r\nnpm warn deprecated read-package-json@6.0.4: This package is no longer supported. Please use @npmcli/package-json instead.\r\nnpm warn deprecated mkdirp-promise@5.0.1: This package is broken and no longer maintained. 'mkdirp' itself supports promises now, please switch to that.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated @lerna/gitlab-client@3.15.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated @lerna/github-client@3.22.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated @lerna/conventional-commits@3.22.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated @lerna/resolve-symlink@3.16.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated npm-lifecycle@3.1.5: The lifecycle script runner used in npm is now @npmcli/run-script. Please use that module moving forward\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated @lerna/create-symlink@3.16.2: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated @lerna/npm-run-script@3.16.5: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/timer@3.13.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/get-packed@3.16.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated read-package-json@2.1.2: This package is no longer supported. Please use @npmcli/package-json instead.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated @lerna/collect-uncommitted@3.16.5: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated @evocateur/libnpmpublish@1.2.2: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/npm-publish@3.18.5: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated @lerna/otplease@3.18.5: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated @lerna/pack-directory@3.16.4: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/npm-dist-tag@3.18.5: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/check-working-tree@3.16.5: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated @lerna/log-packed@3.16.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated @lerna/prerelease-id-from-version@3.16.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/package@3.16.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated @lerna/get-npm-exec-opts@3.13.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated @evocateur/libnpmaccess@3.1.2: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated @lerna/query-graph@3.18.5: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/filter-packages@3.18.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated @lerna/profiler@3.20.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/write-log-file@3.13.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated @lerna/project@3.21.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated @lerna/describe-ref@3.16.5: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/output@3.13.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated read-package-tree@5.3.1: The functionality that this package provided is now in @npmcli/arborist\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated @lerna/global-options@3.13.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated @lerna/listable@3.18.5: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated @lerna/collect-updates@3.20.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated @lerna/prompt@3.18.5: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/symlink-binary@3.17.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/symlink-dependencies@3.17.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/run-lifecycle@3.16.2: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated @lerna/pulse-till-done@3.13.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/run-topologically@3.18.5: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated @lerna/rimraf-dir@3.16.5: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated osenv@0.1.5: This package is no longer supported.\r\nnpm warn deprecated @lerna/package-graph@3.18.5: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/npm-install@3.16.5: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated @lerna/has-npm-version@3.16.5: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated @lerna/validation-error@3.13.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated @lerna/filter-options@3.20.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @evocateur/npm-registry-fetch@4.0.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/command@3.21.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/npm-conf@3.16.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated @lerna/publish@3.22.1: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/version@3.22.1: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @evocateur/pacote@9.6.5: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/run@3.21.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/info@3.21.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated @lerna/link@3.21.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/list@3.21.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/init@3.21.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/import@3.22.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/exec@3.21.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/diff@3.21.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn deprecated @lerna/cli@3.18.5: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/changed@3.21.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/clean@3.21.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/bootstrap@3.21.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @lerna/add@3.21.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated boolean@3.2.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.\r\nnpm warn deprecated @xmldom/xmldom@0.7.13: this version is no longer supported, please update to at least 0.8.*\r\nnpm warn deprecated glob@7.1.6: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.1.6: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated glob@7.1.6: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated @types/jest-expect-message@1.1.0: This is a stub types definition. jest-expect-message provides its own type definitions, so you do not need this installed.\r\nnpm warn deprecated @babel/plugin-proposal-optional-catch-binding@7.18.6: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-optional-catch-binding instead.\r\nnpm warn deprecated @babel/plugin-proposal-logical-assignment-operators@7.20.7: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-logical-assignment-operators instead.\r\nnpm warn deprecated @babel/plugin-proposal-async-generator-functions@7.20.7: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-async-generator-functions instead.\r\nnpm warn deprecated @babel/plugin-proposal-object-rest-spread@7.12.1: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-object-rest-spread instead.\r\nnpm warn deprecated @types/pdfjs-dist@2.10.378: This is a stub types definition. pdfjs-dist provides its own type definitions, so you do not need this installed.\r\nnpm warn deprecated @types/nanoid@3.0.0: This is a stub types definition. nanoid provides its own type definitions, so you do not need this installed.\r\nnpm warn deprecated glob@7.0.6: Glob versions prior to v9 are no longer supported\r\nnpm warn deprecated @types/tesseract.js@2.0.0: This is a stub types definition. tesseract.js provides its own type definitions, so you do not need this installed.\r\nnpm warn deprecated @joeattardi/emoji-button@4.6.4: Emoji Button is now PicMo! Please install the 'picmo' package, see https://picmojs.com for details\r\nnpm warn deprecated gauge@4.0.4: This package is no longer supported.\r\nnpm warn deprecated are-we-there-yet@3.0.1: This package is no longer supported.\r\nnpm warn deprecated npmlog@6.0.2: This package is no longer supported.\r\nnpm warn deprecated gauge@4.0.4: This package is no longer supported.\r\nnpm warn deprecated are-we-there-yet@3.0.1: This package is no longer supported.\r\nnpm warn deprecated npmlog@6.0.2: This package is no longer supported.\r\nnpm warn deprecated gauge@2.7.4: This package is no longer supported.\r\nnpm warn deprecated are-we-there-yet@1.1.7: This package is no longer supported.\r\nnpm warn deprecated npmlog@4.1.2: This package is no longer supported.\r\nnpm warn cleanup Failed to remove some directories [\r\nnpm warn cleanup [\r\nnpm warn cleanup '/Users/manabu/workplace/joplin/node_modules/@joeattardi',\r\nnpm warn cleanup [Error: ENOTEMPTY: directory not empty, rmdir '/Users/manabu/workplace/joplin/node_modules/@joeattardi/emoji-button'] {\r\nnpm warn cleanup errno: -66,\r\nnpm warn cleanup code: 'ENOTEMPTY',\r\nnpm warn cleanup syscall: 'rmdir',\r\nnpm warn cleanup path: '/Users/manabu/workplace/joplin/node_modules/@joeattardi/emoji-button'\r\nnpm warn cleanup }\r\nnpm warn cleanup ],\r\nnpm warn cleanup [\r\nnpm warn cleanup '/Users/manabu/workplace/joplin/node_modules',\r\nnpm warn cleanup [Error: ENOTEMPTY: directory not empty, rmdir '/Users/manabu/workplace/joplin/node_modules/@joeattardi/emoji-button'] {\r\nnpm warn cleanup errno: -66,\r\nnpm warn cleanup code: 'ENOTEMPTY',\r\nnpm warn cleanup syscall: 'rmdir',\r\nnpm warn cleanup path: '/Users/manabu/workplace/joplin/node_modules/@joeattardi/emoji-button'\r\nnpm warn cleanup }\r\nnpm warn cleanup ],\r\nnpm warn cleanup [\r\nnpm warn cleanup '/Users/manabu/workplace/joplin/node_modules/eslint-plugin-jest',\r\nnpm warn cleanup [Error: ENOTEMPTY: directory not empty, rmdir '/Users/manabu/workplace/joplin/node_modules/eslint-plugin-jest'] {\r\nnpm warn cleanup errno: -66,\r\nnpm warn cleanup code: 'ENOTEMPTY',\r\nnpm warn cleanup syscall: 'rmdir',\r\nnpm warn cleanup path: '/Users/manabu/workplace/joplin/node_modules/eslint-plugin-jest'\r\nnpm warn cleanup }\r\nnpm warn cleanup ],\r\nnpm warn cleanup [\r\nnpm warn cleanup '/Users/manabu/workplace/joplin/node_modules/@mixmark-io',\r\nnpm warn cleanup [Error: ENOTEMPTY: directory not empty, rmdir '/Users/manabu/workplace/joplin/node_modules/@mixmark-io'] {\r\nnpm warn cleanup errno: -66,\r\nnpm warn cleanup code: 'ENOTEMPTY',\r\nnpm warn cleanup syscall: 'rmdir',\r\nnpm warn cleanup path: '/Users/manabu/workplace/joplin/node_modules/@mixmark-io'\r\nnpm warn cleanup }\r\nnpm warn cleanup ],\r\nnpm warn cleanup [\r\nnpm warn cleanup '/Users/manabu/workplace/joplin/node_modules/react-native-rsa-native',\r\nnpm warn cleanup [Error: ENOTEMPTY: directory not empty, rmdir '/Users/manabu/workplace/joplin/node_modules/react-native-rsa-native'] {\r\nnpm warn cleanup errno: -66,\r\nnpm warn cleanup code: 'ENOTEMPTY',\r\nnpm warn cleanup syscall: 'rmdir',\r\nnpm warn cleanup path: '/Users/manabu/workplace/joplin/node_modules/react-native-rsa-native'\r\nnpm warn cleanup }\r\nnpm warn cleanup ],\r\nnpm warn cleanup [\r\nnpm warn cleanup '/Users/manabu/workplace/joplin/node_modules/license-checker-rseidelsohn',\r\nnpm warn cleanup [Error: ENOTEMPTY: directory not empty, rmdir '/Users/manabu/workplace/joplin/node_modules/license-checker-rseidelsohn'] {\r\nnpm warn cleanup errno: -66,\r\nnpm warn cleanup code: 'ENOTEMPTY',\r\nnpm warn cleanup syscall: 'rmdir',\r\nnpm warn cleanup path: '/Users/manabu/workplace/joplin/node_modules/license-checker-rseidelsohn'\r\nnpm warn cleanup }\r\nnpm warn cleanup ],\r\nnpm warn cleanup [\r\nnpm warn cleanup '/Users/manabu/workplace/joplin/packages/app-mobile/node_modules',\r\nnpm warn cleanup [Error: ENOTEMPTY: directory not empty, rmdir '/Users/manabu/workplace/joplin/packages/app-mobile/node_modules/react-native/ReactAndroid'] {\r\nnpm warn cleanup errno: -66,\r\nnpm warn cleanup code: 'ENOTEMPTY',\r\nnpm warn cleanup syscall: 'rmdir',\r\nnpm warn cleanup path: '/Users/manabu/workplace/joplin/packages/app-mobile/node_modules/react-native/ReactAndroid'\r\nnpm warn cleanup }\r\nnpm warn cleanup ],\r\nnpm warn cleanup [\r\nnpm warn cleanup '/Users/manabu/workplace/joplin/packages/app-mobile/node_modules/react-native',\r\nnpm warn cleanup [Error: ENOTEMPTY: directory not empty, rmdir '/Users/manabu/workplace/joplin/packages/app-mobile/node_modules/react-native/ReactAndroid'] {\r\nnpm warn cleanup errno: -66,\r\nnpm warn cleanup code: 'ENOTEMPTY',\r\nnpm warn cleanup syscall: 'rmdir',\r\nnpm warn cleanup path: '/Users/manabu/workplace/joplin/packages/app-mobile/node_modules/react-native/ReactAndroid'\r\nnpm warn cleanup }\r\nnpm warn cleanup ],\r\nnpm warn cleanup [\r\nnpm warn cleanup '/Users/manabu/workplace/joplin/packages/app-mobile/node_modules/react-native-macos',\r\nnpm warn cleanup [Error: ENOTEMPTY: directory not empty, rmdir '/Users/manabu/workplace/joplin/packages/app-mobile/node_modules/react-native-macos'] {\r\nnpm warn cleanup errno: -66,\r\nnpm warn cleanup code: 'ENOTEMPTY',\r\nnpm warn cleanup syscall: 'rmdir',\r\nnpm warn cleanup path: '/Users/manabu/workplace/joplin/packages/app-mobile/node_modules/react-native-macos'\r\nnpm warn cleanup }\r\nnpm warn cleanup ],\r\nnpm warn cleanup [\r\nnpm warn cleanup '/Users/manabu/workplace/joplin/packages/react-native-saf-x/node_modules/react-native',\r\nnpm warn cleanup [Error: ENOTEMPTY: directory not empty, rmdir '/Users/manabu/workplace/joplin/packages/react-native-saf-x/node_modules/react-native'] {\r\nnpm warn cleanup errno: -66,\r\nnpm warn cleanup code: 'ENOTEMPTY',\r\nnpm warn cleanup syscall: 'rmdir',\r\nnpm warn cleanup path: '/Users/manabu/workplace/joplin/packages/react-native-saf-x/node_modules/react-native'\r\nnpm warn cleanup }\r\nnpm warn cleanup ],\r\nnpm warn cleanup [\r\nnpm warn cleanup '/Users/manabu/workplace/joplin/packages/react-native-saf-x/node_modules',\r\nnpm warn cleanup [Error: ENOTEMPTY: directory not empty, rmdir '/Users/manabu/workplace/joplin/packages/react-native-saf-x/node_modules/react-native'] {\r\nnpm warn cleanup errno: -66,\r\nnpm warn cleanup code: 'ENOTEMPTY',\r\nnpm warn cleanup syscall: 'rmdir',\r\nnpm warn cleanup path: '/Users/manabu/workplace/joplin/packages/react-native-saf-x/node_modules/react-native'\r\nnpm warn cleanup }\r\nnpm warn cleanup ],\r\nnpm warn cleanup [\r\nnpm warn cleanup '/Users/manabu/workplace/joplin/node_modules/@craftzdog',\r\nnpm warn cleanup [Error: ENOTEMPTY: directory not empty, rmdir '/Users/manabu/workplace/joplin/node_modules/@craftzdog/react-native-buffer'] {\r\nnpm warn cleanup errno: -66,\r\nnpm warn cleanup code: 'ENOTEMPTY',\r\nnpm warn cleanup syscall: 'rmdir',\r\nnpm warn cleanup path: '/Users/manabu/workplace/joplin/node_modules/@craftzdog/react-native-buffer'\r\nnpm warn cleanup }\r\nnpm warn cleanup ],\r\nnpm warn cleanup [\r\nnpm warn cleanup '/Users/manabu/workplace/joplin/node_modules/@craftzdog/react-native-buffer',\r\nnpm warn cleanup [Error: ENOTEMPTY: directory not empty, rmdir '/Users/manabu/workplace/joplin/node_modules/@craftzdog/react-native-buffer'] {\r\nnpm warn cleanup errno: -66,\r\nnpm warn cleanup code: 'ENOTEMPTY',\r\nnpm warn cleanup syscall: 'rmdir',\r\nnpm warn cleanup path: '/Users/manabu/workplace/joplin/node_modules/@craftzdog/react-native-buffer'\r\nnpm warn cleanup }\r\nnpm warn cleanup ]\r\nnpm warn cleanup ]\r\nnpm error code 1\r\nnpm error path /Users/manabu/workplace/joplin/node_modules/sharp\r\nnpm error command failed\r\nnpm error command sh -c node install/check\r\nnpm error sharp: Detected globally-installed libvips v8.15.3\r\nnpm error sharp: Attempting to build from source via node-gyp\r\nnpm error sharp: Found node-addon-api\r\nnpm error sharp: Found node-gyp version 9.4.1\r\nnpm error sharp: See https://sharp.pixelplumbing.com/install#building-from-source\r\nnpm error CC(target) Release/obj.target/nothing/../../node-addon-api/src/nothing.o\r\nnpm error LIBTOOL-STATIC Release/nothing.a\r\nnpm error TOUCH Release/obj.target/libvips-cpp.stamp\r\nnpm error CXX(target) Release/obj.target/sharp-darwin-arm64/common.o\r\nnpm error gyp info it worked if it ends with ok\r\nnpm error gyp info using node-gyp@9.4.1\r\nnpm error gyp info using node@22.9.0 | darwin | arm64\r\nnpm error gyp info chdir src\r\nnpm error (node:76535) [DEP0060] DeprecationWarning: The `util._extend` API is deprecated. Please use Object.assign() instead.\r\nnpm error (Use `node --trace-deprecation ...` to show where the warning was created)\r\nnpm error gyp info find Python using Python version 3.12.7 found at \"/Users/manabu/myenv/bin/python3\"\r\nnpm error gyp info spawn /Users/manabu/myenv/bin/python3\r\nnpm error gyp info spawn args [\r\nnpm error gyp info spawn args '/Users/manabu/workplace/joplin/node_modules/node-gyp/gyp/gyp_main.py',\r\nnpm error gyp info spawn args 'binding.gyp',\r\nnpm error gyp info spawn args '-f',\r\nnpm error gyp info spawn args 'make',\r\nnpm error gyp info spawn args '-I',\r\nnpm error gyp info spawn args '/Users/manabu/workplace/joplin/node_modules/sharp/src/build/config.gypi',\r\nnpm error gyp info spawn args '-I',\r\nnpm error gyp info spawn args '/Users/manabu/workplace/joplin/node_modules/node-gyp/addon.gypi',\r\nnpm error gyp info spawn args '-I',\r\nnpm error gyp info spawn args '/Users/manabu/Library/Caches/node-gyp/22.9.0/include/node/common.gypi',\r\nnpm error gyp info spawn args '-Dlibrary=shared_library',\r\nnpm error gyp info spawn args '-Dvisibility=default',\r\nnpm error gyp info spawn args '-Dnode_root_dir=/Users/manabu/Library/Caches/node-gyp/22.9.0',\r\nnpm error gyp info spawn args '-Dnode_gyp_dir=/Users/manabu/workplace/joplin/node_modules/node-gyp',\r\nnpm error gyp info spawn args '-Dnode_lib_file=/Users/manabu/Library/Caches/node-gyp/22.9.0/<(target_arch)/node.lib',\r\nnpm error gyp info spawn args '-Dmodule_root_dir=/Users/manabu/workplace/joplin/node_modules/sharp/src',\r\nnpm error gyp info spawn args '-Dnode_engine=v8',\r\nnpm error gyp info spawn args '--depth=.',\r\nnpm error gyp info spawn args '--no-parallel',\r\nnpm error gyp info spawn args '--generator-output',\r\nnpm error gyp info spawn args 'build',\r\nnpm error gyp info spawn args '-Goutput_dir=.'\r\nnpm error gyp info spawn args ]\r\nnpm error :114: SyntaxWarning: invalid escape sequence '\\/'\r\nnpm error gyp info spawn make\r\nnpm error gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]\r\nnpm error warning: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: archive library: Release/nothing.a the table of contents is empty (no object file members in the library define global symbols)\r\nnpm error ../common.cc:12:10: fatal error: 'napi.h' file not found\r\nnpm error 12 | #include \r\nnpm error | ^~~~~~~~\r\nnpm error 1 error generated.\r\nnpm error make: *** [Release/obj.target/sharp-darwin-arm64/common.o] Error 1\r\nnpm error gyp ERR! build error\r\nnpm error gyp ERR! stack Error: `make` failed with exit code: 2\r\nnpm error gyp ERR! stack at ChildProcess.onExit (/Users/manabu/workplace/joplin/node_modules/node-gyp/lib/build.js:203:23)\r\nnpm error gyp ERR! stack at ChildProcess.emit (node:events:519:28)\r\nnpm error gyp ERR! stack at ChildProcess._handle.onexit (node:internal/child_process:293:12)\r\nnpm error gyp ERR! System Darwin 24.1.0\r\nnpm error gyp ERR! command \"/opt/homebrew/Cellar/node/22.9.0_1/bin/node\" \"/Users/manabu/workplace/joplin/node_modules/.bin/node-gyp\" \"rebuild\" \"--directory=src\"\r\nnpm error gyp ERR! cwd /Users/manabu/workplace/joplin/node_modules/sharp/src\r\nnpm error gyp ERR! node -v v22.9.0\r\nnpm error gyp ERR! node-gyp -v v9.4.1\r\nnpm error gyp ERR! not ok\r\nnpm error A complete log of this run can be found in: /Users/manabu/.npm/_logs/2024-12-05T10_29_25_269Z-debug-0.log\r\n
\r\n\r\n", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11471/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11471/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2519982952", + "html_url": "https://github.com/laurent22/joplin/pull/11471#issuecomment-2519982952", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11471", + "id": 2519982952, + "node_id": "IC_kwDOBLftOs6WM-No", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-05T11:01:04Z", + "updated_at": "2024-12-09T16:07:37Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2519982952/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2519997043", + "html_url": "https://github.com/laurent22/joplin/pull/11471#issuecomment-2519997043", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11471", + "id": 2519997043, + "node_id": "IC_kwDOBLftOs6WNBpz", + "user": { + "login": "mshibanami", + "id": 1333214, + "node_id": "MDQ6VXNlcjEzMzMyMTQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1333214?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/mshibanami", + "html_url": "https://github.com/mshibanami", + "followers_url": "https://api.github.com/users/mshibanami/followers", + "following_url": "https://api.github.com/users/mshibanami/following{/other_user}", + "gists_url": "https://api.github.com/users/mshibanami/gists{/gist_id}", + "starred_url": "https://api.github.com/users/mshibanami/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/mshibanami/subscriptions", + "organizations_url": "https://api.github.com/users/mshibanami/orgs", + "repos_url": "https://api.github.com/users/mshibanami/repos", + "events_url": "https://api.github.com/users/mshibanami/events{/privacy}", + "received_events_url": "https://api.github.com/users/mshibanami/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-05T11:06:47Z", + "updated_at": "2024-12-05T11:06:47Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2519997043/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2519997194", + "html_url": "https://github.com/laurent22/joplin/pull/11471#issuecomment-2519997194", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11471", + "id": 2519997194, + "node_id": "IC_kwDOBLftOs6WNBsK", + "user": { + "login": "mshibanami", + "id": 1333214, + "node_id": "MDQ6VXNlcjEzMzMyMTQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1333214?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/mshibanami", + "html_url": "https://github.com/mshibanami", + "followers_url": "https://api.github.com/users/mshibanami/followers", + "following_url": "https://api.github.com/users/mshibanami/following{/other_user}", + "gists_url": "https://api.github.com/users/mshibanami/gists{/gist_id}", + "starred_url": "https://api.github.com/users/mshibanami/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/mshibanami/subscriptions", + "organizations_url": "https://api.github.com/users/mshibanami/orgs", + "repos_url": "https://api.github.com/users/mshibanami/repos", + "events_url": "https://api.github.com/users/mshibanami/events{/privacy}", + "received_events_url": "https://api.github.com/users/mshibanami/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-05T11:06:51Z", + "updated_at": "2024-12-05T11:06:51Z", + "author_association": "CONTRIBUTOR", + "body": "recheck", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2519997194/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/narFnarF_3538115.json b/readme/cla/consent_records/narFnarF_3538115.json new file mode 100644 index 0000000000..add691eccd --- /dev/null +++ b/readme/cla/consent_records/narFnarF_3538115.json @@ -0,0 +1,317 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11867", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11867/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11867/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11867/events", + "html_url": "https://github.com/laurent22/joplin/pull/11867", + "id": 2866499628, + "node_id": "PR_kwDOBLftOs6L6scX", + "number": 11867, + "title": "Fix typo and clarify French default note 3_synchronising_your_notes.md", + "user": { + "login": "narFnarF", + "id": 3538115, + "node_id": "MDQ6VXNlcjM1MzgxMTU=", + "avatar_url": "https://avatars.githubusercontent.com/u/3538115?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/narFnarF", + "html_url": "https://github.com/narFnarF", + "followers_url": "https://api.github.com/users/narFnarF/followers", + "following_url": "https://api.github.com/users/narFnarF/following{/other_user}", + "gists_url": "https://api.github.com/users/narFnarF/gists{/gist_id}", + "starred_url": "https://api.github.com/users/narFnarF/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/narFnarF/subscriptions", + "organizations_url": "https://api.github.com/users/narFnarF/orgs", + "repos_url": "https://api.github.com/users/narFnarF/repos", + "events_url": "https://api.github.com/users/narFnarF/events{/privacy}", + "received_events_url": "https://api.github.com/users/narFnarF/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 3, + "created_at": "2025-02-20T15:23:23Z", + "updated_at": "2025-02-27T18:50:42Z", + "closed_at": "2025-02-27T18:33:59Z", + "author_association": "NONE", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11867", + "html_url": "https://github.com/laurent22/joplin/pull/11867", + "diff_url": "https://github.com/laurent22/joplin/pull/11867.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11867.patch", + "merged_at": null + }, + "body": "The French default note readme/_i18n/fr_FR/welcome/3_synchronising_your_notes.md had some typos and small errors. \r\n\r\nHere's what I changed:\r\n- Replace a non-breaking space in the Nextcloud title, so that markdown correctly recognize it as a title.\r\n- Remove an extra space in the URL path\r\n- Clarify where to go in the Options screen\r\n\r\n", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11867/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11867/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2671828322", + "html_url": "https://github.com/laurent22/joplin/pull/11867#issuecomment-2671828322", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11867", + "id": 2671828322, + "node_id": "IC_kwDOBLftOs6fQN1i", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-20T15:23:37Z", + "updated_at": "2025-02-27T18:50:42Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2671828322/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2671844194", + "html_url": "https://github.com/laurent22/joplin/pull/11867#issuecomment-2671844194", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11867", + "id": 2671844194, + "node_id": "IC_kwDOBLftOs6fQRti", + "user": { + "login": "narFnarF", + "id": 3538115, + "node_id": "MDQ6VXNlcjM1MzgxMTU=", + "avatar_url": "https://avatars.githubusercontent.com/u/3538115?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/narFnarF", + "html_url": "https://github.com/narFnarF", + "followers_url": "https://api.github.com/users/narFnarF/followers", + "following_url": "https://api.github.com/users/narFnarF/following{/other_user}", + "gists_url": "https://api.github.com/users/narFnarF/gists{/gist_id}", + "starred_url": "https://api.github.com/users/narFnarF/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/narFnarF/subscriptions", + "organizations_url": "https://api.github.com/users/narFnarF/orgs", + "repos_url": "https://api.github.com/users/narFnarF/repos", + "events_url": "https://api.github.com/users/narFnarF/events{/privacy}", + "received_events_url": "https://api.github.com/users/narFnarF/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-20T15:28:56Z", + "updated_at": "2025-02-20T15:28:56Z", + "author_association": "NONE", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2671844194/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2688786949", + "html_url": "https://github.com/laurent22/joplin/pull/11867#issuecomment-2688786949", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11867", + "id": 2688786949, + "node_id": "IC_kwDOBLftOs6gQ6IF", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-27T18:33:59Z", + "updated_at": "2025-02-27T18:33:59Z", + "author_association": "OWNER", + "body": "Thank you for the pull request but as mentioned above I would prefer not to merge since it's difficult to say how to access the config screen for each app", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2688786949/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/ost-ch_98581972.json b/readme/cla/consent_records/ost-ch_98581972.json new file mode 100644 index 0000000000..ed32b08191 --- /dev/null +++ b/readme/cla/consent_records/ost-ch_98581972.json @@ -0,0 +1,317 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12011", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/12011/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/12011/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/12011/events", + "html_url": "https://github.com/laurent22/joplin/pull/12011", + "id": 2953449126, + "node_id": "PR_kwDOBLftOs6QarZY", + "number": 12011, + "title": "All: Update index.md: Added Reference to Edge-Addon", + "user": { + "login": "ost-ch", + "id": 98581972, + "node_id": "U_kgDOBeA91A", + "avatar_url": "https://avatars.githubusercontent.com/u/98581972?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/ost-ch", + "html_url": "https://github.com/ost-ch", + "followers_url": "https://api.github.com/users/ost-ch/followers", + "following_url": "https://api.github.com/users/ost-ch/following{/other_user}", + "gists_url": "https://api.github.com/users/ost-ch/gists{/gist_id}", + "starred_url": "https://api.github.com/users/ost-ch/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/ost-ch/subscriptions", + "organizations_url": "https://api.github.com/users/ost-ch/orgs", + "repos_url": "https://api.github.com/users/ost-ch/repos", + "events_url": "https://api.github.com/users/ost-ch/events{/privacy}", + "received_events_url": "https://api.github.com/users/ost-ch/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 3, + "created_at": "2025-03-27T15:29:09Z", + "updated_at": "2025-03-27T17:30:57Z", + "closed_at": "2025-03-27T17:30:45Z", + "author_association": "FIRST_TIMER", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/12011", + "html_url": "https://github.com/laurent22/joplin/pull/12011", + "diff_url": "https://github.com/laurent22/joplin/pull/12011.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/12011.patch", + "merged_at": null + }, + "body": "Edge-Addon\r\n\r\nAdded Reference to Edge-Addon with Joplin Support.", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12011/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/12011/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2758478631", + "html_url": "https://github.com/laurent22/joplin/pull/12011#issuecomment-2758478631", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12011", + "id": 2758478631, + "node_id": "IC_kwDOBLftOs6kawsn", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-27T15:29:18Z", + "updated_at": "2025-03-27T17:30:57Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2758478631/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2758497699", + "html_url": "https://github.com/laurent22/joplin/pull/12011#issuecomment-2758497699", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12011", + "id": 2758497699, + "node_id": "IC_kwDOBLftOs6ka1Wj", + "user": { + "login": "ost-ch", + "id": 98581972, + "node_id": "U_kgDOBeA91A", + "avatar_url": "https://avatars.githubusercontent.com/u/98581972?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/ost-ch", + "html_url": "https://github.com/ost-ch", + "followers_url": "https://api.github.com/users/ost-ch/followers", + "following_url": "https://api.github.com/users/ost-ch/following{/other_user}", + "gists_url": "https://api.github.com/users/ost-ch/gists{/gist_id}", + "starred_url": "https://api.github.com/users/ost-ch/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/ost-ch/subscriptions", + "organizations_url": "https://api.github.com/users/ost-ch/orgs", + "repos_url": "https://api.github.com/users/ost-ch/repos", + "events_url": "https://api.github.com/users/ost-ch/events{/privacy}", + "received_events_url": "https://api.github.com/users/ost-ch/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-27T15:35:20Z", + "updated_at": "2025-03-27T15:35:20Z", + "author_association": "NONE", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2758497699/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2758901598", + "html_url": "https://github.com/laurent22/joplin/pull/12011#issuecomment-2758901598", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12011", + "id": 2758901598, + "node_id": "IC_kwDOBLftOs6kcX9e", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-27T17:30:45Z", + "updated_at": "2025-03-27T17:30:45Z", + "author_association": "OWNER", + "body": "Thank you for the PR, however we only list officially supported extensions here. And also users can (and probably should) install the official web clipper on Edge too.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2758901598/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/outrodani_134531018.json b/readme/cla/consent_records/outrodani_134531018.json new file mode 100644 index 0000000000..52bab7dac9 --- /dev/null +++ b/readme/cla/consent_records/outrodani_134531018.json @@ -0,0 +1,387 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12055", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/12055/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/12055/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/12055/events", + "html_url": "https://github.com/laurent22/joplin/pull/12055", + "id": 2973537834, + "node_id": "PR_kwDOBLftOs6ReC9_", + "number": 12055, + "title": "Desktop: Fixes #9588: Removed download button on mermaid diagrams in rich text editor", + "user": { + "login": "outrodani", + "id": 134531018, + "node_id": "U_kgDOCATHyg", + "avatar_url": "https://avatars.githubusercontent.com/u/134531018?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/outrodani", + "html_url": "https://github.com/outrodani", + "followers_url": "https://api.github.com/users/outrodani/followers", + "following_url": "https://api.github.com/users/outrodani/following{/other_user}", + "gists_url": "https://api.github.com/users/outrodani/gists{/gist_id}", + "starred_url": "https://api.github.com/users/outrodani/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/outrodani/subscriptions", + "organizations_url": "https://api.github.com/users/outrodani/orgs", + "repos_url": "https://api.github.com/users/outrodani/repos", + "events_url": "https://api.github.com/users/outrodani/events{/privacy}", + "received_events_url": "https://api.github.com/users/outrodani/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "open", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 5, + "created_at": "2025-04-04T23:21:31Z", + "updated_at": "2025-04-15T11:42:06Z", + "closed_at": null, + "author_association": "FIRST_TIMER", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/12055", + "html_url": "https://github.com/laurent22/joplin/pull/12055", + "diff_url": "https://github.com/laurent22/joplin/pull/12055.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/12055.patch", + "merged_at": null + }, + "body": "This PR fixes #9588 by removing the download button while hovering over a mermaid diagram in the rich text editor.\r\n\r\nI simply added a verification that checks if the tox-tinymce class is used. If that is the case, the exportButtonMarkup constant will simply be an empty string, resulting in the download button not being visible. Since this class is only found in the rich text editor, the download button will remain visible and functional in the markdown editor.\r\n\r\nhttps://github.com/user-attachments/assets/697115a4-f4de-4295-9b14-77726b48bfb0", + "closed_by": null, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12055/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/12055/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2779892283", + "html_url": "https://github.com/laurent22/joplin/pull/12055#issuecomment-2779892283", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12055", + "id": 2779892283, + "node_id": "IC_kwDOBLftOs6lsco7", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-04T23:21:43Z", + "updated_at": "2025-04-11T18:02:35Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2779892283/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2779892643", + "html_url": "https://github.com/laurent22/joplin/pull/12055#issuecomment-2779892643", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12055", + "id": 2779892643, + "node_id": "IC_kwDOBLftOs6lscuj", + "user": { + "login": "outrodani", + "id": 134531018, + "node_id": "U_kgDOCATHyg", + "avatar_url": "https://avatars.githubusercontent.com/u/134531018?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/outrodani", + "html_url": "https://github.com/outrodani", + "followers_url": "https://api.github.com/users/outrodani/followers", + "following_url": "https://api.github.com/users/outrodani/following{/other_user}", + "gists_url": "https://api.github.com/users/outrodani/gists{/gist_id}", + "starred_url": "https://api.github.com/users/outrodani/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/outrodani/subscriptions", + "organizations_url": "https://api.github.com/users/outrodani/orgs", + "repos_url": "https://api.github.com/users/outrodani/repos", + "events_url": "https://api.github.com/users/outrodani/events{/privacy}", + "received_events_url": "https://api.github.com/users/outrodani/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-04T23:22:07Z", + "updated_at": "2025-04-04T23:22:07Z", + "author_association": "NONE", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2779892643/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2784335330", + "html_url": "https://github.com/laurent22/joplin/pull/12055#issuecomment-2784335330", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12055", + "id": 2784335330, + "node_id": "IC_kwDOBLftOs6l9ZXi", + "user": { + "login": "personalizedrefrigerator", + "id": 46334387, + "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", + "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/personalizedrefrigerator", + "html_url": "https://github.com/personalizedrefrigerator", + "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", + "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", + "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", + "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", + "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", + "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", + "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", + "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-07T19:14:01Z", + "updated_at": "2025-04-07T19:14:01Z", + "author_association": "COLLABORATOR", + "body": "Thank you for working on this!\r\n\r\nFor reference, I'm linking to [a commit that takes an alternate approach that *might* fix this](https://github.com/personalizedrefrigerator/joplin/commit/3cffd0c55dc62a9298cd9276a18e5595accf5b47) if we do eventually want to support the download button in the Rich Text Editor. (If I recall correctly, there was an issue with the linked commit (e.g. right-click menus opened with the keyboard didn't work?)).", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2784335330/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2798086048", + "html_url": "https://github.com/laurent22/joplin/pull/12055#issuecomment-2798086048", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12055", + "id": 2798086048, + "node_id": "IC_kwDOBLftOs6mx2eg", + "user": { + "login": "personalizedrefrigerator", + "id": 46334387, + "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", + "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/personalizedrefrigerator", + "html_url": "https://github.com/personalizedrefrigerator", + "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", + "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", + "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", + "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", + "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", + "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", + "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", + "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-11T22:03:44Z", + "updated_at": "2025-04-11T22:03:44Z", + "author_association": "COLLABORATOR", + "body": "**Note**: #9588 should now be partially fixed by https://github.com/laurent22/joplin/pull/12076 (the download button now shows a menu, but it doesn't have download options).", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2798086048/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2804763543", + "html_url": "https://github.com/laurent22/joplin/pull/12055#issuecomment-2804763543", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12055", + "id": 2804763543, + "node_id": "IC_kwDOBLftOs6nLUuX", + "user": { + "login": "outrodani", + "id": 134531018, + "node_id": "U_kgDOCATHyg", + "avatar_url": "https://avatars.githubusercontent.com/u/134531018?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/outrodani", + "html_url": "https://github.com/outrodani", + "followers_url": "https://api.github.com/users/outrodani/followers", + "following_url": "https://api.github.com/users/outrodani/following{/other_user}", + "gists_url": "https://api.github.com/users/outrodani/gists{/gist_id}", + "starred_url": "https://api.github.com/users/outrodani/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/outrodani/subscriptions", + "organizations_url": "https://api.github.com/users/outrodani/orgs", + "repos_url": "https://api.github.com/users/outrodani/repos", + "events_url": "https://api.github.com/users/outrodani/events{/privacy}", + "received_events_url": "https://api.github.com/users/outrodani/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-15T11:42:05Z", + "updated_at": "2025-04-15T11:42:05Z", + "author_association": "NONE", + "body": "The purpose of this PR was to remove the download button because it wasn't functional. However, now that it does show a menu (even if without download options), is there still a reason to remove the button?", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2804763543/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/pectum83_11873289.json b/readme/cla/consent_records/pectum83_11873289.json new file mode 100644 index 0000000000..5dc90dfd3f --- /dev/null +++ b/readme/cla/consent_records/pectum83_11873289.json @@ -0,0 +1,272 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11951", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11951/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11951/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11951/events", + "html_url": "https://github.com/laurent22/joplin/pull/11951", + "id": 2916936599, + "node_id": "PR_kwDOBLftOs6OgEBs", + "number": 11951, + "title": "Update webdav.md", + "user": { + "login": "pectum83", + "id": 11873289, + "node_id": "MDQ6VXNlcjExODczMjg5", + "avatar_url": "https://avatars.githubusercontent.com/u/11873289?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/pectum83", + "html_url": "https://github.com/pectum83", + "followers_url": "https://api.github.com/users/pectum83/followers", + "following_url": "https://api.github.com/users/pectum83/following{/other_user}", + "gists_url": "https://api.github.com/users/pectum83/gists{/gist_id}", + "starred_url": "https://api.github.com/users/pectum83/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/pectum83/subscriptions", + "organizations_url": "https://api.github.com/users/pectum83/orgs", + "repos_url": "https://api.github.com/users/pectum83/repos", + "events_url": "https://api.github.com/users/pectum83/events{/privacy}", + "received_events_url": "https://api.github.com/users/pectum83/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 2, + "created_at": "2025-03-13T12:10:19Z", + "updated_at": "2025-03-14T00:16:03Z", + "closed_at": "2025-03-14T00:15:52Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11951", + "html_url": "https://github.com/laurent22/joplin/pull/11951", + "diff_url": "https://github.com/laurent22/joplin/pull/11951.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11951.patch", + "merged_at": "2025-03-14T00:15:52Z" + }, + "body": "I have tested synchronisation with infomaniak kDrive\r\n\r\n", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11951/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11951/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2721040678", + "html_url": "https://github.com/laurent22/joplin/pull/11951#issuecomment-2721040678", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11951", + "id": 2721040678, + "node_id": "IC_kwDOBLftOs6iL8km", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-13T12:10:34Z", + "updated_at": "2025-03-14T00:16:02Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2721040678/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2721045583", + "html_url": "https://github.com/laurent22/joplin/pull/11951#issuecomment-2721045583", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11951", + "id": 2721045583, + "node_id": "IC_kwDOBLftOs6iL9xP", + "user": { + "login": "pectum83", + "id": 11873289, + "node_id": "MDQ6VXNlcjExODczMjg5", + "avatar_url": "https://avatars.githubusercontent.com/u/11873289?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/pectum83", + "html_url": "https://github.com/pectum83", + "followers_url": "https://api.github.com/users/pectum83/followers", + "following_url": "https://api.github.com/users/pectum83/following{/other_user}", + "gists_url": "https://api.github.com/users/pectum83/gists{/gist_id}", + "starred_url": "https://api.github.com/users/pectum83/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/pectum83/subscriptions", + "organizations_url": "https://api.github.com/users/pectum83/orgs", + "repos_url": "https://api.github.com/users/pectum83/repos", + "events_url": "https://api.github.com/users/pectum83/events{/privacy}", + "received_events_url": "https://api.github.com/users/pectum83/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-13T12:12:17Z", + "updated_at": "2025-03-13T12:12:17Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2721045583/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/rabbabansh_31804810.json b/readme/cla/consent_records/rabbabansh_31804810.json new file mode 100644 index 0000000000..eb7419bad2 --- /dev/null +++ b/readme/cla/consent_records/rabbabansh_31804810.json @@ -0,0 +1,767 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11857", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11857/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11857/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11857/events", + "html_url": "https://github.com/laurent22/joplin/pull/11857", + "id": 2861576373, + "node_id": "PR_kwDOBLftOs6LqJRh", + "number": 11857, + "title": "Desktop, Mobile: Fixes #11845: Fixes issues with converting nested lists between bullet and numbered.", + "user": { + "login": "rabbabansh", + "id": 31804810, + "node_id": "MDQ6VXNlcjMxODA0ODEw", + "avatar_url": "https://avatars.githubusercontent.com/u/31804810?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/rabbabansh", + "html_url": "https://github.com/rabbabansh", + "followers_url": "https://api.github.com/users/rabbabansh/followers", + "following_url": "https://api.github.com/users/rabbabansh/following{/other_user}", + "gists_url": "https://api.github.com/users/rabbabansh/gists{/gist_id}", + "starred_url": "https://api.github.com/users/rabbabansh/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/rabbabansh/subscriptions", + "organizations_url": "https://api.github.com/users/rabbabansh/orgs", + "repos_url": "https://api.github.com/users/rabbabansh/repos", + "events_url": "https://api.github.com/users/rabbabansh/events{/privacy}", + "received_events_url": "https://api.github.com/users/rabbabansh/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 13, + "created_at": "2025-02-18T20:32:05Z", + "updated_at": "2025-03-27T14:29:38Z", + "closed_at": "2025-03-27T14:29:14Z", + "author_association": "NONE", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11857", + "html_url": "https://github.com/laurent22/joplin/pull/11857", + "diff_url": "https://github.com/laurent22/joplin/pull/11857.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11857.patch", + "merged_at": null + }, + "body": "\r\n\r\nFixes #11845 now, this\"\r\n\r\n- test\r\n - test\r\n - test\r\n- test\r\n\r\nconverts to:\r\n\r\n![Image](https://github.com/user-attachments/assets/a67555fa-d146-40cb-a003-b41b32266f14)\r\n\r\nChecklists also convert nested lists fully, rather than just converting the first indent to checklists.", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11857/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11857/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2666870893", + "html_url": "https://github.com/laurent22/joplin/pull/11857#issuecomment-2666870893", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11857", + "id": 2666870893, + "node_id": "IC_kwDOBLftOs6e9Tht", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-18T20:32:22Z", + "updated_at": "2025-03-27T14:29:37Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2666870893/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2666874335", + "html_url": "https://github.com/laurent22/joplin/pull/11857#issuecomment-2666874335", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11857", + "id": 2666874335, + "node_id": "IC_kwDOBLftOs6e9UXf", + "user": { + "login": "rabbabansh", + "id": 31804810, + "node_id": "MDQ6VXNlcjMxODA0ODEw", + "avatar_url": "https://avatars.githubusercontent.com/u/31804810?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/rabbabansh", + "html_url": "https://github.com/rabbabansh", + "followers_url": "https://api.github.com/users/rabbabansh/followers", + "following_url": "https://api.github.com/users/rabbabansh/following{/other_user}", + "gists_url": "https://api.github.com/users/rabbabansh/gists{/gist_id}", + "starred_url": "https://api.github.com/users/rabbabansh/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/rabbabansh/subscriptions", + "organizations_url": "https://api.github.com/users/rabbabansh/orgs", + "repos_url": "https://api.github.com/users/rabbabansh/repos", + "events_url": "https://api.github.com/users/rabbabansh/events{/privacy}", + "received_events_url": "https://api.github.com/users/rabbabansh/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-18T20:34:26Z", + "updated_at": "2025-02-18T20:34:26Z", + "author_association": "NONE", + "body": "I have read the CLA Document and I hereby sign the CLA.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2666874335/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2669245353", + "html_url": "https://github.com/laurent22/joplin/pull/11857#issuecomment-2669245353", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11857", + "id": 2669245353, + "node_id": "IC_kwDOBLftOs6fGXOp", + "user": { + "login": "personalizedrefrigerator", + "id": 46334387, + "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", + "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/personalizedrefrigerator", + "html_url": "https://github.com/personalizedrefrigerator", + "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", + "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", + "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", + "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", + "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", + "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", + "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", + "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-19T17:04:32Z", + "updated_at": "2025-02-19T17:04:32Z", + "author_association": "COLLABORATOR", + "body": "Thank you for working on this! Be sure to also update the automated tests in `packages/editor/` with the expected output.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2669245353/reactions", + "total_count": 1, + "+1": 1, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2686501181", + "html_url": "https://github.com/laurent22/joplin/pull/11857#issuecomment-2686501181", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11857", + "id": 2686501181, + "node_id": "IC_kwDOBLftOs6gIME9", + "user": { + "login": "rabbabansh", + "id": 31804810, + "node_id": "MDQ6VXNlcjMxODA0ODEw", + "avatar_url": "https://avatars.githubusercontent.com/u/31804810?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/rabbabansh", + "html_url": "https://github.com/rabbabansh", + "followers_url": "https://api.github.com/users/rabbabansh/followers", + "following_url": "https://api.github.com/users/rabbabansh/following{/other_user}", + "gists_url": "https://api.github.com/users/rabbabansh/gists{/gist_id}", + "starred_url": "https://api.github.com/users/rabbabansh/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/rabbabansh/subscriptions", + "organizations_url": "https://api.github.com/users/rabbabansh/orgs", + "repos_url": "https://api.github.com/users/rabbabansh/repos", + "events_url": "https://api.github.com/users/rabbabansh/events{/privacy}", + "received_events_url": "https://api.github.com/users/rabbabansh/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-27T00:21:46Z", + "updated_at": "2025-02-27T00:21:46Z", + "author_association": "NONE", + "body": "Done! Please review", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2686501181/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2686740124", + "html_url": "https://github.com/laurent22/joplin/pull/11857#issuecomment-2686740124", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11857", + "id": 2686740124, + "node_id": "IC_kwDOBLftOs6gJGac", + "user": { + "login": "personalizedrefrigerator", + "id": 46334387, + "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", + "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/personalizedrefrigerator", + "html_url": "https://github.com/personalizedrefrigerator", + "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", + "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", + "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", + "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", + "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", + "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", + "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", + "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-27T03:08:09Z", + "updated_at": "2025-02-27T03:08:09Z", + "author_association": "COLLABORATOR", + "body": "Thank you! Be sure to update the existing tests, too — one is failing:\r\n```\r\n➤ YN0000: [@joplin/editor]: FAIL CodeMirror/markdown/markdownCommands.toggleList.test.ts\r\n➤ YN0000: [@joplin/editor]: ● markdownCommands.toggleList › should toggle a numbered list without changing its sublists\r\n➤ YN0000: [@joplin/editor]: \r\n➤ YN0000: [@joplin/editor]: expect(received).toBe(expected) // Object.is equality\r\n➤ YN0000: [@joplin/editor]: \r\n➤ YN0000: [@joplin/editor]: - Expected - 3\r\n➤ YN0000: [@joplin/editor]: + Received + 3\r\n➤ YN0000: [@joplin/editor]: \r\n➤ YN0000: [@joplin/editor]: - [ ] Foo\r\n➤ YN0000: [@joplin/editor]: - [ ] Bar\r\n➤ YN0000: [@joplin/editor]: - [ ] Baz\r\n➤ YN0000: [@joplin/editor]: - \t- Test\r\n➤ YN0000: [@joplin/editor]: + \t- [ ] Test\r\n➤ YN0000: [@joplin/editor]: - \t- of\r\n➤ YN0000: [@joplin/editor]: + \t- [ ] of\r\n➤ YN0000: [@joplin/editor]: - \t- sublists\r\n➤ YN0000: [@joplin/editor]: + \t- [ ] sublists\r\n➤ YN0000: [@joplin/editor]: - [ ] Foo\r\n➤ YN0000: [@joplin/editor]: \r\n➤ YN0000: [@joplin/editor]: 191 |\r\n➤ YN0000: [@joplin/editor]: 192 | \t\ttoggleList(ListType.CheckList)(editor);\r\n➤ YN0000: [@joplin/editor]: > 193 | \t\texpect(editor.state.doc.toString()).toBe(\r\n➤ YN0000: [@joplin/editor]: | \t\t ^\r\n➤ YN0000: [@joplin/editor]: 194 | \t\t\t'- [ ] Foo\\n- [ ] Bar\\n- [ ] Baz\\n\\t- Test\\n\\t- of\\n\\t- sublists\\n- [ ] Foo',\r\n➤ YN0000: [@joplin/editor]: 195 | \t\t);\r\n➤ YN0000: [@joplin/editor]: 196 | \t});\r\n➤ YN0000: [@joplin/editor]: \r\n➤ YN0000: [@joplin/editor]: at Object. (CodeMirror/markdown/markdownCommands.toggleList.test.ts:193:39)\r\n```", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2686740124/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2687865469", + "html_url": "https://github.com/laurent22/joplin/pull/11857#issuecomment-2687865469", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11857", + "id": 2687865469, + "node_id": "IC_kwDOBLftOs6gNZJ9", + "user": { + "login": "rabbabansh", + "id": 31804810, + "node_id": "MDQ6VXNlcjMxODA0ODEw", + "avatar_url": "https://avatars.githubusercontent.com/u/31804810?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/rabbabansh", + "html_url": "https://github.com/rabbabansh", + "followers_url": "https://api.github.com/users/rabbabansh/followers", + "following_url": "https://api.github.com/users/rabbabansh/following{/other_user}", + "gists_url": "https://api.github.com/users/rabbabansh/gists{/gist_id}", + "starred_url": "https://api.github.com/users/rabbabansh/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/rabbabansh/subscriptions", + "organizations_url": "https://api.github.com/users/rabbabansh/orgs", + "repos_url": "https://api.github.com/users/rabbabansh/repos", + "events_url": "https://api.github.com/users/rabbabansh/events{/privacy}", + "received_events_url": "https://api.github.com/users/rabbabansh/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-27T12:47:44Z", + "updated_at": "2025-02-27T12:47:44Z", + "author_association": "NONE", + "body": "That tests passes now! I rewrote the expected results for a nested checklist that gives checklists to the sublists as well.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2687865469/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2688789478", + "html_url": "https://github.com/laurent22/joplin/pull/11857#issuecomment-2688789478", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11857", + "id": 2688789478, + "node_id": "IC_kwDOBLftOs6gQ6vm", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-27T18:35:09Z", + "updated_at": "2025-02-27T18:35:09Z", + "author_association": "OWNER", + "body": "@personalizedrefrigerator, please let me know when you think it's ready to merge, as I don't know enough about the CM6 implementation to review", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2688789478/reactions", + "total_count": 1, + "+1": 1, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2692729176", + "html_url": "https://github.com/laurent22/joplin/pull/11857#issuecomment-2692729176", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11857", + "id": 2692729176, + "node_id": "IC_kwDOBLftOs6gf8lY", + "user": { + "login": "rabbabansh", + "id": 31804810, + "node_id": "MDQ6VXNlcjMxODA0ODEw", + "avatar_url": "https://avatars.githubusercontent.com/u/31804810?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/rabbabansh", + "html_url": "https://github.com/rabbabansh", + "followers_url": "https://api.github.com/users/rabbabansh/followers", + "following_url": "https://api.github.com/users/rabbabansh/following{/other_user}", + "gists_url": "https://api.github.com/users/rabbabansh/gists{/gist_id}", + "starred_url": "https://api.github.com/users/rabbabansh/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/rabbabansh/subscriptions", + "organizations_url": "https://api.github.com/users/rabbabansh/orgs", + "repos_url": "https://api.github.com/users/rabbabansh/repos", + "events_url": "https://api.github.com/users/rabbabansh/events{/privacy}", + "received_events_url": "https://api.github.com/users/rabbabansh/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-02T13:18:51Z", + "updated_at": "2025-03-02T13:18:51Z", + "author_association": "NONE", + "body": "any updates @personalizedrefrigerator ?", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2692729176/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2692857697", + "html_url": "https://github.com/laurent22/joplin/pull/11857#issuecomment-2692857697", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11857", + "id": 2692857697, + "node_id": "IC_kwDOBLftOs6ggb9h", + "user": { + "login": "personalizedrefrigerator", + "id": 46334387, + "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", + "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/personalizedrefrigerator", + "html_url": "https://github.com/personalizedrefrigerator", + "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", + "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", + "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", + "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", + "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", + "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", + "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", + "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-02T18:53:16Z", + "updated_at": "2025-03-02T18:53:16Z", + "author_association": "COLLABORATOR", + "body": "> any updates @personalizedrefrigerator ?\r\n\r\nThe code looks good to me! I plan to test the change locally before approving the pull request.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2692857697/reactions", + "total_count": 1, + "+1": 1, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2695783056", + "html_url": "https://github.com/laurent22/joplin/pull/11857#issuecomment-2695783056", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11857", + "id": 2695783056, + "node_id": "IC_kwDOBLftOs6grmKQ", + "user": { + "login": "personalizedrefrigerator", + "id": 46334387, + "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", + "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/personalizedrefrigerator", + "html_url": "https://github.com/personalizedrefrigerator", + "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", + "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", + "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", + "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", + "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", + "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", + "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", + "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-03T23:16:03Z", + "updated_at": "2025-03-03T23:17:10Z", + "author_association": "COLLABORATOR", + "body": "I've tested this locally. I've noticed that changing the list type with the cursor anywhere in the toplevel list (with an empty selection) changes the list types of all sublists. The description of #11845 includes only the case where all text is selected.\r\n - **Note**: This is different from how Joplin's Rich Text Editor behaves and thus may not be desired behavior (but to be confirmed by @laurent22). For comparison, moving the cursor to a bulleted list in the Rich Text Editor with bulleted sublists, then clicking \"numbered list\" only changes the outer list.\r\n - For example, with this pull request clicking \"numbered list\" with the following\r\n ```\r\n - This is a test. Cursor here ->> |\r\n - Sublist\r\n - Sub sublist.\r\n - Testing\r\n - Test.\r\n ```\r\n produces\r\n ```\r\n 1. This is a test. Cursor here ->> |\r\n 1. Sublist\r\n 1. Sub sublist.\r\n 2. Testing\r\n 3. Test.\r\n ```\r\n Whereas in the Rich Text Editor, it would preserve the bulleted sublists.\r\n\r\nThank you @rabbabansh for the work you've done on this so far!", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2695783056/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2708236936", + "html_url": "https://github.com/laurent22/joplin/pull/11857#issuecomment-2708236936", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11857", + "id": 2708236936, + "node_id": "IC_kwDOBLftOs6hbGqI", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-08T12:13:42Z", + "updated_at": "2025-03-08T12:13:42Z", + "author_association": "OWNER", + "body": "Not sure what's best here? What do other editors do in this situation?", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2708236936/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2727304447", + "html_url": "https://github.com/laurent22/joplin/pull/11857#issuecomment-2727304447", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11857", + "id": 2727304447, + "node_id": "IC_kwDOBLftOs6ij1z_", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-16T09:51:06Z", + "updated_at": "2025-03-16T09:51:06Z", + "author_association": "OWNER", + "body": "> Note: This is different from how Joplin's Rich Text Editor behaves and thus may not be desired behavior (but to be confirmed by @laurent22). For comparison, moving the cursor to a bulleted list in the Rich Text Editor with bulleted sublists, then clicking \"numbered list\" only changes the outer list.\r\n\r\nI agree that's not ideal. I think as a general rule we should limit all kind of \"smart\" behaviour when it comes to lists so in this case it should:\r\n\r\n- Either changes only what's selected\r\n- Or if nothing is selected it should just change the current line\r\n\r\nAnything else may or may not be what the user wants and we should avoid that. I'd rather have the editor be more plain but with a predictable behaviour.\r\n\r\n@rabbabansh, are you able to complete this pull request?", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2727304447/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2758269361", + "html_url": "https://github.com/laurent22/joplin/pull/11857#issuecomment-2758269361", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11857", + "id": 2758269361, + "node_id": "IC_kwDOBLftOs6kZ9mx", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-27T14:29:15Z", + "updated_at": "2025-03-27T14:29:15Z", + "author_association": "OWNER", + "body": "Closing stale pull request", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2758269361/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/rathoreSahil_90506484.json b/readme/cla/consent_records/rathoreSahil_90506484.json new file mode 100644 index 0000000000..f8f9f52828 --- /dev/null +++ b/readme/cla/consent_records/rathoreSahil_90506484.json @@ -0,0 +1,317 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11828", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11828/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11828/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11828/events", + "html_url": "https://github.com/laurent22/joplin/pull/11828", + "id": 2848689941, + "node_id": "PR_kwDOBLftOs6K-vZi", + "number": 11828, + "title": "Mobile: Fixes #11827: Canceling dev plugin path setup shows error", + "user": { + "login": "rathoreSahil", + "id": 90506484, + "node_id": "MDQ6VXNlcjkwNTA2NDg0", + "avatar_url": "https://avatars.githubusercontent.com/u/90506484?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/rathoreSahil", + "html_url": "https://github.com/rathoreSahil", + "followers_url": "https://api.github.com/users/rathoreSahil/followers", + "following_url": "https://api.github.com/users/rathoreSahil/following{/other_user}", + "gists_url": "https://api.github.com/users/rathoreSahil/gists{/gist_id}", + "starred_url": "https://api.github.com/users/rathoreSahil/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/rathoreSahil/subscriptions", + "organizations_url": "https://api.github.com/users/rathoreSahil/orgs", + "repos_url": "https://api.github.com/users/rathoreSahil/repos", + "events_url": "https://api.github.com/users/rathoreSahil/events{/privacy}", + "received_events_url": "https://api.github.com/users/rathoreSahil/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 3, + "created_at": "2025-02-12T16:00:18Z", + "updated_at": "2025-02-12T20:01:58Z", + "closed_at": "2025-02-12T20:01:44Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11828", + "html_url": "https://github.com/laurent22/joplin/pull/11828", + "diff_url": "https://github.com/laurent22/joplin/pull/11828.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11828.patch", + "merged_at": "2025-02-12T20:01:44Z" + }, + "body": "# What It Does\r\nFixes the following issue\r\n### Trying to set development plugin path and then cancelling displays an error page #11827\r\n* In Settings => Plugins => Advanced settings.\r\n* Click on \"Development plugins\"\r\n* Cancel the dialog\r\n-> An error message is displayed\r\n\r\n# How it does it\r\nThe showDirectoryPicker method throws AbortError when user dismisses the prompt without making a selection. The method was not wrapped in a try catch block to handle the error.\r\nThis pr fixes the same by wrapping up showDirectoryPicker call inside a try catch block.\r\n\r\n- References: [Window: showDirectoryPicker() method](https://developer.mozilla.org/en-US/docs/Web/API/Window/showDirectoryPicker)\r\n\r\n# Video\r\n\r\n## Before\r\nhttps://github.com/user-attachments/assets/3a9ae68c-f83e-487b-9461-b5ac44e13b89\r\n\r\n## After\r\nhttps://github.com/user-attachments/assets/2858b4a5-e3ba-4437-be39-3aa72d6825f6", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11828/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11828/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2654155183", + "html_url": "https://github.com/laurent22/joplin/pull/11828#issuecomment-2654155183", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11828", + "id": 2654155183, + "node_id": "IC_kwDOBLftOs6eMzGv", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-12T16:00:54Z", + "updated_at": "2025-02-12T20:01:58Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2654155183/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2654174649", + "html_url": "https://github.com/laurent22/joplin/pull/11828#issuecomment-2654174649", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11828", + "id": 2654174649, + "node_id": "IC_kwDOBLftOs6eM325", + "user": { + "login": "rathoreSahil", + "id": 90506484, + "node_id": "MDQ6VXNlcjkwNTA2NDg0", + "avatar_url": "https://avatars.githubusercontent.com/u/90506484?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/rathoreSahil", + "html_url": "https://github.com/rathoreSahil", + "followers_url": "https://api.github.com/users/rathoreSahil/followers", + "following_url": "https://api.github.com/users/rathoreSahil/following{/other_user}", + "gists_url": "https://api.github.com/users/rathoreSahil/gists{/gist_id}", + "starred_url": "https://api.github.com/users/rathoreSahil/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/rathoreSahil/subscriptions", + "organizations_url": "https://api.github.com/users/rathoreSahil/orgs", + "repos_url": "https://api.github.com/users/rathoreSahil/repos", + "events_url": "https://api.github.com/users/rathoreSahil/events{/privacy}", + "received_events_url": "https://api.github.com/users/rathoreSahil/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-12T16:07:37Z", + "updated_at": "2025-02-12T16:07:37Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2654174649/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2654175544", + "html_url": "https://github.com/laurent22/joplin/pull/11828#issuecomment-2654175544", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11828", + "id": 2654175544, + "node_id": "IC_kwDOBLftOs6eM4E4", + "user": { + "login": "rathoreSahil", + "id": 90506484, + "node_id": "MDQ6VXNlcjkwNTA2NDg0", + "avatar_url": "https://avatars.githubusercontent.com/u/90506484?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/rathoreSahil", + "html_url": "https://github.com/rathoreSahil", + "followers_url": "https://api.github.com/users/rathoreSahil/followers", + "following_url": "https://api.github.com/users/rathoreSahil/following{/other_user}", + "gists_url": "https://api.github.com/users/rathoreSahil/gists{/gist_id}", + "starred_url": "https://api.github.com/users/rathoreSahil/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/rathoreSahil/subscriptions", + "organizations_url": "https://api.github.com/users/rathoreSahil/orgs", + "repos_url": "https://api.github.com/users/rathoreSahil/repos", + "events_url": "https://api.github.com/users/rathoreSahil/events{/privacy}", + "received_events_url": "https://api.github.com/users/rathoreSahil/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-12T16:07:55Z", + "updated_at": "2025-02-12T16:07:55Z", + "author_association": "CONTRIBUTOR", + "body": "recheck", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2654175544/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/rcrisanti_27363609.json b/readme/cla/consent_records/rcrisanti_27363609.json new file mode 100644 index 0000000000..d67a4a1779 --- /dev/null +++ b/readme/cla/consent_records/rcrisanti_27363609.json @@ -0,0 +1,362 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11531", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11531/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11531/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11531/events", + "html_url": "https://github.com/laurent22/joplin/pull/11531", + "id": 2745663384, + "node_id": "PR_kwDOBLftOs6FiHol", + "number": 11531, + "title": "Server: allow self-signed certificate for ldap auth", + "user": { + "login": "rcrisanti", + "id": 27363609, + "node_id": "MDQ6VXNlcjI3MzYzNjA5", + "avatar_url": "https://avatars.githubusercontent.com/u/27363609?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/rcrisanti", + "html_url": "https://github.com/rcrisanti", + "followers_url": "https://api.github.com/users/rcrisanti/followers", + "following_url": "https://api.github.com/users/rcrisanti/following{/other_user}", + "gists_url": "https://api.github.com/users/rcrisanti/gists{/gist_id}", + "starred_url": "https://api.github.com/users/rcrisanti/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/rcrisanti/subscriptions", + "organizations_url": "https://api.github.com/users/rcrisanti/orgs", + "repos_url": "https://api.github.com/users/rcrisanti/repos", + "events_url": "https://api.github.com/users/rcrisanti/events{/privacy}", + "received_events_url": "https://api.github.com/users/rcrisanti/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 4, + "created_at": "2024-12-17T18:08:38Z", + "updated_at": "2024-12-19T13:44:54Z", + "closed_at": "2024-12-19T13:44:37Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11531", + "html_url": "https://github.com/laurent22/joplin/pull/11531", + "diff_url": "https://github.com/laurent22/joplin/pull/11531.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11531.patch", + "merged_at": "2024-12-19T13:44:37Z" + }, + "body": "\r\n\r\nThis adds the ability to specify a local certificate file for using the [LDAP authentication](https://github.com/laurent22/joplin/pull/9150) with a self-signed certificate. This was first proposed in the forum [here](https://discourse.joplinapp.org/t/joplin-server-ldap-self-signed-certificate/42417). It adds new env variables (`LDAP_1_TLS_CA_FILE` & `LDAP_2_TLS_CA_FILE`) that can point to the appropriate public key.\r\n\r\nI'm not sure if there is any way to include a test for this, but I tested it locally and it seems to be working well.", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11531/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11531/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2549330896", + "html_url": "https://github.com/laurent22/joplin/pull/11531#issuecomment-2549330896", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11531", + "id": 2549330896, + "node_id": "IC_kwDOBLftOs6X87PQ", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-17T18:51:16Z", + "updated_at": "2024-12-19T13:44:54Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2549330896/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2549340653", + "html_url": "https://github.com/laurent22/joplin/pull/11531#issuecomment-2549340653", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11531", + "id": 2549340653, + "node_id": "IC_kwDOBLftOs6X89nt", + "user": { + "login": "rcrisanti", + "id": 27363609, + "node_id": "MDQ6VXNlcjI3MzYzNjA5", + "avatar_url": "https://avatars.githubusercontent.com/u/27363609?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/rcrisanti", + "html_url": "https://github.com/rcrisanti", + "followers_url": "https://api.github.com/users/rcrisanti/followers", + "following_url": "https://api.github.com/users/rcrisanti/following{/other_user}", + "gists_url": "https://api.github.com/users/rcrisanti/gists{/gist_id}", + "starred_url": "https://api.github.com/users/rcrisanti/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/rcrisanti/subscriptions", + "organizations_url": "https://api.github.com/users/rcrisanti/orgs", + "repos_url": "https://api.github.com/users/rcrisanti/repos", + "events_url": "https://api.github.com/users/rcrisanti/events{/privacy}", + "received_events_url": "https://api.github.com/users/rcrisanti/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-17T18:54:46Z", + "updated_at": "2024-12-17T18:54:46Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2549340653/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2549348341", + "html_url": "https://github.com/laurent22/joplin/pull/11531#issuecomment-2549348341", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11531", + "id": 2549348341, + "node_id": "IC_kwDOBLftOs6X8_f1", + "user": { + "login": "rcrisanti", + "id": 27363609, + "node_id": "MDQ6VXNlcjI3MzYzNjA5", + "avatar_url": "https://avatars.githubusercontent.com/u/27363609?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/rcrisanti", + "html_url": "https://github.com/rcrisanti", + "followers_url": "https://api.github.com/users/rcrisanti/followers", + "following_url": "https://api.github.com/users/rcrisanti/following{/other_user}", + "gists_url": "https://api.github.com/users/rcrisanti/gists{/gist_id}", + "starred_url": "https://api.github.com/users/rcrisanti/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/rcrisanti/subscriptions", + "organizations_url": "https://api.github.com/users/rcrisanti/orgs", + "repos_url": "https://api.github.com/users/rcrisanti/repos", + "events_url": "https://api.github.com/users/rcrisanti/events{/privacy}", + "received_events_url": "https://api.github.com/users/rcrisanti/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-17T18:56:18Z", + "updated_at": "2024-12-17T18:56:18Z", + "author_association": "CONTRIBUTOR", + "body": "recheck", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2549348341/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2554065085", + "html_url": "https://github.com/laurent22/joplin/pull/11531#issuecomment-2554065085", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11531", + "id": 2554065085, + "node_id": "IC_kwDOBLftOs6YO_C9", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-19T13:44:27Z", + "updated_at": "2024-12-19T13:44:27Z", + "author_association": "OWNER", + "body": "That looks good now, thank you for implementing this!", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2554065085/reactions", + "total_count": 1, + "+1": 1, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/redrathnure_643360.json b/readme/cla/consent_records/redrathnure_643360.json new file mode 100644 index 0000000000..2e2b33eb09 --- /dev/null +++ b/readme/cla/consent_records/redrathnure_643360.json @@ -0,0 +1,317 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11554", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11554/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11554/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11554/events", + "html_url": "https://github.com/laurent22/joplin/pull/11554", + "id": 2754897979, + "node_id": "PR_kwDOBLftOs6GBmJu", + "number": 11554, + "title": "Server: use node:18 (bookworm) instead node:18-bullseye", + "user": { + "login": "redrathnure", + "id": 643360, + "node_id": "MDQ6VXNlcjY0MzM2MA==", + "avatar_url": "https://avatars.githubusercontent.com/u/643360?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/redrathnure", + "html_url": "https://github.com/redrathnure", + "followers_url": "https://api.github.com/users/redrathnure/followers", + "following_url": "https://api.github.com/users/redrathnure/following{/other_user}", + "gists_url": "https://api.github.com/users/redrathnure/gists{/gist_id}", + "starred_url": "https://api.github.com/users/redrathnure/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/redrathnure/subscriptions", + "organizations_url": "https://api.github.com/users/redrathnure/orgs", + "repos_url": "https://api.github.com/users/redrathnure/repos", + "events_url": "https://api.github.com/users/redrathnure/events{/privacy}", + "received_events_url": "https://api.github.com/users/redrathnure/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 3, + "created_at": "2024-12-22T23:32:31Z", + "updated_at": "2025-01-09T15:41:48Z", + "closed_at": "2025-01-09T15:25:57Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11554", + "html_url": "https://github.com/laurent22/joplin/pull/11554", + "diff_url": "https://github.com/laurent22/joplin/pull/11554.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11554.patch", + "merged_at": "2025-01-09T15:25:57Z" + }, + "body": "Joplin server is built on Bullseye based images. This Debian distributive has \"old stable\" status and related docker images have significantly bigger amount of vulnerabilities (the both full and slim images, please see a dockerhub statistic for more details).\r\n\r\nThe proposed version do not use explicit distro name in image tag which allow to using latest stable distro automatically. \r\n\r\nAs bonus, looks like bookworm slim image has slightly smaller size.\r\n", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11554/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11554/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2558647571", + "html_url": "https://github.com/laurent22/joplin/pull/11554#issuecomment-2558647571", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11554", + "id": 2558647571, + "node_id": "IC_kwDOBLftOs6Ygd0T", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-22T23:32:47Z", + "updated_at": "2025-01-09T15:41:48Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2558647571/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2558648968", + "html_url": "https://github.com/laurent22/joplin/pull/11554#issuecomment-2558648968", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11554", + "id": 2558648968, + "node_id": "IC_kwDOBLftOs6YgeKI", + "user": { + "login": "redrathnure", + "id": 643360, + "node_id": "MDQ6VXNlcjY0MzM2MA==", + "avatar_url": "https://avatars.githubusercontent.com/u/643360?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/redrathnure", + "html_url": "https://github.com/redrathnure", + "followers_url": "https://api.github.com/users/redrathnure/followers", + "following_url": "https://api.github.com/users/redrathnure/following{/other_user}", + "gists_url": "https://api.github.com/users/redrathnure/gists{/gist_id}", + "starred_url": "https://api.github.com/users/redrathnure/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/redrathnure/subscriptions", + "organizations_url": "https://api.github.com/users/redrathnure/orgs", + "repos_url": "https://api.github.com/users/redrathnure/repos", + "events_url": "https://api.github.com/users/redrathnure/events{/privacy}", + "received_events_url": "https://api.github.com/users/redrathnure/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-22T23:36:27Z", + "updated_at": "2024-12-22T23:36:27Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2558648968/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2580559718", + "html_url": "https://github.com/laurent22/joplin/pull/11554#issuecomment-2580559718", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11554", + "id": 2580559718, + "node_id": "IC_kwDOBLftOs6Z0Ddm", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-01-09T15:25:53Z", + "updated_at": "2025-01-09T15:25:53Z", + "author_association": "OWNER", + "body": "That makes sense, thanks for updating this!", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2580559718/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/sudokillnine_46093340.json b/readme/cla/consent_records/sudokillnine_46093340.json new file mode 100644 index 0000000000..726ad2c50a --- /dev/null +++ b/readme/cla/consent_records/sudokillnine_46093340.json @@ -0,0 +1,507 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11889", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11889/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11889/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11889/events", + "html_url": "https://github.com/laurent22/joplin/pull/11889", + "id": 2882287192, + "node_id": "PR_kwDOBLftOs6MriPL", + "number": 11889, + "title": "Desktop: Fix issue on fedora with install script.", + "user": { + "login": "sudokillnine", + "id": 46093340, + "node_id": "MDQ6VXNlcjQ2MDkzMzQw", + "avatar_url": "https://avatars.githubusercontent.com/u/46093340?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/sudokillnine", + "html_url": "https://github.com/sudokillnine", + "followers_url": "https://api.github.com/users/sudokillnine/followers", + "following_url": "https://api.github.com/users/sudokillnine/following{/other_user}", + "gists_url": "https://api.github.com/users/sudokillnine/gists{/gist_id}", + "starred_url": "https://api.github.com/users/sudokillnine/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/sudokillnine/subscriptions", + "organizations_url": "https://api.github.com/users/sudokillnine/orgs", + "repos_url": "https://api.github.com/users/sudokillnine/repos", + "events_url": "https://api.github.com/users/sudokillnine/events{/privacy}", + "received_events_url": "https://api.github.com/users/sudokillnine/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [ + { + "id": 1366671832, + "node_id": "MDU6TGFiZWwxMzY2NjcxODMy", + "url": "https://api.github.com/repos/laurent22/joplin/labels/linux", + "name": "linux", + "color": "bfd4f2", + "default": false, + "description": "" + } + ], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 7, + "created_at": "2025-02-26T17:17:24Z", + "updated_at": "2025-03-04T01:51:46Z", + "closed_at": "2025-03-04T01:51:32Z", + "author_association": "NONE", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11889", + "html_url": "https://github.com/laurent22/joplin/pull/11889", + "diff_url": "https://github.com/laurent22/joplin/pull/11889.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11889.patch", + "merged_at": null + }, + "body": "No issue created, the header of the script asks for direct PR.\r\n\r\nIssue on fedora 40 with the installation script. It looks like wget is not in the repository anymore.\r\n\r\nProblem solved with curl which should be more common over different Os.", + "closed_by": { + "login": "tessus", + "id": 223439, + "node_id": "MDQ6VXNlcjIyMzQzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tessus", + "html_url": "https://github.com/tessus", + "followers_url": "https://api.github.com/users/tessus/followers", + "following_url": "https://api.github.com/users/tessus/following{/other_user}", + "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", + "organizations_url": "https://api.github.com/users/tessus/orgs", + "repos_url": "https://api.github.com/users/tessus/repos", + "events_url": "https://api.github.com/users/tessus/events{/privacy}", + "received_events_url": "https://api.github.com/users/tessus/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11889/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11889/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2685706684", + "html_url": "https://github.com/laurent22/joplin/pull/11889#issuecomment-2685706684", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11889", + "id": 2685706684, + "node_id": "IC_kwDOBLftOs6gFKG8", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-26T17:17:39Z", + "updated_at": "2025-03-04T01:51:46Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2685706684/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2685761366", + "html_url": "https://github.com/laurent22/joplin/pull/11889#issuecomment-2685761366", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11889", + "id": 2685761366, + "node_id": "IC_kwDOBLftOs6gFXdW", + "user": { + "login": "sudokillnine", + "id": 46093340, + "node_id": "MDQ6VXNlcjQ2MDkzMzQw", + "avatar_url": "https://avatars.githubusercontent.com/u/46093340?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/sudokillnine", + "html_url": "https://github.com/sudokillnine", + "followers_url": "https://api.github.com/users/sudokillnine/followers", + "following_url": "https://api.github.com/users/sudokillnine/following{/other_user}", + "gists_url": "https://api.github.com/users/sudokillnine/gists{/gist_id}", + "starred_url": "https://api.github.com/users/sudokillnine/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/sudokillnine/subscriptions", + "organizations_url": "https://api.github.com/users/sudokillnine/orgs", + "repos_url": "https://api.github.com/users/sudokillnine/repos", + "events_url": "https://api.github.com/users/sudokillnine/events{/privacy}", + "received_events_url": "https://api.github.com/users/sudokillnine/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-26T17:40:11Z", + "updated_at": "2025-02-26T17:40:11Z", + "author_association": "NONE", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2685761366/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2685761959", + "html_url": "https://github.com/laurent22/joplin/pull/11889#issuecomment-2685761959", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11889", + "id": 2685761959, + "node_id": "IC_kwDOBLftOs6gFXmn", + "user": { + "login": "sudokillnine", + "id": 46093340, + "node_id": "MDQ6VXNlcjQ2MDkzMzQw", + "avatar_url": "https://avatars.githubusercontent.com/u/46093340?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/sudokillnine", + "html_url": "https://github.com/sudokillnine", + "followers_url": "https://api.github.com/users/sudokillnine/followers", + "following_url": "https://api.github.com/users/sudokillnine/following{/other_user}", + "gists_url": "https://api.github.com/users/sudokillnine/gists{/gist_id}", + "starred_url": "https://api.github.com/users/sudokillnine/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/sudokillnine/subscriptions", + "organizations_url": "https://api.github.com/users/sudokillnine/orgs", + "repos_url": "https://api.github.com/users/sudokillnine/repos", + "events_url": "https://api.github.com/users/sudokillnine/events{/privacy}", + "received_events_url": "https://api.github.com/users/sudokillnine/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-26T17:40:30Z", + "updated_at": "2025-02-26T17:40:30Z", + "author_association": "NONE", + "body": "recheck", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2685761959/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2685848665", + "html_url": "https://github.com/laurent22/joplin/pull/11889#issuecomment-2685848665", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11889", + "id": 2685848665, + "node_id": "IC_kwDOBLftOs6gFsxZ", + "user": { + "login": "personalizedrefrigerator", + "id": 46334387, + "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", + "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/personalizedrefrigerator", + "html_url": "https://github.com/personalizedrefrigerator", + "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", + "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", + "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", + "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", + "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", + "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", + "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", + "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-26T18:21:14Z", + "updated_at": "2025-02-26T18:21:14Z", + "author_association": "COLLABORATOR", + "body": "Thank you for the pull request!\r\n\r\nA few notes:\r\n- **Ubuntu incompatibility**: Be aware that Ubuntu 24.04, at least on my system, doesn't have `curl` by default.\r\n- **Issue doesn't happen on Fedora 41 (KDE)** I'm unable to reproduce this on Fedora 41. Does the issue occur with the installation script from the `dev` branch? (Some users have experienced issues with the [script on the `master` branch, which is very old](https://github.com/laurent22/joplin/blob/master/Joplin_install_and_update.sh)).", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2685848665/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2685875698", + "html_url": "https://github.com/laurent22/joplin/pull/11889#issuecomment-2685875698", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11889", + "id": 2685875698, + "node_id": "IC_kwDOBLftOs6gFzXy", + "user": { + "login": "sudokillnine", + "id": 46093340, + "node_id": "MDQ6VXNlcjQ2MDkzMzQw", + "avatar_url": "https://avatars.githubusercontent.com/u/46093340?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/sudokillnine", + "html_url": "https://github.com/sudokillnine", + "followers_url": "https://api.github.com/users/sudokillnine/followers", + "following_url": "https://api.github.com/users/sudokillnine/following{/other_user}", + "gists_url": "https://api.github.com/users/sudokillnine/gists{/gist_id}", + "starred_url": "https://api.github.com/users/sudokillnine/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/sudokillnine/subscriptions", + "organizations_url": "https://api.github.com/users/sudokillnine/orgs", + "repos_url": "https://api.github.com/users/sudokillnine/repos", + "events_url": "https://api.github.com/users/sudokillnine/events{/privacy}", + "received_events_url": "https://api.github.com/users/sudokillnine/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-26T18:34:52Z", + "updated_at": "2025-02-26T18:34:52Z", + "author_association": "NONE", + "body": "Thank you for the quick feedback !\r\n\r\nOn my side, I was setting up joplin on debian 12 and fedora 40 (Qubes OS templates) and fedora is missing `wget` (not present in repos).\r\n\r\nI may have open the PR to quickly, because I also notice fedora 41 is available as a Qubes template so I will try with it first.\r\n\r\nIf it is still not working on fedora, what do you think about making the script able to handle both command ?\r\nLike if `wget` is present use `wget`, else use `curl`.\r\n\r\n", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2685875698/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2685885677", + "html_url": "https://github.com/laurent22/joplin/pull/11889#issuecomment-2685885677", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11889", + "id": 2685885677, + "node_id": "IC_kwDOBLftOs6gF1zt", + "user": { + "login": "personalizedrefrigerator", + "id": 46334387, + "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", + "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/personalizedrefrigerator", + "html_url": "https://github.com/personalizedrefrigerator", + "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", + "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", + "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", + "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", + "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", + "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", + "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", + "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-26T18:38:20Z", + "updated_at": "2025-02-26T18:38:20Z", + "author_association": "COLLABORATOR", + "body": "> On my side, I was setting up joplin on debian 12 and fedora 40 (Qubes OS templates) and fedora is missing wget (not present in repos).\r\n\r\nFor me, the packages are `wget2` (and possibly `wget2-wget`).", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2685885677/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2695978461", + "html_url": "https://github.com/laurent22/joplin/pull/11889#issuecomment-2695978461", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11889", + "id": 2695978461, + "node_id": "IC_kwDOBLftOs6gsV3d", + "user": { + "login": "tessus", + "id": 223439, + "node_id": "MDQ6VXNlcjIyMzQzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tessus", + "html_url": "https://github.com/tessus", + "followers_url": "https://api.github.com/users/tessus/followers", + "following_url": "https://api.github.com/users/tessus/following{/other_user}", + "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", + "organizations_url": "https://api.github.com/users/tessus/orgs", + "repos_url": "https://api.github.com/users/tessus/repos", + "events_url": "https://api.github.com/users/tessus/events{/privacy}", + "received_events_url": "https://api.github.com/users/tessus/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-04T01:51:32Z", + "updated_at": "2025-03-04T01:51:32Z", + "author_association": "COLLABORATOR", + "body": "Thanks for the PR, since it got me thinking. However, the current implementation is not optimal. I will update the script either tonight or tomorrow to allow the use of wget, wget2, or curl. The issue is that some distros replaced wget with wget2, but did nor set an alias. Some others have neither by default, but use curl.\r\n\r\nEither way, thank you for bringing up this flaw in the script.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2695978461/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/summoner001_11212632.json b/readme/cla/consent_records/summoner001_11212632.json new file mode 100644 index 0000000000..4e7b44cf92 --- /dev/null +++ b/readme/cla/consent_records/summoner001_11212632.json @@ -0,0 +1,362 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11682", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11682/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11682/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11682/events", + "html_url": "https://github.com/laurent22/joplin/pull/11682", + "id": 2797600881, + "node_id": "PR_kwDOBLftOs6IRG8b", + "number": 11682, + "title": "Update hu_HU.po", + "user": { + "login": "summoner001", + "id": 11212632, + "node_id": "MDQ6VXNlcjExMjEyNjMy", + "avatar_url": "https://avatars.githubusercontent.com/u/11212632?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/summoner001", + "html_url": "https://github.com/summoner001", + "followers_url": "https://api.github.com/users/summoner001/followers", + "following_url": "https://api.github.com/users/summoner001/following{/other_user}", + "gists_url": "https://api.github.com/users/summoner001/gists{/gist_id}", + "starred_url": "https://api.github.com/users/summoner001/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/summoner001/subscriptions", + "organizations_url": "https://api.github.com/users/summoner001/orgs", + "repos_url": "https://api.github.com/users/summoner001/repos", + "events_url": "https://api.github.com/users/summoner001/events{/privacy}", + "received_events_url": "https://api.github.com/users/summoner001/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 4, + "created_at": "2025-01-19T12:32:03Z", + "updated_at": "2025-01-20T18:00:09Z", + "closed_at": "2025-01-20T17:45:25Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11682", + "html_url": "https://github.com/laurent22/joplin/pull/11682", + "diff_url": "https://github.com/laurent22/joplin/pull/11682.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11682.patch", + "merged_at": "2025-01-20T17:45:25Z" + }, + "body": "Retranslating the Hungarian texts.\r\n\r\nFix old translation\r\nFix coherence\r\n\r\nIf the new translation merged into Joplin, I will debug the new strings (text long etc...)\r\n\r\n", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11682/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11682/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2600840613", + "html_url": "https://github.com/laurent22/joplin/pull/11682#issuecomment-2600840613", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11682", + "id": 2600840613, + "node_id": "IC_kwDOBLftOs6bBa2l", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-01-19T12:32:19Z", + "updated_at": "2025-01-20T17:45:36Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2600840613/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2600843602", + "html_url": "https://github.com/laurent22/joplin/pull/11682#issuecomment-2600843602", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11682", + "id": 2600843602, + "node_id": "IC_kwDOBLftOs6bBblS", + "user": { + "login": "summoner001", + "id": 11212632, + "node_id": "MDQ6VXNlcjExMjEyNjMy", + "avatar_url": "https://avatars.githubusercontent.com/u/11212632?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/summoner001", + "html_url": "https://github.com/summoner001", + "followers_url": "https://api.github.com/users/summoner001/followers", + "following_url": "https://api.github.com/users/summoner001/following{/other_user}", + "gists_url": "https://api.github.com/users/summoner001/gists{/gist_id}", + "starred_url": "https://api.github.com/users/summoner001/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/summoner001/subscriptions", + "organizations_url": "https://api.github.com/users/summoner001/orgs", + "repos_url": "https://api.github.com/users/summoner001/repos", + "events_url": "https://api.github.com/users/summoner001/events{/privacy}", + "received_events_url": "https://api.github.com/users/summoner001/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-01-19T12:40:25Z", + "updated_at": "2025-01-19T12:40:25Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2600843602/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2602981582", + "html_url": "https://github.com/laurent22/joplin/pull/11682#issuecomment-2602981582", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11682", + "id": 2602981582, + "node_id": "IC_kwDOBLftOs6bJljO", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-01-20T17:45:22Z", + "updated_at": "2025-01-20T17:45:22Z", + "author_association": "OWNER", + "body": "That looks good, thank you!", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2602981582/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2603002269", + "html_url": "https://github.com/laurent22/joplin/pull/11682#issuecomment-2603002269", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11682", + "id": 2603002269, + "node_id": "IC_kwDOBLftOs6bJqmd", + "user": { + "login": "summoner001", + "id": 11212632, + "node_id": "MDQ6VXNlcjExMjEyNjMy", + "avatar_url": "https://avatars.githubusercontent.com/u/11212632?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/summoner001", + "html_url": "https://github.com/summoner001", + "followers_url": "https://api.github.com/users/summoner001/followers", + "following_url": "https://api.github.com/users/summoner001/following{/other_user}", + "gists_url": "https://api.github.com/users/summoner001/gists{/gist_id}", + "starred_url": "https://api.github.com/users/summoner001/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/summoner001/subscriptions", + "organizations_url": "https://api.github.com/users/summoner001/orgs", + "repos_url": "https://api.github.com/users/summoner001/repos", + "events_url": "https://api.github.com/users/summoner001/events{/privacy}", + "received_events_url": "https://api.github.com/users/summoner001/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-01-20T18:00:08Z", + "updated_at": "2025-01-20T18:00:08Z", + "author_association": "CONTRIBUTOR", + "body": "> That looks good, thank you!\r\n\r\nHi! You are very welcome. I will try to maintain the future texts and correct my own mistakes. The old translation was already in very bad shape. It will now comply with the Hungarian language requirements and the context. I really hope that the Hungarian users of Joplin will also like it.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2603002269/reactions", + "total_count": 1, + "+1": 1, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/tbjgolden_8162045.json b/readme/cla/consent_records/tbjgolden_8162045.json new file mode 100644 index 0000000000..15a94a1505 --- /dev/null +++ b/readme/cla/consent_records/tbjgolden_8162045.json @@ -0,0 +1,542 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12057", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/12057/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/12057/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/12057/events", + "html_url": "https://github.com/laurent22/joplin/pull/12057", + "id": 2974139065, + "node_id": "PR_kwDOBLftOs6RgDb9", + "number": 12057, + "title": "All: Updated translations for en_GB", + "user": { + "login": "tbjgolden", + "id": 8162045, + "node_id": "MDQ6VXNlcjgxNjIwNDU=", + "avatar_url": "https://avatars.githubusercontent.com/u/8162045?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tbjgolden", + "html_url": "https://github.com/tbjgolden", + "followers_url": "https://api.github.com/users/tbjgolden/followers", + "following_url": "https://api.github.com/users/tbjgolden/following{/other_user}", + "gists_url": "https://api.github.com/users/tbjgolden/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tbjgolden/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tbjgolden/subscriptions", + "organizations_url": "https://api.github.com/users/tbjgolden/orgs", + "repos_url": "https://api.github.com/users/tbjgolden/repos", + "events_url": "https://api.github.com/users/tbjgolden/events{/privacy}", + "received_events_url": "https://api.github.com/users/tbjgolden/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 8, + "created_at": "2025-04-05T11:29:24Z", + "updated_at": "2025-04-05T20:28:36Z", + "closed_at": "2025-04-05T13:56:14Z", + "author_association": "NONE", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/12057", + "html_url": "https://github.com/laurent22/joplin/pull/12057", + "diff_url": "https://github.com/laurent22/joplin/pull/12057.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/12057.patch", + "merged_at": null + }, + "body": "- Added explicit confirmed translations for each\r\n- Only word changed was \"trash\" to \"bin\"\r\n\r\n> Windows UK: Recycle Bin, MacOS UK: Bin\r\n>\r\n> \"Screenshot\r\n", + "closed_by": { + "login": "tbjgolden", + "id": 8162045, + "node_id": "MDQ6VXNlcjgxNjIwNDU=", + "avatar_url": "https://avatars.githubusercontent.com/u/8162045?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tbjgolden", + "html_url": "https://github.com/tbjgolden", + "followers_url": "https://api.github.com/users/tbjgolden/followers", + "following_url": "https://api.github.com/users/tbjgolden/following{/other_user}", + "gists_url": "https://api.github.com/users/tbjgolden/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tbjgolden/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tbjgolden/subscriptions", + "organizations_url": "https://api.github.com/users/tbjgolden/orgs", + "repos_url": "https://api.github.com/users/tbjgolden/repos", + "events_url": "https://api.github.com/users/tbjgolden/events{/privacy}", + "received_events_url": "https://api.github.com/users/tbjgolden/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12057/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/12057/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780673598", + "html_url": "https://github.com/laurent22/joplin/pull/12057#issuecomment-2780673598", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12057", + "id": 2780673598, + "node_id": "IC_kwDOBLftOs6lvbY-", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-05T11:29:35Z", + "updated_at": "2025-04-05T13:56:26Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780673598/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780677909", + "html_url": "https://github.com/laurent22/joplin/pull/12057#issuecomment-2780677909", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12057", + "id": 2780677909, + "node_id": "IC_kwDOBLftOs6lvccV", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-05T11:42:11Z", + "updated_at": "2025-04-05T11:43:14Z", + "author_association": "OWNER", + "body": "There are technical challenges with changing \"trash\" to \"bin\" because the changes need to be made in the code, not the .po file. Also Apple has not localised \"Trash\" so it seems reasonable that we don't either. It annoys me a bit that everywhere in the code it will be called \"Trash\" (in functions, variables, etc.), but in user-facing strings it will be called \"Bin\".\r\n\r\nAnd so another issue is we don't modify en_GB.po because it's automatically generated from the code. If there are other strings that need to be changed, you would need to modify them in the .ts/.js files instead.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780677909/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780733298", + "html_url": "https://github.com/laurent22/joplin/pull/12057#issuecomment-2780733298", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12057", + "id": 2780733298, + "node_id": "IC_kwDOBLftOs6lvp9y", + "user": { + "login": "tbjgolden", + "id": 8162045, + "node_id": "MDQ6VXNlcjgxNjIwNDU=", + "avatar_url": "https://avatars.githubusercontent.com/u/8162045?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tbjgolden", + "html_url": "https://github.com/tbjgolden", + "followers_url": "https://api.github.com/users/tbjgolden/followers", + "following_url": "https://api.github.com/users/tbjgolden/following{/other_user}", + "gists_url": "https://api.github.com/users/tbjgolden/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tbjgolden/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tbjgolden/subscriptions", + "organizations_url": "https://api.github.com/users/tbjgolden/orgs", + "repos_url": "https://api.github.com/users/tbjgolden/repos", + "events_url": "https://api.github.com/users/tbjgolden/events{/privacy}", + "received_events_url": "https://api.github.com/users/tbjgolden/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-05T13:49:36Z", + "updated_at": "2025-04-05T13:49:36Z", + "author_association": "NONE", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780733298/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780736036", + "html_url": "https://github.com/laurent22/joplin/pull/12057#issuecomment-2780736036", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12057", + "id": 2780736036, + "node_id": "IC_kwDOBLftOs6lvqok", + "user": { + "login": "tbjgolden", + "id": 8162045, + "node_id": "MDQ6VXNlcjgxNjIwNDU=", + "avatar_url": "https://avatars.githubusercontent.com/u/8162045?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tbjgolden", + "html_url": "https://github.com/tbjgolden", + "followers_url": "https://api.github.com/users/tbjgolden/followers", + "following_url": "https://api.github.com/users/tbjgolden/following{/other_user}", + "gists_url": "https://api.github.com/users/tbjgolden/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tbjgolden/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tbjgolden/subscriptions", + "organizations_url": "https://api.github.com/users/tbjgolden/orgs", + "repos_url": "https://api.github.com/users/tbjgolden/repos", + "events_url": "https://api.github.com/users/tbjgolden/events{/privacy}", + "received_events_url": "https://api.github.com/users/tbjgolden/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-05T13:56:14Z", + "updated_at": "2025-04-05T13:56:14Z", + "author_association": "NONE", + "body": "> There are technical challenges with changing \"trash\" to \"bin\" because the changes need to be made in the code, not the .po file. Also Apple has not localised \"Trash\" so it seems reasonable that we don't either. It annoys me a bit that everywhere in the code it will be called \"Trash\" (in functions, variables, etc.), but in user-facing strings it will be called \"Bin\".\r\n\r\nApple has localised it, hence the screenshot provided. Maybe they haven't localised it consistently? I wonder if, as technical people, we use trash more than typical users because we need to refer to it within our code, e.g. `~/.Trash`? Thanks for explaining the technical and logistical issues.\r\n\r\nOn one hand it's a pure Americanism - I'd wager that if I asked the average non-coder Briton where their deleted files go to, they'd say the Recycle Bin/Bin. But can also see why it might be awkward to change it from Trash to Bin after it has already been released.\r\n\r\n> And so another issue is we don't modify en_GB.po because it's automatically generated from the code. If there are other strings that need to be changed, you would need to modify them in the .ts/.js files instead.\r\n\r\nAh was wondering about this and why they were empty but also marked as translated, apologies\r\n\r\nGiven all that will close the PR but happy to reopen if you want to revisit.\r\n", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780736036/reactions", + "total_count": 1, + "+1": 1, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780884686", + "html_url": "https://github.com/laurent22/joplin/pull/12057#issuecomment-2780884686", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12057", + "id": 2780884686, + "node_id": "IC_kwDOBLftOs6lwO7O", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-05T16:08:21Z", + "updated_at": "2025-04-05T16:08:21Z", + "author_association": "OWNER", + "body": "Thanks for the information. Not being a native speaker I had completely missed that \"trash\" wasn't British English. I guess we should indeed change it in this case but as mentioned the changes would need to be done on the source code itself.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780884686/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2781032383", + "html_url": "https://github.com/laurent22/joplin/pull/12057#issuecomment-2781032383", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12057", + "id": 2781032383, + "node_id": "IC_kwDOBLftOs6lwy-_", + "user": { + "login": "tessus", + "id": 223439, + "node_id": "MDQ6VXNlcjIyMzQzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tessus", + "html_url": "https://github.com/tessus", + "followers_url": "https://api.github.com/users/tessus/followers", + "following_url": "https://api.github.com/users/tessus/following{/other_user}", + "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", + "organizations_url": "https://api.github.com/users/tessus/orgs", + "repos_url": "https://api.github.com/users/tessus/repos", + "events_url": "https://api.github.com/users/tessus/events{/privacy}", + "received_events_url": "https://api.github.com/users/tessus/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-05T18:29:51Z", + "updated_at": "2025-04-05T18:29:51Z", + "author_association": "COLLABORATOR", + "body": "@laurent22 isn't the trash/bin referenced by id rather than by name (when moving notes into it or any other operations that involve that object)? In such a case, changing the name, given that the aource code adds a translation point, should be trivial.\r\nIf not, using a special id, e.g. `deaddeaddeaddeaddeaddeaddeaddead` could be useful.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2781032383/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2781051613", + "html_url": "https://github.com/laurent22/joplin/pull/12057#issuecomment-2781051613", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12057", + "id": 2781051613, + "node_id": "IC_kwDOBLftOs6lw3rd", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-05T19:21:37Z", + "updated_at": "2025-04-05T19:21:37Z", + "author_association": "OWNER", + "body": "Yes it's referenced by an ID (`de1e7ede1e7ede1e7ede1e7ede1e7ede` for \"delete\") but it's more about going through all the files, and documentation too to update this. Then the .po files will also have to be updated so as not to invalidate all the translations. The trash folder is actually translated in other languages but it's just British English here that's special.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2781051613/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2781083305", + "html_url": "https://github.com/laurent22/joplin/pull/12057#issuecomment-2781083305", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12057", + "id": 2781083305, + "node_id": "IC_kwDOBLftOs6lw_ap", + "user": { + "login": "tessus", + "id": 223439, + "node_id": "MDQ6VXNlcjIyMzQzOQ==", + "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tessus", + "html_url": "https://github.com/tessus", + "followers_url": "https://api.github.com/users/tessus/followers", + "following_url": "https://api.github.com/users/tessus/following{/other_user}", + "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", + "organizations_url": "https://api.github.com/users/tessus/orgs", + "repos_url": "https://api.github.com/users/tessus/repos", + "events_url": "https://api.github.com/users/tessus/events{/privacy}", + "received_events_url": "https://api.github.com/users/tessus/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-05T20:28:35Z", + "updated_at": "2025-04-05T20:28:35Z", + "author_association": "COLLABORATOR", + "body": "Ok, makes sense. Although the documentation should not be such an issue. Most people still understand `trash`, even though `bin` is used in their every day speech. In fact I suspect that more people who learn English as their second language will learn trash and not bin.\r\nDon't get me started on what Irish, Scots, Welsh, Canadians, Aussis, and Kiwis use in their respective dialects... ;-)\r\n\r\nAs long as it doesn't mean the exact opposite (which is unfortunately possible between US and British English) it should be fine. I think the docs should use the term `trash` anyway, since more people are familiar with it.\r\n\r\nChanging all the .po files is a hassle, but doable. I have done it a few times before. I would have to look into how many source files use `trash` though. I can have a look at it when I have a bit more time.\r\n\r\n\r\n\r\n ", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2781083305/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/teardroponfire_1015199.json b/readme/cla/consent_records/teardroponfire_1015199.json new file mode 100644 index 0000000000..8f12c29e74 --- /dev/null +++ b/readme/cla/consent_records/teardroponfire_1015199.json @@ -0,0 +1,362 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11890", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11890/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11890/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11890/events", + "html_url": "https://github.com/laurent22/joplin/pull/11890", + "id": 2882342306, + "node_id": "PR_kwDOBLftOs6Mruto", + "number": 11890, + "title": "Update S3 synchronization documentation", + "user": { + "login": "teardroponfire", + "id": 1015199, + "node_id": "MDQ6VXNlcjEwMTUxOTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/1015199?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/teardroponfire", + "html_url": "https://github.com/teardroponfire", + "followers_url": "https://api.github.com/users/teardroponfire/followers", + "following_url": "https://api.github.com/users/teardroponfire/following{/other_user}", + "gists_url": "https://api.github.com/users/teardroponfire/gists{/gist_id}", + "starred_url": "https://api.github.com/users/teardroponfire/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/teardroponfire/subscriptions", + "organizations_url": "https://api.github.com/users/teardroponfire/orgs", + "repos_url": "https://api.github.com/users/teardroponfire/repos", + "events_url": "https://api.github.com/users/teardroponfire/events{/privacy}", + "received_events_url": "https://api.github.com/users/teardroponfire/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 4, + "created_at": "2025-02-26T17:34:36Z", + "updated_at": "2025-02-27T18:24:59Z", + "closed_at": "2025-02-27T18:24:45Z", + "author_association": "CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11890", + "html_url": "https://github.com/laurent22/joplin/pull/11890", + "diff_url": "https://github.com/laurent22/joplin/pull/11890.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11890.patch", + "merged_at": "2025-02-27T18:24:45Z" + }, + "body": "Included instructions on how to connect Joplin Sync with DigitalOcean's Spaces S3-compatible object storage.", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11890/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11890/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2685749190", + "html_url": "https://github.com/laurent22/joplin/pull/11890#issuecomment-2685749190", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11890", + "id": 2685749190, + "node_id": "IC_kwDOBLftOs6gFUfG", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-26T17:34:50Z", + "updated_at": "2025-02-27T18:24:59Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2685749190/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2685750652", + "html_url": "https://github.com/laurent22/joplin/pull/11890#issuecomment-2685750652", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11890", + "id": 2685750652, + "node_id": "IC_kwDOBLftOs6gFU18", + "user": { + "login": "teardroponfire", + "id": 1015199, + "node_id": "MDQ6VXNlcjEwMTUxOTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/1015199?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/teardroponfire", + "html_url": "https://github.com/teardroponfire", + "followers_url": "https://api.github.com/users/teardroponfire/followers", + "following_url": "https://api.github.com/users/teardroponfire/following{/other_user}", + "gists_url": "https://api.github.com/users/teardroponfire/gists{/gist_id}", + "starred_url": "https://api.github.com/users/teardroponfire/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/teardroponfire/subscriptions", + "organizations_url": "https://api.github.com/users/teardroponfire/orgs", + "repos_url": "https://api.github.com/users/teardroponfire/repos", + "events_url": "https://api.github.com/users/teardroponfire/events{/privacy}", + "received_events_url": "https://api.github.com/users/teardroponfire/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-26T17:35:30Z", + "updated_at": "2025-02-26T17:35:30Z", + "author_association": "CONTRIBUTOR", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2685750652/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2685751086", + "html_url": "https://github.com/laurent22/joplin/pull/11890#issuecomment-2685751086", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11890", + "id": 2685751086, + "node_id": "IC_kwDOBLftOs6gFU8u", + "user": { + "login": "teardroponfire", + "id": 1015199, + "node_id": "MDQ6VXNlcjEwMTUxOTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/1015199?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/teardroponfire", + "html_url": "https://github.com/teardroponfire", + "followers_url": "https://api.github.com/users/teardroponfire/followers", + "following_url": "https://api.github.com/users/teardroponfire/following{/other_user}", + "gists_url": "https://api.github.com/users/teardroponfire/gists{/gist_id}", + "starred_url": "https://api.github.com/users/teardroponfire/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/teardroponfire/subscriptions", + "organizations_url": "https://api.github.com/users/teardroponfire/orgs", + "repos_url": "https://api.github.com/users/teardroponfire/repos", + "events_url": "https://api.github.com/users/teardroponfire/events{/privacy}", + "received_events_url": "https://api.github.com/users/teardroponfire/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-26T17:35:42Z", + "updated_at": "2025-02-26T17:35:42Z", + "author_association": "CONTRIBUTOR", + "body": "recheck", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2685751086/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2688764481", + "html_url": "https://github.com/laurent22/joplin/pull/11890#issuecomment-2688764481", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11890", + "id": 2688764481, + "node_id": "IC_kwDOBLftOs6gQ0pB", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-27T18:24:39Z", + "updated_at": "2025-02-27T18:24:39Z", + "author_association": "OWNER", + "body": "looks good, thank you!", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2688764481/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/tnshgarg_91324988.json b/readme/cla/consent_records/tnshgarg_91324988.json new file mode 100644 index 0000000000..7ee834402d --- /dev/null +++ b/readme/cla/consent_records/tnshgarg_91324988.json @@ -0,0 +1,272 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11477", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11477/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11477/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11477/events", + "html_url": "https://github.com/laurent22/joplin/pull/11477", + "id": 2725020143, + "node_id": "PR_kwDOBLftOs6EbeTY", + "number": 11477, + "title": "All: Resolves #11476 Removed duplicate image, so there is no path collision", + "user": { + "login": "tnshgarg", + "id": 91324988, + "node_id": "MDQ6VXNlcjkxMzI0OTg4", + "avatar_url": "https://avatars.githubusercontent.com/u/91324988?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tnshgarg", + "html_url": "https://github.com/tnshgarg", + "followers_url": "https://api.github.com/users/tnshgarg/followers", + "following_url": "https://api.github.com/users/tnshgarg/following{/other_user}", + "gists_url": "https://api.github.com/users/tnshgarg/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tnshgarg/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tnshgarg/subscriptions", + "organizations_url": "https://api.github.com/users/tnshgarg/orgs", + "repos_url": "https://api.github.com/users/tnshgarg/repos", + "events_url": "https://api.github.com/users/tnshgarg/events{/privacy}", + "received_events_url": "https://api.github.com/users/tnshgarg/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 2, + "created_at": "2024-12-08T07:46:57Z", + "updated_at": "2024-12-08T20:14:22Z", + "closed_at": "2024-12-08T20:14:06Z", + "author_association": "NONE", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11477", + "html_url": "https://github.com/laurent22/joplin/pull/11477", + "diff_url": "https://github.com/laurent22/joplin/pull/11477.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11477.patch", + "merged_at": null + }, + "body": "Updated the test image in `packages/app-cli/tests/support` to replace the duplicate `photo-åäö.jpg` with `photo sample.jpg` to avoid collision warnings.", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11477/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11477/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2525478275", + "html_url": "https://github.com/laurent22/joplin/pull/11477#issuecomment-2525478275", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11477", + "id": 2525478275, + "node_id": "IC_kwDOBLftOs6Wh72D", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-08T07:47:14Z", + "updated_at": "2024-12-08T20:14:22Z", + "author_association": "CONTRIBUTOR", + "body": "**CLA Assistant Lite bot:**
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our [Contributor License Agreement](https://github.com/laurent22/joplin/blob/dev/readme/cla.md) before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.
\n - - -\n I have read the CLA Document and I hereby sign the CLA\n - - -\n **Tanish garg** seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please [add the email address used for this commit to your account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).
You can retrigger this bot by commenting **recheck** in this Pull Request", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2525478275/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2525480239", + "html_url": "https://github.com/laurent22/joplin/pull/11477#issuecomment-2525480239", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11477", + "id": 2525480239, + "node_id": "IC_kwDOBLftOs6Wh8Uv", + "user": { + "login": "tnshgarg", + "id": 91324988, + "node_id": "MDQ6VXNlcjkxMzI0OTg4", + "avatar_url": "https://avatars.githubusercontent.com/u/91324988?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tnshgarg", + "html_url": "https://github.com/tnshgarg", + "followers_url": "https://api.github.com/users/tnshgarg/followers", + "following_url": "https://api.github.com/users/tnshgarg/following{/other_user}", + "gists_url": "https://api.github.com/users/tnshgarg/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tnshgarg/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tnshgarg/subscriptions", + "organizations_url": "https://api.github.com/users/tnshgarg/orgs", + "repos_url": "https://api.github.com/users/tnshgarg/repos", + "events_url": "https://api.github.com/users/tnshgarg/events{/privacy}", + "received_events_url": "https://api.github.com/users/tnshgarg/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2024-12-08T07:48:43Z", + "updated_at": "2024-12-08T07:48:43Z", + "author_association": "NONE", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2525480239/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/ttcchhmm_60962195.json b/readme/cla/consent_records/ttcchhmm_60962195.json new file mode 100644 index 0000000000..e93a7ebae7 --- /dev/null +++ b/readme/cla/consent_records/ttcchhmm_60962195.json @@ -0,0 +1,702 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11865", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11865/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11865/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11865/events", + "html_url": "https://github.com/laurent22/joplin/pull/11865", + "id": 2865709635, + "node_id": "PR_kwDOBLftOs6L3-PD", + "number": 11865, + "title": "All: Add SAML support", + "user": { + "login": "ttcchhmm", + "id": 60962195, + "node_id": "MDQ6VXNlcjYwOTYyMTk1", + "avatar_url": "https://avatars.githubusercontent.com/u/60962195?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/ttcchhmm", + "html_url": "https://github.com/ttcchhmm", + "followers_url": "https://api.github.com/users/ttcchhmm/followers", + "following_url": "https://api.github.com/users/ttcchhmm/following{/other_user}", + "gists_url": "https://api.github.com/users/ttcchhmm/gists{/gist_id}", + "starred_url": "https://api.github.com/users/ttcchhmm/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/ttcchhmm/subscriptions", + "organizations_url": "https://api.github.com/users/ttcchhmm/orgs", + "repos_url": "https://api.github.com/users/ttcchhmm/repos", + "events_url": "https://api.github.com/users/ttcchhmm/events{/privacy}", + "received_events_url": "https://api.github.com/users/ttcchhmm/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "open", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 12, + "created_at": "2025-02-20T10:16:34Z", + "updated_at": "2025-04-25T10:46:33Z", + "closed_at": null, + "author_association": "FIRST_TIME_CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/11865", + "html_url": "https://github.com/laurent22/joplin/pull/11865", + "diff_url": "https://github.com/laurent22/joplin/pull/11865.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/11865.patch", + "merged_at": null + }, + "body": "This PR adds SAML support to Joplin.\r\n\r\n# Server\r\nBased on the [`samlify`](https://www.npmjs.com/package/samlify) library that provides the SAML logic flow for Joplin Server.\r\n\r\nThis adds the following environment variables used as configuration parameters to Joplin Server :\r\n- `SAML_ENABLED`: If set to `true`, enables SAML support.\r\n- `DISABLE_BUILTIN_LOGIN_FLOW`: If set to `true`, all auth requests MUST go though SAML. Users can't log-in using Joplin-specific credentials and/or LDAP.\r\n- `SAML_IDP_CONFIG_FILE`: Should be a path to an XML file containing the metadata for the Identity Provider (IDP).\r\n- `SAML_SP_CONFIG_FILE`: Should be a path to an XML file containing the metadata for the Service Provider (SP, in this case Joplin).\r\n- `SAML_ORGANIZATION_DISPLAY_NAME`: Name of the organization, as shown on the log-in screen. Optional.\r\n\r\nThe XML files are standard SAML IDP/SP metadata that should be created by the identity solution.\r\n\r\n# Clients\r\nAs for the clients themselves, no additional libraries are needed, since the actual log-in process is happening in a web browser, outside of Joplin itself.\r\n\r\nIt also adds a new sync target, based on the one for Joplin Server: \"Joplin Server (Beta, SAML)\". We kept \"Beta\" in the name for this since the main Joplin Server target itself is currently considered as such.\r\n\r\n> [!IMPORTANT]\r\n> The log-in flow uses a callback to a `joplin://` URL, and thus requires that only one instance of Joplin is running at any given time. This is important for the desktop client, since the single instance lock is not enforced in the `dev` environment.\r\n\r\n## Log-in flow\r\nThe log-in process differs slightly if started from within a client or within the server web interface.\r\n\r\n```mermaid\r\n graph TB;\r\n 12([From the server web interface]) --> 13[The user clicks 'Sign-in using your organization account']\r\n\r\n 13 --> 5\r\n\r\n 0([From a client]) --> 1\r\n\r\n 1[The user chooses the SAML sync target] --> 2[They enter the server's address]\r\n 2 --> 3[They click 'Sign-in using your organization account']\r\n 3 --> 4[The Joplin client opens the default web browser to an URL pointing to Joplin Server]\r\n 4 --> 5[Joplin Server reads its configuration and redirects the browser to the Identity Provider sign-in page]\r\n 5 --> 6[The user signs-in]\r\n 6 --> 7[The Identity Provider generates and signs a SAML payload, and redirects the browser to Joplin Server]\r\n 7 --> 8[Joplin Server validates the payload signature]\r\n\r\n 8 -- Client --- 9[If the signature is valid, Joplin Server creates a new token for this user]\r\n 9 --> 10[Using a joplin:// URL, the browser calls back into the client, with the new token]\r\n\r\n 8 -- Server web interface --- 11[If the signature is valid, a new session is created]\r\n```\r\n\r\n# Testing and development\r\nFor development purposes, we used [`saml-idp`](https://www.npmjs.com/package/saml-idp) as the Identity Provider, as it allows to quickly create new users on the fly and is simple to set up. After generating the keypair (look at the `saml-idp` documentation to see how), just running `npx saml-idp --acsUrl 'http://localhost:22300/api/saml' --audience http://localhost:22300 --issuer 'saml-idp'` is enough to get a test Identity Provider running, assuming that Joplin Server is running on `localhost:22300`.\r\n\r\nSince `saml-idp` does not support generating SP metadata, here is a sample configuration for the Service Provider part :\r\n```xml\r\n\r\n\r\n \r\n urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress\r\n \r\n \r\n\r\n```", + "closed_by": null, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/11865/reactions", + "total_count": 2, + "+1": 1, + "-1": 0, + "laugh": 0, + "hooray": 1, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11865/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2671054761", + "html_url": "https://github.com/laurent22/joplin/pull/11865#issuecomment-2671054761", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11865", + "id": 2671054761, + "node_id": "IC_kwDOBLftOs6fNQ-p", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-20T10:16:50Z", + "updated_at": "2025-04-10T09:25:10Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2671054761/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2671105647", + "html_url": "https://github.com/laurent22/joplin/pull/11865#issuecomment-2671105647", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11865", + "id": 2671105647, + "node_id": "IC_kwDOBLftOs6fNdZv", + "user": { + "login": "ttcchhmm", + "id": 60962195, + "node_id": "MDQ6VXNlcjYwOTYyMTk1", + "avatar_url": "https://avatars.githubusercontent.com/u/60962195?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/ttcchhmm", + "html_url": "https://github.com/ttcchhmm", + "followers_url": "https://api.github.com/users/ttcchhmm/followers", + "following_url": "https://api.github.com/users/ttcchhmm/following{/other_user}", + "gists_url": "https://api.github.com/users/ttcchhmm/gists{/gist_id}", + "starred_url": "https://api.github.com/users/ttcchhmm/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/ttcchhmm/subscriptions", + "organizations_url": "https://api.github.com/users/ttcchhmm/orgs", + "repos_url": "https://api.github.com/users/ttcchhmm/repos", + "events_url": "https://api.github.com/users/ttcchhmm/events{/privacy}", + "received_events_url": "https://api.github.com/users/ttcchhmm/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-20T10:37:57Z", + "updated_at": "2025-02-20T10:37:57Z", + "author_association": "NONE", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2671105647/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2672001760", + "html_url": "https://github.com/laurent22/joplin/pull/11865#issuecomment-2672001760", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11865", + "id": 2672001760, + "node_id": "IC_kwDOBLftOs6fQ4Lg", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-20T16:23:25Z", + "updated_at": "2025-02-20T16:23:25Z", + "author_association": "OWNER", + "body": "Thanks for creating this pull request! At the moment it has some issues related to the linter, which you should be able to fix by running `yarn linter ./` from the root. Would you mind fixing this so that CI passes? As it's a large PR it might take a while before we can review it but as a first step it would help if it doesn't have any CI error", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2672001760/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2673979256", + "html_url": "https://github.com/laurent22/joplin/pull/11865#issuecomment-2673979256", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11865", + "id": 2673979256, + "node_id": "IC_kwDOBLftOs6fYa94", + "user": { + "login": "ttcchhmm", + "id": 60962195, + "node_id": "MDQ6VXNlcjYwOTYyMTk1", + "avatar_url": "https://avatars.githubusercontent.com/u/60962195?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/ttcchhmm", + "html_url": "https://github.com/ttcchhmm", + "followers_url": "https://api.github.com/users/ttcchhmm/followers", + "following_url": "https://api.github.com/users/ttcchhmm/following{/other_user}", + "gists_url": "https://api.github.com/users/ttcchhmm/gists{/gist_id}", + "starred_url": "https://api.github.com/users/ttcchhmm/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/ttcchhmm/subscriptions", + "organizations_url": "https://api.github.com/users/ttcchhmm/orgs", + "repos_url": "https://api.github.com/users/ttcchhmm/repos", + "events_url": "https://api.github.com/users/ttcchhmm/events{/privacy}", + "received_events_url": "https://api.github.com/users/ttcchhmm/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-21T09:03:47Z", + "updated_at": "2025-02-21T09:03:47Z", + "author_association": "NONE", + "body": "I fixed the issues related to the linter.\r\n\r\nHowever, the server image does not build since the XML schema validator ([`@authenio/samlify-xsd-schema-validator`](https://www.npmjs.com/package/@authenio/samlify-xsd-schema-validator)) has a dependency on a Java environment that is missing in the CI. If needed I can replace this dependency with something else since `samlify` supports several validators, but this validator is the one recommended in the [`samlify` README file](https://github.com/tngan/samlify/blob/master/README.md#installation), so I hope this is not an issue?", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2673979256/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2674212623", + "html_url": "https://github.com/laurent22/joplin/pull/11865#issuecomment-2674212623", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11865", + "id": 2674212623, + "node_id": "IC_kwDOBLftOs6fZT8P", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-21T10:46:59Z", + "updated_at": "2025-02-21T10:46:59Z", + "author_association": "OWNER", + "body": "Hmm, if it's just to validate an XML schema I guess it's not worth adding a Java dependency? From their doc it looks like there's a TypeScript package too?", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2674212623/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2674568915", + "html_url": "https://github.com/laurent22/joplin/pull/11865#issuecomment-2674568915", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11865", + "id": 2674568915, + "node_id": "IC_kwDOBLftOs6faq7T", + "user": { + "login": "ttcchhmm", + "id": 60962195, + "node_id": "MDQ6VXNlcjYwOTYyMTk1", + "avatar_url": "https://avatars.githubusercontent.com/u/60962195?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/ttcchhmm", + "html_url": "https://github.com/ttcchhmm", + "followers_url": "https://api.github.com/users/ttcchhmm/followers", + "following_url": "https://api.github.com/users/ttcchhmm/following{/other_user}", + "gists_url": "https://api.github.com/users/ttcchhmm/gists{/gist_id}", + "starred_url": "https://api.github.com/users/ttcchhmm/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/ttcchhmm/subscriptions", + "organizations_url": "https://api.github.com/users/ttcchhmm/orgs", + "repos_url": "https://api.github.com/users/ttcchhmm/repos", + "events_url": "https://api.github.com/users/ttcchhmm/events{/privacy}", + "received_events_url": "https://api.github.com/users/ttcchhmm/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-02-21T13:34:08Z", + "updated_at": "2025-02-21T13:34:08Z", + "author_association": "NONE", + "body": "I got rid of the Java dependency, and replaced the schema validator with `@authenio/samlify-xmllint-wasm`, which doesn't require any native code. This allows the server image to build.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2674568915/reactions", + "total_count": 2, + "+1": 1, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 1 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2754863975", + "html_url": "https://github.com/laurent22/joplin/pull/11865#issuecomment-2754863975", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11865", + "id": 2754863975, + "node_id": "IC_kwDOBLftOs6kM-Nn", + "user": { + "login": "ttcchhmm", + "id": 60962195, + "node_id": "MDQ6VXNlcjYwOTYyMTk1", + "avatar_url": "https://avatars.githubusercontent.com/u/60962195?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/ttcchhmm", + "html_url": "https://github.com/ttcchhmm", + "followers_url": "https://api.github.com/users/ttcchhmm/followers", + "following_url": "https://api.github.com/users/ttcchhmm/following{/other_user}", + "gists_url": "https://api.github.com/users/ttcchhmm/gists{/gist_id}", + "starred_url": "https://api.github.com/users/ttcchhmm/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/ttcchhmm/subscriptions", + "organizations_url": "https://api.github.com/users/ttcchhmm/orgs", + "repos_url": "https://api.github.com/users/ttcchhmm/repos", + "events_url": "https://api.github.com/users/ttcchhmm/events{/privacy}", + "received_events_url": "https://api.github.com/users/ttcchhmm/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-26T15:37:38Z", + "updated_at": "2025-03-26T15:37:38Z", + "author_association": "NONE", + "body": "Sorry to bump this, but is there any update about this?", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2754863975/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2755452083", + "html_url": "https://github.com/laurent22/joplin/pull/11865#issuecomment-2755452083", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11865", + "id": 2755452083, + "node_id": "IC_kwDOBLftOs6kPNyz", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-26T18:51:00Z", + "updated_at": "2025-03-26T18:51:00Z", + "author_association": "OWNER", + "body": "Hello, sorry for the lack of feedback yet. As this is a large pull request I will need more time to review it.\r\n\r\nThe fact that it is deeply integrated to both the server and apps mean there will be maintenance concerns since unlike for example a sync target that works independently, the new code will have to be maintained by us probably over time. I don't assume it's possible to make things a bit more modular? i.e. most of the code in new files, and a few integration points here and there;", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2755452083/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2758443099", + "html_url": "https://github.com/laurent22/joplin/pull/11865#issuecomment-2758443099", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11865", + "id": 2758443099, + "node_id": "IC_kwDOBLftOs6kaoBb", + "user": { + "login": "ttcchhmm", + "id": 60962195, + "node_id": "MDQ6VXNlcjYwOTYyMTk1", + "avatar_url": "https://avatars.githubusercontent.com/u/60962195?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/ttcchhmm", + "html_url": "https://github.com/ttcchhmm", + "followers_url": "https://api.github.com/users/ttcchhmm/followers", + "following_url": "https://api.github.com/users/ttcchhmm/following{/other_user}", + "gists_url": "https://api.github.com/users/ttcchhmm/gists{/gist_id}", + "starred_url": "https://api.github.com/users/ttcchhmm/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/ttcchhmm/subscriptions", + "organizations_url": "https://api.github.com/users/ttcchhmm/orgs", + "repos_url": "https://api.github.com/users/ttcchhmm/repos", + "events_url": "https://api.github.com/users/ttcchhmm/events{/privacy}", + "received_events_url": "https://api.github.com/users/ttcchhmm/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-27T15:18:20Z", + "updated_at": "2025-03-27T15:18:20Z", + "author_association": "NONE", + "body": "I don't think I can make the code more modular than it currently is. I refactored it a bit to help with your review (mostly by adding comments, but also by doing a bit of cleanup), and merged the current `dev` branch into mine. The only conflict I got was on a dictionary file, and after testing everything was still working as intended (on the SAML side, at least), so even if it's only one limited example it seems rather positive.\r\n\r\nThe new SAML sync target extends the base Joplin Server one, so on this topic I think I made things more modular than they were before by allowing the sync target to provide a session to `JoplinServerApi`, in addition to the regular login/password combo.\r\n\r\nUnfortunately since the SAML login process relies on a web browser, I didn't have a choice but to rely on a callback from a web page which means that I needed to use the `x-callback-url` scheme, and thus I had to add a new command that can be called externally (which means modifying part of the existing code). I don't think I can do this in a different way other than using a webview within the apps, and doing this would defeat part of the security benefit that comes with SAML. Furthermore, doing it that way would need even more code in the clients to handle this, so I think the current approach is the best one.\r\n\r\nAnd on the server, I had to modify `UserModel` since the only way to authenticate before was with a username and a password. This was required since the response from the Identity Provider is trusted (and we don't have the password anyways), and we need to create new users dynamically if they are not already known by the server. I also had to modify the `/login` route to add redirects as needed. Otherwise, the other modifications should be rather minor, and most of the actual SAML-related logic is within `routes/api/login.ts` and `utils/saml.ts`, which are new files.\r\n\r\nIf you have any tips about making this better, feel free to tell me so I can implement them.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2758443099/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2759472335", + "html_url": "https://github.com/laurent22/joplin/pull/11865#issuecomment-2759472335", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11865", + "id": 2759472335, + "node_id": "IC_kwDOBLftOs6kejTP", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-03-27T21:03:53Z", + "updated_at": "2025-03-27T21:03:53Z", + "author_association": "OWNER", + "body": "Thank you for the detailed explanation, it does help. I also need to go back to your top post and check the diagram again so I understand things at a higher level before diving into the code review. I will try to do that as soon as possible and will get back to you.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2759472335/reactions", + "total_count": 2, + "+1": 2, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2792054280", + "html_url": "https://github.com/laurent22/joplin/pull/11865#issuecomment-2792054280", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11865", + "id": 2792054280, + "node_id": "IC_kwDOBLftOs6ma14I", + "user": { + "login": "ttcchhmm", + "id": 60962195, + "node_id": "MDQ6VXNlcjYwOTYyMTk1", + "avatar_url": "https://avatars.githubusercontent.com/u/60962195?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/ttcchhmm", + "html_url": "https://github.com/ttcchhmm", + "followers_url": "https://api.github.com/users/ttcchhmm/followers", + "following_url": "https://api.github.com/users/ttcchhmm/following{/other_user}", + "gists_url": "https://api.github.com/users/ttcchhmm/gists{/gist_id}", + "starred_url": "https://api.github.com/users/ttcchhmm/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/ttcchhmm/subscriptions", + "organizations_url": "https://api.github.com/users/ttcchhmm/orgs", + "repos_url": "https://api.github.com/users/ttcchhmm/repos", + "events_url": "https://api.github.com/users/ttcchhmm/events{/privacy}", + "received_events_url": "https://api.github.com/users/ttcchhmm/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-10T08:59:09Z", + "updated_at": "2025-04-10T08:59:09Z", + "author_association": "NONE", + "body": "I updated my branch with your feedback. I removed the use of `x-callback-url` in favor of a code-based authentication flow, like the way Dropbox works. I did it that way to keep the same experience between the desktop and mobile clients.\r\n\r\nThis required additional modifications to the server side of things to handle auth codes (mostly `UserModel.ts` and `api/login.ts`). I also added a new task that runs every 15 minutes that removes expired auth codes from the database.\r\n\r\nOn the clients, the removal of the `x-callback-url` based flow makes things a bit cleaner. I added a new screen dedicated to opening the login page and entering an auth code. I made it modular (it's not specific to SAML), so it's possible to port the Dropbox login screen to it in the future.\r\n\r\nThis is tested on desktop (Windows 10) and mobile (both Android and iOS).", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2792054280/reactions", + "total_count": 1, + "+1": 1, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2830070749", + "html_url": "https://github.com/laurent22/joplin/pull/11865#issuecomment-2830070749", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11865", + "id": 2830070749, + "node_id": "IC_kwDOBLftOs6or3Pd", + "user": { + "login": "ttcchhmm", + "id": 60962195, + "node_id": "MDQ6VXNlcjYwOTYyMTk1", + "avatar_url": "https://avatars.githubusercontent.com/u/60962195?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/ttcchhmm", + "html_url": "https://github.com/ttcchhmm", + "followers_url": "https://api.github.com/users/ttcchhmm/followers", + "following_url": "https://api.github.com/users/ttcchhmm/following{/other_user}", + "gists_url": "https://api.github.com/users/ttcchhmm/gists{/gist_id}", + "starred_url": "https://api.github.com/users/ttcchhmm/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/ttcchhmm/subscriptions", + "organizations_url": "https://api.github.com/users/ttcchhmm/orgs", + "repos_url": "https://api.github.com/users/ttcchhmm/repos", + "events_url": "https://api.github.com/users/ttcchhmm/events{/privacy}", + "received_events_url": "https://api.github.com/users/ttcchhmm/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-25T10:46:33Z", + "updated_at": "2025-04-25T10:46:33Z", + "author_association": "NONE", + "body": "Do I have to do something to fix the CLA CI job? I did sign the CLA when I started this pull request, so this should pass.", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2830070749/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/tue-AqielOostenbrug_104417251.json b/readme/cla/consent_records/tue-AqielOostenbrug_104417251.json new file mode 100644 index 0000000000..de2a7ac696 --- /dev/null +++ b/readme/cla/consent_records/tue-AqielOostenbrug_104417251.json @@ -0,0 +1,432 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12121", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/12121/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/12121/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/12121/events", + "html_url": "https://github.com/laurent22/joplin/pull/12121", + "id": 3002529135, + "node_id": "PR_kwDOBLftOs6S_hAU", + "number": 12121, + "title": "Desktop: Fixes #12049: Fixes MD extensionless imports/tagging", + "user": { + "login": "tue-AqielOostenbrug", + "id": 104417251, + "node_id": "U_kgDOBjlH4w", + "avatar_url": "https://avatars.githubusercontent.com/u/104417251?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tue-AqielOostenbrug", + "html_url": "https://github.com/tue-AqielOostenbrug", + "followers_url": "https://api.github.com/users/tue-AqielOostenbrug/followers", + "following_url": "https://api.github.com/users/tue-AqielOostenbrug/following{/other_user}", + "gists_url": "https://api.github.com/users/tue-AqielOostenbrug/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tue-AqielOostenbrug/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tue-AqielOostenbrug/subscriptions", + "organizations_url": "https://api.github.com/users/tue-AqielOostenbrug/orgs", + "repos_url": "https://api.github.com/users/tue-AqielOostenbrug/repos", + "events_url": "https://api.github.com/users/tue-AqielOostenbrug/events{/privacy}", + "received_events_url": "https://api.github.com/users/tue-AqielOostenbrug/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "open", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 6, + "created_at": "2025-04-17T13:36:30Z", + "updated_at": "2025-04-24T13:16:19Z", + "closed_at": null, + "author_association": "FIRST_TIME_CONTRIBUTOR", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/12121", + "html_url": "https://github.com/laurent22/joplin/pull/12121", + "diff_url": "https://github.com/laurent22/joplin/pull/12121.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/12121.patch", + "merged_at": null + }, + "body": "# Background\r\nThis PR attempts to fix issue #12049. In the issue, @marph91 reports on a mix of two problems with importing files with no extension in Markdown. \r\n\r\n# Fix Results\r\nFiles without extensions are imported as files without extensions in Markdown :D. Files without extension are assumed to be of type `application/octet-stream` (binary) as @laurent22 suggested.\r\n\r\n# Explanation\r\n\r\n### Problem 1\r\nFiles without an extension and leading `./` like `![file1](./file1)` get imported as `.file1` whilst only importing `file` is expected.\r\n\r\n### Fix 1\r\nSquashing all `/./` into `/` for the provided path in the function `filename(path)` in `packages/utils/path.ts`:\r\n\r\n![Image](https://github.com/user-attachments/assets/f5e6de76-d1b6-4b64-b147-84b7cb79be72)\r\n(fixed code)\r\n\r\nAnd only splitting on `.` **to find the extension** after removing text preceding the last `/` in the path in the function `fileExtension(path)` in `packages/utils/path.ts`. This ensures that the `..././...` does not get interpreted as a file with the extension `/...` (which has to be filtered out later in the code.)\r\n\r\n![Image](https://github.com/user-attachments/assets/15ea0f98-2fa8-436a-9075-a9a3cc20622f)\r\n(fixed code)\r\n### Problem 2\r\nFiles without an extension, like `![file2](file2)`, are not imported because we attempt to import them as `../../file2.` instead of `../../file2`\r\n\r\n![Image](https://github.com/user-attachments/assets/9abf474e-8a7d-486e-ab8e-3f95c674df83)\r\n(old code)\r\n\r\n### Fix 2\r\nWhile parsing, make it optional to concatenate filenames and their extensions in the function `importLocalFiles(...)` in `packages/lib/services/interop/InteropService_Importer_Md.ts`. So if the file doesn't have an extension (the extension is an empty string), we don't try to import the file as `..\\..\\file3.`, and instead attempt to import the file as `..\\..\\file3`\r\n\r\n![fix2](https://github.com/user-attachments/assets/5e044c63-35f8-457c-a2bb-328fbca8693c)\r\n(fixed code)\r\n\r\n# Testing\r\nAdd an extensionless file and a Markdown file with the first two cases described by @marph91 i.e. containing:\r\n```\r\n1. File without extension and leading `./`: [file1](./sample-extensionless). Get's imported, but filename is converted to extension, like `.file1`\r\n2. File without extension: [file2](sample-extensionless). Not imported at all.\r\n```\r\nCheck if there are truly 2 resulting imports, and if `.sample-extension-less` and `./sample-extension-less` don't occur in the file (could happen if they were not imported).", + "closed_by": null, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12121/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/12121/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2812961629", + "html_url": "https://github.com/laurent22/joplin/pull/12121#issuecomment-2812961629", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12121", + "id": 2812961629, + "node_id": "IC_kwDOBLftOs6nqmNd", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-17T13:36:43Z", + "updated_at": "2025-04-20T11:40:01Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2812961629/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2812962785", + "html_url": "https://github.com/laurent22/joplin/pull/12121#issuecomment-2812962785", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12121", + "id": 2812962785, + "node_id": "IC_kwDOBLftOs6nqmfh", + "user": { + "login": "tue-AqielOostenbrug", + "id": 104417251, + "node_id": "U_kgDOBjlH4w", + "avatar_url": "https://avatars.githubusercontent.com/u/104417251?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tue-AqielOostenbrug", + "html_url": "https://github.com/tue-AqielOostenbrug", + "followers_url": "https://api.github.com/users/tue-AqielOostenbrug/followers", + "following_url": "https://api.github.com/users/tue-AqielOostenbrug/following{/other_user}", + "gists_url": "https://api.github.com/users/tue-AqielOostenbrug/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tue-AqielOostenbrug/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tue-AqielOostenbrug/subscriptions", + "organizations_url": "https://api.github.com/users/tue-AqielOostenbrug/orgs", + "repos_url": "https://api.github.com/users/tue-AqielOostenbrug/repos", + "events_url": "https://api.github.com/users/tue-AqielOostenbrug/events{/privacy}", + "received_events_url": "https://api.github.com/users/tue-AqielOostenbrug/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-17T13:37:04Z", + "updated_at": "2025-04-17T13:37:04Z", + "author_association": "NONE", + "body": "I have read the CLA Document and I hereby sign the CLA", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2812962785/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2812998902", + "html_url": "https://github.com/laurent22/joplin/pull/12121#issuecomment-2812998902", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12121", + "id": 2812998902, + "node_id": "IC_kwDOBLftOs6nqvT2", + "user": { + "login": "personalizedrefrigerator", + "id": 46334387, + "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", + "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/personalizedrefrigerator", + "html_url": "https://github.com/personalizedrefrigerator", + "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", + "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", + "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", + "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", + "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", + "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", + "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", + "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-17T13:49:20Z", + "updated_at": "2025-04-17T13:49:20Z", + "author_association": "COLLABORATOR", + "body": "Thank you for working on this!\r\n\r\nThe pull request currently splits by `/` and replaces `/./` with `/`. Windows, however, supports `\\`s as path separators. Does the issue still exist on Windows, with this pull request?", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2812998902/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2813633894", + "html_url": "https://github.com/laurent22/joplin/pull/12121#issuecomment-2813633894", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12121", + "id": 2813633894, + "node_id": "IC_kwDOBLftOs6ntKVm", + "user": { + "login": "tue-AqielOostenbrug", + "id": 104417251, + "node_id": "U_kgDOBjlH4w", + "avatar_url": "https://avatars.githubusercontent.com/u/104417251?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tue-AqielOostenbrug", + "html_url": "https://github.com/tue-AqielOostenbrug", + "followers_url": "https://api.github.com/users/tue-AqielOostenbrug/followers", + "following_url": "https://api.github.com/users/tue-AqielOostenbrug/following{/other_user}", + "gists_url": "https://api.github.com/users/tue-AqielOostenbrug/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tue-AqielOostenbrug/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tue-AqielOostenbrug/subscriptions", + "organizations_url": "https://api.github.com/users/tue-AqielOostenbrug/orgs", + "repos_url": "https://api.github.com/users/tue-AqielOostenbrug/repos", + "events_url": "https://api.github.com/users/tue-AqielOostenbrug/events{/privacy}", + "received_events_url": "https://api.github.com/users/tue-AqielOostenbrug/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-17T17:37:11Z", + "updated_at": "2025-04-17T17:38:15Z", + "author_association": "NONE", + "body": "Hi @personalizedrefrigerator, happy to be here n contribute :).\r\n\r\nFrom what I've seen of Joplin, I think that it automatically converts forward slashes to backward slashes since:\r\n- I think Markdown is only supposed to work with forward slashes\r\n- Testing tagging with backslashes tested on Windows shows me that backslashes are automatically converted to forward slashes. \r\n- A forward slash is hardcoded into the assignment of attachmentPath just before my code modifications in the `importLocalFiles(...)` function in `packages/lib/services/interop/InteropService_Importer_Md.ts` (above) and mixing backward and forward slashes would cause havoc filepath resolving.\r\n\r\nSo, I think this PR would also fix it for Windows since the behaviour would be the same.\r\n\r\nBut, right now I'm struggling a bit with a CI specific check:\r\n[InteropService_Importer_OneNote › should be able to create notes from corrupted attachment](https://github.com/laurent22/joplin/actions/runs/14520029169/job/40738459628?pr=12121)\r\n(https://github.com/laurent22/joplin/tree/dev/packages/lib/services/interop/InteropService_Importer_OneNote.test.ts) (line 170)\r\n```\r\nskipIfNotCI('should ignore broken characters at the start of paragraph', async () => {\r\n\t\tlet idx = 0;\r\n\t\tconst originalIdGenerator = BaseModel.setIdGenerator(() => String(idx++));\r\n\t\tconst notes = await importNote(`${supportDir}/onenote/bug_broken_character.zip`);\r\n\r\n\t\texpect(notes.find(n => n.title === 'Action research - Wikipedia').body).toMatchSnapshot();\r\n\r\n\t\tBaseModel.setIdGenerator(originalIdGenerator);\r\n\t});\r\n```\r\nThis seems to just be a CI specific test that can't run locally. Do you maybe know a bit more about why it is failing?", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2813633894/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2826714702", + "html_url": "https://github.com/laurent22/joplin/pull/12121#issuecomment-2826714702", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12121", + "id": 2826714702, + "node_id": "IC_kwDOBLftOs6ofD5O", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-24T08:00:07Z", + "updated_at": "2025-04-24T08:00:07Z", + "author_association": "OWNER", + "body": "> But, right now I'm struggling a bit with a CI specific check\r\n\r\nThe failing test seems to be related to your change since it affects a path. To run the tests on your machine have a look here: `packages/onenote-converter/README.md`. I think you'd need to run `IS_CONTINUOUS_INTEGRATION=1 yarn test` to run this particular test. @pedr maybe can confirm", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2826714702/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2827601464", + "html_url": "https://github.com/laurent22/joplin/pull/12121#issuecomment-2827601464", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12121", + "id": 2827601464, + "node_id": "IC_kwDOBLftOs6oicY4", + "user": { + "login": "pedr", + "id": 5051088, + "node_id": "MDQ6VXNlcjUwNTEwODg=", + "avatar_url": "https://avatars.githubusercontent.com/u/5051088?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/pedr", + "html_url": "https://github.com/pedr", + "followers_url": "https://api.github.com/users/pedr/followers", + "following_url": "https://api.github.com/users/pedr/following{/other_user}", + "gists_url": "https://api.github.com/users/pedr/gists{/gist_id}", + "starred_url": "https://api.github.com/users/pedr/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/pedr/subscriptions", + "organizations_url": "https://api.github.com/users/pedr/orgs", + "repos_url": "https://api.github.com/users/pedr/repos", + "events_url": "https://api.github.com/users/pedr/events{/privacy}", + "received_events_url": "https://api.github.com/users/pedr/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-24T13:16:18Z", + "updated_at": "2025-04-24T13:16:18Z", + "author_association": "COLLABORATOR", + "body": "> > But, right now I'm struggling a bit with a CI specific check\r\n> \r\n> The failing test seems to be related to your change since it affects a path. To run the tests on your machine have a look here: `packages/onenote-converter/README.md`. I think you'd need to run `IS_CONTINUOUS_INTEGRATION=1 yarn test` to run this particular test. @pedr maybe can confirm\r\n\r\nThat is correct, we disable the tests that rely on `onenote-converter` package by default so developers who are not going to work with it don't have to handle the Rust environment and dependencies.\r\n\r\n@laurent22 Maybe we could add this information in the error so next contributors might be able to get that the tests is failing is not only a random CI failure. I'm going to see if there is anything we can do about it with Jest", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2827601464/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file diff --git a/readme/cla/consent_records/tuliogit_4997388.json b/readme/cla/consent_records/tuliogit_4997388.json new file mode 100644 index 0000000000..0043d34314 --- /dev/null +++ b/readme/cla/consent_records/tuliogit_4997388.json @@ -0,0 +1,362 @@ +{ + "issue": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12069", + "repository_url": "https://api.github.com/repos/laurent22/joplin", + "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/12069/labels{/name}", + "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/12069/comments", + "events_url": "https://api.github.com/repos/laurent22/joplin/issues/12069/events", + "html_url": "https://github.com/laurent22/joplin/pull/12069", + "id": 2977178091, + "node_id": "PR_kwDOBLftOs6Rpmoh", + "number": 12069, + "title": "adding complete pt_BR translation", + "user": { + "login": "tuliogit", + "id": 4997388, + "node_id": "MDQ6VXNlcjQ5OTczODg=", + "avatar_url": "https://avatars.githubusercontent.com/u/4997388?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tuliogit", + "html_url": "https://github.com/tuliogit", + "followers_url": "https://api.github.com/users/tuliogit/followers", + "following_url": "https://api.github.com/users/tuliogit/following{/other_user}", + "gists_url": "https://api.github.com/users/tuliogit/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tuliogit/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tuliogit/subscriptions", + "organizations_url": "https://api.github.com/users/tuliogit/orgs", + "repos_url": "https://api.github.com/users/tuliogit/repos", + "events_url": "https://api.github.com/users/tuliogit/events{/privacy}", + "received_events_url": "https://api.github.com/users/tuliogit/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "labels": [], + "state": "closed", + "locked": false, + "assignee": null, + "assignees": [], + "milestone": null, + "comments": 4, + "created_at": "2025-04-07T15:05:49Z", + "updated_at": "2025-04-09T17:34:11Z", + "closed_at": "2025-04-09T13:40:37Z", + "author_association": "NONE", + "active_lock_reason": null, + "draft": false, + "pull_request": { + "url": "https://api.github.com/repos/laurent22/joplin/pulls/12069", + "html_url": "https://github.com/laurent22/joplin/pull/12069", + "diff_url": "https://github.com/laurent22/joplin/pull/12069.diff", + "patch_url": "https://github.com/laurent22/joplin/pull/12069.patch", + "merged_at": null + }, + "body": "", + "closed_by": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/12069/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/12069/timeline", + "performed_via_github_app": null, + "state_reason": null + }, + "comments": [ + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2783663961", + "html_url": "https://github.com/laurent22/joplin/pull/12069#issuecomment-2783663961", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12069", + "id": 2783663961, + "node_id": "IC_kwDOBLftOs6l61dZ", + "user": { + "login": "github-actions[bot]", + "id": 41898282, + "node_id": "MDM6Qm90NDE4OTgyODI=", + "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github-actions%5Bbot%5D", + "html_url": "https://github.com/apps/github-actions", + "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", + "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", + "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", + "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", + "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", + "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", + "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", + "type": "Bot", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-07T15:06:00Z", + "updated_at": "2025-04-09T13:40:47Z", + "author_association": "CONTRIBUTOR", + "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2783663961/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": { + "id": 15368, + "client_id": "Iv1.05c79e9ad1f6bdfa", + "slug": "github-actions", + "node_id": "MDM6QXBwMTUzNjg=", + "owner": { + "login": "github", + "id": 9919, + "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", + "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/github", + "html_url": "https://github.com/github", + "followers_url": "https://api.github.com/users/github/followers", + "following_url": "https://api.github.com/users/github/following{/other_user}", + "gists_url": "https://api.github.com/users/github/gists{/gist_id}", + "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/github/subscriptions", + "organizations_url": "https://api.github.com/users/github/orgs", + "repos_url": "https://api.github.com/users/github/repos", + "events_url": "https://api.github.com/users/github/events{/privacy}", + "received_events_url": "https://api.github.com/users/github/received_events", + "type": "Organization", + "user_view_type": "public", + "site_admin": false + }, + "name": "GitHub Actions", + "description": "Automate your workflow from idea to production", + "external_url": "https://help.github.com/en/actions", + "html_url": "https://github.com/apps/github-actions", + "created_at": "2018-07-30T09:30:17Z", + "updated_at": "2025-03-07T16:35:00Z", + "permissions": { + "actions": "write", + "administration": "read", + "attestations": "write", + "checks": "write", + "contents": "write", + "deployments": "write", + "discussions": "write", + "issues": "write", + "merge_queues": "write", + "metadata": "read", + "models": "read", + "packages": "write", + "pages": "write", + "pull_requests": "write", + "repository_hooks": "write", + "repository_projects": "write", + "security_events": "write", + "statuses": "write", + "vulnerability_alerts": "read" + }, + "events": [ + "branch_protection_rule", + "check_run", + "check_suite", + "create", + "delete", + "deployment", + "deployment_status", + "discussion", + "discussion_comment", + "fork", + "gollum", + "issues", + "issue_comment", + "label", + "merge_group", + "milestone", + "page_build", + "project", + "project_card", + "project_column", + "public", + "pull_request", + "pull_request_review", + "pull_request_review_comment", + "push", + "registry_package", + "release", + "repository", + "repository_dispatch", + "status", + "watch", + "workflow_dispatch", + "workflow_run" + ] + } + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2783741664", + "html_url": "https://github.com/laurent22/joplin/pull/12069#issuecomment-2783741664", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12069", + "id": 2783741664, + "node_id": "IC_kwDOBLftOs6l7Ibg", + "user": { + "login": "tuliogit", + "id": 4997388, + "node_id": "MDQ6VXNlcjQ5OTczODg=", + "avatar_url": "https://avatars.githubusercontent.com/u/4997388?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/tuliogit", + "html_url": "https://github.com/tuliogit", + "followers_url": "https://api.github.com/users/tuliogit/followers", + "following_url": "https://api.github.com/users/tuliogit/following{/other_user}", + "gists_url": "https://api.github.com/users/tuliogit/gists{/gist_id}", + "starred_url": "https://api.github.com/users/tuliogit/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/tuliogit/subscriptions", + "organizations_url": "https://api.github.com/users/tuliogit/orgs", + "repos_url": "https://api.github.com/users/tuliogit/repos", + "events_url": "https://api.github.com/users/tuliogit/events{/privacy}", + "received_events_url": "https://api.github.com/users/tuliogit/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-07T15:31:25Z", + "updated_at": "2025-04-07T15:31:25Z", + "author_association": "NONE", + "body": "I have read the CLA Document and I hereby sign the CLA\r\n\r\n\r\n", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2783741664/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2784238609", + "html_url": "https://github.com/laurent22/joplin/pull/12069#issuecomment-2784238609", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12069", + "id": 2784238609, + "node_id": "IC_kwDOBLftOs6l9BwR", + "user": { + "login": "personalizedrefrigerator", + "id": 46334387, + "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", + "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/personalizedrefrigerator", + "html_url": "https://github.com/personalizedrefrigerator", + "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", + "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", + "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", + "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", + "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", + "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", + "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", + "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-07T18:41:23Z", + "updated_at": "2025-04-07T18:41:23Z", + "author_association": "COLLABORATOR", + "body": "recheck", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2784238609/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + }, + { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2784279988", + "html_url": "https://github.com/laurent22/joplin/pull/12069#issuecomment-2784279988", + "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12069", + "id": 2784279988, + "node_id": "IC_kwDOBLftOs6l9L20", + "user": { + "login": "laurent22", + "id": 1285584, + "node_id": "MDQ6VXNlcjEyODU1ODQ=", + "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", + "gravatar_id": "", + "url": "https://api.github.com/users/laurent22", + "html_url": "https://github.com/laurent22", + "followers_url": "https://api.github.com/users/laurent22/followers", + "following_url": "https://api.github.com/users/laurent22/following{/other_user}", + "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", + "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", + "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", + "organizations_url": "https://api.github.com/users/laurent22/orgs", + "repos_url": "https://api.github.com/users/laurent22/repos", + "events_url": "https://api.github.com/users/laurent22/events{/privacy}", + "received_events_url": "https://api.github.com/users/laurent22/received_events", + "type": "User", + "user_view_type": "public", + "site_admin": false + }, + "created_at": "2025-04-07T18:59:22Z", + "updated_at": "2025-04-07T18:59:22Z", + "author_association": "OWNER", + "body": "CI error - use PoEdit:\r\n\r\n```\r\nStep: Validating translations...\r\nError: Command failed: msgfmt -v \"/home/runner/work/joplin/joplin/packages/tools/../../packages/tools/locales/pt_BR.po\"\r\n/home/runner/work/joplin/joplin/packages/tools/../../packages/tools/locales/pt_BR.po:35: missing 'msgstr' section\r\n/home/runner/work/joplin/joplin/packages/tools/../../packages/tools/locales/pt_BR.po:35:10: syntax error\r\n/home/runner/work/joplin/joplin/packages/tools/../../packages/tools/locales/pt_BR.po:36: keyword \"s\" unknown\r\n/home/runner/work/joplin/joplin/packages/tools/../../packages/tools/locales/pt_BR.po:164: keyword \"add\" unknown\r\n/home/runner/work/joplin/joplin/packages/tools/../../packages/tools/locales/pt_BR.po:164:33: syntax error\r\n/home/runner/work/joplin/joplin/packages/tools/../../packages/tools/locales/pt_BR.po:165: keyword \"add\" unknown\r\n/home/runner/work/joplin/joplin/packages/tools/../../packages/tools/locales/pt_BR.po:167: keyword \"toggle\" unknown\r\n/home/runner/work/joplin/joplin/packages/tools/../../packages/tools/locales/pt_BR.po:168: keyword \"toggle\" unknown\r\n/home/runner/work/joplin/joplin/packages/tools/../../packages/tools/locales/pt_BR.po:191: missing 'msgstr' section\r\n/home/runner/work/joplin/joplin/packages/tools/../../packages/tools/locales/pt_BR.po:191:22: syntax error\r\n/home/runner/work/joplin/joplin/packages/tools/../../packages/tools/locales/pt_BR.po:192: keyword \"s\" unknown\r\n/home/runner/work/joplin/joplin/packages/tools/../../packages/tools/locales/pt_BR.po:194: missing 'msgstr' section\r\n/home/runner/work/joplin/joplin/packages/tools/../../packages/tools/locales/pt_BR.po:195: keyword \"s\" unknown\r\n/home/runner/work/joplin/joplin/packages/tools/../../packages/tools/locales/pt_BR.po:275: keyword \"ignored\" unknown\r\n/home/runner/work/joplin/joplin/packages/tools/../../packages/tools/locales/pt_BR.po:275:59: syntax error\r\n/home/runner/work/joplin/joplin/packages/tools/../../packages/tools/locales/pt_BR.po:276: keyword \"ignoradas\" unknown\r\n/home/runner/work/joplin/joplin/packages/tools/../../packages/tools/locales/pt_BR.po:305: missing 'msgstr' section\r\n/home/runner/work/joplin/joplin/packages/tools/../../packages/tools/locales/pt_BR.po:305:29: syntax error\r\n/home/runner/work/joplin/joplin/packages/tools/../../packages/tools/locales/pt_BR.po:306: keyword \"s\" unknown\r\n/home/runner/work/joplin/joplin/packages/tools/../../packages/tools/locales/pt_BR.po:308: missing 'msgstr' section\r\nmsgfmt: too many errors, aborting\r\n\r\n at ChildProcess.exithandler (node:child_process:419:12)\r\n at ChildProcess.emit (node:events:513:28)\r\n at maybeClose (node:internal/child_process:1091:16)\r\n at ChildProcess._handle.onexit (node:internal/child_process:302:5) {\r\n code: 1,\r\n killed: false,\r\n signal: null,\r\n cmd: 'msgfmt -v \"/home/runner/work/joplin/joplin/packages/tools/../../packages/tools/locales/pt_BR.po\"'\r\n}\r\nError: Some .po files could not be validated\r\n at main (/home/runner/work/joplin/joplin/packages/tools/validate-translation.js:27:23)\r\n at process.processTicksAndRejections (node:internal/process/task_queues:95:5)\r\n```", + "reactions": { + "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2784279988/reactions", + "total_count": 0, + "+1": 0, + "-1": 0, + "laugh": 0, + "hooray": 0, + "confused": 0, + "heart": 0, + "rocket": 0, + "eyes": 0 + }, + "performed_via_github_app": null + } + ] +} \ No newline at end of file