1
0
mirror of https://github.com/laurent22/joplin.git synced 2025-11-29 22:48:10 +02:00

fix for #906, 1) windows paths like C:\a\b weren't accepted because b… (#935)

* fix for #906, 1) windows paths like C:\a\b weren't accepted because backslashes were treated as escape sequences, 2) common paths like C:\Program Files\Foo\Foo.exe weren't accepted because of the space in the path

* Using anothing approach,
a) backslashes are no longer treated as escape characters,
b) string change to remind people to add spaces

* Removing joplin.pot from the patch, it will be updated later.

* Removing unused code.
This commit is contained in:
Ben Fisher
2018-11-20 13:46:18 -08:00
committed by Laurent Cozic
parent 0a0afd7245
commit 58b68cab0c
3 changed files with 12 additions and 5 deletions

View File

@@ -127,8 +127,7 @@ class ExternalEditWatcher {
const editorCommand = Setting.value('editor');
if (!editorCommand) return null;
const s = splitCommandString(editorCommand);
const s = splitCommandString(editorCommand, {handleEscape: false});
const path = s.splice(0, 1);
if (!path.length) throw new Error('Invalid editor command: ' + editorCommand);