self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2024-11-24 08:12:24 +02:00
Code Issues Releases Activity

All: Refresh sidebar and notes when moving note outside of conflict folder

Browse Source
This commit is contained in:
Laurent Cozic 2020-11-19 16:21:24 +00:00
parent a40ab434ca
commit 61618fb37c
3 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/lib/BaseApplication.ts
View File

@ -542,7 +542,11 @@ export default class BaseApplication {
} }
if (action.type === 'NOTE_UPDATE_ONE') { if (action.type === 'NOTE_UPDATE_ONE') {
if (!action.changedFields.length || action.changedFields.includes('parent_id') || action.changedFields.includes('encryption_applied')) { if (!action.changedFields.length ||
action.changedFields.includes('parent_id') ||
action.changedFields.includes('encryption_applied') ||
action.changedFields.includes('is_conflict')
) {
refreshFolders = true; refreshFolders = true;
} }
} }

2
packages/lib/models/Note.js
View File

@ -276,7 +276,7 @@ class Note extends BaseItem {
includeTimestamps: true, includeTimestamps: true,
}, options); }, options);
const output = ['id', 'title', 'is_todo', 'todo_completed', 'todo_due', 'parent_id', 'encryption_applied', 'order', 'markup_language']; const output = ['id', 'title', 'is_todo', 'todo_completed', 'todo_due', 'parent_id', 'encryption_applied', 'order', 'markup_language', 'is_conflict'];
if (options.includeTimestamps) { if (options.includeTimestamps) {
output.push('updated_time'); output.push('updated_time');

10
packages/lib/reducer.ts
View File

@ -787,8 +787,14 @@ const reducer = produce((draft: Draft<State> = defaultState, action: any) => {
for (let i = 0; i < newNotes.length; i++) { for (let i = 0; i < newNotes.length; i++) {
const n = newNotes[i]; const n = newNotes[i];
if (n.id == modNote.id) { if (n.id == modNote.id) {
// Note is still in the same folder if (n.is_conflict && !modNote.is_conflict) {
if (isViewingAllNotes || noteIsInFolder(modNote, n.parent_id)) { // Note was a conflict but was moved outside of
// the conflict folder
newNotes.splice(i, 1);
noteFolderHasChanged = true;
movedNotePreviousIndex = i;
} else if (isViewingAllNotes || noteIsInFolder(modNote, n.parent_id)) {
// Note is still in the same folder
// Merge the properties that have changed (in modNote) into // Merge the properties that have changed (in modNote) into
// the object we already have. // the object we already have.
newNotes[i] = Object.assign({}, newNotes[i]); newNotes[i] = Object.assign({}, newNotes[i]);