1
0
mirror of https://github.com/laurent22/joplin.git synced 2025-07-16 00:14:34 +02:00

Tools: Rewrite randomly failing test (#3328)

This commit is contained in:
Naveen M V
2020-06-05 20:35:47 +05:30
committed by GitHub
parent 0f4a781df0
commit 643b06ffa7

View File

@ -172,12 +172,10 @@ describe('feature_NoteHistory', function() {
it('should ensure no adjacent duplicates', asyncTest(async () => { it('should ensure no adjacent duplicates', asyncTest(async () => {
const folders = await createNTestFolders(2); const folders = await createNTestFolders(2);
await testApp.wait(); const notes0 = await createNTestNotes(3, folders[0]);
const notes0 = await createNTestNotes(5, folders[0]);
await testApp.wait(); await testApp.wait();
testApp.dispatch({ type: 'FOLDER_SELECT', id: id(folders[0]) }); testApp.dispatch({ type: 'FOLDER_SELECT', id: id(folders[0]) });
await testApp.wait();
testApp.dispatch({ type: 'NOTE_SELECT', id: notes0[0].id }); testApp.dispatch({ type: 'NOTE_SELECT', id: notes0[0].id });
await testApp.wait(); await testApp.wait();
@ -186,28 +184,16 @@ describe('feature_NoteHistory', function() {
await testApp.wait(); await testApp.wait();
goToNote(testApp, notes0[2]); goToNote(testApp, notes0[2]);
await testApp.wait(); await testApp.wait();
goToNote(testApp, notes0[3]); goToNote(testApp, notes0[1]);
await testApp.wait(); await testApp.wait();
goToNote(testApp, notes0[2]); goToNote(testApp, notes0[2]);
await testApp.wait(); await testApp.wait();
goToNote(testApp, notes0[3]);
await testApp.wait();
goToNote(testApp, notes0[2]);
await testApp.wait();
goToNote(testApp, notes0[3]);
await testApp.wait();
goToNote(testApp, notes0[2]);
await testApp.wait();
goToNote(testApp, notes0[3]);
await testApp.wait();
goToNote(testApp, notes0[2]);
await testApp.wait();
goToNote(testApp, notes0[3]);
await testApp.wait();
let state = testApp.store().getState(); let state = testApp.store().getState();
expect(state.selectedNoteIds).toEqual([notes0[2].id]);
expect(state.selectedFolderId).toEqual(folders[0].id);
goBackWard(state); testApp.dispatch({ type: 'NOTE_DELETE', id: notes0[1].id });
await testApp.wait(); await testApp.wait();
state = testApp.store().getState(); state = testApp.store().getState();
@ -215,33 +201,11 @@ describe('feature_NoteHistory', function() {
expect(state.selectedFolderId).toEqual(folders[0].id); expect(state.selectedFolderId).toEqual(folders[0].id);
goBackWard(state); goBackWard(state);
state = testApp.store().getState();
expect(state.selectedNoteIds).toEqual([notes0[3].id]);
expect(state.selectedFolderId).toEqual(folders[0].id);
goBackWard(state);
state = testApp.store().getState();
expect(state.selectedNoteIds).toEqual([notes0[2].id]);
expect(state.selectedFolderId).toEqual(folders[0].id);
goBackWard(state);
state = testApp.store().getState();
expect(state.selectedNoteIds).toEqual([notes0[3].id]);
expect(state.selectedFolderId).toEqual(folders[0].id);
testApp.dispatch({ type: 'NOTE_DELETE', id: notes0[2].id });
await testApp.wait(); await testApp.wait();
state = testApp.store().getState(); state = testApp.store().getState();
expect(state.selectedNoteIds).toEqual([notes0[0].id]);
// These tests are randomly failing so disabling them for now. expect(state.selectedFolderId).toEqual(folders[0].id);
// https://github.com/laurent22/joplin/pull/2819#issuecomment-636551313
//
// expect(state.selectedNoteIds).toEqual([notes0[3].id]);
// expect(state.selectedFolderId).toEqual(folders[0].id);
})); }));
it('should ensure history is not corrupted when notes get deleted.', asyncTest(async () => { it('should ensure history is not corrupted when notes get deleted.', asyncTest(async () => {