From 675ef8aefdcadd67ebb960bf37a46eb1e3a2b80c Mon Sep 17 00:00:00 2001
From: Laurent Cozic <laurent@cozic.net>
Date: Fri, 14 Feb 2020 00:36:11 +0000
Subject: [PATCH] Mobile: Fixes #2141: Fixed links not working within TOC

---
 .../lib/joplin-renderer/webviewLib.js         | 110 ------------------
 ReactNativeClient/lib/renderers/webviewLib.js |  12 +-
 2 files changed, 8 insertions(+), 114 deletions(-)
 delete mode 100644 ReactNativeClient/lib/joplin-renderer/webviewLib.js

diff --git a/ReactNativeClient/lib/joplin-renderer/webviewLib.js b/ReactNativeClient/lib/joplin-renderer/webviewLib.js
deleted file mode 100644
index 4f9a34e67..000000000
--- a/ReactNativeClient/lib/joplin-renderer/webviewLib.js
+++ /dev/null
@@ -1,110 +0,0 @@
-const webviewLib = {};
-
-let manualDownloadResourceElements = [];
-
-webviewLib.onUnloadedResourceClick = function(event) {
-	const resourceId = event.currentTarget.getAttribute('data-resource-id');
-	webviewLib.options_.postMessage(`markForDownload:${resourceId}`);
-};
-
-webviewLib.setupResourceManualDownload = function() {
-	for (const element of manualDownloadResourceElements) {
-		element.style.cursor = 'default';
-		element.removeEventListener('click', webviewLib.onUnloadedResourceClick);
-	}
-
-	manualDownloadResourceElements = [];
-
-	const elements = document.getElementsByClassName('resource-status-notDownloaded');
-
-	for (const element of elements) {
-		element.style.cursor = 'pointer';
-		element.addEventListener('click', webviewLib.onUnloadedResourceClick);
-		manualDownloadResourceElements.push(element);
-	}
-};
-
-webviewLib.handleInternalLink = function(event, anchorNode) {
-	const href = anchorNode.getAttribute('href');
-	if (!href) return false;
-
-	if (href.indexOf('#') === 0) {
-		event.preventDefault();
-		let old_hash = location.hash;
-
-		location.hash = href;
-
-		// HACK
-		// For some reason anchors at the bottom cause the webview to move itself
-		// so that the content is aligned with the top of the screen
-		// This basically refreshes the scroll view so that is returns to a normal
-		// position, the scroll positions stays correct though
-		// Additionally an anchor could not be clicked twice because the location
-		// would not change, this fixes that also
-		setTimeout(function() {
-			location.hash = old_hash;
-		}, 10);
-		return true;
-	}
-
-	return false;
-};
-
-webviewLib.getParentAnchorElement = function(element) {
-	let counter = 0;
-	while (true) {
-		if (counter++ >= 10000) {
-			console.warn('been looping for too long - exiting');
-			return null;
-		}
-
-		if (!element) return null;
-		if (element.nodeName === 'A') return element;
-		element = element.parentElement;
-	}
-};
-
-webviewLib.cloneError = function(error) {
-	return {
-		message: error.message,
-		stack: error.stack,
-	};
-};
-
-webviewLib.logEnabledEventHandler = function(fn) {
-	return function(event) {
-		try {
-			return fn(event);
-		} catch (error) {
-			webviewLib.options_.postMessage(`error:${JSON.stringify(webviewLib.cloneError(error))}`);
-			throw error;
-		}
-	};
-};
-
-webviewLib.initialize = function(options) {
-	webviewLib.options_ = options;
-};
-
-document.addEventListener('click', function(event) {
-	const anchor = webviewLib.getParentAnchorElement(event.target);
-	if (!anchor) return;
-
-	// Prevent URLs added via <a> tags from being opened within the application itself
-	// otherwise it would open the whole website within the WebView.
-
-	// Note that we already handle some links in html_inline.js, however not all of them
-	// go through this plugin, in particular links coming from third-party packages such
-	// as Katex.
-	if (!anchor.hasAttribute('data-from-md')) {
-		if (webviewLib.handleInternalLink(event, anchor)) return;
-		event.preventDefault();
-		if (anchor.getAttribute('href')) webviewLib.options_.postMessage(anchor.getAttribute('href'));
-		return;
-	}
-
-	// If this is an internal link, jump to the anchor directly
-	if (anchor.hasAttribute('data-from-md')) {
-		if (webviewLib.handleInternalLink(event, anchor)) return;
-	}
-});
diff --git a/ReactNativeClient/lib/renderers/webviewLib.js b/ReactNativeClient/lib/renderers/webviewLib.js
index 4f9a34e67..a3798dfc7 100644
--- a/ReactNativeClient/lib/renderers/webviewLib.js
+++ b/ReactNativeClient/lib/renderers/webviewLib.js
@@ -30,7 +30,7 @@ webviewLib.handleInternalLink = function(event, anchorNode) {
 
 	if (href.indexOf('#') === 0) {
 		event.preventDefault();
-		let old_hash = location.hash;
+		// let old_hash = location.hash;
 
 		location.hash = href;
 
@@ -41,9 +41,13 @@ webviewLib.handleInternalLink = function(event, anchorNode) {
 		// position, the scroll positions stays correct though
 		// Additionally an anchor could not be clicked twice because the location
 		// would not change, this fixes that also
-		setTimeout(function() {
-			location.hash = old_hash;
-		}, 10);
+		//
+		// Commented out to fix https://github.com/laurent22/joplin/issues/2141
+		// We might need to fix a better fix to the previous bug.
+		//
+		// setTimeout(function() {
+		// 	location.hash = old_hash;
+		// }, 10);
 		return true;
 	}