Linter update (#1777)

* Update eslint config

* Applied linter to lib

* Applied eslint config to CliClient/app

* Removed prettier due to https://github.com/prettier/prettier/pull/4765

* First pass on test units

* Applied linter config to test units

* Applied eslint config to clipper

* Applied to plugin dir

* Applied to root of ElectronClient

* Applied on RN root

* Applied on CLI root

* Applied on Clipper root

* Applied config to tools

* test hook

* test hook

* test hook

* Added pre-commit hook

* Applied rule no-trailing-spaces

* Make sure root packages are installed when installing sub-dir

* Added doc

ReactNativeClient/lib/components/shared/note-screen-shared.js

@@ -188,6 +188,7 @@ shared.attachedResources = async function(noteBody) {
 				localState: localState,
 			};
 
+			// eslint-disable-next-line require-atomic-updates
 			resourceCache_[id] = o;
 			output[id] = o;
 		}
@@ -229,6 +230,7 @@ shared.initState = async function(comp) {
 		this.noteComponent_change(comp, 'body', comp.props.sharedData.value);
 	}
 
+	// eslint-disable-next-line require-atomic-updates
 	comp.lastLoadedNoteId_ = note ? note.id : null;
 };
 

ReactNativeClient/lib/components/shared/side-menu-shared.js

@@ -1,4 +1,3 @@
-const ArrayUtils = require('lib/ArrayUtils');
 const Folder = require('lib/models/Folder');
 const BaseModel = require('lib/BaseModel');
 
@@ -22,8 +21,6 @@ function folderIsVisible(folders, folderId, collapsedFolderIds) {
 		if (collapsedFolderIds.indexOf(folder.parent_id) >= 0) return false;
 		folderId = folder.parent_id;
 	}
-
-	return true;
 }
 
 function renderFoldersRecursive_(props, renderItem, items, parentId, depth, order) {
@@ -85,7 +82,6 @@ shared.renderTags = function(props, renderItem) {
 // }
 
 shared.synchronize_press = async function(comp) {
-	const Setting = require('lib/models/Setting.js');
 	const { reg } = require('lib/registry.js');
 
 	const action = comp.props.syncStarted ? 'cancel' : 'start';