Tools: Ignore existing components for react-hook rule

.eslintrc.js

@@ -6,6 +6,11 @@ module.exports = {
 	},
 	"parser": "@typescript-eslint/parser",
 	'extends': ['eslint:recommended'],
+	"settings": {
+		'react': {
+			'version': '16.12',
+		},
+	},
 	'globals': {
 		'Atomics': 'readonly',
 		'SharedArrayBuffer': 'readonly',

CONTRIBUTING.md

@@ -54,27 +54,9 @@ The tests are under CliClient/tests. To get them running, you first need to buil
 
     cd CliClient
     npm i
+    ./build.sh
 
-To run the test units, you must have an instance of the cli app running. In a first window navigate into `CliClient` and run:
-
-```sh
-./run.sh
-```
-
-> If you get an error like `Error: Cannot find module '../locales/index.js'`, this means you must (a) rebuild translations or (b) take > them from one of the other apps. To do option b, you can run the following command to copy them from the `ReactNativeClient` directory:> 
->
-> ```sh
-> cd .. # Return to the root of the project
-> rsync -aP ./ReactNativeClient/locales/ ./CliClient/build/locales/
-> ```
-
-> If you get an error like `Error: Cannot find module './path/to/node_sqlite3.node'`, that likely means you need to install sqlite:
->
-> ```sh
-> npm install sqlite3 --build-from-source
-> ```
-
-Then run the tests in a second window. To run all the test units:
+To run all the test units:
 
     ./run_test.sh
 

Clipper/joplin-webclipper/popup/src/App.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 import React, { Component } from 'react';
 import './App.css';
 import led_red from './led_red.png';

ElectronClient/app/gui/ClipperConfigScreen.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { connect } = require('react-redux');
 const { bridge } = require('electron').remote.require('./bridge');

ElectronClient/app/gui/ConfigMenuBar.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const styleSelector = require('./style/ConfigMenuBar');
 const Setting = require('lib/models/Setting');

ElectronClient/app/gui/ConfigScreen.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { connect } = require('react-redux');
 const Setting = require('lib/models/Setting.js');

ElectronClient/app/gui/DialogButtonRow.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { _ } = require('lib/locale.js');
 const { themeStyle } = require('../theme.js');

ElectronClient/app/gui/DropboxLoginScreen.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { connect } = require('react-redux');
 const { bridge } = require('electron').remote.require('./bridge');

ElectronClient/app/gui/EncryptionConfigScreen.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { connect } = require('react-redux');
 const Setting = require('lib/models/Setting');

ElectronClient/app/gui/ExtensionBadge.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { bridge } = require('electron').remote.require('./bridge');
 const styleSelector = require('./style/ExtensionBadge');

ElectronClient/app/gui/Header.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { connect } = require('react-redux');
 const { themeStyle } = require('../theme.js');

ElectronClient/app/gui/HelpButton.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { connect } = require('react-redux');
 const { themeStyle } = require('../theme.js');

ElectronClient/app/gui/IconButton.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { themeStyle } = require('../theme.js');
 

ElectronClient/app/gui/ImportScreen.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { connect } = require('react-redux');
 const Folder = require('lib/models/Folder.js');

ElectronClient/app/gui/ItemList.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 
 class ItemList extends React.Component {

ElectronClient/app/gui/MainScreen.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { connect } = require('react-redux');
 const { Header } = require('./Header.min.js');

ElectronClient/app/gui/Navigator.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const Component = React.Component;
 const { connect } = require('react-redux');

ElectronClient/app/gui/NoteList.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const { ItemList } = require('./ItemList.min.js');
 const React = require('react');
 const { connect } = require('react-redux');

ElectronClient/app/gui/NotePropertiesDialog.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { _ } = require('lib/locale.js');
 const { themeStyle } = require('../theme.js');

ElectronClient/app/gui/NoteRevisionViewer.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { connect } = require('react-redux');
 const { themeStyle } = require('../theme.js');

ElectronClient/app/gui/NoteSearchBar.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { connect } = require('react-redux');
 const { themeStyle } = require('../theme.js');

ElectronClient/app/gui/NoteStatusBar.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { connect } = require('react-redux');
 const { time } = require('lib/time-utils.js');

ElectronClient/app/gui/NoteText.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const Note = require('lib/models/Note.js');
 const BaseItem = require('lib/models/BaseItem.js');

ElectronClient/app/gui/NoteTextViewer.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { connect } = require('react-redux');
 

ElectronClient/app/gui/OneDriveLoginScreen.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { connect } = require('react-redux');
 const { reg } = require('lib/registry.js');

ElectronClient/app/gui/PromptDialog.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { _ } = require('lib/locale.js');
 const { themeStyle } = require('../theme.js');

ElectronClient/app/gui/Root.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { render } = require('react-dom');
 const { connect, Provider } = require('react-redux');

ElectronClient/app/gui/ShareNoteDialog.tsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 import * as React from 'react';
 import { useState, useEffect } from 'react';
 import JoplinServerApi from '../lib/JoplinServerApi';

ElectronClient/app/gui/SideBar.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { connect } = require('react-redux');
 const shared = require('lib/components/shared/side-menu-shared.js');

ElectronClient/app/gui/StatusScreen.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { connect } = require('react-redux');
 const Setting = require('lib/models/Setting.js');

ElectronClient/app/gui/TagItem.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { connect } = require('react-redux');
 const { themeStyle } = require('../theme.js');

ElectronClient/app/gui/TagList.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { connect } = require('react-redux');
 const { themeStyle } = require('../theme.js');

ElectronClient/app/gui/Toolbar.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { connect } = require('react-redux');
 const { themeStyle } = require('../theme.js');

ElectronClient/app/gui/ToolbarButton.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { themeStyle } = require('../theme.js');
 

ElectronClient/app/gui/ToolbarSpace.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { themeStyle } = require('../theme.js');
 

ElectronClient/app/gui/VerticalResizer.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { bridge } = require('electron').remote.require('./bridge');
 

ElectronClient/app/gui/dialogs.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const smalltalk = require('smalltalk');
 
 class Dialogs {

ElectronClient/app/plugins/GotoAnything.jsx

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { connect } = require('react-redux');
 const { _ } = require('lib/locale.js');

ReactNativeClient/lib/components/CameraView.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const Component = React.Component;
 const { connect } = require('react-redux');

ReactNativeClient/lib/components/Dropdown.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { TouchableOpacity, TouchableWithoutFeedback, Dimensions, Text, Modal, View } = require('react-native');
 const { ItemList } = require('lib/components/ItemList.js');

ReactNativeClient/lib/components/ItemList.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { View, ScrollView } = require('react-native');
 

ReactNativeClient/lib/components/ModalDialog.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { Text, Modal, View, StyleSheet, Button } = require('react-native');
 const { themeStyle } = require('lib/components/global-style.js');

ReactNativeClient/lib/components/action-button.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 
 const { StyleSheet } = require('react-native');

ReactNativeClient/lib/components/app-nav.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const Component = React.Component;
 const { connect } = require('react-redux');

ReactNativeClient/lib/components/base-screen.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 
 const { StyleSheet } = require('react-native');

ReactNativeClient/lib/components/checkbox.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const Component = React.Component;
 const { View, TouchableHighlight } = require('react-native');

ReactNativeClient/lib/components/global-style.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const Setting = require('lib/models/Setting.js');
 const { Platform } = require('react-native');
 

ReactNativeClient/lib/components/note-body-viewer.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const Component = React.Component;
 const { Platform, View, Text } = require('react-native');

ReactNativeClient/lib/components/note-item.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const Component = React.Component;
 const { connect } = require('react-redux');

ReactNativeClient/lib/components/note-list.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const Component = React.Component;
 const { connect } = require('react-redux');

ReactNativeClient/lib/components/screen-header.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 
 const { connect } = require('react-redux');

ReactNativeClient/lib/components/screens/NoteTagsDialog.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 
 const { StyleSheet, View, Text, FlatList, TouchableOpacity, TextInput } = require('react-native');

ReactNativeClient/lib/components/screens/config.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { Platform, TouchableOpacity, Linking, View, Switch, StyleSheet, Text, Button, ScrollView, TextInput, Alert } = require('react-native');
 const { connect } = require('react-redux');

ReactNativeClient/lib/components/screens/dropbox-login.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 
 const { View, Button, Text, TextInput, TouchableOpacity, StyleSheet, ScrollView } = require('react-native');

ReactNativeClient/lib/components/screens/encryption-config.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 
 const { TextInput, TouchableOpacity, Linking, View, StyleSheet, Text, Button, ScrollView } = require('react-native');

ReactNativeClient/lib/components/screens/folder.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 
 const { View, TextInput, StyleSheet } = require('react-native');

ReactNativeClient/lib/components/screens/log.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 
 const { ListView, View, Text, Button, StyleSheet, Platform } = require('react-native');

ReactNativeClient/lib/components/screens/note.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { Platform, Clipboard, Keyboard, View, TextInput, StyleSheet, Linking, Image, Share } = require('react-native');
 const { connect } = require('react-redux');

ReactNativeClient/lib/components/screens/notes.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 
 const { AppState, View, StyleSheet } = require('react-native');

ReactNativeClient/lib/components/screens/onedrive-login.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 
 const { View } = require('react-native');

ReactNativeClient/lib/components/screens/search.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 
 const { StyleSheet, View, TextInput, FlatList, TouchableHighlight } = require('react-native');

ReactNativeClient/lib/components/screens/status.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 
 const { StyleSheet, View, Text, Button, FlatList } = require('react-native');

ReactNativeClient/lib/components/screens/tags.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 
 const { View, Text, FlatList, StyleSheet, TouchableOpacity } = require('react-native');

ReactNativeClient/lib/components/select-date-time-dialog.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 import React from 'react';
 import { View } from 'react-native';
 import PopupDialog, { DialogTitle, DialogButton } from 'react-native-popup-dialog';

ReactNativeClient/lib/components/side-menu-content-note.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const Component = React.Component;
 const { TouchableOpacity, Text, StyleSheet, ScrollView, View } = require('react-native');

ReactNativeClient/lib/components/side-menu-content.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const Component = React.Component;
 const { Easing, Animated, TouchableOpacity, Text, StyleSheet, ScrollView, View, Alert } = require('react-native');

ReactNativeClient/lib/components/side-menu.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const { connect } = require('react-redux');
 const SideMenu_ = require('react-native-side-menu').default;
 

ReactNativeClient/root.js

@@ -1,3 +1,5 @@
+/* eslint-disable enforce-react-hooks/enforce-react-hooks */
+
 const React = require('react');
 const { AppState, Keyboard, NativeModules, BackHandler, Platform, Animated } = require('react-native');
 const { SafeAreaView } = require('react-navigation');