self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2025-07-16 00:14:34 +02:00
Code Issues Releases Activity

Cli,Desktop,Mobile: Resolves #9465: Log user actions (deletions) (#9585)

Browse Source
This commit is contained in:
Henry Heino
2024-03-09 02:33:05 -08:00
committed by GitHub
parent 3222b620b9
commit 75cb639ed2
36 changed files with 182 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/lib/models/Note.ts
View File

@ -16,6 +16,7 @@ const { pregQuote, substrWithEllipsis } = require('../string-utils.js');
const { _ } = require('../locale');
import { pull, removeElement, unique } from '../ArrayUtils';
import { LoadOptions, SaveOptions } from './utils/types';
import ActionLogger from '../utils/ActionLogger';
import { getDisplayParentId, getTrashFolderId } from '../services/trash';
const urlUtils = require('../urlUtils.js');
const { isImageMimeType } = require('../resourceUtils');
@ -827,7 +828,7 @@ export default class Note extends BaseItem {
return savedNote;
}
public static async batchDelete(ids: string[], options: DeleteOptions = null) {
public static async batchDelete(ids: string[], options: DeleteOptions = {}) {
if (!ids.length) return;
ids = ids.slice();
@ -871,7 +872,12 @@ export default class Note extends BaseItem {
await this.db().exec({ sql, params });
} else {
await super.batchDelete(processIds, options);
// For now, we intentionally log only permanent batchDeletions.
const actionLogger = ActionLogger.from(options.sourceDescription);
const noteTitles = notes.map(note => note.title);
actionLogger.addDescription(`titles: ${JSON.stringify(noteTitles)}`);
await super.batchDelete(processIds, { ...options, sourceDescription: actionLogger });
}
for (let i = 0; i < processIds.length; i++) {