self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2025-07-06 23:56:13 +02:00
Code Issues Releases Activity

Desktop, Mobile, Cli: Allow setting a minimum app version on the sync target (#9778)

Browse Source
This commit is contained in:
Laurent Cozic
2024-01-26 10:32:35 +00:00
committed by GitHub
parent 2cc4ac087b
commit 7b06090255
12 changed files with 166 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
packages/lib/services/synchronizer/Synchronizer.basics.test.ts
View File

@ -1,11 +1,13 @@
import Setting from '../../models/Setting';
import { allNotesFolders, remoteNotesAndFolders, localNotesFoldersSameAsRemote } from '../../testing/test-utils-synchronizer';
import { syncTargetName, afterAllCleanUp, synchronizerStart, setupDatabaseAndSynchronizer, synchronizer, sleep, switchClient, syncTargetId, fileApi } from '../../testing/test-utils';
import { syncTargetName, afterAllCleanUp, synchronizerStart, setupDatabaseAndSynchronizer, synchronizer, sleep, switchClient, syncTargetId, fileApi, expectThrow } from '../../testing/test-utils';
import Folder from '../../models/Folder';
import Note from '../../models/Note';
import BaseItem from '../../models/BaseItem';
import WelcomeUtils from '../../WelcomeUtils';
import { NoteEntity } from '../database/types';
import { fetchSyncInfo, setAppMinVersion, uploadSyncInfo } from './syncInfoUtils';
import { ErrorCode } from '../../errors';
describe('Synchronizer.basics', () => {
@ -459,4 +461,40 @@ describe('Synchronizer.basics', () => {
expect(remotes.find(r => r.path === `${note.id}.md`)).toBeTruthy();
}));
it('should throw an error if the app version is not compatible with the sync target info', (async () => {
await synchronizerStart();
const remoteInfo = await fetchSyncInfo(synchronizer().api());
remoteInfo.appMinVersion = '100.0.0';
await uploadSyncInfo(synchronizer().api(), remoteInfo);
await expectThrow(async () => synchronizerStart(1, {
throwOnError: true,
}), ErrorCode.MustUpgradeApp);
}));
it('should update the remote appMinVersion when synchronising', (async () => {
await synchronizerStart();
const remoteInfoBefore = await fetchSyncInfo(synchronizer().api());
// Simulates upgrading the client
setAppMinVersion('100.0.0');
await synchronizerStart();
// Then after sync, appMinVersion should be the same as that client version
const remoteInfoAfter = await fetchSyncInfo(synchronizer().api());
expect(remoteInfoBefore.appMinVersion).toBe('0.0.0');
expect(remoteInfoAfter.appMinVersion).toBe('100.0.0');
// Now simulates synchronising with an older client version. In that case, it should not be
// allowed and the remote info.json should not change.
setAppMinVersion('80.0.0');
await expectThrow(async () => synchronizerStart(1, { throwOnError: true }), ErrorCode.MustUpgradeApp);
expect((await fetchSyncInfo(synchronizer().api())).appMinVersion).toBe('100.0.0');
}));
});