From 7f95186a97cd9c14ba8087fe57aa4a1ed50c8673 Mon Sep 17 00:00:00 2001 From: Laurent Cozic Date: Sat, 18 Jan 2020 13:08:23 +0000 Subject: [PATCH] Doc: Updated GSoC ideas and added section about abandoned pull requests --- CONTRIBUTING.md | 10 ++++++++++ joplin.code-workspace | 10 +++++++++- readme/gsoc2020/ideas.md | 6 +++--- 3 files changed, 22 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c146d9a16..eb09d6b17 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -78,3 +78,13 @@ Then run the tests in a second window. To run all the test units: To run just one particular file: ./run_test.sh markdownUtils # Don't add the .js extension + +## About abandoned pull requests + +It happens that a pull request is started but not finished and despite our attempts to contact the contributor, we don’t hear from them again. + +In that case we will not merge the pull request, even if only small changes are missing. Our policy is simply to close the pull request. Why? Because an unfinished pull request essentially means giving us work and moving on. We would rather not encourage this behaviour. + +Also, please note that since we have spent time reviewing the pull request and proposing solutions, we reserve the right to re-use that knowledge to create a new pull request, potentially based on your changes. + +We’d much prefer that you complete the pull request though, so we’ll be sure to ping you a few times before that! diff --git a/joplin.code-workspace b/joplin.code-workspace index 8d3035529..e38243287 100644 --- a/joplin.code-workspace +++ b/joplin.code-workspace @@ -82,6 +82,14 @@ "ReactNativeClient/node_modules/": true, "Server/db*.sqlite/": true, "Server/dist/": true, - } + }, + "spellright.language": [ + "en" + ], + "spellright.documentTypes": [ + "markdown", + "latex", + "plaintext" + ] }, } \ No newline at end of file diff --git a/readme/gsoc2020/ideas.md b/readme/gsoc2020/ideas.md index 589b8246f..60a181e72 100644 --- a/readme/gsoc2020/ideas.md +++ b/readme/gsoc2020/ideas.md @@ -123,7 +123,7 @@ Difficulty Level: Medium Skills Required: JavaScript; React -Potential Mentor(s): [laurent22](https://github.com/laurent22/) +Potential Mentor(s): [PackElend](https://github.com/PackElend), [laurent22](https://github.com/laurent22/) ## 7. Search @@ -147,7 +147,7 @@ Difficulty Level: Medium Skills Required: JavaScript -Potential Mentor(s): [tessus](https://github.com/tessus), [laurent22](https://github.com/laurent22/) +Potential Mentor(s): [laurent22](https://github.com/laurent22/) More info: [Search engine improvements](https://github.com/laurent22/joplin/issues/1877) @@ -161,7 +161,7 @@ Difficulty Level: High Skills Required: JavaScript; React -Potential Mentor(s): [laurent22](https://github.com/laurent22/) +Potential Mentor(s): [PackElend](https://github.com/PackElend), [laurent22](https://github.com/laurent22/) More info: [WYSIWYG thread on the forum](https://discourse.joplinapp.org/t/wysiwyg-editor-in-joplin/2253)