self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2024-12-24 10:27:10 +02:00
Code Issues Releases Activity

Update pull_request_guidelines.md

Browse Source
This commit is contained in:
Laurent 2021-03-12 11:18:08 +00:00 committed by GitHub
parent dcbb6f5dd2
commit 7fb1692565
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
readme/gsoc2021/pull_request_guidelines.md
View File

@ -16,6 +16,6 @@ Due to our limited resources and in order to give everyone a chance to submit a
7. Please **do not `@mention` contributors and mentors**. Sometimes it takes time before we can review your pull request or answer your questions but we'll get to it sooner or later. `@mentioning` someone just adds to the pile of notifications we get and it won't make us look at your issue faster.
8. **Do not force push**. If you make changes to your pull request, please simply add a new commit as that makes it easy for us to review your new changes. If you force push, we'll have to review everything from the beginning. Additionally, force push often leads to situation where unrelated changes from other commits get added to the pull request, and you need to avoid this. As with the other rules, if we need to ask you multiple times to fix your pull request, we might have to close it as we cannot dedicate that much time dealing with basic git operations.
8. **Do not force push**. If you make changes to your pull request, please simply add a new commit as that makes it easy for us to review your new changes. If you force push, we'll have to review everything from the beginning.
These rules we hope are fair to everyone, to contributors and maintainers, however if something is unclear or you have any question about them, please let us know!