self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2025-11-29 22:48:10 +02:00
Code Issues Releases Activity

Mobile: Plugins: Make panel opening/closing more consistent with desktop (#10385)

Browse Source
This commit is contained in:
Henry Heino
2024-05-02 06:59:50 -07:00
committed by GitHub
parent 4056fc2281
commit 85f890e7c5
4 changed files with 86 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
packages/app-mobile/components/ScreenHeader/index.tsx
View File

@@ -34,12 +34,17 @@ const PADDING_V = 10;
type OnSelectCallbackType=()=> void;
type OnPressCallback=()=> void;
export interface MenuOptionType {
export type MenuOptionType = {
onPress: OnPressCallback;
isDivider?: boolean;
title: string;
disabled?: boolean;
}
}|{
isDivider: true;
title?: undefined;
onPress?: undefined;
disabled?: false;
};
interface ScreenHeaderProps {
selectedNoteIds: string[];
@@ -427,8 +432,10 @@ class ScreenHeaderComponent extends PureComponent<ScreenHeaderProps, ScreenHeade
// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
const pluginPanelToggleButton = (styles: any, onPress: OnPressCallback) => {
const allPluginViews = Object.values(this.props.plugins).map(plugin => Object.values(plugin.views)).flat();
const allPanels = allPluginViews.filter(view => view.containerType === ContainerType.Panel);
if (allPanels.length === 0) return null;
const allVisiblePanels = allPluginViews.filter(
view => view.containerType === ContainerType.Panel && view.opened,
);
if (allVisiblePanels.length === 0) return null;
return (
<CustomButton