First pass at linting lib dir

ReactNativeClient/lib/shim-init-node.js

@@ -10,9 +10,10 @@ const Note = require('lib/models/Note.js');
 const Resource = require('lib/models/Resource.js');
 const urlValidator = require('valid-url');
 
-
 function shimInit() {
-	shim.fsDriver = () => { throw new Error('Not implemented') }
+	shim.fsDriver = () => {
+		throw new Error('Not implemented');
+	};
 	shim.FileApiDriverLocal = FileApiDriverLocal;
 	shim.Geolocation = GeolocationNode;
 	shim.FormData = require('form-data');
@@ -21,14 +22,14 @@ function shimInit() {
 	shim.fsDriver = () => {
 		if (!shim.fsDriver_) shim.fsDriver_ = new FsDriverNode();
 		return shim.fsDriver_;
-	}
+	};
 
-	shim.randomBytes = async (count) => {
+	shim.randomBytes = async count => {
 		const buffer = require('crypto').randomBytes(count);
 		return Array.from(buffer);
-	}
+	};
 
-	shim.detectAndSetLocale = function (Setting) {
+	shim.detectAndSetLocale = function(Setting) {
 		let locale = process.env.LANG;
 		if (!locale) locale = defaultLocale();
 		locale = locale.split('.');
@@ -37,10 +38,11 @@ function shimInit() {
 		Setting.setValue('locale', locale);
 		setLocale(locale);
 		return locale;
-	}
+	};
 
 	shim.writeImageToFile = async function(nativeImage, mime, targetPath) {
-		if (shim.isElectron()) { // For Electron
+		if (shim.isElectron()) {
+			// For Electron
 			let buffer = null;
 
 			mime = mime.toLowerCase();
@@ -57,12 +59,13 @@ function shimInit() {
 		} else {
 			throw new Error('Node support not implemented');
 		}
-	}
+	};
 
 	const resizeImage_ = async function(filePath, targetPath, mime) {
 		const maxDim = Resource.IMAGE_MAX_DIMENSION;
 
-		if (shim.isElectron()) { // For Electron
+		if (shim.isElectron()) {
+			// For Electron
 			const nativeImage = require('electron').nativeImage;
 			let image = nativeImage.createFromPath(filePath);
 			if (image.isEmpty()) throw new Error('Image is invalid or does not exist: ' + filePath);
@@ -84,7 +87,8 @@ function shimInit() {
 			image = image.resize(options);
 
 			await shim.writeImageToFile(image, mime, targetPath);
-		} else { // For the CLI tool
+		} else {
+			// For the CLI tool
 			const sharp = require('sharp');
 
 			const image = sharp(filePath);
@@ -96,19 +100,21 @@ function shimInit() {
 			}
 
 			return new Promise((resolve, reject) => {
-				image.resize(Resource.IMAGE_MAX_DIMENSION, Resource.IMAGE_MAX_DIMENSION, {
-					fit: 'inside',
-					withoutEnlargement: true,
-				}).toFile(targetPath, (err, info) => {
-					if (err) {
-						reject(err);
-					} else {
-						resolve(info);
-					}
-				});
+				image
+					.resize(Resource.IMAGE_MAX_DIMENSION, Resource.IMAGE_MAX_DIMENSION, {
+						fit: 'inside',
+						withoutEnlargement: true,
+					})
+					.toFile(targetPath, (err, info) => {
+						if (err) {
+							reject(err);
+						} else {
+							resolve(info);
+						}
+					});
 			});
 		}
-	}
+	};
 
 	shim.createResourceFromPath = async function(filePath, defaultProps = null) {
 		const readChunk = require('read-chunk');
@@ -167,10 +173,9 @@ function shimInit() {
 		resource.size = fileStat.size;
 
 		return await Resource.save(resource, { isNew: true });
-	}
+	};
 
 	shim.attachFileToNote = async function(note, filePath, position = null, createFileURL = false) {
-
 		const { basename } = require('path');
 		const { escapeLinkText } = require('lib/markdownUtils');
 		const { toFileProtocolPath } = require('lib/path-utils');
@@ -192,7 +197,7 @@ function shimInit() {
 			newBody.push(Resource.markdownTag(resource));
 		} else {
 			let filename = escapeLinkText(basename(filePath)); // to get same filename as standard drag and drop
-			let fileURL = "[" + filename + "]("+ toFileProtocolPath(filePath) +")"
+			let fileURL = '[' + filename + '](' + toFileProtocolPath(filePath) + ')';
 			newBody.push(fileURL);
 		}
 
@@ -202,7 +207,7 @@ function shimInit() {
 			body: newBody.join('\n\n'),
 		});
 		return await Note.save(newNote);
-	}
+	};
 
 	shim.imageFromDataUrl = async function(imageDataUrl, filePath, options = null) {
 		if (options === null) options = {};
@@ -227,27 +232,27 @@ function shimInit() {
 
 			const imageDataURI = require('image-data-uri');
 			const result = imageDataURI.decode(imageDataUrl);
-			await shim.fsDriver().writeFile(filePath, result.dataBuffer, 'buffer');	
+			await shim.fsDriver().writeFile(filePath, result.dataBuffer, 'buffer');
 		}
-	}
+	};
 
 	const nodeFetch = require('node-fetch');
 
 	// Not used??
-	shim.readLocalFileBase64 = (path) => {
+	shim.readLocalFileBase64 = path => {
 		const data = fs.readFileSync(path);
 		return new Buffer(data).toString('base64');
-	}
+	};
 
 	shim.fetch = async function(url, options = null) {
 		const validatedUrl = urlValidator.isUri(url);
 		if (!validatedUrl) throw new Error('Not a valid URL: ' + url);
 
 		return shim.fetchWithRetry(() => {
-			return nodeFetch(url, options)
+			return nodeFetch(url, options);
 		}, options);
-	}
-	
+	};
+
 	shim.fetchBlob = async function(url, options) {
 		if (!options || !options.path) throw new Error('fetchBlob: target file path is missing');
 		if (!options.method) options.method = 'GET';
@@ -265,8 +270,12 @@ function shimInit() {
 			return {
 				ok: response.statusCode < 400,
 				path: filePath,
-				text: () => { return response.statusMessage; },
-				json: () => { return { message: response.statusCode + ': ' + response.statusMessage }; },
+				text: () => {
+					return response.statusMessage;
+				},
+				json: () => {
+					return { message: response.statusCode + ': ' + response.statusMessage };
+				},
 				status: response.statusCode,
 				headers: response.headers,
 			};
@@ -285,19 +294,21 @@ function shimInit() {
 			return new Promise((resolve, reject) => {
 				let file = null;
 
-				const cleanUpOnError = (error) => {
+				const cleanUpOnError = error => {
 					// We ignore any unlink error as we only want to report on the main error
-					fs.unlink(filePath).catch(() => {}).then(() => {
-						if (file) {
-							file.close(() => {
-								file = null;
+					fs.unlink(filePath)
+						.catch(() => {})
+						.then(() => {
+							if (file) {
+								file.close(() => {
+									file = null;
+									reject(error);
+								});
+							} else {
 								reject(error);
-							});
-						} else {
-							reject(error);
-						}						
-					});
-				}
+							}
+						});
+				};
 
 				try {
 					// Note: relative paths aren't supported
@@ -315,7 +326,7 @@ function shimInit() {
 								resolve(makeResponse(response));
 							});
 						});
-					})
+					});
 
 					request.on('error', function(error) {
 						cleanUpOnError(error);
@@ -329,30 +340,29 @@ function shimInit() {
 		};
 
 		return shim.fetchWithRetry(doFetchOperation, options);
-	}
+	};
 
 	shim.uploadBlob = async function(url, options) {
-		 if (!options || !options.path) throw new Error('uploadBlob: source file path is missing');
+		if (!options || !options.path) throw new Error('uploadBlob: source file path is missing');
 		const content = await fs.readFile(options.path);
 		options = Object.assign({}, options, {
 			body: content,
 		});
 		return shim.fetch(url, options);
-	}
+	};
 
 	shim.stringByteLength = function(string) {
 		return Buffer.byteLength(string, 'utf-8');
-	}
+	};
 
 	shim.Buffer = Buffer;
 
-	shim.openUrl = (url) => {
+	shim.openUrl = url => {
 		const { bridge } = require('electron').remote.require('./bridge');
-		bridge().openExternal(url)
-	}
-
-	shim.waitForFrame = () => {}
+		bridge().openExternal(url);
+	};
 
+	shim.waitForFrame = () => {};
 }
 
 module.exports = { shimInit };