self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2025-01-11 18:24:43 +02:00
Code Issues Releases Activity

Desktop: Fixes #4505: Make plugin links clickable from search (#4548)

Browse Source
This commit is contained in:
Roman Musin 2021-03-10 19:12:43 +00:00 committed by GitHub
parent 286a31a7f7
commit 876fcfe008
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
packages/app-desktop/gui/ConfigScreen/controls/plugins/PluginBox.tsx
View File

@ -1,5 +1,5 @@
import * as React from 'react'; import * as React from 'react';
import { useCallback } from 'react'; import { useCallback, useMemo } from 'react';
import { _ } from '@joplin/lib/locale'; import { _ } from '@joplin/lib/locale';
import styled from 'styled-components'; import styled from 'styled-components';
import ToggleButton from '../../../lib/ToggleButton/ToggleButton'; import ToggleButton from '../../../lib/ToggleButton/ToggleButton';
@ -134,12 +134,15 @@ const StyledDescription = styled.div`
`; `;
export default function(props: Props) { export default function(props: Props) {
const item = props.item ? props.item : manifestToItem(props.manifest); const item = useMemo(() => {
return props.item ? props.item : manifestToItem(props.manifest);
}, [props.item, props.manifest]);
const onNameClick = useCallback(() => { const onNameClick = useCallback(() => {
if (!props.item.manifest.homepage_url) return; const manifest = item.manifest;
bridge().openExternal(props.item.manifest.homepage_url); if (!manifest.homepage_url) return;
}, [props.item]); bridge().openExternal(manifest.homepage_url);
}, [item]);
// For plugins in dev mode things like enabling/disabling or // For plugins in dev mode things like enabling/disabling or
// uninstalling them doesn't make sense, as that should be done by // uninstalling them doesn't make sense, as that should be done by