self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2025-11-26 22:41:17 +02:00
Code Issues Releases Activity

All: Reducer should not mutate state

Browse Source
This commit is contained in:
Laurent Cozic
2020-06-25 20:27:14 +01:00
parent 20482b2f14
commit 87ccb86f54
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ReactNativeClient/lib/reducer.js
View File

@@ -467,14 +467,14 @@ function handleHistory(state, action) {
backwardHistoryNotes = backwardHistoryNotes.map(note => { backwardHistoryNotes = backwardHistoryNotes.map(note => {
if (note.id === modNote.id) { if (note.id === modNote.id) {
return Object.assign(note, { parent_id: modNote.parent_id, selectedFolderId: modNote.parent_id }); return Object.assign({}, note, { parent_id: modNote.parent_id, selectedFolderId: modNote.parent_id });
} }
return note; return note;
}); });
forwardHistoryNotes = forwardHistoryNotes.map(note => { forwardHistoryNotes = forwardHistoryNotes.map(note => {
if (note.id === modNote.id) { if (note.id === modNote.id) {
return Object.assign(note, { parent_id: modNote.parent_id, selectedFolderId: modNote.parent_id }); return Object.assign({}, note, { parent_id: modNote.parent_id, selectedFolderId: modNote.parent_id });
} }
return note; return note;
}); });