Tweaks to make sure Nextcloud driver passes all test units

CliClient/tests/synchronizer.js

@@ -322,7 +322,7 @@ describe('Synchronizer', function() {
 		await synchronizer().start();
 
 		let all = await allItems();
-		localItemsSameAsRemote(all, expect);
+		await localItemsSameAsRemote(all, expect);
 	}));
 
 	it('should delete local folder', asyncTest(async () => {
@@ -345,7 +345,7 @@ describe('Synchronizer', function() {
 		await synchronizer().start();
 
 		let items = await allItems();
-		localItemsSameAsRemote(items, expect);
+		await localItemsSameAsRemote(items, expect);
 	}));
 
 	it('should resolve conflict if remote folder has been deleted, but note has been added to folder locally', asyncTest(async () => {
@@ -388,7 +388,7 @@ describe('Synchronizer', function() {
 		expect(items.length).toBe(1);
 		expect(items[0].title).toBe('folder');
 
-		localItemsSameAsRemote(items, expect);
+		await localItemsSameAsRemote(items, expect);
 	}));
 
 	it('should cross delete all folders', asyncTest(async () => {

CliClient/tests/test-utils.js

@@ -15,6 +15,7 @@ const { Synchronizer } = require('lib/synchronizer.js');
 const { FileApi } = require('lib/file-api.js');
 const { FileApiDriverMemory } = require('lib/file-api-driver-memory.js');
 const { FileApiDriverLocal } = require('lib/file-api-driver-local.js');
+const { FileApiDriverWebDav } = require('lib/file-api-driver-webdav.js');
 const { FsDriverNode } = require('lib/fs-driver-node.js');
 const { time } = require('lib/time-utils.js');
 const { shimInit } = require('lib/shim-init-node.js');
@@ -22,8 +23,10 @@ const SyncTargetRegistry = require('lib/SyncTargetRegistry.js');
 const SyncTargetMemory = require('lib/SyncTargetMemory.js');
 const SyncTargetFilesystem = require('lib/SyncTargetFilesystem.js');
 const SyncTargetOneDrive = require('lib/SyncTargetOneDrive.js');
+const SyncTargetNextcloud = require('lib/SyncTargetNextcloud.js');
 const EncryptionService = require('lib/services/EncryptionService.js');
 const DecryptionWorker = require('lib/services/DecryptionWorker.js');
+const WebDavApi = require('lib/WebDavApi');
 
 let databases_ = [];
 let synchronizers_ = [];
@@ -46,13 +49,17 @@ fs.mkdirpSync(logDir, 0o755);
 SyncTargetRegistry.addClass(SyncTargetMemory);
 SyncTargetRegistry.addClass(SyncTargetFilesystem);
 SyncTargetRegistry.addClass(SyncTargetOneDrive);
+SyncTargetRegistry.addClass(SyncTargetNextcloud);
 
-//const syncTargetId_ = SyncTargetRegistry.nameToId('memory');
-const syncTargetId_ = SyncTargetRegistry.nameToId('filesystem');
+//const syncTargetId_ = SyncTargetRegistry.nameToId('nextcloud');
+const syncTargetId_ = SyncTargetRegistry.nameToId('memory');
+//const syncTargetId_ = SyncTargetRegistry.nameToId('filesystem');
 const syncDir = __dirname + '/../tests/sync';
 
 const sleepTime = syncTargetId_ == SyncTargetRegistry.nameToId('filesystem') ? 1001 : 400;
 
+console.info('Testing with sync target: ' + SyncTargetRegistry.idToName(syncTargetId_));
+
 const logger = new Logger();
 logger.addTarget('console');
 logger.addTarget('file', { path: logDir + '/log.txt' });
@@ -174,12 +181,14 @@ async function setupDatabaseAndSynchronizer(id = null) {
 	decryptionWorkers_[id] = new DecryptionWorker();
 	decryptionWorkers_[id].setEncryptionService(encryptionServices_[id]);
 
-	if (syncTargetId_ == SyncTargetRegistry.nameToId('filesystem')) {
-		fs.removeSync(syncDir)
-		fs.mkdirpSync(syncDir, 0o755);
-	} else {
-		await fileApi().format();
-	}
+	// if (syncTargetId_ == SyncTargetRegistry.nameToId('filesystem')) {
+	// 	fs.removeSync(syncDir)
+	// 	fs.mkdirpSync(syncDir, 0o755);
+	// } else {
+		await fileApi().clearRoot();
+
+		//await fileApi().format();
+	//}
 }
 
 function db(id = null) {
@@ -230,7 +239,17 @@ function fileApi() {
 		fileApi_ = new FileApi(syncDir, new FileApiDriverLocal());
 	} else if (syncTargetId_ == SyncTargetRegistry.nameToId('memory')) {
 		fileApi_ = new FileApi('/root', new FileApiDriverMemory());
+	} else if (syncTargetId_ == SyncTargetRegistry.nameToId('nextcloud')) {
+		const options = {
+			baseUrl: () => 'http://nextcloud.local/remote.php/dav/files/admin/JoplinTest',
+			username: () => 'admin',
+			password: () => '123456',
+		};
+
+		const api = new WebDavApi(options);
+		fileApi_ = new FileApi('', new FileApiDriverWebDav(api));
 	}
+
 	// } else if (syncTargetId == Setting.SYNC_TARGET_ONEDRIVE) {
 	// 	let auth = require('./onedrive-auth.json');
 	// 	if (!auth) {

ReactNativeClient/lib/SyncTargetRegistry.js

@@ -31,6 +31,10 @@ class SyncTargetRegistry {
 		throw new Error('ID not found: ' + id);
 	}
 
+	static idToName(id) {
+		return this.idToMetadata(id).name;
+	}
+
 	static idAndLabelPlainObject() {
 		let output = {};
 		for (let n in this.reg_) {

ReactNativeClient/lib/WebDavApi.js

@@ -195,7 +195,7 @@ class WebDavApi {
 			if (json['d:error']) {
 				const code = json['d:error']['s:exception'] ? json['d:error']['s:exception'].join(' ') : response.status;
 				const message = json['d:error']['s:message'] ? json['d:error']['s:message'].join("\n") : shortResponseText();
-				throw new JoplinError(message + ' (' + code + ')', response.status);
+				throw new JoplinError(method + ' ' + path + ': ' + message + ' (' + code + ')', response.status);
 			}
 
 			throw new JoplinError(shortResponseText(), response.status);

ReactNativeClient/lib/file-api-driver-local.js

@@ -224,6 +224,11 @@ class FileApiDriverLocal {
 		throw new Error('Not supported');
 	}
 
+	async clearRoot(baseDir) {
+		await this.fsDriver().remove(baseDir);
+		await this.fsDriver().mkdir(baseDir);
+	}
+
 }
 
 module.exports = { FileApiDriverLocal };

ReactNativeClient/lib/file-api-driver-memory.js

@@ -159,6 +159,11 @@ class FileApiDriverMemory {
 		return output;
 	}
 
+	clearRoot() {
+		this.items_ = [];
+		return Promise.resolve();
+	}
+
 }
 
 module.exports = { FileApiDriverMemory };

ReactNativeClient/lib/file-api-driver-onedrive.js

@@ -189,6 +189,10 @@ class FileApiDriverOneDrive {
 		return this.pathCache_[path];
 	}
 
+	clearRoot() {
+		throw new Error('Not implemented');
+	}
+
 	async delta(path, options = null) {
 		let output = {
 			hasMore: false,

ReactNativeClient/lib/file-api-driver-webdav.js

@@ -66,20 +66,26 @@ class FileApiDriverWebDav {
 
 	async delta(path, options) {
 		const getDirStats = async (path) => {
-			const result = await this.api().execPropFind(path, 1, [
-				'd:getlastmodified',
-				'd:resourcetype',
-			]);
-
-			const resources = this.api().arrayFromJson(result, ['d:multistatus', 'd:response']);
-			return this.statsFromResources_(resources);
+			const result = await this.list(path);
+			return result.items;
 		};
 
 		return await basicDelta(path, getDirStats, options);
 	}
 
 	async list(path, options) {
-		throw new Error('Not implemented'); // Not needed
+		const result = await this.api().execPropFind(path, 1, [
+			'd:getlastmodified',
+			'd:resourcetype',
+		]);
+
+		const resources = this.api().arrayFromJson(result, ['d:multistatus', 'd:response']);
+
+		return {
+			items: this.statsFromResources_(resources),
+			hasMore: false,
+			context: null,
+		};
 	}
 
 	async get(path, options) {
@@ -120,6 +126,11 @@ class FileApiDriverWebDav {
 		throw new Error('Not supported');
 	}
 
+	async clearRoot() {
+		await this.delete('');
+		await this.mkdir('');
+	}
+
 }
 
 module.exports = { FileApiDriverWebDav };

ReactNativeClient/lib/file-api.js

@@ -64,6 +64,7 @@ class FileApi {
 		});
 	}
 
+	// Deprectated
 	setTimestamp(path, timestampMs) {
 		this.logger().debug('setTimestamp ' + this.fullPath_(path));
 		return this.driver_.setTimestamp(this.fullPath_(path), timestampMs);
@@ -105,15 +106,21 @@ class FileApi {
 		return this.driver_.delete(this.fullPath_(path));
 	}
 
+	// Deprectated
 	move(oldPath, newPath) {
 		this.logger().debug('move ' + this.fullPath_(oldPath) + ' => ' + this.fullPath_(newPath));
 		return this.driver_.move(this.fullPath_(oldPath), this.fullPath_(newPath));
 	}
 
+	// Deprectated
 	format() {
 		return this.driver_.format();
 	}
 
+	clearRoot() {
+		return this.driver_.clearRoot(this.baseDir_);
+	}
+
 	delta(path, options = null) {
 		this.logger().debug('delta ' + this.fullPath_(path));
 		return this.driver_.delta(this.fullPath_(path), options);

ReactNativeClient/lib/fs-driver-node.js

@@ -20,6 +20,11 @@ class FsDriverNode {
 		return fs.writeFile(path, string, { encoding: encoding });
 	}
 
+	// same as rm -rf
+	async remove(path) {
+		return fs.remove(path);
+	}
+
 	async move(source, dest) {
 		let lastError = null;
 

ReactNativeClient/lib/fs-driver-rn.js

@@ -14,6 +14,11 @@ class FsDriverRN {
 		return RNFS.writeFile(path, string, encoding);
 	}
 
+	// same as rm -rf
+	async remove(path) {
+		throw new Error('Not implemented');
+	}
+
 	writeBinaryFile(path, content) {
 		throw new Error('Not implemented');
 	}