Desktop, CLI: Fixes #1583: Handle multiple lines in attributes when importing Enex files

CliClient/tests/enex_to_md/multiline_attribute.html

@@ -0,0 +1,5 @@
+<img src="https://joplinapp.org/images/Icon512.png" alt="multiple
+lines
+are
+possible
+I guess"/><img src="https://joplinapp.org/images/Icon512.png" alt="This should ] be escaped"/>

CliClient/tests/enex_to_md/multiline_attribute.md

@@ -0,0 +1 @@
+![multiple lines are possible I guess](https://joplinapp.org/images/Icon512.png)![This should \] be escaped](https://joplinapp.org/images/Icon512.png)

ReactNativeClient/lib/import-enex-md-gen.js

@@ -309,11 +309,21 @@ function isImageMimeType(m) {
 	return imageMimeTypes.indexOf(m) >= 0;
 }
 
+function tagAttributeToMdText(attr) {
+	// HTML attributes may contain newlines so remove them.
+	// https://github.com/laurent22/joplin/issues/1583
+	if (!attr) return '';
+	attr = attr.replace(/[\n\r]+/g, ' ');
+	attr = attr.replace(/\]/g, '\\]');
+	return attr;
+}
+
 function addResourceTag(lines, resource, alt = "") {
 	// Note: refactor to use Resource.markdownTag
 
 	let tagAlt = alt == "" ? resource.alt : alt;
 	if (!tagAlt) tagAlt = '';
+	tagAlt = tagAttributeToMdText(tagAlt);
 	if (isImageMimeType(resource.mime)) {
 		lines.push("![");
 		lines.push(tagAlt);
@@ -516,7 +526,7 @@ function enexXmlToMdArray(stream, resources) {
 			} else if (n == 'img') {
 				if (nodeAttributes.src) { // Many (most?) img tags don't have no source associated, especially when they were imported from HTML
 					let s = '![';
-					if (nodeAttributes.alt) s += nodeAttributes.alt;
+					if (nodeAttributes.alt) s += tagAttributeToMdText(nodeAttributes.alt);
 					s += '](' + nodeAttributes.src + ')';
 					section.lines.push(s);
 				}