self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2025-07-16 00:14:34 +02:00
Code Issues Releases Activity

Desktop: Enabled plugin throttling logic to prevent certain plugins from freezing the app

Browse Source
This commit is contained in:
Laurent Cozic
2022-04-19 15:52:32 +01:00
parent 627b16728d
commit b7167552ec
5 changed files with 71 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
packages/lib/services/plugins/BasePluginRunner.ts
View File

@ -4,7 +4,21 @@ import Global from './api/Global';
export default abstract class BasePluginRunner extends BaseService {
async run(plugin: Plugin, sandbox: Global): Promise<void> {
// A dictionary with the plugin ID as key. Then each entry has a list
// of timestamp/call counts.
//
// 'org.joplinapp.plugins.ExamplePlugin': {
// 1650375620: 5, // 5 calls at second 1650375620
// 1650375621: 19, // 19 calls at second 1650375621
// 1650375623: 12,
// },
// 'org.joplinapp.plugins.AnotherOne': {
// 1650375620: 1,
// 1650375623: 4,
// };
private callStats_: Record<string, Record<number, number>> = {};
public async run(plugin: Plugin, sandbox: Global): Promise<void> {
throw new Error(`Not implemented: ${plugin} / ${sandbox}`);
}
@ -12,4 +26,26 @@ export default abstract class BasePluginRunner extends BaseService {
throw new Error('Not implemented: waitForSandboxCalls');
}
protected recordCallStat(pluginId: string) {
const timeSeconds = Math.floor(Date.now() / 1000);
if (!this.callStats_[pluginId]) this.callStats_[pluginId] = {};
if (!this.callStats_[pluginId][timeSeconds]) this.callStats_[pluginId][timeSeconds] = 0;
this.callStats_[pluginId][timeSeconds]++;
}
// Duration in seconds
public callStatsSummary(pluginId: string, duration: number): number[] {
const output: number[] = [];
const startTime = Math.floor(Date.now() / 1000 - duration);
const endTime = startTime + duration;
for (let t = startTime; t <= endTime; t++) {
const callCount = this.callStats_[pluginId][t];
output.push(callCount ? callCount : 0);
}
return output;
}
}