self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2025-11-26 22:41:17 +02:00
Code Issues Releases Activity

Chore: Refactor WebViewController (#13133)

Browse Source
This commit is contained in:
Henry Heino
2025-09-08 02:56:51 -07:00
committed by GitHub
parent 5e1909cee0
commit bdc4687327
9 changed files with 249 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/lib/commands/showEditorPlugin.ts
View File

@@ -44,7 +44,7 @@ export const runtime = (): CommandRuntime => {
throw new Error(`No controller registered for editor view ${editorView.id}`);
}
const previousVisible = editorView.parentWindowId === windowId && controller.isVisible();
const previousVisible = editorView.parentWindowId === windowId && controller.visible;
if (show && previousVisible) {
logger.info(`Editor is already visible: ${editorViewId}`);
@@ -68,7 +68,7 @@ export const runtime = (): CommandRuntime => {
};
Setting.setValue('plugins.shownEditorViewIds', getUpdatedShownViewIds());
controller.setOpened(show);
await controller.setOpen(show);
},
};
};