1
0
mirror of https://github.com/laurent22/joplin.git synced 2025-07-13 00:10:37 +02:00

All: Also duplicate resources when duplicating a note

Ref: https://github.com/laurent22/joplin/issues/5796
This commit is contained in:
Laurent Cozic
2021-11-27 16:05:28 +00:00
parent 4ce58fa486
commit c0a8c330a9
3 changed files with 43 additions and 5 deletions

View File

@ -595,23 +595,36 @@ export default class Note extends BaseItem {
}
}
static async duplicate(noteId: string, options: any = null) {
private static async duplicateNoteResources(noteBody: string): Promise<string> {
const resourceIds = await this.linkedResourceIds(noteBody);
let newBody: string = noteBody;
for (const resourceId of resourceIds) {
const newResource = await Resource.duplicateResource(resourceId);
const regex = new RegExp(resourceId, 'gi');
newBody = newBody.replace(regex, newResource.id);
}
return newBody;
}
public static async duplicate(noteId: string, options: any = null) {
const changes = options && options.changes;
const uniqueTitle = options && options.uniqueTitle;
const originalNote = await Note.load(noteId);
const originalNote: NoteEntity = await Note.load(noteId);
if (!originalNote) throw new Error(`Unknown note: ${noteId}`);
const newNote = Object.assign({}, originalNote);
const fieldsToReset = ['id', 'created_time', 'updated_time', 'user_created_time', 'user_updated_time'];
for (const field of fieldsToReset) {
delete newNote[field];
delete (newNote as any)[field];
}
for (const n in changes) {
if (!changes.hasOwnProperty(n)) continue;
newNote[n] = changes[n];
(newNote as any)[n] = changes[n];
}
if (uniqueTitle) {
@ -619,6 +632,8 @@ export default class Note extends BaseItem {
newNote.title = title;
}
newNote.body = await this.duplicateNoteResources(newNote.body);
const newNoteSaved = await this.save(newNote);
const originalTags = await Tag.tagsByNoteId(noteId);
for (const tagToAdd of originalTags) {