self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2025-07-16 00:14:34 +02:00
Code Issues Releases Activity

Chore: Desktop: Fixes #9873: Fix Playwright test failure due to image not visible (#9874)

Browse Source
This commit is contained in:
Henry Heino
2024-02-08 08:56:12 -08:00
committed by GitHub
parent debd8a6ebe
commit c54603025b
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/app-desktop/integration-tests/main.spec.ts
View File

@ -153,10 +153,12 @@ test.describe('main', () => {
await editor.attachFileButton.click(); await editor.attachFileButton.click();
const getImageSize = async () => { const getImageSize = async () => {
// Wait for it to render
const viewerFrame = editor.getNoteViewerIframe(); const viewerFrame = editor.getNoteViewerIframe();
const renderedImage = viewerFrame.getByAltText(filename); const renderedImage = viewerFrame.getByAltText(filename);
await renderedImage.waitFor();
// Use state: 'attached' -- we don't need the image to be on the screen (just present
// in the DOM).
await renderedImage.waitFor({ state: 'attached' });
// We load a copy of the image to avoid returning an overriden width set with // We load a copy of the image to avoid returning an overriden width set with
// .width = some_number // .width = some_number