self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2025-01-11 18:24:43 +02:00
Code Issues Releases Activity

Add more logging info to ExternalEditWatcher so that I do not need to ask to enable debug mode

Browse Source
This commit is contained in:
Laurent Cozic 2019-10-02 19:04:50 +01:00
parent cdcc3902c5
commit ce5db5a5c1
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ReactNativeClient/lib/services/ExternalEditWatcher.js
View File

@ -51,7 +51,11 @@ class ExternalEditWatcher {
if (!this.watcher_) { if (!this.watcher_) {
this.watcher_ = this.chokidar_.watch(fileToWatch); this.watcher_ = this.chokidar_.watch(fileToWatch);
this.watcher_.on('all', async (event, path) => { this.watcher_.on('all', async (event, path) => {
this.logger().debug(`ExternalEditWatcher: Event: ${event}: ${path}`); // For now, to investigate the lost content issue when using an external editor,
// make all the debug statement to info() so that it goes to the log file.
// Those that were previous debug() statements are marked as "was_debug"
/* was_debug */ this.logger().info(`ExternalEditWatcher: Event: ${event}: ${path}`);
if (event === 'unlink') { if (event === 'unlink') {
// File are unwatched in the stopWatching functions below. When we receive an unlink event // File are unwatched in the stopWatching functions below. When we receive an unlink event
@ -197,7 +201,7 @@ class ExternalEditWatcher {
const iid = setInterval(() => { const iid = setInterval(() => {
if (subProcess && subProcess.pid) { if (subProcess && subProcess.pid) {
this.logger().debug(`Started editor with PID ${subProcess.pid}`); /* was_debug */ this.logger().info(`Started editor with PID ${subProcess.pid}`);
clearInterval(iid); clearInterval(iid);
resolve(); resolve();
} }
@ -273,7 +277,7 @@ class ExternalEditWatcher {
return; return;
} }
this.logger().debug(`ExternalEditWatcher: Update note file: ${note.id}`); /* was_debug */ this.logger().info(`ExternalEditWatcher: Update note file: ${note.id}`);
// When the note file is updated programmatically, we skip the next change event to // When the note file is updated programmatically, we skip the next change event to
// avoid update loops. We only want to listen to file changes made by the user. // avoid update loops. We only want to listen to file changes made by the user.