From cffc919791f86dd980bf326c913c4931c3261eca Mon Sep 17 00:00:00 2001 From: fhfuih Date: Fri, 13 Mar 2020 13:19:51 -0400 Subject: [PATCH] Revert "Refactor "retry all" renderer to avoid hacks" This reverts commit 51ba6ea65521c8bfa953d90f8078684d8293122b. --- ElectronClient/gui/StatusScreen.jsx | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/ElectronClient/gui/StatusScreen.jsx b/ElectronClient/gui/StatusScreen.jsx index d23e3be5c..8e5de29e4 100644 --- a/ElectronClient/gui/StatusScreen.jsx +++ b/ElectronClient/gui/StatusScreen.jsx @@ -55,6 +55,8 @@ class StatusScreenComponent extends React.Component { height: style.height - theme.headerHeight - containerPadding * 2, }); + let retryHandlers = []; + function renderSectionTitleHtml(key, title) { return (

@@ -81,6 +83,8 @@ class StatusScreenComponent extends React.Component { this.resfreshScreen(); }; + retryHandlers.push(item.retryHandler); + retryLink = ( {_('Retry')} @@ -105,24 +109,13 @@ class StatusScreenComponent extends React.Component { return
{itemsHtml}
; }; - function renderRetryAllHtml(report) { - let retryHandlers = []; + function renderRetryAllHtml() { let retryAllLink = null; - - report.forEach(section => { - section.body.forEach(item => { - if (item.canRetry) { - retryHandlers.push(item.retryHandler); - } - }); - }); - if (retryHandlers.length > 1) { const onClick = async () => { await Promise.all(retryHandlers.map(handler => handler())); this.resfreshScreen(); }; - retryAllLink = (
@@ -143,7 +136,7 @@ class StatusScreenComponent extends React.Component { sectionsHtml.push(renderSectionHtml(i, section)); } - let retryAllHtml = renderRetryAllHtml(report); + let retryAllHtml = renderRetryAllHtml(); // must be called after renderSectionHtml return (