self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2025-07-13 00:10:37 +02:00
Code Issues Releases Activity

Chore: Mobile: Fix Note.test.tsx warnings (#12448)

Browse Source
This commit is contained in:
Henry Heino
2025-06-10 16:13:42 -07:00
committed by GitHub
parent 303ccce7d2
commit f6056b2d75
3 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/app-mobile/components/NoteEditor/CodeMirror/CodeMirror.ts
View File

@ -15,6 +15,18 @@ import CodeMirrorControl from '@joplin/editor/CodeMirror/CodeMirrorControl';
import WebViewToRNMessenger from '../../../utils/ipc/WebViewToRNMessenger'; import WebViewToRNMessenger from '../../../utils/ipc/WebViewToRNMessenger';
import { WebViewToEditorApi } from '../types'; import { WebViewToEditorApi } from '../types';
import { focus } from '@joplin/lib/utils/focusHandler'; import { focus } from '@joplin/lib/utils/focusHandler';
import Logger, { TargetType } from '@joplin/utils/Logger';
let loggerCreated = false;
export const setUpLogger = () => {
if (!loggerCreated) {
const logger = new Logger();
logger.addTarget(TargetType.Console);
logger.setLevel(Logger.LEVEL_WARN);
Logger.initializeGlobalLogger(logger);
loggerCreated = true;
}
};
export const initCodeMirror = ( export const initCodeMirror = (
parentElement: HTMLElement, parentElement: HTMLElement,

1
packages/app-mobile/components/NoteEditor/NoteEditor.tsx
View File

@ -387,6 +387,7 @@ function NoteEditor(props: Props, ref: any) {
try { try {
${shim.injectedJs('codeMirrorBundle')}; ${shim.injectedJs('codeMirrorBundle')};
codeMirrorBundle.setUpLogger();
const parentElement = document.getElementsByClassName('CodeMirror')[0]; const parentElement = document.getElementsByClassName('CodeMirror')[0];
// On Android, injectJavaScript is run twice -- once before the parent element exists. // On Android, injectJavaScript is run twice -- once before the parent element exists.

2
packages/app-mobile/components/screens/Note/Note.test.tsx
View File

@ -292,7 +292,7 @@ describe('screens/Note', () => {
const deleteButton = await screen.findByText('Delete'); const deleteButton = await screen.findByText('Delete');
expect(deleteButton).toBeDisabled(); expect(deleteButton).toBeDisabled();
cleanup(); act(() => cleanup());
}); });
it.each([ it.each([