Follow up to #893
Now using middleware to set the tags when a note is selected
This avoids the ugly code in the NoteTextComponent where we determine
if tags are to be fetched, identify if they have been modified, fetch
them and then dispatch an action to update the store which might
again re-render the component.
Also implements style related fixes from #1000
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
Fixes: #469
* Add external editor actions to the note context menu.
Also start up external editor on note double click.
These changes enhance user experience by placing the actions where
they feel natural.
* Remove double-click behaviour and change menu text.
Changes in response to review comments.
* Move handling of external editor actions to main screen from note text
This is to ensure correct behaviour even when the user launches the
action on a note in the list that is under the pointer, but not selected.
* Move external edit actions to NoteListUtils from MainScreen.
* Reconnect external edit action in main edit menu.
* Started updating to use external renderer package
* Added way to build renderer assets
* Done mobile compatilibty
* Upgrade joplin-renderer
* Added joplin-renderer package
* Moved button row to separate component file and started Sharing dialog
* Adding Sharing dialog
* Applied "npx react-codemod rename-unsafe-lifecycles"
* More UI
* Tools: Improved TypeScript integration
* Improved share dialog
* Tools Added support for translation validation in CI, and added support for plural translations
* Improved UI and sharing workflow
* Share workflow
* Cleaned up and improved sharing config error handling
* Fixed build scripts and doc for TypeScript
* Run linter
* Delete unused file
* Implement CssUtils
* Inject custom CSS styles
* Add info about custom CSS styles to README
* Add note that ElectronClient/app/app.js is generated
* Add support for Setting.TYPE_BUTTON
* Add buttons in Preferences to open custom CSS files
* Swap custom CSS filenames
* Swap custom CSS filenames
* Wrap "Edit" with translation fn
* Incorporate PR feedback from @laurent22
* Add openOrCreateFile to Settings
* Move openOrCreateFile to shim
* Removing header for now - see https://github.com/laurent22/joplin/pull/2099#discussion_r353120915
* Added highlight_mark token to Ace editor rules
* Fix edge case for highlight_mark Ace rule
* Add ==mark== rule only if plugin is enabled
* Rm temporary highlight class
* Adding node counts for folders and tags
* Add unit tests
* Fix count update when the tag list for a note is updated
* Right align note counts and remove from the settings screen
* Folder note count calculation update to include descendants
* Update Setting.js
* Change count style and fix click on counts
* Fix tag/folder count update on delete/add note
* Review updates
* Add keyboard modes to editor (vim, emacs, default)
This adds a new option to settings, and then sets the
appropriate keyboard handler in the ace editor.
The "default" option is equivalent to the old keyboard
behaviour.
* Remove stray console.log
* Move the keyboard-mode setting to the general section
* Change `keyboardMode` setting to `editor.keyboardMode`
* Prevent horizontal scrolling on Linux when a scrollbar is present in the note list.
* max-width usage specifically to target Linux horizontal scroll problem.
* Add menu item to toggle note list #1988
* Hiding the noteList now fully works + standardized casing for noteList #1988
* hiding verticalResizer to fully hide note list and its extra border #1988
* curly braces on the same line #1988
* fa-tasks is "less" worse as an icon for toggle note list #1988
* liking this icon a whole lot more
* removed useless width tweak
* add setting: export.pdfPageSize
* create 2 settings: size and orientation
* export.pdfPageOrientation: use string instead of boolean
* add other page formats supported by Electron
* set cancel as the default in dangerous operations, rename buttons (delete, remove) and context menu (for tags)
fixes#1662 (partially, because I can't fix the upstream issue, unless we update Electron)
* add default value for buttonLabel