Laurent Cozic
a96734f5be
Revert "Tools: Added eslint rule arrow-parens"
...
This reverts commit 0b6f5581f0
2020-05-21 09:14:33 +01:00
Laurent Cozic
0b6f5581f0
Tools: Added eslint rule arrow-parens
2020-05-20 17:16:43 +01:00
Laurent Cozic
cb8dca747b
Refactor note editor
...
Refactor note editor using React Hooks and TypeScript
and moved editor-specific code to separate files.
Moved business logic into more maintainable custom hooks.
Squashed commit of the following:
commit f243d9bf89bdcfa1849ee26df5c0dd3e33405010
Author: Laurent Cozic <laurent@cozic.net>
Date: Sat May 2 16:04:14 2020 +0100
Fixed saving issue
commit 055f68d2e8b6cf6f130336c38ac2ab480887583d
Author: Laurent Cozic <laurent@cozic.net>
Date: Sat May 2 15:43:38 2020 +0100
Fixed HTML notes
commit 99a3cf71f58d2fedcdf3001bf4110b6e8e3993da
Merge: 9be85c45f2 b16ebbbf7a150ee14de67ceb68d835
2020-05-02 16:41:07 +01:00
Laurent Cozic
d0d2bad7f4
Tools: Enforce and apply eslint rules prefer-const and no-var
2020-03-13 23:46:14 +00:00
Laurent Cozic
15f09ef169
Revert "Desktop: Stop watching external edits when closing editor ( #1981 )"
...
Due to this issue:
https://discourse.joplinapp.org/t/joplin-version-1-0-173/4232/7
This reverts commit 0eb51e6bb0
2019-11-12 17:51:57 +00:00
Caleb John
0eb51e6bb0
Desktop: Stop watching external edits when closing editor ( #1981 )
...
* Stop watching external edits
* move onClose to options
* Wrap openExternal in promise
* More specific error with locale
* Removed localization of external edit error
2019-10-17 22:40:27 +02:00
Laurent Cozic
fdafe3b947
Desktop: Fixes #1854 : Prevent note content from being deleted when using certain external editors (in particular Typora)
2019-10-12 22:51:38 +02:00
Laurent Cozic
6dec711a0a
Desktop: Fixes #1854 : Prevent external editor from clearing the note in some hard to replicate cases
2019-10-12 21:30:38 +02:00
Laurent Cozic
ce5db5a5c1
Add more logging info to ExternalEditWatcher so that I do not need to ask to enable debug mode
2019-10-02 19:04:50 +01:00
Laurent Cozic
e648392330
Chore: Apply eslint rules
2019-09-19 22:51:18 +01:00
Laurent Cozic
15a42a3729
Chore: Apply eslint no-unused-vars eslint config and add TypeScript config
2019-09-12 22:16:42 +00:00
Laurent Cozic
71efff6827
Linter update ( #1777 )
...
* Update eslint config
* Applied linter to lib
* Applied eslint config to CliClient/app
* Removed prettier due to https://github.com/prettier/prettier/pull/4765
* First pass on test units
* Applied linter config to test units
* Applied eslint config to clipper
* Applied to plugin dir
* Applied to root of ElectronClient
* Applied on RN root
* Applied on CLI root
* Applied on Clipper root
* Applied config to tools
* test hook
* test hook
* test hook
* Added pre-commit hook
* Applied rule no-trailing-spaces
* Make sure root packages are installed when installing sub-dir
* Added doc
2019-07-30 09:35:42 +02:00
Laurent Cozic
86dc72b204
First pass at linting lib dir
2019-07-29 15:43:53 +02:00
Caleb John
b461625518
Desktop: Fixed issue with issue with watching file on Linux ( #1659 )
...
Watch for rename events in the external editor and re-watch file
2019-06-20 00:44:51 +01:00
Laurent Cozic
016ce3dd61
Desktop: Resolves #1502 : Improved note deletion dialog
2019-05-11 13:36:44 +01:00
Laurent Cozic
afb375955e
Fixed regressions following fix for #1425
2019-05-11 12:08:28 +01:00
Laurent Cozic
b702b0b40c
Desktop: Fixes #1425 : Improved handling of images when using external editor, so that it works in Atom, VSCode and Typora
2019-05-11 11:46:13 +01:00
Laurent Cozic
08af9de190
All: Resolves #712 : New: Support for note history ( #1415 )
...
* Started revisions support
* More rev changes
* More rev changes
* More revs changes
* Fixed deletion algorithm
* More tests and moved updated time to separate field
* Display info when restoring note
* Better handling of existing notes
* wip
* Further improvements and fixed tests
* Better handling of changes created via sync
* Enable chokidar again
* Testing special case
* Further improved logic to handle notes that existed before the revision service
* Added tests
* Better handling of encrypted revisions
* Improved handling of deleted note revisions by moving logic to collectRevision
* Improved handling of old notes by moving logic to collectRevision()
* Handle case when deleting revisions while one is still encrypted
* UI tweaks
* Added revision service to mobile app
* Fixed config screens on mobile and desktop
* Enabled revisions on CLI app
2019-05-06 21:35:29 +01:00
Laurent Cozic
9289dbdf77
All: Refactor Markdown rendering ( #1315 )
...
* Refactoring MdToHtml to avoid manually rendering tokens
* Minor fix
* Fixed loading of resources
* Handle clicking on checkboxes
* Added back Katex support
* Fixed issues with Katex and note rendering
* Added back support for links
* Restored code block highlighting support
* clean up
* Applying update to mobile
* Fixed handling of links and cleaned up to share more code between mobile and desktop
* Restored content caching and improved handling of additional assets
* Clean up and a few fixes
* Applied more updates to mobile and added code highlighting support
2019-03-08 17:14:17 +00:00
Laurent Cozic
2256b0c5ec
Desktop: Fixes very slow startup since Electron 4 upgrade
2019-02-28 23:24:28 +00:00
Laurent Cozic
e62d91dda8
Desktop: Allow using macOS App bundle as external editor, and improved error handling
2019-02-05 22:00:25 +00:00
Laurent Cozic
19252af345
Desktop: Fixes #996 : Allow editing multiple notes in external editor
2018-11-21 19:50:50 +00:00
Ben Fisher
58b68cab0c
fix for #906 , 1) windows paths like C:\a\b weren't accepted because b… ( #935 )
...
* fix for #906 , 1) windows paths like C:\a\b weren't accepted because backslashes were treated as escape sequences, 2) common paths like C:\Program Files\Foo\Foo.exe weren't accepted because of the space in the path
* Using anothing approach,
a) backslashes are no longer treated as escape characters,
b) string change to remind people to add spaces
* Removing joplin.pot from the patch, it will be updated later.
* Removing unused code.
2018-11-20 21:46:18 +00:00
Laurent Cozic
0a5ad1d628
Electron: Fixes #710 : Don't unwatch file when it is temporarily deleted
2018-09-13 19:29:48 +01:00
Laurent Cozic
7d7e1e1637
Electron: Resolves #647 : Allow specifying text editor path and arguments in setting
2018-06-27 21:34:41 +01:00
Laurent Cozic
1f3a1c49df
Electron: Resolves #611 : Allow opening and editing note in external editor
2018-06-18 18:56:07 +00:00
