mirror of
https://github.com/laurent22/joplin.git
synced 2025-01-26 18:58:21 +02:00
f965708ad3
When the mobile application tries to synchronize a note with attached resource files, e.g. from the notebook "Welcome! (Mobile)", readFile() is called to return a Buffer although that isn't implemented in FsDriverRN.readFile(). This is changing the code to return base64 encoded content from react-native and turn it into a Buffer before the S3 putObject() API call is used to create the remote object. Tested with AVD Android 10.0 target. Signed-off-by: Jan Blunck <jblunck@users.noreply.github.com>
@joplin/lib
Library shared between all applications.
- It should not have dependencies to any other
@joplin
package to avoid dependency cycles. - Binary packages should be passed via dependency injection from the parent packages, for example like it is done in shim-init-node. This is because each app might need to compile the binary package in a specific way, so doing it from /lib would cause issues.
- It should not include the
react
orreact-native
packages because React in particular breaks when there's more than one instance of it in node_modules. React is passed via dependency injections so that some hooks can be shared.