1
0
mirror of https://github.com/laurent22/joplin.git synced 2024-12-30 10:36:35 +02:00
joplin/ReactNativeClient/lib/services/InteropService_Importer_Md.js
Bart 37158fdb89
Desktop: Fixes #2334: MD importer handle special chars in linked image name (#2346)
* md importer: decode uri encoded links to cover case of special chars in linked image names

* md importer: temp debug logs for linux test pipeline

* md importer: more temp debug logs

* md importer: tests, add special char image name on linux

* md importer: tests, use const not let

* md importer: remove debug logs
2020-03-27 12:20:38 +00:00

109 lines
3.9 KiB
JavaScript

const InteropService_Importer_Base = require('lib/services/InteropService_Importer_Base');
const Folder = require('lib/models/Folder.js');
const Note = require('lib/models/Note.js');
const { basename, filename, rtrimSlashes, fileExtension, dirname } = require('lib/path-utils.js');
const { shim } = require('lib/shim');
const { _ } = require('lib/locale');
const { extractImageUrls } = require('lib/markdownUtils');
const { unique } = require('lib/ArrayUtils');
const { pregQuote } = require('lib/string-utils-common');
class InteropService_Importer_Md extends InteropService_Importer_Base {
async exec(result) {
let parentFolderId = null;
const sourcePath = rtrimSlashes(this.sourcePath_);
const filePaths = [];
if (await shim.fsDriver().isDirectory(sourcePath)) {
if (!this.options_.destinationFolder) {
const folderTitle = await Folder.findUniqueItemTitle(basename(sourcePath));
const folder = await Folder.save({ title: folderTitle });
parentFolderId = folder.id;
} else {
parentFolderId = this.options_.destinationFolder.id;
}
this.importDirectory(sourcePath, parentFolderId);
} else {
if (!this.options_.destinationFolder) throw new Error(_('Please specify the notebook where the notes should be imported to.'));
parentFolderId = this.options_.destinationFolder.id;
filePaths.push(sourcePath);
}
for (let i = 0; i < filePaths.length; i++) {
await this.importFile(filePaths[i], parentFolderId);
}
return result;
}
async importDirectory(dirPath, parentFolderId) {
console.info(`Import: ${dirPath}`);
const supportedFileExtension = this.metadata().fileExtensions;
const stats = await shim.fsDriver().readDirStats(dirPath);
for (let i = 0; i < stats.length; i++) {
const stat = stats[i];
if (stat.isDirectory()) {
const folderTitle = await Folder.findUniqueItemTitle(basename(stat.path));
const folder = await Folder.save({ title: folderTitle, parent_id: parentFolderId });
this.importDirectory(`${dirPath}/${basename(stat.path)}`, folder.id);
} else if (supportedFileExtension.indexOf(fileExtension(stat.path).toLowerCase()) >= 0) {
this.importFile(`${dirPath}/${stat.path}`, parentFolderId);
}
}
}
/**
* Parse text for links, attempt to find local file, if found create Joplin resource
* and update link accordingly.
*/
async importLocalImages(filePath, md) {
let updated = md;
const imageLinks = unique(extractImageUrls(md));
await Promise.all(imageLinks.map(async (encodedLink) => {
const link = decodeURI(encodedLink);
const attachmentPath = filename(`${dirname(filePath)}/${link}`, true);
const pathWithExtension = `${attachmentPath}.${fileExtension(link)}`;
const stat = await shim.fsDriver().stat(pathWithExtension);
const isDir = stat ? stat.isDirectory() : false;
if (stat && !isDir) {
const resource = await shim.createResourceFromPath(pathWithExtension);
// NOTE: use ](link) in case the link also appears elsewhere, such as in alt text
const linkPatternEscaped = pregQuote(`](${link})`);
const reg = new RegExp(linkPatternEscaped, 'g');
updated = updated.replace(reg, `](:/${resource.id})`);
}
}));
return updated;
}
async importFile(filePath, parentFolderId) {
const stat = await shim.fsDriver().stat(filePath);
if (!stat) throw new Error(`Cannot read ${filePath}`);
const title = filename(filePath);
const body = await shim.fsDriver().readFile(filePath);
let updatedBody;
try {
updatedBody = await this.importLocalImages(filePath, body);
} catch (error) {
// console.error(`Problem importing links for file ${filePath}, error:\n ${error}`);
}
const note = {
parent_id: parentFolderId,
title: title,
body: updatedBody || body,
updated_time: stat.mtime.getTime(),
created_time: stat.birthtime.getTime(),
user_updated_time: stat.mtime.getTime(),
user_created_time: stat.birthtime.getTime(),
};
return Note.save(note, { autoTimestamp: false });
}
}
module.exports = InteropService_Importer_Md;