mirror of
https://github.com/spantaleev/matrix-docker-ansible-deploy.git
synced 2024-12-12 08:43:55 +02:00
5eed874199
Fixes https://github.com/spantaleev/matrix-docker-ansible-deploy/issues/716 This patch makes us use more fully-qualified container image names (either prefixed with docker.io/ or with localhost/). The latter happens when self-building is enabled. We've recently had issues where if an image was removed manually and the service was restarted (making `docker run` fetch it from Docker Hub, etc.), we'd end up with a pulled image, even though we're aiming for a self-built one. Re-running the playbook would then not do a rebuild, because: - the image with that name already exists (even though it's something else) - we sometimes had conditional logic where we'd build only if the git repo changed By explicitly changing the name of the images (prefixing with localhost/), we avoid such confusion and the possibility that we'd automatically pul something which is not what we expect. Also, I've removed that condition where building would happen on git changes only. We now always build (unless an image with that name already exists). We just force-build when the git repo changes.
62 lines
2.5 KiB
YAML
62 lines
2.5 KiB
YAML
---
|
|
|
|
- name: Ensure Dynamic DNS image is pulled
|
|
docker_image:
|
|
name: "{{ matrix_dynamic_dns_docker_image }}"
|
|
source: "{{ 'pull' if ansible_version.major > 2 or ansible_version.minor > 7 else omit }}"
|
|
force_source: "{{ matrix_dynamic_dns_docker_image_force_pull if ansible_version.major > 2 or ansible_version.minor >= 8 else omit }}"
|
|
force: "{{ omit if ansible_version.major > 2 or ansible_version.minor >= 8 else matrix_dynamic_dns_docker_image_force_pull }}"
|
|
when: matrix_dynamic_dns_enabled|bool and not matrix_dynamic_dns_container_image_self_build
|
|
|
|
- name: Ensure Dynamic DNS paths exist
|
|
file:
|
|
path: "{{ item.path }}"
|
|
state: directory
|
|
mode: 0751
|
|
owner: "{{ matrix_user_username }}"
|
|
group: "{{ matrix_user_groupname }}"
|
|
with_items:
|
|
- { path: "{{ matrix_dynamic_dns_base_path }}", when: true }
|
|
- { path: "{{ matrix_dynamic_dns_config_path }}", when: true }
|
|
- { path: "{{ matrix_dynamic_dns_docker_src_files_path }}", when: "{{ matrix_dynamic_dns_container_image_self_build }}" }
|
|
when: matrix_dynamic_dns_enabled|bool and item.when|bool
|
|
|
|
- name: Ensure Dynamic DNS repository is present on self build
|
|
git:
|
|
repo: https://github.com/linuxserver/docker-ddclient.git
|
|
dest: "{{ matrix_dynamic_dns_docker_src_files_path }}"
|
|
force: "yes"
|
|
register: matrix_dynamic_dns_git_pull_results
|
|
when: "matrix_dynamic_dns_enabled|bool and matrix_dynamic_dns_container_image_self_build|bool"
|
|
|
|
- name: Ensure Dynamic DNS Docker image is built
|
|
docker_image:
|
|
name: "{{ matrix_dynamic_dns_docker_image }}"
|
|
source: build
|
|
force_source: "{{ matrix_dynamic_dns_git_pull_results.changed }}"
|
|
build:
|
|
dockerfile: Dockerfile
|
|
path: "{{ matrix_dynamic_dns_docker_src_files_path }}"
|
|
pull: yes
|
|
when: "matrix_dynamic_dns_enabled|bool and matrix_dynamic_dns_container_image_self_build|bool"
|
|
|
|
- name: Ensure Dynamic DNS ddclient.conf installed
|
|
template:
|
|
src: "{{ role_path }}/templates/ddclient.conf.j2"
|
|
dest: "{{ matrix_dynamic_dns_config_path }}/ddclient.conf"
|
|
mode: 0644
|
|
owner: "{{ matrix_user_username }}"
|
|
group: "{{ matrix_user_groupname }}"
|
|
|
|
- name: Ensure matrix-dynamic-dns.service installed
|
|
template:
|
|
src: "{{ role_path }}/templates/systemd/matrix-dynamic-dns.service.j2"
|
|
dest: "/etc/systemd/system/matrix-dynamic-dns.service"
|
|
mode: 0644
|
|
register: matrix_dynamic_dns_systemd_service_result
|
|
|
|
- name: Ensure systemd reloaded after matrix-dynamic-dns.service installation
|
|
service:
|
|
daemon_reload: yes
|
|
when: "matrix_dynamic_dns_systemd_service_result.changed"
|