From 02db8e5247a6af6aeb9776556637ffd4ed72629e Mon Sep 17 00:00:00 2001
From: Daniel Wang <dewang@linkedin.com>
Date: Thu, 8 Jun 2017 18:42:13 -0700
Subject: [PATCH] Fix promise in team pin

---
 src/oncall/ui/static/js/oncall.js | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/oncall/ui/static/js/oncall.js b/src/oncall/ui/static/js/oncall.js
index 2b555d1..5cb4370 100644
--- a/src/oncall/ui/static/js/oncall.js
+++ b/src/oncall/ui/static/js/oncall.js
@@ -419,8 +419,7 @@ var oncall = {
       endpointTypes: ['services', 'teams'],
       searchForm: '.main-search',
       recentlyViewed: null,
-      pinnedTeams: null,
-      pinnedPromise: $.Deferred()
+      pinnedTeams: null
     },
     init: function(query){
       var $form,
@@ -430,7 +429,8 @@ var oncall = {
           teams,
           servicesCt,
           teamsCt,
-          self = this;
+          self = this,
+          pinnedPromise = $.Deferred();
 
       Handlebars.registerPartial('dashboard-card-inner', this.data.cardInnerTemplate);
       oncall.callbacks.onLogin = function(){
@@ -440,13 +440,13 @@ var oncall = {
       if (oncall.data.user) {
         $.get('/api/v0/users/' + oncall.data.user + '/pinned_teams').done(function(response){
           self.data.pinnedTeams = response;
-          self.data.pinnedPromise.resolve();
+          pinnedPromise.resolve();
         })
       } else {
-        this.data.pinnedPromise.resolve();
+        pinnedPromise.resolve();
       }
 
-      this.data.pinnedPromise.done(function() {
+      pinnedPromise.done(function() {
         self.renderPage();
         self.getTeamSummaries();
         $form = self.data.$page.find(self.data.searchForm);