1
0
mirror of https://github.com/linkedin/oncall.git synced 2025-12-07 00:26:58 +02:00

Fix promise in team pin

This commit is contained in:
Daniel Wang
2017-06-08 18:42:13 -07:00
committed by Qingping Hou
parent 55351171b4
commit 02db8e5247

View File

@@ -419,8 +419,7 @@ var oncall = {
endpointTypes: ['services', 'teams'], endpointTypes: ['services', 'teams'],
searchForm: '.main-search', searchForm: '.main-search',
recentlyViewed: null, recentlyViewed: null,
pinnedTeams: null, pinnedTeams: null
pinnedPromise: $.Deferred()
}, },
init: function(query){ init: function(query){
var $form, var $form,
@@ -430,7 +429,8 @@ var oncall = {
teams, teams,
servicesCt, servicesCt,
teamsCt, teamsCt,
self = this; self = this,
pinnedPromise = $.Deferred();
Handlebars.registerPartial('dashboard-card-inner', this.data.cardInnerTemplate); Handlebars.registerPartial('dashboard-card-inner', this.data.cardInnerTemplate);
oncall.callbacks.onLogin = function(){ oncall.callbacks.onLogin = function(){
@@ -440,13 +440,13 @@ var oncall = {
if (oncall.data.user) { if (oncall.data.user) {
$.get('/api/v0/users/' + oncall.data.user + '/pinned_teams').done(function(response){ $.get('/api/v0/users/' + oncall.data.user + '/pinned_teams').done(function(response){
self.data.pinnedTeams = response; self.data.pinnedTeams = response;
self.data.pinnedPromise.resolve(); pinnedPromise.resolve();
}) })
} else { } else {
this.data.pinnedPromise.resolve(); pinnedPromise.resolve();
} }
this.data.pinnedPromise.done(function() { pinnedPromise.done(function() {
self.renderPage(); self.renderPage();
self.getTeamSummaries(); self.getTeamSummaries();
$form = self.data.$page.find(self.data.searchForm); $form = self.data.$page.find(self.data.searchForm);