self-hosted/oncall
1
0
Fork 0
mirror of https://github.com/linkedin/oncall.git synced 2025-11-26 23:10:47 +02:00
Code Issues Releases Activity

remove bare exceptions

Browse Source
This commit is contained in:
Diego Cepeda
2022-02-01 11:36:21 -08:00
committed by James Won
parent c5d1a60f13
commit 099057a4f5
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/oncall/healthcheck.py
View File

@@ -5,7 +5,7 @@ from falcon import HTTPNotFound, HTTPInternalServerError
from . import db from . import db
import logging import logging
logger = logging.getLogger('oncall.app') logger = logging.getLogger(__name__)
class HealthCheck(object): class HealthCheck(object):
@@ -31,13 +31,13 @@ class HealthCheck(object):
cursor.execute("SELECT VERSION();") cursor.execute("SELECT VERSION();")
cursor.close() cursor.close()
connection.close() connection.close()
except: except Exception:
logger.exception('failed to query DB for healthcheck') logger.exception('failed to query DB for healthcheck')
raise HTTPInternalServerError() raise HTTPInternalServerError()
try: try:
with open(self.path) as f: with open(self.path) as f:
status = f.readline().strip() status = f.readline().strip()
except: except IOError:
logger.error('could not open healthcheck file') logger.error('could not open healthcheck file')
raise HTTPNotFound() raise HTTPNotFound()
resp.content_type = 'text/plain' resp.content_type = 'text/plain'