self-hosted/oncall
1
0
Fork 0
mirror of https://github.com/linkedin/oncall.git synced 2025-11-29 23:38:17 +02:00
Code Issues Releases Activity

Fix round robin populate bug

Browse Source
This commit is contained in:
Daniel Wang
2018-06-18 17:41:23 -07:00
committed by Joe Gillotti
parent 06ad13ae62
commit a92d87f8fa
3 changed files with 20 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/test_scheduler.py
View File

@@ -22,7 +22,7 @@ def test_find_new_user_as_least_active_user(mocker):
mocker.patch('oncall.scheduler.default.Scheduler.get_busy_user_by_event_range')
mocker.patch('oncall.scheduler.default.Scheduler.find_least_active_user_id_by_team')
user_id = scheduler.find_least_active_available_user_id(MOCK_SCHEDULE, [{'start': 0, 'end': 5}], None)
user_id = scheduler.find_next_user_id(MOCK_SCHEDULE, [{'start': 0, 'end': 5}], None)
assert user_id == 123
@@ -251,7 +251,7 @@ def test_find_least_active_available_user(mocker):
{'start': 570, 'end': 588},
{'start': 600, 'end': 700}]
scheduler = oncall.scheduler.default.Scheduler()
scheduler.find_least_active_available_user_id(MOCK_SCHEDULE, future_events, None)
scheduler.find_next_user_id(MOCK_SCHEDULE, future_events, None)
mock_active_user_by_team.assert_called_with({456, 789}, 1, 440, 2, None)
@@ -270,6 +270,6 @@ def test_find_least_active_available_user_conflicts(mocker):
mock_busy_user_by_range.side_effect = mock_busy_user_by_range_side_effect
future_events = [{'start': 440, 'end': 570}]
scheduler = oncall.scheduler.default.Scheduler()
assert scheduler.find_least_active_available_user_id(MOCK_SCHEDULE, future_events, None) is None
assert scheduler.find_next_user_id(MOCK_SCHEDULE, future_events, None) is None
mock_active_user_by_team.assert_not_called()