1
0
mirror of https://github.com/linkedin/oncall.git synced 2025-12-15 01:26:25 +02:00
* Py3 migration

* Update to Python 3 for CircleCI

* Fix auth bugs for python 3

Also fix notifier bug to check for active users

* Update notifier exception handling

Ignore role:target lookup failures from Iris, since these don't represent
problems with the underlying system, just that people have inactive users
on-call in the future.

* Add get_id param option (#246)

* add get_id param option

* removed superfluous select and simplified logic

* Flake8 typo (#247)

* Hide confusing team settings in an advanced dropdown

* Fix test fixtures

* Add "allow duplicate" scheduler in UI

Already in backend, so enable in FE too

* Add Dockerfile to run oncall in a container

* Move deps into a virtualenv.
Run app not as super user.
Mimick prod setup by using uwsgi

* Fix issue with Dockerfile not having MANIFEST.in and wrong passwords in (#257)

config

* Update to ubuntu:18.04 and python3 packages and executables

* Open config file as utf8

The default configuration file has utf8 characters, and python3
attempts to open the file as ASCII unless an alternate encoding
is specified

* Switch to the python3 uwsgi plugin

* Update print and os.execv statements for python3

Python3 throws an exception when the first argument to os.execv is empty:
ValueError: execv() arg 2 first element cannot be empty

The module documentation suggests that the first element should be the
name of the executed program:
https://docs.python.org/3.7/library/os.html#os.execv

* Map config.docker.yaml in to the container as a volume

./ops/entrypoint.py has the start of environment variable support
to specify a configuration file, but it is incomplete until we
update ./ops/daemons/uwsgi-docker.yaml or add environment support
to oncall-notifier and oncall-scheduler.

This commit allows users to map a specific configuration file in
to their container and have it used by all oncall programs.

* Convert line endings to match the rest of the project.

* Add mysql port to docker configuration

* Assume localhost mysql for default config.yaml

* Update python-dev package and MySQL root password

* Use password when configuring mysql

The project has started using a password on the mysql instance.
Once password auth is consistently working we can consider extracting
the hardcoded password into an env file that is optionally randomly
generated on initial startup.

* Fix preview for round-robin (#269)

* #275 fix for Python3 and Gunicorn load config

* Fixed E303 flake8

* Change encoding & collation + test  unicode name

Co-authored-by: Daniel Wang <dwang159@gmail.com>
Co-authored-by: ahm3djafri <42748963+ahm3djafri@users.noreply.github.com>
Co-authored-by: TK <tkahnoski+github@gmail.com>
Co-authored-by: Tim Freund <tim@freunds.net>
Co-authored-by: Rafał Zawadzki <bluszcz@bluszcz.net>
This commit is contained in:
Diego Cepeda
2020-01-15 15:38:25 -08:00
committed by GitHub
parent b688b3c885
commit af327b4e4a
65 changed files with 331 additions and 164 deletions

View File

@@ -13,11 +13,11 @@ import yaml
@pytest.fixture(scope="session", autouse=True)
def require_db():
def require_db(request):
# Read config based on pytest root directory. Assumes config lives at oncall/configs/config.yaml
cfg_path = os.path.join(str(pytest.config.rootdir), 'configs/config.yaml')
cfg_path = os.path.join(str(request.config.rootdir), 'configs/config.yaml')
with open(cfg_path) as f:
config = yaml.load(f)
config = yaml.safe_load(f)
db.init(config['db'])
@@ -69,6 +69,7 @@ def team(request, user, service):
def __init__(self, prefix):
self.prefix = prefix
self.created = set()
self.created_ids = set()
self.connection = db.connect()
self.cursor = self.connection.cursor()
@@ -76,7 +77,9 @@ def team(request, user, service):
name = '_'.join([self.prefix, 'team', str(len(self.created))])
re = requests.post(api_v0('teams'), json={'name': name, 'scheduling_timezone': 'utc'})
assert re.status_code in [201, 422]
team_id = requests.get(api_v0('teams/%s' % name)).json()['id']
self.created.add(name)
self.created_ids.add(team_id)
return name
def mark_for_cleaning(self, team_name):
@@ -85,8 +88,8 @@ def team(request, user, service):
def cleanup(self):
for team in self.created:
requests.delete(api_v0('teams/' + team))
if self.created:
self.cursor.execute('DELETE FROM team WHERE name IN %s', (self.created,))
if self.created_ids:
self.cursor.execute('DELETE FROM team WHERE id IN %s', (self.created_ids,))
self.connection.commit()
self.cursor.close()
self.connection.close()