From 1ae44e8d7f0e62b778b2178ee28b7053cb37874a Mon Sep 17 00:00:00 2001 From: "Patrik J. Braun" Date: Fri, 12 Apr 2024 23:45:49 +0200 Subject: [PATCH] Add reminder todos for better extension loading #784 --- src/backend/model/extension/ExtensionConfigTemplateLoader.ts | 2 ++ src/common/config/private/subconfigs/ServerExtensionsConfig.ts | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/backend/model/extension/ExtensionConfigTemplateLoader.ts b/src/backend/model/extension/ExtensionConfigTemplateLoader.ts index fc989b9e..435189f9 100644 --- a/src/backend/model/extension/ExtensionConfigTemplateLoader.ts +++ b/src/backend/model/extension/ExtensionConfigTemplateLoader.ts @@ -102,6 +102,8 @@ export class ExtensionConfigTemplateLoader { if (ext.template) { c.configs = new ext.template(); } + // TODO: this does not hold if the order of the extensions mixes up. + // TODO: experiment with a map instead of an array config.Extensions.extensions.push(c); } diff --git a/src/common/config/private/subconfigs/ServerExtensionsConfig.ts b/src/common/config/private/subconfigs/ServerExtensionsConfig.ts index 589f50ee..d84932c7 100644 --- a/src/common/config/private/subconfigs/ServerExtensionsConfig.ts +++ b/src/common/config/private/subconfigs/ServerExtensionsConfig.ts @@ -59,7 +59,8 @@ export class ServerExtensionsConfig extends ClientExtensionsConfig { }) folder: string = 'extensions'; - + // TODO: this does not hold if the order of the extensions mixes up. + // TODO: experiment with a map instead of an array @ConfigProperty({ arrayType: ServerExtensionsEntryConfig, tags: {