self-hosted/pigallery2
1
0
Fork 0
mirror of https://github.com/bpatrik/pigallery2.git synced 2025-11-27 22:38:10 +02:00
Code Issues Releases Activity

Implementing media fail check.

Browse Source 
Gallery now will stop indexing if the root folder is empty. That is probably unintentional and would erase the whole database.
This commit is contained in:
Patrik J. Braun
2022-05-15 22:07:46 +02:00
parent e3bc01e41b
commit 5778ef00f7
2 changed files with 88 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
test/backend/unit/model/sql/IndexingManager.spec.ts
View File

@@ -21,7 +21,9 @@ import {DiskManager} from '../../../../../src/backend/model/DiskManger';
import {AlbumManager} from '../../../../../src/backend/model/database/sql/AlbumManager';
import {SortingMethods} from '../../../../../src/common/entities/SortingMethods';
// eslint-disable-next-line @typescript-eslint/no-var-requires
const deepEqualInAnyOrder = require('deep-equal-in-any-order');
// eslint-disable-next-line @typescript-eslint/no-var-requires
const chai = require('chai');
chai.use(deepEqualInAnyOrder);
@@ -53,9 +55,11 @@ class IndexingManagerTest extends IndexingManager {
}
// to help WebStorm to handle the test cases
// eslint-disable-next-line @typescript-eslint/no-explicit-any
declare let describe: any;
declare const after: any;
declare const it: any;
// eslint-disable-next-line prefer-const
describe = DBTestHelper.describe();
describe('IndexingManager', (sqlHelper: DBTestHelper) => {
@@ -155,6 +159,46 @@ describe('IndexingManager', (sqlHelper: DBTestHelper) => {
});
it('should stop indexing on empty folder', async () => {
const gm = new GalleryManagerTest();
ProjectPath.reset();
ProjectPath.ImageFolder = path.join(__dirname, '/../../../assets');
Config.Server.Threading.enabled = false;
await ObjectManagers.getInstance().IndexingManager.indexDirectory('.');
if (ObjectManagers.getInstance().IndexingManager.IsSavingInProgress) {
await ObjectManagers.getInstance().IndexingManager.SavingReady;
}
const directoryPath = GalleryManager.parseRelativeDirePath(
'.'
);
const conn = await SQLConnection.getConnection();
const selected = await gm.selectParentDir(conn, directoryPath.name,
directoryPath.parent);
await gm.fillParentDir(conn, selected);
expect(selected?.media?.length)
.to.be.greaterThan(0);
const tmpDir = path.join(__dirname, '/../../../tmp/rnd5sdf_emptyDir');
fs.mkdirSync(tmpDir);
ProjectPath.ImageFolder = tmpDir;
let notFailed = false;
try {
await ObjectManagers.getInstance().IndexingManager.indexDirectory('.');
notFailed = true;
} catch (e) {
// it expected to fail
}
if (notFailed) {
expect(true).to.equal(false, 'indexDirectory is expected to fail');
}
});
it('should support case sensitive directory', async () => {
const gm = new GalleryManagerTest();
const im = new IndexingManagerTest();
@@ -605,6 +649,7 @@ describe('IndexingManager', (sqlHelper: DBTestHelper) => {
});
afterEach(() => {
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
fs.statSync = statSync;
});
@@ -612,6 +657,7 @@ describe('IndexingManager', (sqlHelper: DBTestHelper) => {
it('with re indexing severity low', async () => {
Config.Server.Indexing.reIndexingSensitivity = ReIndexingSensitivity.low;
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
fs.statSync = () => ({ctime: new Date(dirTime), mtime: new Date(dirTime)});
const gm = new GalleryManagerTest();