self-hosted/pigallery2
1
0
Fork 0
mirror of https://github.com/bpatrik/pigallery2.git synced 2025-01-26 05:27:35 +02:00
Code Issues Releases Activity

Disabling random link by default as it poses a security risk. #392

Browse Source
This commit is contained in:
Patrik J. Braun 2022-02-06 15:13:40 +01:00
parent 42fd161a66
commit a1de381caa
2 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/common/config/public/ClientConfig.ts
View File

@ -57,8 +57,8 @@ export class ClientSharingConfig {
@SubConfigClass() @SubConfigClass()
export class ClientRandomPhotoConfig { export class ClientRandomPhotoConfig {
@ConfigProperty() @ConfigProperty({description: 'Enables random link generation. NOTE: With the current implementation, it poses a security risk. See https://github.com/bpatrik/pigallery2/issues/392'})
enabled: boolean = true; enabled: boolean = false;
} }
@SubConfigClass() @SubConfigClass()

15
src/frontend/app/ui/settings/random-photo/random-photo.settings.component.html
View File

@ -25,10 +25,17 @@
<ng-container *ngIf="states.enabled.value || settingsService.isSupported()"> <ng-container *ngIf="states.enabled.value || settingsService.isSupported()">
<div class="alert alert-secondary" role="alert" i18n> <div class="alert alert-secondary" role="alert">
This feature enables you to generate 'random photo' urls. <ng-container i18n>
That URL returns a photo random selected from your gallery. This feature enables you to generate 'random photo' urls.
You can use the url with 3rd party application like random changing desktop background. That URL returns a photo random selected from your gallery.
You can use the url with 3rd party application like random changing desktop background.
</ng-container>
<br/>
<ng-container i18n>
Note: With the current implementation, it poses a security risk. See:
</ng-container>
<a href="https://github.com/bpatrik/pigallery2/issues/392">#392</a>
</div> </div>
</ng-container> </ng-container>