self-hosted/watchtower
self-hosted/watchtower
1
0
Fork 0
mirror of https://github.com/containrrr/watchtower.git synced 2025-02-07 19:30:19 +02:00
Code Issues Releases Activity

fix(notifier): don't panic on unconfigured notifier (#869)

Browse Source
This commit is contained in:
nils måsén 2021-04-18 18:11:46 +02:00 committed by GitHub
parent 3b60afe553
commit b644ec6829
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/notifications/notifier.go
View File

@ -55,6 +55,12 @@ func (n *Notifier) String() string {
sb.WriteString(", ")
}
}
if sb.Len() < 2 {
// No notification services are configured, return early as the separator strip is not applicable
return "none"
}
names := sb.String()
// remove the last separator

16
pkg/notifications/notifier_test.go
View File

@ -23,6 +23,22 @@ func TestActions(t *testing.T) {
}
var _ = Describe("notifications", func() {
Describe("the notifier", func() {
When("only empty notifier types are provided", func() {
command := cmd.NewRootCommand()
flags.RegisterNotificationFlags(command)
err := command.ParseFlags([]string{
"--notifications",
"shoutrrr",
})
Expect(err).NotTo(HaveOccurred())
notif := notifications.NewNotifier(command)
Expect(notif.String()).To(Equal("none"))
})
})
Describe("the slack notifier", func() {
builderFn := notifications.NewSlackNotifier