From 6ddc2abf47cbf5d101106d966d90186941637de0 Mon Sep 17 00:00:00 2001 From: Jeff Storey Date: Tue, 29 Mar 2016 14:07:50 -0400 Subject: [PATCH 1/3] #1550 deployment status hooks for github --- remote/github/github.go | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/remote/github/github.go b/remote/github/github.go index fe7244bba..1f698ded8 100644 --- a/remote/github/github.go +++ b/remote/github/github.go @@ -236,7 +236,14 @@ func (g *Github) File(u *model.User, r *model.Repo, b *model.Build, f string) ([ // An example would be the GitHub pull request status. func (g *Github) Status(u *model.User, r *model.Repo, b *model.Build, link string) error { client := NewClient(g.API, u.Token, g.SkipVerify) + if ( b.Event == "deployment") { + return deploymentStatus(client,r,b,link) + } else { + return repoStatus(client,r,b,link) + } +} +func repoStatus(client *github.Client, r *model.Repo, b *model.Build, link string) error { status := getStatus(b.Status) desc := getDesc(b.Status) data := github.RepoStatus{ @@ -249,6 +256,21 @@ func (g *Github) Status(u *model.User, r *model.Repo, b *model.Build, link strin return err } +func deploymentStatus(client *github.Client, r *model.Repo, b *model.Build, link string) error { + // the deployment ID is only available in the the link to the build as the last element in the URL + parts := strings.Split(b.Link,"/") + id, _ := strconv.Atoi(parts[len(parts)-1]) + status := getStatus(b.Status) + desc := getDesc(b.Status) + data := github.DeploymentStatusRequest{ + State: github.String(status), + Description: github.String(desc), + TargetURL: github.String(link), + } + _, _, err := client.Repositories.CreateDeploymentStatus(r.Owner, r.Name, id, &data) + return err +} + // Netrc returns a .netrc file that can be used to clone // private repositories from a remote system. func (g *Github) Netrc(u *model.User, r *model.Repo) (*model.Netrc, error) { From 3e4b871991936d8a32e3895228e3c7896d9f1828 Mon Sep 17 00:00:00 2001 From: Jeff Storey Date: Tue, 29 Mar 2016 20:05:28 -0400 Subject: [PATCH 2/3] adding check for github link --- remote/github/github.go | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/remote/github/github.go b/remote/github/github.go index 1f698ded8..867c23ec8 100644 --- a/remote/github/github.go +++ b/remote/github/github.go @@ -6,6 +6,7 @@ import ( "fmt" "net/http" "net/url" + "regexp" "strconv" "strings" @@ -25,6 +26,8 @@ const ( DefaultMergeRef = "merge" ) +var githubDeployRegex = regexp.MustCompile(".+/deployments/(\\d+)") + type Github struct { URL string API string @@ -236,10 +239,10 @@ func (g *Github) File(u *model.User, r *model.Repo, b *model.Build, f string) ([ // An example would be the GitHub pull request status. func (g *Github) Status(u *model.User, r *model.Repo, b *model.Build, link string) error { client := NewClient(g.API, u.Token, g.SkipVerify) - if ( b.Event == "deployment") { - return deploymentStatus(client,r,b,link) + if b.Event == "deployment" { + return deploymentStatus(client, r, b, link) } else { - return repoStatus(client,r,b,link) + return repoStatus(client, r, b, link) } } @@ -258,14 +261,19 @@ func repoStatus(client *github.Client, r *model.Repo, b *model.Build, link strin func deploymentStatus(client *github.Client, r *model.Repo, b *model.Build, link string) error { // the deployment ID is only available in the the link to the build as the last element in the URL - parts := strings.Split(b.Link,"/") + parts := strings.Split(b.Link, "/") + matches := githubDeployRegex.FindStringSubmatch(b.Link) + // if the deployment was not triggered from github, don't send a deployment status + if len(matches) != 2 { + return nil + } id, _ := strconv.Atoi(parts[len(parts)-1]) status := getStatus(b.Status) desc := getDesc(b.Status) data := github.DeploymentStatusRequest{ - State: github.String(status), - Description: github.String(desc), - TargetURL: github.String(link), + State: github.String(status), + Description: github.String(desc), + TargetURL: github.String(link), } _, _, err := client.Repositories.CreateDeploymentStatus(r.Owner, r.Name, id, &data) return err From 79dc866f437ea53e9794f83d0296ab089dc6c6cf Mon Sep 17 00:00:00 2001 From: Jeff Storey Date: Wed, 30 Mar 2016 07:58:24 -0400 Subject: [PATCH 3/3] getting rid of string split and using the regex match --- remote/github/github.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/remote/github/github.go b/remote/github/github.go index 867c23ec8..9ace24773 100644 --- a/remote/github/github.go +++ b/remote/github/github.go @@ -260,14 +260,13 @@ func repoStatus(client *github.Client, r *model.Repo, b *model.Build, link strin } func deploymentStatus(client *github.Client, r *model.Repo, b *model.Build, link string) error { - // the deployment ID is only available in the the link to the build as the last element in the URL - parts := strings.Split(b.Link, "/") matches := githubDeployRegex.FindStringSubmatch(b.Link) // if the deployment was not triggered from github, don't send a deployment status if len(matches) != 2 { return nil } - id, _ := strconv.Atoi(parts[len(parts)-1]) + // the deployment ID is only available in the the link to the build as the last element in the URL + id, _ := strconv.Atoi(matches[1]) status := getStatus(b.Status) desc := getDesc(b.Status) data := github.DeploymentStatusRequest{