1
0
mirror of https://github.com/woodpecker-ci/woodpecker.git synced 2025-11-23 21:44:44 +02:00

Include forge type in netrc (#4908)

This commit is contained in:
qwerty287
2025-02-28 15:07:30 +02:00
committed by GitHub
parent 7528179f21
commit 434670ddbd
11 changed files with 14 additions and 3 deletions

View File

@@ -349,6 +349,7 @@ func (c *config) Netrc(u *model.User, _ *model.Repo) (*model.Netrc, error) {
Machine: "bitbucket.org", Machine: "bitbucket.org",
Login: "x-token-auth", Login: "x-token-auth",
Password: u.AccessToken, Password: u.AccessToken,
Type: model.ForgeTypeBitbucket,
}, nil }, nil
} }

View File

@@ -55,6 +55,7 @@ func TestBitbucket(t *testing.T) {
assert.Equal(t, "bitbucket.org", netrc.Machine) assert.Equal(t, "bitbucket.org", netrc.Machine)
assert.Equal(t, "x-token-auth", netrc.Login) assert.Equal(t, "x-token-auth", netrc.Login)
assert.Equal(t, fakeUser.AccessToken, netrc.Password) assert.Equal(t, fakeUser.AccessToken, netrc.Password)
assert.Equal(t, model.ForgeTypeBitbucket, netrc.Type)
user, _, err := c.Login(ctx, &types.OAuthRequest{}) user, _, err := c.Login(ctx, &types.OAuthRequest{})
assert.NoError(t, err) assert.NoError(t, err)

View File

@@ -331,6 +331,7 @@ func (c *client) Netrc(_ *model.User, r *model.Repo) (*model.Netrc, error) {
Login: c.username, Login: c.username,
Password: c.password, Password: c.password,
Machine: host, Machine: host,
Type: model.ForgeTypeBitbucketDatacenter,
}, nil }, nil
} }

View File

@@ -350,6 +350,7 @@ func (c *Forgejo) Netrc(u *model.User, r *model.Repo) (*model.Netrc, error) {
Login: login, Login: login,
Password: token, Password: token,
Machine: host, Machine: host,
Type: model.ForgeTypeForgejo,
}, nil }, nil
} }

View File

@@ -61,6 +61,7 @@ func Test_forgejo(t *testing.T) {
assert.Equal(t, "forgejo.org", netrc.Machine) assert.Equal(t, "forgejo.org", netrc.Machine)
assert.Equal(t, fakeUser.Login, netrc.Login) assert.Equal(t, fakeUser.Login, netrc.Login)
assert.Equal(t, fakeUser.AccessToken, netrc.Password) assert.Equal(t, fakeUser.AccessToken, netrc.Password)
assert.Equal(t, model.ForgeTypeForgejo, netrc.Type)
}) })
t.Run("netrc with machine account", func(t *testing.T) { t.Run("netrc with machine account", func(t *testing.T) {
forge, _ := New(Opts{}) forge, _ := New(Opts{})

View File

@@ -352,6 +352,7 @@ func (c *Gitea) Netrc(u *model.User, r *model.Repo) (*model.Netrc, error) {
Login: login, Login: login,
Password: token, Password: token,
Machine: host, Machine: host,
Type: model.ForgeTypeGitea,
}, nil }, nil
} }

View File

@@ -62,6 +62,7 @@ func Test_gitea(t *testing.T) {
assert.Equal(t, "gitea.com", netrc.Machine) assert.Equal(t, "gitea.com", netrc.Machine)
assert.Equal(t, fakeUser.Login, netrc.Login) assert.Equal(t, fakeUser.Login, netrc.Login)
assert.Equal(t, fakeUser.AccessToken, netrc.Password) assert.Equal(t, fakeUser.AccessToken, netrc.Password)
assert.Equal(t, model.ForgeTypeGitea, netrc.Type)
}) })
t.Run("netrc with machine account", func(t *testing.T) { t.Run("netrc with machine account", func(t *testing.T) {
forge, _ := New(Opts{}) forge, _ := New(Opts{})

View File

@@ -360,6 +360,7 @@ func (c *client) Netrc(u *model.User, r *model.Repo) (*model.Netrc, error) {
Login: login, Login: login,
Password: token, Password: token,
Machine: host, Machine: host,
Type: model.ForgeTypeGithub,
}, nil }, nil
} }

View File

@@ -61,6 +61,7 @@ func Test_github(t *testing.T) {
assert.Equal(t, "github.com", netrc.Machine) assert.Equal(t, "github.com", netrc.Machine)
assert.Equal(t, fakeUser.AccessToken, netrc.Login) assert.Equal(t, fakeUser.AccessToken, netrc.Login)
assert.Equal(t, "x-oauth-basic", netrc.Password) assert.Equal(t, "x-oauth-basic", netrc.Password)
assert.Equal(t, model.ForgeTypeGithub, netrc.Type)
}) })
t.Run("netrc with machine account", func(t *testing.T) { t.Run("netrc with machine account", func(t *testing.T) {
forge, _ := New(Opts{}) forge, _ := New(Opts{})

View File

@@ -476,6 +476,7 @@ func (g *GitLab) Netrc(u *model.User, r *model.Repo) (*model.Netrc, error) {
Login: login, Login: login,
Password: token, Password: token,
Machine: host, Machine: host,
Type: model.ForgeTypeGitlab,
}, nil }, nil
} }

View File

@@ -15,7 +15,8 @@
package model package model
type Netrc struct { type Netrc struct {
Machine string `json:"machine"` Machine string `json:"machine"`
Login string `json:"login"` Login string `json:"login"`
Password string `json:"password"` Password string `json:"password"`
Type ForgeType `json:"type"`
} }