self-hosted/woodpecker
1
0
Fork 0
mirror of https://github.com/woodpecker-ci/woodpecker.git synced 2025-07-12 22:21:40 +02:00
Code Issues Releases Activity

fix: can't run multiple services on k8s (#3395)

Browse Source 
Fix Issue: https://github.com/woodpecker-ci/woodpecker/issues/3288

The way the pod service starts up makes it impossible to run two or more
pipelines at the same time when we have a service section.

The idea is to set the name of the service in the same way we did for
the pod name.

Pipeline: 

```yaml

services:
  mydb:
    image: mysql
    environment:
      - MYSQL_DATABASE=test
      - MYSQL_ROOT_PASSWORD=example
    ports:
      - 3306/tcp
steps:
  get-version:
    image: ubuntu
    commands:
      - ( apt update && apt dist-upgrade -y && apt install -y mysql-client 2>&1 )> /dev/null
      - sleep 30s # need to wait for mysql-server init
      - echo 'SHOW VARIABLES LIKE "version"' | mysql -uroot -hmydb test -pexample
```

Running more than one pipeline result:


![image](https://github.com/woodpecker-ci/woodpecker/assets/22245125/e512309f-0d1e-4125-bab9-2357a710fedd)

---------

Co-authored-by: elias.souza <elias.souza@quintoandar.com.br>
This commit is contained in:
Elias
2024-02-17 08:30:06 -03:00
committed by GitHub
parent b7891b93ff
commit bffc9c8ff8
4 changed files with 14 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
pipeline/backend/kubernetes/service.go
View File

@ -29,7 +29,8 @@ import (
)
const (
ServiceLabel = "service"
ServiceLabel = "service"
servicePrefix = "wp-svc-"
)
func mkService(step *types.Step, config *config) (*v1.Service, error) {
@ -62,7 +63,7 @@ func mkService(step *types.Step, config *config) (*v1.Service, error) {
}
func serviceName(step *types.Step) (string, error) {
return dnsName(step.Name)
return dnsName(servicePrefix + step.UUID + "-" + step.Name)
}
func servicePort(port types.Port) v1.ServicePort {